commit 561bc9ab7918bfddcfd0ecc722b162e43a9bc46b
author Jens Geyer <jensg@apache.org> Wed Jan 26 22:38:04 2022 +0100
committer Jens Geyer <Jens-G@users.noreply.github.com> Thu Jan 27 08:51:15 2022 +0100
tree 9a00a668fd7be50c30fccb8eb0db091868c6d6d9
parent bf0967537bdf189a8806fe05a2710e1011370956

THRIFT-5504 CA2254 Message template should be compile time constant
Client netstd
Patch: Jens Geyer

lib/netstd/Thrift/Server/TServer.cs

diff --git a/lib/netstd/Thrift/Server/TServer.cs b/lib/netstd/Thrift/Server/TServer.cs
index 3fd0bc5..3d4f3fc 100644
--- a/lib/netstd/Thrift/Server/TServer.cs
+++ b/lib/netstd/Thrift/Server/TServer.cs
@@ -35,7 +35,7 @@
         protected TProtocolFactory OutputProtocolFactory;
         protected TTransportFactory OutputTransportFactory;
 
-        protected TServerEventHandler ServerEventHandler;
+        protected ITServerEventHandler ServerEventHandler;
         protected TServerTransport ServerTransport;
 
         protected TServer(ITProcessorFactory processorFactory, TServerTransport serverTransport,
@@ -52,12 +52,12 @@
             Logger = logger; // null is absolutely legal
         }
 
-        public void SetEventHandler(TServerEventHandler seh)
+        public void SetEventHandler(ITServerEventHandler seh)
         {
             ServerEventHandler = seh;
         }
 
-        public TServerEventHandler GetEventHandler()
+        public ITServerEventHandler GetEventHandler()
         {
             return ServerEventHandler;
         }
@@ -66,7 +66,7 @@
         protected void LogError( string msg)
         {
             if (Logger != null)
-                Logger.LogError(msg);
+                Logger.LogError("{Msg}",msg);  // NOTE: Log message template, not string interpolation!
         }
 
         public abstract void Stop();