commit 4fcd0725b837dc65842638b9d2f5167bedd15399
author dejank-isystem <119041215+dejank-isystem@users.noreply.github.com> Tue Feb 14 13:34:26 2023 +0100
committer Jens Geyer <Jens-G@users.noreply.github.com> Tue Feb 21 22:55:01 2023 +0100
tree 87c72f1ae967c3568f6d0b19991757c8d8f3785c
parent d96b17740c52734714afc77a83147d06f3ea70da

lib/cpp: Fix MSVC warning C4706 (BinaryProtocol)

MSVC warning C4706: assignment within conditional expression

lib/cpp/src/thrift/protocol/TBinaryProtocol.tcc

diff --git a/lib/cpp/src/thrift/protocol/TBinaryProtocol.tcc b/lib/cpp/src/thrift/protocol/TBinaryProtocol.tcc
index 755f243..c448e77 100644
--- a/lib/cpp/src/thrift/protocol/TBinaryProtocol.tcc
+++ b/lib/cpp/src/thrift/protocol/TBinaryProtocol.tcc
@@ -448,9 +448,9 @@
   }
 
   // Try to borrow first
-  const uint8_t* borrow_buf;
   uint32_t got = size;
-  if ((borrow_buf = this->trans_->borrow(nullptr, &got))) {
+  const uint8_t* borrow_buf = this->trans_->borrow(nullptr, &got);
+  if (borrow_buf) {
     str.assign((const char*)borrow_buf, size);
     this->trans_->consume(size);
     return size;