commit 4a78c6eb8670cbb664a199b1c98518033e51e525
author David Helder <david@twitter.com> Tue Jan 06 11:59:41 2015 -0800
committer Roger Meier <roger@apache.org> Tue Jan 06 23:57:26 2015 +0100
tree 98e36613f9e123d23afca6c13465afd35ad47729
parent 4f2c0a066f1d59c1d57a718e829eb67e488b3c62

THRIFT-1618: synchronize access to hashtable in FieldMetaData

lib/java/src/org/apache/thrift/meta_data/FieldMetaData.java

diff --git a/lib/java/src/org/apache/thrift/meta_data/FieldMetaData.java b/lib/java/src/org/apache/thrift/meta_data/FieldMetaData.java
index b634291..445f7e4 100644
--- a/lib/java/src/org/apache/thrift/meta_data/FieldMetaData.java
+++ b/lib/java/src/org/apache/thrift/meta_data/FieldMetaData.java
@@ -45,7 +45,7 @@
     this.valueMetaData = vMetaData;
   }
   
-  public static void addStructMetaDataMap(Class<? extends TBase> sClass, Map<? extends TFieldIdEnum, FieldMetaData> map){
+  public static synchronized void addStructMetaDataMap(Class<? extends TBase> sClass, Map<? extends TFieldIdEnum, FieldMetaData> map){
     structMap.put(sClass, map);
   }
 
@@ -55,7 +55,7 @@
    *
    * @param sClass The TBase class for which the metadata map is requested
    */
-  public static Map<? extends TFieldIdEnum, FieldMetaData> getStructMetaDataMap(Class<? extends TBase> sClass){
+  public static synchronized Map<? extends TFieldIdEnum, FieldMetaData> getStructMetaDataMap(Class<? extends TBase> sClass){
     if (!structMap.containsKey(sClass)){ // Load class if it hasn't been loaded
       try{
         sClass.newInstance();

lib/javame/src/org/apache/thrift/meta_data/FieldMetaData.java

diff --git a/lib/javame/src/org/apache/thrift/meta_data/FieldMetaData.java b/lib/javame/src/org/apache/thrift/meta_data/FieldMetaData.java
index 11a5a08..bce02c7 100644
--- a/lib/javame/src/org/apache/thrift/meta_data/FieldMetaData.java
+++ b/lib/javame/src/org/apache/thrift/meta_data/FieldMetaData.java
@@ -63,7 +63,7 @@
     this.valueMetaData = vMetaData;
   }
   
-  public static void addStructMetaDataMap(Class sClass, Hashtable map){
+  public static synchronized void addStructMetaDataMap(Class sClass, Hashtable map){
     structMap.put(sClass, map);
   }
 
@@ -73,7 +73,7 @@
    *
    * @param sClass The TBase class for which the metadata map is requested
    */
-  public static Hashtable getStructMetaDataMap(Class sClass){
+  public static synchronized Hashtable getStructMetaDataMap(Class sClass){
     if (!structMap.containsKey(sClass)){ // Load class if it hasn't been loaded
       try{
         sClass.newInstance();