commit 44d8cc6b435557ef5ba9e4c9df91b2f114a5bfa0
author belugabehr <12578579+belugabehr@users.noreply.github.com> Sat Dec 14 04:33:37 2019 -0500
committer Duru Can Celasun <dcelasun@apache.org> Sat Dec 14 09:33:37 2019 +0000
tree ba811a88715fa2294c816adda9bf09e0994a485a
parent b374ce35550659d4f109c2afc657733e7590aaed

THRIFT-5014: Do Direct Comparison on Raw Values Instead of Objects

Client: java

This closes #1935.

compiler/cpp/src/thrift/generate/t_java_generator.cc

diff --git a/compiler/cpp/src/thrift/generate/t_java_generator.cc b/compiler/cpp/src/thrift/generate/t_java_generator.cc
index 581e1cf..1805585 100644
--- a/compiler/cpp/src/thrift/generate/t_java_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_java_generator.cc
@@ -2056,8 +2056,8 @@
   vector<t_field*>::const_iterator m_iter;
   for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
     t_field* field = *m_iter;
-    indent(out) << "lastComparison = java.lang.Boolean.valueOf(" << generate_isset_check(field)
-                << ").compareTo(other." << generate_isset_check(field) << ");" << endl;
+    indent(out) << "lastComparison = java.lang.Boolean.compare(" << generate_isset_check(field)
+                << ", other." << generate_isset_check(field) << ");" << endl;
     indent(out) << "if (lastComparison != 0) {" << endl;
     indent(out) << "  return lastComparison;" << endl;
     indent(out) << "}" << endl;