commit 418d88b447769745eeba372d12f486b22053a7a8
author belugabehr <12578579+belugabehr@users.noreply.github.com> Fri Dec 13 04:13:12 2019 -0500
committer Duru Can Celasun <dcelasun@apache.org> Fri Dec 13 09:13:12 2019 +0000
tree 5b02bdf4119ae7271a688ded8f85f2dcb5503225
parent 0ebf3ce99d74bc77912536dc3ad95dac10ebf12a

THRIFT-5013: Replace NullPointerException with RequireNonNull

Co-Authored-By: Christopher Tubbs <ctubbsii@apache.org>

Client: java

This closes #1934.

compiler/cpp/src/thrift/generate/t_java_generator.cc

diff --git a/compiler/cpp/src/thrift/generate/t_java_generator.cc b/compiler/cpp/src/thrift/generate/t_java_generator.cc
index 7254e12..581e1cf 100644
--- a/compiler/cpp/src/thrift/generate/t_java_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_java_generator.cc
@@ -1060,11 +1060,15 @@
     }
     indent(out) << "public void set" << get_cap_name(field->get_name()) << "("
                 << type_name(field->get_type()) << " value) {" << endl;
-    if (type_can_be_null(field->get_type())) {
-      indent(out) << "  if (value == null) throw new java.lang.NullPointerException();" << endl;
-    }
+
     indent(out) << "  setField_ = _Fields." << constant_name(field->get_name()) << ";" << endl;
-    indent(out) << "  value_ = value;" << endl;
+
+    if (type_can_be_null(field->get_type())) {
+      indent(out) << "  value_ = java.util.Objects.requireNonNull(value,\"" << "_Fields." << constant_name(field->get_name()) << "\");" << endl;
+    } else {
+      indent(out) << "  value_ = value;" << endl;
+    }
+
     indent(out) << "}" << endl;
   }
 }