THRIFT-3598 TBufferedTransport doesn't instantiate client connection
Client: Lua
Patch: Phongphan Phuttha
This closes #836
diff --git a/lib/lua/TBufferedTransport.lua b/lib/lua/TBufferedTransport.lua
index 2b0b946..45ef4b1 100644
--- a/lib/lua/TBufferedTransport.lua
+++ b/lib/lua/TBufferedTransport.lua
@@ -37,7 +37,7 @@
error('You must provide ' .. ttype(self) .. ' with a trans')
end
- return TTransportBase:new(obj)
+ return TTransportBase.new(self, obj)
end
function TBufferedTransport:isOpen()
diff --git a/test/known_failures_Linux.json b/test/known_failures_Linux.json
index 220d03d..ab2f374 100644
--- a/test/known_failures_Linux.json
+++ b/test/known_failures_Linux.json
@@ -1,5 +1,4 @@
[
- "c_glib-lua_binary_buffered-ip",
"cpp-cpp_binary_buffered-ip-ssl",
"cpp-cpp_binary_framed-ip-ssl",
"cpp-cpp_binary_http-domain",
@@ -33,7 +32,6 @@
"cpp-java_compact_http-ip-ssl",
"cpp-java_json_http-ip",
"cpp-java_json_http-ip-ssl",
- "cpp-lua_binary_buffered-ip",
"cpp-perl_binary_buffered-ip-ssl",
"cpp-perl_binary_framed-ip-ssl",
"cpp-py_binary-accel_framed-ip-ssl",
@@ -54,7 +52,6 @@
"csharp-go_compact_framed-ip-ssl",
"csharp-go_json_buffered-ip-ssl",
"csharp-go_json_framed-ip-ssl",
- "csharp-lua_binary_buffered-ip",
"csharp-nodejs_binary_buffered-ip-ssl",
"csharp-nodejs_binary_framed-ip-ssl",
"csharp-nodejs_compact_buffered-ip-ssl",
@@ -81,7 +78,6 @@
"erl-cpp_compact_buffered-ip-ssl",
"erl-cpp_compact_framed-ip",
"erl-cpp_compact_framed-ip-ssl",
- "erl-lua_binary_buffered-ip",
"erl-nodejs_binary_buffered-ip",
"erl-nodejs_compact_buffered-ip",
"erl-perl_binary_buffered-ip-ssl",
@@ -109,7 +105,6 @@
"go-java_compact_http-ip-ssl",
"go-java_json_http-ip",
"go-java_json_http-ip-ssl",
- "go-lua_binary_buffered-ip",
"go-perl_binary_buffered-ip-ssl",
"go-perl_binary_framed-ip-ssl",
"hs-csharp_binary_framed-ip",
@@ -117,32 +112,25 @@
"hs-csharp_json_framed-ip",
"hs-dart_binary_framed-ip",
"hs-dart_json_framed-ip",
- "hs-lua_binary_buffered-ip",
"hs-py3_json_buffered-ip",
"hs-py3_json_framed-ip",
"hs-py_json_buffered-ip",
"hs-py_json_framed-ip",
- "java-lua_binary_buffered-ip",
"java-perl_binary_buffered-ip-ssl",
"java-perl_binary_fastframed-framed-ip-ssl",
"java-perl_binary_framed-ip-ssl",
- "nodejs-lua_binary_buffered-ip",
"nodejs-perl_binary_buffered-ip-ssl",
"nodejs-perl_binary_framed-ip-ssl",
- "perl-lua_binary_buffered-ip",
"perl-perl_binary_buffered-ip-ssl",
"perl-perl_binary_framed-ip-ssl",
"perl-php_binary_framed-ip",
"py-cpp_compact_buffered-ip",
"py-lua_accel-binary_buffered-ip",
- "py-lua_binary_buffered-ip",
"py-perl_accel-binary_buffered-ip-ssl",
"py-perl_accel-binary_framed-ip-ssl",
"py-perl_binary_buffered-ip-ssl",
"py-perl_binary_framed-ip-ssl",
- "py3-lua_binary_buffered-ip",
"py3-perl_binary_buffered-ip-ssl",
"py3-perl_binary_framed-ip-ssl",
- "rb-lua_accel-binary_buffered-ip",
- "rb-lua_binary_buffered-ip"
-]
\ No newline at end of file
+ "rb-lua_accel-binary_buffered-ip"
+]
diff --git a/test/lua/test_basic_client.lua b/test/lua/test_basic_client.lua
index 5e0966f..34bd9b1 100644
--- a/test/lua/test_basic_client.lua
+++ b/test/lua/test_basic_client.lua
@@ -84,8 +84,8 @@
}
assert(client, 'Failed to create client')
- -- Open the socket
- local status, _ = pcall(socket.open, socket)
+ -- Open the transport
+ local status, _ = pcall(transport.open, transport)
assert(status, 'Failed to connect to server')
-- String