[thrift] clean up error logging in Erlang

Summary: pushed all formatting out of thrift_error_logger.erl, reenable crash logs, standardize

Reviewed By: eletuchy

Test Plan: works with latest ch server


git-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665305 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/lib/erl/src/thrift_utils.erl b/lib/erl/src/thrift_utils.erl
index f78767c..8305224 100644
--- a/lib/erl/src/thrift_utils.erl
+++ b/lib/erl/src/thrift_utils.erl
@@ -35,18 +35,17 @@
     List1 = sformat("~w", [List]),
     string:substr(List1, 2, length(List1)-2).
 
-first_item(DeepTuple) ->
-    case is_tuple(DeepTuple) of
-	true  -> first_item(element(1, DeepTuple));
-	false -> DeepTuple
-    end.
+first_item(DeepTuple) when is_tuple(DeepTuple) ->
+    first_item(element(1, DeepTuple));
+first_item(NotTuple) ->
+    NotTuple.
 
 unnest_record(Term, RecordTag) ->
     case is_record(Term, RecordTag) of
-	true ->
-	    {ok, Term};
-	false when is_tuple(Term) ->
-	    unnest_record(element(1, Term), RecordTag);
-	_ ->
-	    error
+        true ->
+            {ok, Term};
+        false when is_tuple(Term) ->
+            unnest_record(element(1, Term), RecordTag);
+        _ ->
+            error
     end.