THRIFT-2663: py - per module logger used in python lib
Client: Python-Library
Patch: Dustin Spicuzza
This enables per module log message filtering
This closes #187
diff --git a/lib/py/src/server/TNonblockingServer.py b/lib/py/src/server/TNonblockingServer.py
index fa478d0..4a035b6 100644
--- a/lib/py/src/server/TNonblockingServer.py
+++ b/lib/py/src/server/TNonblockingServer.py
@@ -29,7 +29,9 @@
import Queue
import select
import struct
+
import logging
+logger = logging.getLogger(__name__)
from thrift.transport import TTransport
from thrift.protocol.TBinaryProtocol import TBinaryProtocolFactory
@@ -54,7 +56,7 @@
processor.process(iprot, oprot)
callback(True, otrans.getvalue())
except Exception:
- logging.exception("Exception while processing request")
+ logger.exception("Exception while processing request")
callback(False, '')
WAIT_LEN = 0
@@ -116,18 +118,18 @@
# if we read 0 bytes and self.message is empty, then
# the client closed the connection
if len(self.message) != 0:
- logging.error("can't read frame size from socket")
+ logger.error("can't read frame size from socket")
self.close()
return
self.message += read
if len(self.message) == 4:
self.len, = struct.unpack('!i', self.message)
if self.len < 0:
- logging.error("negative frame size, it seems client "
+ logger.error("negative frame size, it seems client "
"doesn't use FramedTransport")
self.close()
elif self.len == 0:
- logging.error("empty frame, it's really strange")
+ logger.error("empty frame, it's really strange")
self.close()
else:
self.message = ''
@@ -145,7 +147,7 @@
elif self.status == WAIT_MESSAGE:
read = self.socket.recv(self.len - len(self.message))
if len(read) == 0:
- logging.error("can't read frame from socket (get %d of "
+ logger.error("can't read frame from socket (get %d of "
"%d bytes)" % (len(self.message), self.len))
self.close()
return