THRIFT-5008: Improve TSaslTransport logging
Client: Java
Patch: Qinghui Xu
This closes #1931
diff --git a/lib/java/src/org/apache/thrift/transport/TSaslTransport.java b/lib/java/src/org/apache/thrift/transport/TSaslTransport.java
index 4a453b6..4685d64 100644
--- a/lib/java/src/org/apache/thrift/transport/TSaslTransport.java
+++ b/lib/java/src/org/apache/thrift/transport/TSaslTransport.java
@@ -392,7 +392,7 @@
try {
sasl.dispose();
} catch (SaslException e) {
- // Not much we can do here.
+ LOGGER.warn("Failed to dispose sasl participant.", e);
}
}
@@ -427,9 +427,7 @@
} catch (TTransportException transportException) {
// If there is no-data or no-sasl header in the stream, log the failure, and rethrow.
if (transportException.getType() == TTransportException.END_OF_FILE) {
- if (LOGGER.isDebugEnabled()) {
- LOGGER.debug("No data or no sasl data in the stream during negotiation");
- }
+ LOGGER.debug("No data or no sasl data in the stream during negotiation");
}
throw transportException;
}