commit 38e7155c039f1dba6dd73a3114dd3a5ac7052418
author Simon South <ssouth@simonsouth.com> Mon Aug 03 10:51:16 2015 +0000
committer Roger Meier <roger@apache.org> Mon Aug 03 22:10:23 2015 +0200
tree 92f45ebeb3fff1d46efa7aa066dc3dc348c95732
parent 7bc907a95931985792e11713eb38244259f1b926

THRIFT-3288 c_glib: Build unit tests without compiler warnings

These changes allow the unit tests for C (GLib) to build without
compiler warnings, even with additional warnings enabled. They
include

- Disabling string-function optimizations when glibc is used, as
  these produce compiler warnings when a string function is used
  within a call to assert ();

- Remove the "LL" suffix (added in C99) from 64-bit integer
  literals;

- Replace C++-style ("//") comments with C-style equivalents;

- Remove unused constant declarations that generated warnings;
  and

- Mark (or remove, from main ()) unused function parameters.

lib/c_glib/test/teststruct.c

diff --git a/lib/c_glib/test/teststruct.c b/lib/c_glib/test/teststruct.c
index a1b3cc0..5d4baf3 100755
--- a/lib/c_glib/test/teststruct.c
+++ b/lib/c_glib/test/teststruct.c
@@ -51,6 +51,10 @@
 thrift_test_struct_read (ThriftStruct *object, ThriftProtocol *protocol,
                          GError **error)
 {
+  THRIFT_UNUSED_VAR (object);
+  THRIFT_UNUSED_VAR (protocol);
+  THRIFT_UNUSED_VAR (error);
+
   return 0;
 }
 
@@ -58,6 +62,10 @@
 thrift_test_struct_write (ThriftStruct *object, ThriftProtocol *protocol,
                           GError **error)
 {
+  THRIFT_UNUSED_VAR (object);
+  THRIFT_UNUSED_VAR (protocol);
+  THRIFT_UNUSED_VAR (error);
+
   return 0;
 }