commit 333bbf3d8899a6a0e8971ed7abb10f51b4fc7867
author Roger Meier <roger@apache.org> Sun Jan 08 21:51:08 2012 +0000
committer Roger Meier <roger@apache.org> Sun Jan 08 21:51:08 2012 +0000
tree 8df4f544f44ff3e6cefecf0ec45ed09a10b9ca4a
parent 77e1e629131228cdeda3b740ef4cbf27a7af886b

THRIFT-1485 Performance: pass large and/or refcounted arguments as "const"
Patch: Jens Geyer

git-svn-id: https://svn.apache.org/repos/asf/thrift/trunk@1228965 13f79535-47bb-0310-9956-ffa450edef68

lib/delphi/src/Thrift.Collections.pas

diff --git a/lib/delphi/src/Thrift.Collections.pas b/lib/delphi/src/Thrift.Collections.pas
index abc401f..66ff1c0 100644
--- a/lib/delphi/src/Thrift.Collections.pas
+++ b/lib/delphi/src/Thrift.Collections.pas
@@ -195,11 +195,11 @@
     function GetCount: Integer;

     property Count: Integer read GetCount;

     property IsReadOnly: Boolean read GetIsReadOnly;

-    procedure Add( item: TValue);

+    procedure Add( const item: TValue);

     procedure Clear;

-    function Contains( item: TValue): Boolean;

+    function Contains( const item: TValue): Boolean;

     procedure CopyTo(var A: TArray<TValue>; arrayIndex: Integer);

-    function Remove( item: TValue ): Boolean;

+    function Remove( const item: TValue ): Boolean;

   end;

 

   THashSetImpl<TValue> = class( TInterfacedObject, IHashSet<TValue>)

@@ -212,11 +212,11 @@
     function GetCount: Integer;

     property Count: Integer read GetCount;

     property IsReadOnly: Boolean read FIsReadOnly;

-    procedure Add( item: TValue);

+    procedure Add( const item: TValue);

     procedure Clear;

-    function Contains( item: TValue): Boolean;

+    function Contains( const item: TValue): Boolean;

     procedure CopyTo(var A: TArray<TValue>; arrayIndex: Integer);

-    function Remove( item: TValue ): Boolean;

+    function Remove( const item: TValue ): Boolean;

   public

     constructor Create;

   end;

@@ -225,7 +225,7 @@
 

 { THashSetImpl<TValue> }

 

-procedure THashSetImpl<TValue>.Add(item: TValue);

+procedure THashSetImpl<TValue>.Add( const item: TValue);

 begin

   if not FDictionary.ContainsKey(item) then

   begin

@@ -238,7 +238,7 @@
   FDictionary.Clear;

 end;

 

-function THashSetImpl<TValue>.Contains(item: TValue): Boolean;

+function THashSetImpl<TValue>.Contains( const item: TValue): Boolean;

 begin

   Result := FDictionary.ContainsKey(item);

 end;

@@ -277,7 +277,7 @@
   Result := FIsReadOnly;

 end;

 

-function THashSetImpl<TValue>.Remove(item: TValue): Boolean;

+function THashSetImpl<TValue>.Remove( const item: TValue): Boolean;

 begin

   Result := False;

   if FDictionary.ContainsKey( item ) then

@@ -330,8 +330,7 @@
 end;

 

 {$IF CompilerVersion >= 21.0}

-function TThriftDictionaryImpl<TKey, TValue>.ExtractPair(

-  const Key: TKey): TPair<TKey, TValue>;

+function TThriftDictionaryImpl<TKey, TValue>.ExtractPair( const Key: TKey): TPair<TKey, TValue>;

 begin

   Result := FDictionaly.ExtractPair( Key);

 end;