commit 2df9c20dc76c044e502861a2111b90cbdcbbb957
author Paul <pavel.finkelshtein@gmail.com> Sat Sep 24 22:47:58 2016 +0300
committer Jens Geyer <jensg@apache.org> Mon Sep 26 22:05:19 2016 +0200
tree 1eda14560902355a4eeeca2eccb20e5d04f05c77
parent 1ac0a80aa07421a4b7a857d801038b7991833f7f

THRIFT-3855 Replaced complex CompareAndSwapInt64 with syncOnce.
Client: Go
Paul <pavel.finkelshtein@gmail.com>

This closes #1094

lib/go/thrift/simple_server.go

diff --git a/lib/go/thrift/simple_server.go b/lib/go/thrift/simple_server.go
index 8c56a4f..4097c4a 100644
--- a/lib/go/thrift/simple_server.go
+++ b/lib/go/thrift/simple_server.go
@@ -22,13 +22,12 @@
 import (
 	"log"
 	"runtime/debug"
-	"sync/atomic"
+	"sync"
 )
 
 // Simple, non-concurrent server for testing.
 type TSimpleServer struct {
 	quit chan struct{}
-	stopped int64
 
 	processorFactory       TProcessorFactory
 	serverTransport        TServerTransport
@@ -150,11 +149,14 @@
 	return nil
 }
 
+var once sync.Once
+
 func (p *TSimpleServer) Stop() error {
-	if atomic.CompareAndSwapInt64(&p.stopped, 0, 1) {
+	q := func() {
 		p.quit <- struct{}{}
 		p.serverTransport.Interrupt()
 	}
+	once.Do(q)
 	return nil
 }
 
@@ -186,7 +188,7 @@
 		if err, ok := err.(TApplicationException); ok && err.TypeId() == UNKNOWN_METHOD {
 			continue
 		}
-		if !ok {
+ 		if !ok {
 			break
 		}
 	}