THRIFT-2029 Port C++ tests to Windows
THRIFT-847 Test Framework harmonization across all languages
fix compact protocol test within TestServer.cpp and TestClient.cpp
remove stuff that breaks the cross language test suite
- TestServer.cpp: cin read
- test.sh: mkfifo
Reported-by: Chamila Wijayarathna
diff --git a/test/cpp/src/TestServer.cpp b/test/cpp/src/TestServer.cpp
index ad7df07..11ed359 100755
--- a/test/cpp/src/TestServer.cpp
+++ b/test/cpp/src/TestServer.cpp
@@ -545,13 +545,14 @@
if (!protocol_type.empty()) {
if (protocol_type == "binary") {
+ } else if (protocol_type == "compact") {
} else if (protocol_type == "json") {
} else {
throw invalid_argument("Unknown protocol type "+protocol_type);
}
}
- if (!transport_type.empty()) {
+ if (!transport_type.empty()) {
if (transport_type == "buffered") {
} else if (transport_type == "framed") {
} else if (transport_type == "http") {
@@ -689,8 +690,12 @@
boost::shared_ptr<apache::thrift::concurrency::Thread> thread = factory.newThread(serverThreadRunner);
thread->start();
- cout<<"Press enter to stop the server."<<endl;
- cin.ignore(); //wait until a key is pressed
+ // HACK: cross language test suite is unable to handle cin properly
+ // that's why we stay in a endless loop here
+ while(1){}
+ // FIXME: find another way to stop the server (e.g. a signal)
+ // cout<<"Press enter to stop the server."<<endl;
+ // cin.ignore(); //wait until a key is pressed
server->stop();
thread->join();