THRIFT-5444 Netstd generator produces uncompileable code for enums ending with "_result" or "_args"
Client: netstd
Patch: Jens Geyer
This closes #2424
diff --git a/compiler/cpp/src/thrift/generate/t_netstd_generator.cc b/compiler/cpp/src/thrift/generate/t_netstd_generator.cc
index 4a50e45..2f202d8 100644
--- a/compiler/cpp/src/thrift/generate/t_netstd_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_netstd_generator.cc
@@ -92,34 +92,6 @@
out_dir_base_ = "gen-netstd";
}
-/**
-* \brief Search and replace "_args" substring in struct name if exist (for C# class naming)
-* \param struct_name
-* \return Modified struct name ("Struct_args" -> "StructArgs") or original name
-*/
-static string check_and_correct_struct_name(const string& struct_name)
-{
- string args_end = "_args";
- size_t i = struct_name.find(args_end);
- if (i != string::npos)
- {
- string new_struct_name = struct_name;
- new_struct_name.replace(i, args_end.length(), "Args");
- return new_struct_name;
- }
-
- string result_end = "_result";
- size_t j = struct_name.find(result_end);
- if (j != string::npos)
- {
- string new_struct_name = struct_name;
- new_struct_name.replace(j, result_end.length(), "Result");
- return new_struct_name;
- }
-
- return struct_name;
-}
-
static bool field_has_default(t_field* tfield) { return tfield->get_value() != nullptr; }
static bool field_is_required(t_field* tfield) { return tfield->get_req() == t_field::T_REQUIRED; }
@@ -417,7 +389,7 @@
start_netstd_namespace(out);
generate_netstd_doc(out, tenum);
- out << indent() << "public enum " << tenum->get_name() << endl;
+ out << indent() << "public enum " << type_name(tenum,false) << endl;
scope_up(out);
vector<t_enum_value*> constants = tenum->get_constants();
@@ -914,7 +886,7 @@
bool is_final = tstruct->annotations_.find("final") != tstruct->annotations_.end();
- string sharp_struct_name = check_and_correct_struct_name(normalize_name(tstruct->get_name()));
+ string sharp_struct_name = type_name(tstruct, false);
out << indent() << "public " << (is_final ? "sealed " : "") << "partial class " << sharp_struct_name << " : ";
@@ -1121,7 +1093,7 @@
bool is_final = tstruct->annotations_.find("final") != tstruct->annotations_.end();
- out << indent() << "public " << (is_final ? "sealed " : "") << "partial class " << tstruct->get_name() << "Fault" << endl
+ out << indent() << "public " << (is_final ? "sealed " : "") << "partial class " << type_name(tstruct,false) << "Fault" << endl
<< indent() << "{" << endl;
indent_up();
@@ -1780,7 +1752,7 @@
out << indent() << "public override bool Equals(object that)" << endl
<< indent() << "{" << endl;
indent_up();
- out << indent() << "if (!(that is " << check_and_correct_struct_name(normalize_name(tstruct->get_name())) << " other)) return false;" << endl
+ out << indent() << "if (!(that is " << type_name(tstruct,false) << " other)) return false;" << endl
<< indent() << "if (ReferenceEquals(this, other)) return true;" << endl;
@@ -2050,7 +2022,7 @@
indent_up();
string tmpvar = tmp("tmp");
- string argsname = (*functions_iterator)->get_name() + "Args";
+ string argsname = (*functions_iterator)->get_name() + "_args";
out << indent() << "await OutputProtocol.WriteMessageBeginAsync(new TMessage(\"" << raw_func_name
<< "\", TMessageType." << ((*functions_iterator)->is_oneway() ? "Oneway" : "Call")
@@ -2089,7 +2061,7 @@
<< indent() << "{" << endl;
indent_up();
- string resultname = (*functions_iterator)->get_name() + "Result";
+ string resultname = (*functions_iterator)->get_name() + "_result";
t_struct noargs(program_);
t_struct* xs = (*functions_iterator)->get_xceptions();
collect_extensions_types(xs);
@@ -2318,8 +2290,8 @@
<< indent() << "{" << endl;
indent_up();
- string argsname = tfunction->get_name() + "Args";
- string resultname = tfunction->get_name() + "Result";
+ string argsname = tfunction->get_name() + "_args";
+ string resultname = tfunction->get_name() + "_result";
string args = tmp("tmp");
out << indent() << "var " << args << " = new InternalStructs." << argsname << "();" << endl
@@ -2950,14 +2922,16 @@
{
out << indent() << "[DataMember(Order = 0)]" << endl;
}
+ out << indent() << (isPublic ? "public " : "private ") << type_name(tfield->get_type()) << " " << prop_name(tfield);
+
bool is_required = field_is_required(tfield);
if (is_required)
{
- out << indent() << (isPublic ? "public " : "private ") << type_name(tfield->get_type()) << " " << prop_name(tfield) << " { get; set; }" << endl;
+ out << " { get; set; }" << endl;
}
else
{
- out << indent() << (isPublic ? "public " : "private ") << type_name(tfield->get_type()) << " " << prop_name(tfield) << endl
+ out << endl
<< indent() << "{" << endl;
indent_up();
@@ -2965,8 +2939,6 @@
<< indent() << "{" << endl;
indent_up();
- bool use_nullable = false;
-
out << indent() << "return " << fieldPrefix + tfield->get_name() << ";" << endl;
indent_down();
out << indent() << "}" << endl
@@ -2974,22 +2946,11 @@
<< indent() << "{" << endl;
indent_up();
- if (use_nullable)
+ if (generateIsset)
{
- if (generateIsset)
- {
- out << indent() << "__isset." << get_isset_name(normalize_name(tfield->get_name())) << " = value.HasValue;" << endl;
- }
- out << indent() << "if (value.HasValue) this." << fieldPrefix + tfield->get_name() << " = value.Value;" << endl;
+ out << indent() << "__isset." << get_isset_name(normalize_name(tfield->get_name())) << " = true;" << endl;
}
- else
- {
- if (generateIsset)
- {
- out << indent() << "__isset." << get_isset_name(normalize_name(tfield->get_name())) << " = true;" << endl;
- }
- out << indent() << "this." << fieldPrefix + tfield->get_name() << " = value;" << endl;
- }
+ out << indent() << "this." << fieldPrefix + tfield->get_name() << " = value;" << endl;
indent_down();
out << indent() << "}" << endl;
@@ -3238,7 +3199,7 @@
return get_mapped_member_name(fname);
}
-string t_netstd_generator::type_name(t_type* ttype)
+string t_netstd_generator::type_name(t_type* ttype, bool with_namespace)
{
ttype = resolve_typedef(ttype);
@@ -3265,15 +3226,18 @@
return "List<" + type_name(tlist->get_elem_type()) + ">";
}
- string the_name = check_and_correct_struct_name(normalize_name(ttype->get_name()));
+ string the_name = normalize_name(ttype->get_name());
- t_program* program = ttype->get_program();
- if (program != nullptr)// && program != program_)
+ if(with_namespace)
{
- string ns = program->get_namespace("netstd");
- if (!ns.empty())
+ t_program* program = ttype->get_program();
+ if (program != nullptr)// && program != program_)
{
- return "global::" + ns + "." + the_name;
+ string ns = program->get_namespace("netstd");
+ if (!ns.empty())
+ {
+ return "global::" + ns + "." + the_name;
+ }
}
}
diff --git a/compiler/cpp/src/thrift/generate/t_netstd_generator.h b/compiler/cpp/src/thrift/generate/t_netstd_generator.h
index 51230e8..b8a4ba4 100644
--- a/compiler/cpp/src/thrift/generate/t_netstd_generator.h
+++ b/compiler/cpp/src/thrift/generate/t_netstd_generator.h
@@ -135,7 +135,7 @@
static const int MODE_NO_RETURN = 0x01;
static const int MODE_NO_ARGS = 0x02;
- string type_name(t_type* ttype);
+ string type_name(t_type* ttype, bool with_namespace = true);
string base_type_name(t_base_type* tbase);
string declare_field(t_field* tfield, bool init = false, string prefix = "");
string function_signature_async(t_function* tfunction, string prefix = "", int mode = MODE_FULL_DECL);
diff --git a/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/Thrift.PublicInterfaces.Compile.Tests.csproj b/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/Thrift.PublicInterfaces.Compile.Tests.csproj
index d34c60a..bb93894 100644
--- a/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/Thrift.PublicInterfaces.Compile.Tests.csproj
+++ b/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/Thrift.PublicInterfaces.Compile.Tests.csproj
@@ -74,6 +74,7 @@
<!-- Generate the thrift test files -->
<Exec Command="$(PathToThrift) -gen netstd:wcf,union,serial -r ./CassandraTest.thrift" />
<Exec Command="$(PathToThrift) -gen netstd:wcf,union,serial -r ./optional_required_default.thrift" />
+ <Exec Command="$(PathToThrift) -gen netstd:wcf,union,serial -r ./name_conflicts.thrift" />
<Exec Command="$(PathToThrift) -gen netstd:wcf,union,serial -r ./../../../../test/ThriftTest.thrift" />
<Exec Command="$(PathToThrift) -gen netstd:wcf,union,serial -r ./../../../../contrib/fb303/if/fb303.thrift" />
<Exec Command="$(PathToThrift) -gen netstd:wcf,union,serial -r ./Thrift5253.thrift" />
diff --git a/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/name_conflicts.enum.thrift b/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/name_conflicts.enum.thrift
new file mode 100644
index 0000000..c3ca127
--- /dev/null
+++ b/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/name_conflicts.enum.thrift
@@ -0,0 +1,36 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+// Testcases for
+// - THRIFT-5091 Netstd generator produces uncompileable code for struct names ending with "_result" or "_args"
+// - THRIFT-5444 netstd generator produces uncompileable code for enums ending with "_result" or "_args"
+
+namespace * name_conflicts_enum
+
+enum some_result {
+ foo,
+ bar,
+ baz
+}
+
+enum some_args {
+ foo,
+ bar,
+ baz
+}
+
+
+// EOF
diff --git a/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/name_conflicts.thrift b/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/name_conflicts.thrift
new file mode 100644
index 0000000..66282ba
--- /dev/null
+++ b/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/name_conflicts.thrift
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+// Testcases for
+// - THRIFT-5091 Netstd generator produces uncompileable code for struct names ending with "_result" or "_args"
+// - THRIFT-5444 netstd generator produces uncompileable code for enums ending with "_result" or "_args"
+
+namespace * name_conflicts
+
+include "name_conflicts.enum.thrift"
+
+struct some_struct_args {
+ 1: name_conflicts.enum.some_args some_args
+ 2: name_conflicts.enum.some_result some_result
+}
+
+exception some_error_result {
+ 1: name_conflicts.enum.some_args some_args
+ 2: name_conflicts.enum.some_result some_result
+}
+
+service some_service {
+
+ name_conflicts.enum.some_result some_method(
+ 1: name_conflicts.enum.some_args some_args
+ 2: some_struct_args more_args
+ ) throws (
+ 1: some_error_result some_error_result
+ )
+
+}
+
+// EOF
diff --git a/test/netstd/Client/TestClient.cs b/test/netstd/Client/TestClient.cs
index 70a21e1..2d18cf1 100644
--- a/test/netstd/Client/TestClient.cs
+++ b/test/netstd/Client/TestClient.cs
@@ -15,6 +15,9 @@
// specific language governing permissions and limitations
// under the License.
+#pragma warning disable IDE0066 // switch expression
+#pragma warning disable IDE0057 // substring
+
using System;
using System.Collections.Generic;
using System.Diagnostics;