GHA/build: upgrade artifact-actions from v3 to v4
V3 is based on Node.js v16 and will get deprecated. Currently it's just causing a warning.
With v4 the artifact-upload action fails as all matrix-jobs use the same name and the
default prevents overwriting existing ones. Therefore we use individual artifact names
which will also preserve all logs, not just a singe one only.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 2472029..f126a92 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -70,7 +70,7 @@
# only upload while building ubuntu-20.04
- name: Archive built thrift compiler
if: matrix.os == 'ubuntu-20.04'
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
with:
name: thrift-compiler
path: compiler/cpp/thrift
@@ -157,7 +157,7 @@
run: |
./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-go/with-go/')
- - uses: actions/download-artifact@v3
+ - uses: actions/download-artifact@v4
with:
name: thrift-compiler
path: compiler/cpp
@@ -181,7 +181,7 @@
- name: Upload go precross artifacts
if: matrix.go == '1.22'
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
with:
name: go-precross
if-no-files-found: error
@@ -235,7 +235,7 @@
run: |
./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-java/with-java/' | sed 's/without-kotlin/with-kotlin/')
- - uses: actions/download-artifact@v3
+ - uses: actions/download-artifact@v4
with:
name: thrift-compiler
path: compiler/cpp
@@ -253,7 +253,7 @@
run: make -C lib/java install
- name: Upload java libthrift artifacts
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
with:
name: libthrift
if-no-files-found: error
@@ -266,7 +266,7 @@
run: make -C lib/java precross
- name: Upload java precross artifacts
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
with:
name: java-precross
if-no-files-found: error
@@ -288,7 +288,7 @@
run: make -C lib/kotlin precross
- name: Upload kotlin precross artifacts
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
with:
name: kotlin-precross
if-no-files-found: error
@@ -310,7 +310,7 @@
run: |
./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-swift/with-swift/')
- - uses: actions/download-artifact@v3
+ - uses: actions/download-artifact@v4
with:
name: thrift-compiler
path: compiler/cpp
@@ -324,7 +324,7 @@
run: make -C test/swift precross
- name: Upload swift precross artifacts
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
with:
name: swift-precross
if-no-files-found: error
@@ -363,7 +363,7 @@
run: |
./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-rs/with-rs/')
- - uses: actions/download-artifact@v3
+ - uses: actions/download-artifact@v4
with:
name: thrift-compiler
path: compiler/cpp
@@ -386,7 +386,7 @@
run: make -C test/rs precross
- name: Upload rust precross artifacts
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
with:
name: rs-precross
if-no-files-found: error
@@ -434,7 +434,7 @@
run: |
./configure $(echo $CONFIG_ARGS_FOR_LIBS | sed 's/without-py3/with-py3/')
- - uses: actions/download-artifact@v3
+ - uses: actions/download-artifact@v4
with:
name: thrift-compiler
path: compiler/cpp
@@ -490,31 +490,31 @@
sudo apt-get install -y --no-install-recommends openssl ca-certificates
- name: Download java precross artifacts
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
with:
name: java-precross
path: lib/java/build
- name: Download kotlin precross artifacts
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
with:
name: kotlin-precross
path: lib/kotlin
- name: Download swift precross artifacts
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
with:
name: swift-precross
path: test/swift/CrossTests/.build/x86_64-unknown-linux-gnu/debug
- name: Download rust precross artifacts
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
with:
name: rs-precross
path: test/rs/bin
- name: Download go precross artifacts
- uses: actions/download-artifact@v3
+ uses: actions/download-artifact@v4
with:
name: go-precross
path: test/go/bin
@@ -540,10 +540,10 @@
--client ${{ matrix.client_lang }}
- name: Upload log files from failed cross test runs
- uses: actions/upload-artifact@v3
+ uses: actions/upload-artifact@v4
if: failure()
with:
- name: cross-test-log
+ name: cross-test-log_${{ matrix.server_lang }}-${{ matrix.client_lang }}
path: test/log/
retention-days: 3