commit 17a9cffabb746f7dc481a5af9d8a1aeeda537fb6
author proller <proller@users.noreply.github.com> Wed Dec 05 19:11:20 2018 +0300
committer James E. King III <jking@apache.org> Wed Dec 05 16:14:09 2018 -0500
tree 7cf7c71986192c3edbb050615060ecfbcefa950e
parent 54e9587117595d3ecbde1bf8065dc09197808bdb

Fix warning: catching polymorphic type ‘class std::runtime_error’ by value

../contrib/thrift/lib/cpp/src/thrift/protocol/TJSONProtocol.cpp:902:35: warning: catching polymorphic type ‘class std::runtime_error’ by value [-Wcatch-value=]
       } catch (std::runtime_error e) {
                                   ^
../contrib/thrift/lib/cpp/src/thrift/protocol/TJSONProtocol.cpp:915:33: warning: catching polymorphic type ‘class std::runtime_error’ by value [-Wcatch-value=]
     } catch (std::runtime_error e) {
                                 ^

lib/cpp/src/thrift/protocol/TJSONProtocol.cpp

diff --git a/lib/cpp/src/thrift/protocol/TJSONProtocol.cpp b/lib/cpp/src/thrift/protocol/TJSONProtocol.cpp
index a49a148..80def7f 100644
--- a/lib/cpp/src/thrift/protocol/TJSONProtocol.cpp
+++ b/lib/cpp/src/thrift/protocol/TJSONProtocol.cpp
@@ -899,7 +899,7 @@
       }
       try {
         num = fromString<double>(str);
-      } catch (std::runtime_error e) {
+      } catch (std::runtime_error& e) {
         throw TProtocolException(TProtocolException::INVALID_DATA,
                                      "Expected numeric value; got \"" + str + "\"");
       }
@@ -912,7 +912,7 @@
     result += readJSONNumericChars(str);
     try {
       num = fromString<double>(str);
-    } catch (std::runtime_error e) {
+    } catch (std::runtime_error& e) {
       throw TProtocolException(TProtocolException::INVALID_DATA,
                                    "Expected numeric value; got \"" + str + "\"");
     }