THRIFT-2783:Prop bin encoding in node
Client: Node Lib
Patch: John Campbell
Fixes node web socket lib bin encoding propagation.
diff --git a/lib/nodejs/lib/thrift/web_server.js b/lib/nodejs/lib/thrift/web_server.js
index e6f6f97..40fc1ae 100644
--- a/lib/nodejs/lib/thrift/web_server.js
+++ b/lib/nodejs/lib/thrift/web_server.js
@@ -450,12 +450,12 @@
//Handle WebSocket calls (TWebSocketTransport)
///////////////////////////////////////////////////
- function processWS(data, socket, svc) {
+ function processWS(data, socket, svc, binEncoding) {
svc.transport.receiver(function(transportWithData) {
var input = new svc.protocol(transportWithData);
var output = new svc.protocol(new svc.transport(undefined, function(buf) {
try {
- var frame = wsFrame.encode(buf);
+ var frame = wsFrame.encode(buf, null, binEncoding);
socket.write(frame);
} catch (err) {
//TODO: Add better error processing
@@ -537,7 +537,7 @@
}
//If this completes a message process it
if (result.FIN) {
- processWS(result.data, socket, svc);
+ processWS(result.data, socket, svc, result.binEncoding);
} else {
data = result.data;
}