commit 0a84eae1db28abb5e3ee730e8fa40a154c6e1097
author Philip Frank <ich@philipfrank.de> Wed Dec 27 12:54:28 2017 +0100
committer James E. King, III <jking@apache.org> Thu Dec 28 07:57:36 2017 -0500
tree 83a1e8f5ad760c15ea4589f11c901b9d85841d48
parent 041c3c777db9639b0a9195bc6aa1f935501fd506

THRIFT-4437: JavaScript WebSocket - fix duplicate callbacks and enable ThriftWS test suite
Client: js

This closes #1450

lib/js/Gruntfile.js

diff --git a/lib/js/Gruntfile.js b/lib/js/Gruntfile.js
index bff250f..e678cd5 100644
--- a/lib/js/Gruntfile.js
+++ b/lib/js/Gruntfile.js
@@ -161,11 +161,13 @@
                               'external_daemon:ThriftTestServer', 'external_daemon:ThriftTestServer_TLS',
                               'shell:ThriftGenDeepConstructor', 'qunit:ThriftDeepConstructor',
                               'qunit:ThriftJS', 'qunit:ThriftJS_TLS',
+                              'qunit:ThriftWS',
                               'shell:ThriftGenJQ', 'qunit:ThriftJSJQ', 'qunit:ThriftJSJQ_TLS'
                              ]);
   grunt.registerTask('default', ['jshint', 'shell:InstallThriftJS', 'shell:InstallThriftNodeJSDep', 'shell:ThriftGen',
                                  'external_daemon:ThriftTestServer', 'external_daemon:ThriftTestServer_TLS',
                                  'qunit:ThriftJS', 'qunit:ThriftJS_TLS',
+                                 'qunit:ThriftWS',
                                  'shell:ThriftGenJQ', 'qunit:ThriftJSJQ', 'qunit:ThriftJSJQ_TLS',
                                  'concat', 'uglify', 'jsdoc'
                                 ]);

lib/js/src/thrift.js

diff --git a/lib/js/src/thrift.js b/lib/js/src/thrift.js
index 1a11871..5d420a2 100644
--- a/lib/js/src/thrift.js
+++ b/lib/js/src/thrift.js
@@ -572,18 +572,11 @@
           var clientCallback = callback;
           return function(msg) {
             self.setRecvBuffer(msg);
-            clientCallback();
+            if (clientCallback) {
+                clientCallback();
+            }
           };
         }()));
-        if(callback) {
-          this.callbacks.push((function() {
-            var clientCallback = callback;
-            return function(msg) {
-              self.setRecvBuffer(msg);
-              clientCallback();
-            };
-          }()));
-        }
       } else {
         //Queue the send to go out __onOpen
         this.send_pending.push({