commit 06340a4664cd05cb78064a4216736c8aa4f782a8
author Jens Geyer <jensg@apache.org> Fri Mar 25 01:34:03 2016 +0200
committer Jens Geyer <jensg@apache.org> Fri Mar 25 02:28:24 2016 +0200
tree 955de035510c8dd56139b79301967c29b5064f68
parent 1043d71c2efb0ffdc2ec526c4177b97a8a0ff4c6

THRIFT-3751 Compiler allows field ids that are too large for generated code
Client: Compiler (General)
Patch: Jens Geyer

This closes #964

compiler/cpp/src/thrifty.yy

diff --git a/compiler/cpp/src/thrifty.yy b/compiler/cpp/src/thrifty.yy
index dee4cb9..292670d 100644
--- a/compiler/cpp/src/thrifty.yy
+++ b/compiler/cpp/src/thrifty.yy
@@ -913,11 +913,19 @@
         $$.value = static_cast<int32_t>($1);
         $$.auto_assigned = false;
       }
+      if( (SHRT_MIN > $$.value) || ($$.value > SHRT_MAX)) {
+        pwarning(1, "Field key (%d) exceeds allowed range (%d..%d).\n",
+                 $$.value, SHRT_MIN, SHRT_MAX);
+      }
     }
 |
     {
       $$.value = y_field_val--;
       $$.auto_assigned = true;
+      if( (SHRT_MIN > $$.value) || ($$.value > SHRT_MAX)) {
+        pwarning(1, "Field key (%d) exceeds allowed range (%d..%d).\n",
+                 $$.value, SHRT_MIN, SHRT_MAX);
+      }
     }
 
 FieldReference: