commit 9c1400c124c9ac07ed835110408e1aaa5ed2630e
author Pavlo Shchelokovskyy <shchelokovskyy@gmail.com> Fri Apr 11 14:15:11 2025 +0000
committer Pavlo Shchelokovskyy <shchelokovskyy@gmail.com> Tue Apr 15 06:37:45 2025 +0000
tree 40d8958b1b5228285a77ddeb2a5c6799a7e47713
parent 20bb0e7cd15318bcb321a3aab6e06e04f97bb61b

Wait for actual volume detach in multiattach tests

catching "in-use" volume transitioning back to "in-use" is error prone,
the volume might've been not even started to be detached,
but the test logic already may consider it as 'detached' and proceed.
As a result, such "in-use" volume might fail to be deleted later.

Related-Issue: PRODX-51560
Change-Id: Ic6672846f4dd3ccccdcb417a0b50b1d542e1813b

tempest/api/compute/volumes/test_attach_volume.py

diff --git a/tempest/api/compute/volumes/test_attach_volume.py b/tempest/api/compute/volumes/test_attach_volume.py
index 5e230c6..73ea12f 100644
--- a/tempest/api/compute/volumes/test_attach_volume.py
+++ b/tempest/api/compute/volumes/test_attach_volume.py
@@ -375,8 +375,19 @@
         volume = self.volumes_client.show_volume(volume_id)['volume']
         attachments = volume['attachments']
         wait_status = 'in-use' if len(attachments) > 1 else 'available'
+        attachment_id = [
+            attachment["attachment_id"] for attachment in attachments
+            if attachment["server_id"] == server_id
+        ][0]
         # Now detach the volume from the given server.
         self.servers_client.detach_volume(server_id, volume_id)
+        # wait for both cinder and nova detaching the volume
+        waiters.wait_for_volume_attachment_remove_from_server(
+            self.servers_client, server_id, volume_id
+        )
+        waiters.wait_for_volume_attachment_remove(
+            self.volumes_client, volume_id, attachment_id
+        )
         # Now wait for the volume status to change.
         waiters.wait_for_volume_resource_status(
             self.volumes_client, volume_id, wait_status)