commit f603b05dc518a82041b0210f7f5c22146d3bff2e
author Ghanshyam <ghanshyam.mann@nectechnologies.in> Wed Dec 16 15:06:55 2015 +0900
committer Ghanshyam <ghanshyam.mann@nectechnologies.in> Wed Dec 16 15:06:55 2015 +0900
tree 04f2a22e72dc0cf19eaaa04ba2aeca46311fb0a5
parent 25b3016f401f4d68ea0af4790d6029be247b9478

Fix telemetry tests to use v1 create image correctly

Telemetry create image using v1 as well as v2 glance service client.
And Glance has different set of expected param between v1 and v2.

But Telemetry tests pass common arg in both case and end up with wrong
arg for v1 image-create('visibility' is unexpected)

Caught this issue on Ia03d5e8fdf7d7eac338665670b561e452a1d31d9

This commit fix this issue.

Change-Id: I14e16a1a7d9813b324ee40545c07f0e88fb637b7
Closes-Bug: #1526617

tempest/api/telemetry/base.py

diff --git a/tempest/api/telemetry/base.py b/tempest/api/telemetry/base.py
index 8b617ac..bbf6db2 100644
--- a/tempest/api/telemetry/base.py
+++ b/tempest/api/telemetry/base.py
@@ -75,10 +75,11 @@
         return body
 
     @classmethod
-    def create_image(cls, client):
-        body = client.create_image(
-            name=data_utils.rand_name('image'), container_format='bare',
-            disk_format='raw', visibility='private')
+    def create_image(cls, client, **kwargs):
+        body = client.create_image(name=data_utils.rand_name('image'),
+                                   container_format='bare',
+                                   disk_format='raw',
+                                   **kwargs)
         # TODO(jswarren) Move ['image'] up to initial body value assignment
         # once both v1 and v2 glance clients include the full response
         # object.

tempest/api/telemetry/test_telemetry_notification_api.py

diff --git a/tempest/api/telemetry/test_telemetry_notification_api.py b/tempest/api/telemetry/test_telemetry_notification_api.py
index 7511505..a575125 100644
--- a/tempest/api/telemetry/test_telemetry_notification_api.py
+++ b/tempest/api/telemetry/test_telemetry_notification_api.py
@@ -39,7 +39,7 @@
     @testtools.skipIf(not CONF.image_feature_enabled.api_v1,
                       "Glance api v1 is disabled")
     def test_check_glance_v1_notifications(self):
-        body = self.create_image(self.image_client)
+        body = self.create_image(self.image_client, is_public=False)
         self.image_client.update_image(body['id'], data='data')
 
         query = 'resource', 'eq', body['id']
@@ -55,7 +55,7 @@
     @testtools.skipIf(not CONF.image_feature_enabled.api_v2,
                       "Glance api v2 is disabled")
     def test_check_glance_v2_notifications(self):
-        body = self.create_image(self.image_client_v2)
+        body = self.create_image(self.image_client_v2, visibility='private')
 
         self.image_client_v2.store_image_file(body['id'], "file")
         self.image_client_v2.show_image_file(body['id'])