Fix ICMP code/type in security group rule test
Security group rule with ICMP protocol has type/code fields which
should follow ICMP specification. Remove the ones that are invalid
and add more meaningful type/code values.
- Echo Request (type 8, code 0)
- Echo Response (type 0, code 0)
- Time Exceeded (type 11, code None)
Change-Id: Ia82193eca71f97581e11badd545ac28236f68f85
Closes-bug: #1425328
diff --git a/tempest/api/network/test_security_groups.py b/tempest/api/network/test_security_groups.py
index f9af3cc..6d02eb5 100644
--- a/tempest/api/network/test_security_groups.py
+++ b/tempest/api/network/test_security_groups.py
@@ -171,7 +171,7 @@
sg_id = group_create_body['security_group']['id']
direction = 'ingress'
protocol = 'icmp'
- icmp_type_codes = [(3, 2), (2, 3), (3, 0), (2, None)]
+ icmp_type_codes = [(3, 2), (3, 0), (8, 0), (0, 0), (11, None)]
for icmp_type, icmp_code in icmp_type_codes:
self._create_verify_security_group_rule(sg_id, direction,
self.ethertype, protocol,