Fixes lp:1003476. Adds negative tests for images
This branch adds negative tests to create and delete image API.
Change-Id: Id073454454cd2b6994c7e60d9842640db49f19af
diff --git a/tempest/tests/test_images.py b/tempest/tests/test_images.py
index 65fd4be..c5ea509 100644
--- a/tempest/tests/test_images.py
+++ b/tempest/tests/test_images.py
@@ -7,6 +7,7 @@
from tempest import openstack
from tempest.common.utils import data_utils
from tempest import exceptions
+from tempest.tests import utils
class ImagesTest(BaseComputeTest):
@@ -18,7 +19,37 @@
def setUpClass(cls):
cls.client = cls.images_client
cls.servers_client = cls.servers_client
- cls.create_image_enabled = cls.config.compute.create_image_enabled
+
+ cls.user1 = cls.config.compute.username
+ cls.user2 = cls.config.compute.alt_username
+ cls.user2_password = cls.config.compute.alt_password
+ cls.user2_tenant_name = cls.config.compute.alt_tenant_name
+ cls.multi_user = False
+ cls.image_ids = []
+
+ if (cls.user2 and cls.user1 != cls.user2 and cls.user2_password \
+ and cls.user2_tenant_name):
+
+ try:
+ cls.alt_manager = openstack.AltManager()
+ cls.alt_client = cls.alt_manager.images_client
+ except exceptions.AuthenticationFailure:
+ # multi_user is already set to false, just fall through
+ pass
+ else:
+ cls.multi_user = True
+
+ def tearDown(self):
+ """Terminate test instances created after a test is executed"""
+ for server in self.servers:
+ resp, body = self.servers_client.delete_server(server['id'])
+ if resp['status'] == '204':
+ self.servers.remove(server)
+ self.servers_client.wait_for_server_termination(server['id'])
+
+ for image_id in self.image_ids:
+ self.client.delete_image(image_id)
+ self.image_ids.remove(image_id)
@attr(type='smoke')
@unittest.skipUnless(create_image_enabled,
@@ -103,6 +134,155 @@
" with invalid server id")
@attr(type='negative')
+ @utils.skip_unless_attr('multi_user', 'Second user not configured')
+ def test_create_image_for_server_in_another_tenant(self):
+ """Creating image of another tenant's server should be return error"""
+ server = self.create_server()
+
+ snapshot_name = rand_name('test-snap-')
+ self.assertRaises(exceptions.NotFound, self.alt_client.create_image,
+ server['id'], snapshot_name)
+
+ @attr(type='negative')
+ def test_create_image_when_server_is_building(self):
+ """Return error when creating an image of a server that is building"""
+ server_name = rand_name('test-vm-')
+ resp, server = self.servers_client.create_server(server_name,
+ self.image_ref,
+ self.flavor_ref)
+ self.servers.append(server)
+ snapshot_name = rand_name('test-snap-')
+ self.assertRaises(exceptions.Duplicate, self.client.create_image,
+ server['id'], snapshot_name)
+
+ @attr(type='negative')
+ def test_create_image_when_server_is_rebooting(self):
+ """Return error when creating an image of server that is rebooting"""
+ server = self.create_server()
+ self.servers_client.reboot(server['id'], 'HARD')
+
+ snapshot_name = rand_name('test-snap-')
+ self.assertRaises(exceptions.Duplicate, self.client.create_image,
+ server['id'], snapshot_name)
+
+ @attr(type='negative')
+ def test_create_image_when_server_is_terminating(self):
+ """Return an error when creating image of server that is terminating"""
+ server = self.create_server()
+ self.servers_client.delete_server(server['id'])
+
+ snapshot_name = rand_name('test-snap-')
+ self.assertRaises(exceptions.Duplicate, self.client.create_image,
+ server['id'], snapshot_name)
+
+ @attr(type='negative')
+ def test_create_second_image_when_first_image_is_being_saved(self):
+ """Disallow creating another image when first image is being saved"""
+ server = self.create_server()
+
+ try:
+ # Create first snapshot
+ snapshot_name = rand_name('test-snap-')
+ resp, body = self.client.create_image(server['id'], snapshot_name)
+ image_id = data_utils.parse_image_id(resp['location'])
+ self.image_ids.append(image_id)
+
+ # Create second snapshot
+ alt_snapshot_name = rand_name('test-snap-')
+ self.client.create_image(server['id'], alt_snapshot_name)
+ except exceptions.Duplicate:
+ pass
+
+ else:
+ self.fail("Should allow creating an image when another image of"
+ "the server is still being saved")
+
+ @attr(type='negative')
+ @unittest.skip("Until Bug 1004564 is fixed")
+ def test_create_image_specify_name_over_256_chars(self):
+ """Return an error if snapshot name over 256 characters is passed"""
+ server = self.create_server()
+
+ try:
+ snapshot_name = rand_name('a' * 260)
+ self.assertRaises(exceptions.BadRequest, self.client.create_image,
+ server['id'], snapshot_name)
+ except:
+ self.fail("Should return 400 Bad Request if image name is over 256"
+ " characters")
+
+ @attr(type='negative')
+ @unittest.skip("Until Bug 1005397 is fixed")
+ def test_create_image_specify_uuid_35_characters_or_less(self):
+ """Return an error if Image ID passed is 35 characters or less"""
+ try:
+ snapshot_name = rand_name('test-snap-')
+ test_uuid = ('a' * 35)
+ self.assertRaises(exceptions.BadRequest, self.client.create_image,
+ test_uuid, snapshot_name)
+ except:
+ self.fail("Should return 400 Bad Request if server uuid is 35"
+ " characters or less")
+
+ @attr(type='negative')
+ @unittest.skip("Until Bug 1005397 is fixed")
+ def test_create_image_specify_uuid_37_characters_or_more(self):
+ """Return an error if Image ID passed is 37 characters or more"""
+ try:
+ snapshot_name = rand_name('test-snap-')
+ test_uuid = ('a' * 37)
+ self.assertRaises(exceptions.BadRequest, self.client.create_image,
+ test_uuid, snapshot_name)
+ except:
+ self.fail("Should return 400 Bad Request if server uuid is 37"
+ " characters or more")
+
+ @attr(type='negative')
+ @unittest.skip("Until Bug 1006725 is fixed")
+ def test_create_image_specify_multibyte_character_image_name(self):
+ """Return an error if the image name has multi-byte characters"""
+ server = self.create_server()
+
+ try:
+ snapshot_name = rand_name('\xef\xbb\xbf')
+ self.assertRaises(exceptions.BadRequest,
+ self.client.create_image, server['id'],
+ snapshot_name)
+ except:
+ self.fail("Should return 400 Bad Request if multi byte characters"
+ " are used for image name")
+
+ @attr(type='negative')
+ @unittest.skip("Until Bug 1005423 is fixed")
+ def test_create_image_specify_invalid_metadata(self):
+ """Return an error when creating image with invalid metadata"""
+ server = self.create_server()
+
+ try:
+ snapshot_name = rand_name('test-snap-')
+ meta = {'': ''}
+ self.assertRaises(exceptions.BadRequest, self.client.create_image,
+ server['id'], snapshot_name, meta)
+
+ except:
+ self.fail("Should raise 400 Bad Request if meta data is invalid")
+
+ @attr(type='negative')
+ @unittest.skip("Until Bug 1005423 is fixed")
+ def test_create_image_specify_metadata_over_limits(self):
+ """Return an error when creating image with meta data over 256 chars"""
+ server = self.create_server()
+
+ try:
+ snapshot_name = rand_name('test-snap-')
+ meta = {'a' * 260: 'b' * 260}
+ self.assertRaises(exceptions.OverLimit, self.client.create_image,
+ server['id'], snapshot_name, meta)
+
+ except:
+ self.fail("Should raise 413 Over Limit if meta data was too long")
+
+ @attr(type='negative')
def test_delete_image_with_invalid_image_id(self):
"""An image should not be deleted with invalid image id"""
try:
@@ -115,3 +295,94 @@
else:
self.fail("DELETE image request should rasie NotFound exception"
"when requested with invalid image")
+
+ @attr(type='negative')
+ def test_delete_non_existent_image(self):
+ """Return an error while trying to delete a non-existent image"""
+
+ non_existent_image_id = '11a22b9-12a9-5555-cc11-00ab112223fa'
+ self.assertRaises(exceptions.NotFound, self.client.delete_image,
+ non_existent_image_id)
+
+ @attr(type='negative')
+ @unittest.skip("Until Bug 1006033 is fixed")
+ def test_delete_image_blank_id(self):
+ """Return an error while trying to delete an image with blank Id"""
+
+ try:
+ self.assertRaises(exceptions.BadRequest, self.client.delete_image,
+ '')
+ except:
+ self.fail("Did not return HTTP 400 BadRequest for blank image id")
+
+ @attr(type='negative')
+ @unittest.skip("Until Bug 1006033 is fixed")
+ def test_delete_image_non_hex_string_id(self):
+ """Return an error while trying to delete an image with non hex id"""
+
+ image_id = '11a22b9-120q-5555-cc11-00ab112223gj'
+ try:
+ self.assertRaises(exceptions.BadRequest, self.client.delete_image,
+ image_id)
+ except:
+ self.fail("Did not return HTTP 400 BadRequest for non hex image")
+
+ @attr(type='negative')
+ @unittest.skip("Until Bug 1006033 is fixed")
+ def test_delete_image_negative_image_id(self):
+ """Return an error while trying to delete an image with negative id"""
+
+ try:
+ self.assertRaises(exceptions.BadRequest, self.client.delete_image,
+ -1)
+ except:
+ self.fail("Did not return HTTP 400 BadRequest for negative image "
+ "id")
+
+ @attr(type='negative')
+ @unittest.skip("Until Bug 1006033 is fixed")
+ def test_delete_image_id_is_over_35_character_limit(self):
+ """Return an error while trying to delete image with id over limit"""
+
+ try:
+ self.assertRaises(exceptions.OverLimit, self.client.delete_image,
+ '11a22b9-120q-5555-cc11-00ab112223gj-3fac')
+ except:
+ self.fail("Did not return HTTP 413 OverLimit for image id that "
+ "exceeds 35 character ID length limit")
+
+ @attr(type='negative')
+ @utils.skip_unless_attr('multi_user', 'Second user not configured')
+ def test_delete_image_of_another_tenant(self):
+ """Return an error while trying to delete another tenant's image"""
+
+ server = self.create_server()
+
+ snapshot_name = rand_name('test-snap-')
+ resp, body = self.client.create_image(server['id'], snapshot_name)
+ image_id = data_utils.parse_image_id(resp['location'])
+ self.image_ids.append(image_id)
+ self.client.wait_for_image_resp_code(image_id, 200)
+ self.client.wait_for_image_status(image_id, 'ACTIVE')
+
+ # Delete image
+ self.assertRaises(exceptions.NotFound,
+ self.alt_client.delete_image, image_id)
+
+ @attr(type='negative')
+ def test_delete_image_that_is_not_yet_active(self):
+ """Return an error while trying to delete an active that is creating"""
+
+ server = self.create_server()
+
+ snapshot_name = rand_name('test-snap-')
+ resp, body = self.client.create_image(server['id'], snapshot_name)
+ image_id = data_utils.parse_image_id(resp['location'])
+ self.image_ids.append(image_id)
+
+ # Do not wait, attempt to delete the image, ensure it's successful
+ resp, body = self.client.delete_image(image_id)
+ self.assertEqual('204', resp['status'])
+ self.image_ids.remove(image_id)
+
+ self.assertRaises(exceptions.NotFound, self.client.get_image, image_id)