commit e842fb0722a840a0884247186f8f4208847032d1
author melanie witt <melwittt@gmail.com> Thu Dec 04 15:21:57 2025 -0800
committer melanie witt <melwittt@gmail.com> Fri Dec 05 10:44:18 2025 -0800
tree dd8164d3a668c20fb07eaf566df29077e3729ef8
parent 8ccefd4bea48d6b38f7e16c50f97931b3fc2a5e2

Use local variable for live migration server client

Avoid changing self.server_client to project manager permanently
because [compute_feature_enabled]live_migrate_back_and_forth might be
set to True. If it is, the test will live migrate the server back to
the source using the os-migrate-server:migrate_live:host API, which is
not allowed for project manager by default policy.

This allows use of the project manager or admin client on a per request
basis.

Change-Id: I0ca03bda1bc560d446827be2c95b8932106f7009
Signed-off-by: melanie witt <melwittt@gmail.com>

tempest/api/compute/admin/test_live_migration.py

diff --git a/tempest/api/compute/admin/test_live_migration.py b/tempest/api/compute/admin/test_live_migration.py
index bd2e7bf..526c8a7 100644
--- a/tempest/api/compute/admin/test_live_migration.py
+++ b/tempest/api/compute/admin/test_live_migration.py
@@ -58,7 +58,7 @@
         cls.subnets_client = cls.os_primary.subnets_client
         cls.ports_client = cls.os_primary.ports_client
         cls.trunks_client = cls.os_primary.trunks_client
-        cls.mgr_server_client = cls.admin_servers_client
+        cls.server_client = cls.admin_servers_client
 
     def _migrate_server_to(self, server_id, dest_host, volume_backed=False,
                            use_manager_client=False):
@@ -70,13 +70,19 @@
             block_migration = (CONF.compute_feature_enabled.
                                block_migration_for_live_migration and
                                not volume_backed)
+        # Avoid changing self.server_client permanently because
+        # [compute_feature_enabled]live_migrate_back_and_forth might be
+        # set to True. If it is, the test will live migrate the server back to
+        # the source using the os-migrate-server:migrate_live:host API, which
+        # is not allowed for project manager by default policy.
+        server_client = self.server_client
         if use_manager_client:
-            self.mgr_server_client = self.os_project_manager.servers_client
+            server_client = self.os_project_manager.servers_client
             LOG.info("Using project manager for live migrating server: %s, "
                      "project manager user id: %s",
-                     server_id, self.mgr_server_client.user_id)
+                     server_id, server_client.user_id)
 
-        self.mgr_server_client.live_migrate_server(
+        server_client.live_migrate_server(
             server_id, host=dest_host, block_migration=block_migration,
             **kwargs)