commit bce51c53a0ab5c95d863955067e44bb309f5d1a1
author Georgy Dyuldin <g.dyuldin@gmail.com> Mon Aug 22 15:28:46 2016 +0300
committer Georgy Dyuldin <g.dyuldin@gmail.com> Mon Aug 22 17:10:00 2016 +0300
tree 93fb3645152b71e9f171ca9d02a2fcabbf62573d
parent 3d8118bee9c9a5ccec91d4b047a93447db173131

Fix exec_command to hang indefinitely

Execution `recv_exit_status` before reading from channel may cause it hang
indefinitely.

Change-Id: I24dd3802133509f250659582ffb7d7f759e80988
Closes-Bug: #1615659

tempest/lib/common/ssh.py

diff --git a/tempest/lib/common/ssh.py b/tempest/lib/common/ssh.py
index a831dbd..8e83775 100644
--- a/tempest/lib/common/ssh.py
+++ b/tempest/lib/common/ssh.py
@@ -121,7 +121,6 @@
             channel.fileno()  # Register event pipe
             channel.exec_command(cmd)
             channel.shutdown_write()
-            exit_status = channel.recv_exit_status()
 
             # If the executing host is linux-based, poll the channel
             if self._can_system_poll():
@@ -162,6 +161,8 @@
                 out_data = out_data.decode(encoding)
                 err_data = err_data.decode(encoding)
 
+            exit_status = channel.recv_exit_status()
+
             if 0 != exit_status:
                 raise exceptions.SSHExecCommandFailed(
                     command=cmd, exit_status=exit_status,