Revert "Fix of verify_glance_api_versions"
This reverts commit ff865d625cbb70e858034b06fa494cafc381cd49.
This commits broke at least Gnocchi's gate:
http://logs.openstack.org/97/370897/19/check/gate-gnocchi-dsvm-functional-file-mysql-ubuntu-xenial/6fa2852/logs/devstacklog.txt.gz#_2016-09-19_15_11_33_661
2016-09-19 15:11:30.999 | venv runtests: PYTHONHASHSEED='4186998819'
2016-09-19 15:11:30.999 | venv runtests: commands[0] | tempest verify-config -uro ../../../../tmp/tmp.YD2JoSxiWy
2016-09-19 15:11:33.659 | Traceback (most recent call last):
2016-09-19 15:11:33.660 | File "/opt/stack/new/tempest/tempest/cmd/verify_tempest_config.py", line 425, in take_action
2016-09-19 15:11:33.660 | main(parsed_args)
2016-09-19 15:11:33.660 | File "/opt/stack/new/tempest/tempest/cmd/verify_tempest_config.py", line 403, in main
2016-09-19 15:11:33.660 | verify_api_versions(os, service, update)
2016-09-19 15:11:33.660 | File "/opt/stack/new/tempest/tempest/cmd/verify_tempest_config.py", line 165, in verify_api_versions
2016-09-19 15:11:33.660 | verify[service](os, update)
2016-09-19 15:11:33.661 | File "/opt/stack/new/tempest/tempest/cmd/verify_tempest_config.py", line 129, in verify_keystone_api_versions
2016-09-19 15:11:33.661 | versions = _get_api_versions(os, 'keystone')
2016-09-19 15:11:33.661 | File "/opt/stack/new/tempest/tempest/cmd/verify_tempest_config.py", line 99, in _get_api_versions
2016-09-19 15:11:33.661 | 'glance': os.image_client,
2016-09-19 15:11:33.661 | AttributeError: 'Manager' object has no attribute 'image_client'
2016-09-19 15:11:33.662 | Running config verification...
2016-09-19 15:11:33.712 | ERROR: InvocationError: '/opt/stack/new/tempest/.tox/venv/bin/tempest verify-config -uro ../../../../tmp/tmp.YD2JoSxiWy'
Change-Id: I2eba6c6721c5260c1a117dab9801da50a4b240e4
diff --git a/tempest/cmd/verify_tempest_config.py b/tempest/cmd/verify_tempest_config.py
index 630532c..c36c9be 100644
--- a/tempest/cmd/verify_tempest_config.py
+++ b/tempest/cmd/verify_tempest_config.py
@@ -69,7 +69,7 @@
def verify_glance_api_versions(os, update):
# Check glance api versions
- versions = _get_api_versions(os, 'glance')
+ _, versions = os.image_client.get_versions()
if CONF.image_feature_enabled.api_v1 != contains_version('v1.', versions):
print_and_or_update('api_v1', 'image-feature-enabled',
not CONF.image_feature_enabled.api_v1, update)
@@ -96,7 +96,6 @@
'nova': os.servers_client,
'keystone': os.identity_client,
'cinder': os.volumes_client,
- 'glance': os.image_client,
}
if service != 'keystone':
# Since keystone may be listening on a path, do not remove the path.
diff --git a/tempest/tests/cmd/test_verify_tempest_config.py b/tempest/tests/cmd/test_verify_tempest_config.py
index 68588be..00b4542 100644
--- a/tempest/tests/cmd/test_verify_tempest_config.py
+++ b/tempest/tests/cmd/test_verify_tempest_config.py
@@ -237,45 +237,33 @@
True, True)
self.assertEqual(2, print_mock.call_count)
- @mock.patch('tempest.lib.common.http.ClosingHttp.request')
- def test_verify_glance_version_no_v2_with_v1_1(self, mock_request):
- self.useFixture(mockpatch.PatchObject(
- verify_tempest_config, '_get_unversioned_endpoint',
- return_value='http://fake_endpoint:5000'))
- fake_resp = {'versions': [{'id': 'v1.1'}]}
- fake_resp = json.dumps(fake_resp)
- mock_request.return_value = (None, fake_resp)
+ def test_verify_glance_version_no_v2_with_v1_1(self):
+ def fake_get_versions():
+ return (None, ['v1.1'])
fake_os = mock.MagicMock()
+ fake_os.image_client.get_versions = fake_get_versions
with mock.patch.object(verify_tempest_config,
'print_and_or_update') as print_mock:
verify_tempest_config.verify_glance_api_versions(fake_os, True)
print_mock.assert_called_once_with('api_v2', 'image-feature-enabled',
False, True)
- @mock.patch('tempest.lib.common.http.ClosingHttp.request')
- def test_verify_glance_version_no_v2_with_v1_0(self, mock_request):
- self.useFixture(mockpatch.PatchObject(
- verify_tempest_config, '_get_unversioned_endpoint',
- return_value='http://fake_endpoint:5000'))
- fake_resp = {'versions': [{'id': 'v1.0'}]}
- fake_resp = json.dumps(fake_resp)
- mock_request.return_value = (None, fake_resp)
+ def test_verify_glance_version_no_v2_with_v1_0(self):
+ def fake_get_versions():
+ return (None, ['v1.0'])
fake_os = mock.MagicMock()
+ fake_os.image_client.get_versions = fake_get_versions
with mock.patch.object(verify_tempest_config,
'print_and_or_update') as print_mock:
verify_tempest_config.verify_glance_api_versions(fake_os, True)
print_mock.assert_called_once_with('api_v2', 'image-feature-enabled',
False, True)
- @mock.patch('tempest.lib.common.http.ClosingHttp.request')
- def test_verify_glance_version_no_v1(self, mock_request):
- self.useFixture(mockpatch.PatchObject(
- verify_tempest_config, '_get_unversioned_endpoint',
- return_value='http://fake_endpoint:5000'))
- fake_resp = {'versions': [{'id': 'v2.0'}]}
- fake_resp = json.dumps(fake_resp)
- mock_request.return_value = (None, fake_resp)
+ def test_verify_glance_version_no_v1(self):
+ def fake_get_versions():
+ return (None, ['v2.0'])
fake_os = mock.MagicMock()
+ fake_os.image_client.get_versions = fake_get_versions
with mock.patch.object(verify_tempest_config,
'print_and_or_update') as print_mock:
verify_tempest_config.verify_glance_api_versions(fake_os, True)