Remove unnecessary asserts from test_images.py
This commit removes unnecessary assertTrue()s from the tests in
CreateRegisterImagesTest test class in
tempest.tests.image.v1.test_images. The asserts were being used to
verify a particular field in the response, however this isn't
needed, because get() will throw an error if the key is invalid.
Additionally, for those types of test assertIn() should be used
instead of assertTrue(), but since they are unnecessary the asserts
are just removed.
Change-Id: I3bd24d48eb9bbc11f39d8077d1e823b10e34c6d9
diff --git a/tempest/tests/image/v1/test_images.py b/tempest/tests/image/v1/test_images.py
index 1888b28..af09b79 100644
--- a/tempest/tests/image/v1/test_images.py
+++ b/tempest/tests/image/v1/test_images.py
@@ -49,13 +49,9 @@
self.assertTrue('id' in body)
image_id = body.get('id')
self.created_images.append(image_id)
- self.assertTrue('name' in body)
self.assertEqual('New Name', body.get('name'))
- self.assertTrue('is_public' in body)
self.assertTrue(body.get('is_public'))
- self.assertTrue('status' in body)
self.assertEqual('queued', body.get('status'))
- self.assertTrue('properties' in body)
for key, val in properties.items():
self.assertEqual(val, body.get('properties')[key])
@@ -76,11 +72,8 @@
self.assertTrue('id' in body)
image_id = body.get('id')
self.created_images.append(image_id)
- self.assertTrue('name' in body)
self.assertEqual('New Remote Image', body.get('name'))
- self.assertTrue('is_public' in body)
self.assertTrue(body.get('is_public'))
- self.assertTrue('status' in body)
self.assertEqual('active', body.get('status'))