tree e5fc35053b7c639ed6e45d600b19e09227a68244
parent 2d5bdd04a20fed8e08da4fc6d2a1ecbc1d3ec3e8
author Kevin Benton <kevin@benton.pub> 1486955875 -0800
committer Kevin Benton <kevin@benton.pub> 1486978347 -0800

Fix router port IP address references

The _verify_network_details method is fetching all
router interfaces, including ones that have nothing
to do with the test details being verified.
So it can end up catching a router interface that is being
cleaned up in a concurrent test which has no IP addresses
anymore.

Additionally, it's currently incompatible with router interfaces
containing multiple fixed IPs from different subnets, which would
be problematic if we added more IPv6 tests since routers attached
to multiple IPv6 subnets on the same network re-use the same
interface.

This patch alters the logic to iterate over the fixed IPs
rather than using a fixed index to work with both multiple IP
cases as well as no IP cases. Additionally, it stops fetching all
ports and just fetches ports with the device_id we are looking for.

Closes-Bug: #1664020
Change-Id: I2134ad8df19290fc7161ef22d80fcb34c8d6266a