tree 872dc9d2ea1ec6ad7a24a35094f7ba709635fdc9
parent 11e1e88660aadbb36571546346c798295c599741
author Andrea Frittoli (andreaf) <andrea.frittoli@hpe.com> 1465466942 +0100
committer Andrea Frittoli (andreaf) <andrea.frittoli@hpe.com> 1465468342 +0100

Stop passing TestResources to Managers

Dynamic credential providers generate TestResource objects, which
behave like Credentials but also include network resources.
We used to pass those directly into client managers, but that has
several issues: the interface of the client manager is confusing,
because it accepts two different type of objects in one parameter.
Having the client manager depending on the dynamic credential provider
is a problem because in turn that depends on the client manager,
which may lead to circular dependencies when trying to make those
stable interfaces for tempest.lib.
Finally TestResources seem to confused developers, since a number of tests
ignored the possibility of getting Credential fields from TestResources
directly, and went through the inner credentials atttribute.

I think the best approach for now is to pass auth.Credentials objects
only into the client manager. The client manager does not use the
network resources anyways.

We plan to refactor the link between credential provider and network
resources anyways, so it's better to have that outside of client
managers.

Change-Id: I71d4587bf0b640d05d0f78fb84364ce4d2d021f3
Partially-implements: bp client-manager-refactor