Merge "zuul: Add a CentOS 8 stream job to integrated-gate-compute"
diff --git a/releasenotes/notes/add-qos-minimum-packet-rule-client-c8bfe09873032d4a.yaml b/releasenotes/notes/add-qos-minimum-packet-rule-client-c8bfe09873032d4a.yaml
new file mode 100644
index 0000000..b65b164
--- /dev/null
+++ b/releasenotes/notes/add-qos-minimum-packet-rule-client-c8bfe09873032d4a.yaml
@@ -0,0 +1,10 @@
+---
+features:
+ - |
+ Added QoS minimum packet rate rule client:
+
+ * create_minimum_packet_rate_rule
+ * update_minimum_packet_rate_rule
+ * show_minimum_packet_rate_rule
+ * list_minimum_packet_rate_rules
+ * delete_minimum_packet_rate_rule also
diff --git a/tempest/lib/services/network/qos_minimum_packet_rate_rules_client.py b/tempest/lib/services/network/qos_minimum_packet_rate_rules_client.py
new file mode 100644
index 0000000..98bcafe
--- /dev/null
+++ b/tempest/lib/services/network/qos_minimum_packet_rate_rules_client.py
@@ -0,0 +1,73 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+from tempest.lib.services.network import base
+
+
+class QosMinimumPacketRateRulesClient(base.BaseNetworkClient):
+
+ def create_minimum_packet_rate_rule(self, qos_policy_id, **kwargs):
+ """Creates a minimum packet rate rule for a QoS policy.
+
+ For full list of available parameters, please refer to the official
+ API reference:
+ https://docs.openstack.org/api-ref/network/v2/index.html#create-minimum-packet-rate-rule
+ """
+ uri = '/qos/policies/%s/minimum_packet_rate_rules' % qos_policy_id
+ post_data = {'minimum_packet_rate_rule': kwargs}
+ return self.create_resource(uri, post_data)
+
+ def update_minimum_packet_rate_rule(
+ self, qos_policy_id, rule_id, **kwargs
+ ):
+ """Updates a minimum packet rate rule.
+
+ For full list of available parameters, please refer to the official
+ API reference:
+ https://docs.openstack.org/api-ref/network/v2/index.html#update-minimum-packet-rate-rule
+ """
+ uri = '/qos/policies/%s/minimum_packet_rate_rules/%s' % (
+ qos_policy_id, rule_id)
+ post_data = {'minimum_packet_rate_rule': kwargs}
+ return self.update_resource(uri, post_data)
+
+ def show_minimum_packet_rate_rule(self, qos_policy_id, rule_id, **fields):
+ """Show details of a minimum packet rate rule.
+
+ For full list of available parameters, please refer to the official
+ API reference:
+ https://docs.openstack.org/api-ref/network/v2/index.html#show-minimum-packet-rate-rule-details
+ """
+ uri = '/qos/policies/%s/minimum_packet_rate_rules/%s' % (
+ qos_policy_id, rule_id)
+ return self.show_resource(uri, **fields)
+
+ def delete_minimum_packet_rate_rule(self, qos_policy_id, rule_id):
+ """Deletes a minimum packet rate rule for a QoS policy.
+
+ For full list of available parameters, please refer to the official
+ API reference:
+ https://docs.openstack.org/api-ref/network/v2/index.html#delete-minimum-packet-rate-rule
+ """
+ uri = '/qos/policies/%s/minimum_packet_rate_rules/%s' % (
+ qos_policy_id, rule_id)
+ return self.delete_resource(uri)
+
+ def list_minimum_packet_rate_rules(self, qos_policy_id, **filters):
+ """Lists all minimum packet rate rules for a QoS policy.
+
+ For full list of available parameters, please refer to the official
+ API reference:
+ https://docs.openstack.org/api-ref/network/v2/index.html#list-minimum-packet-rate-rules-for-qos-policy
+ """
+ uri = '/qos/policies/%s/minimum_packet_rate_rules' % qos_policy_id
+ return self.list_resources(uri, **filters)
diff --git a/tempest/scenario/test_minbw_allocation_placement.py b/tempest/scenario/test_network_qos_placement.py
similarity index 93%
rename from tempest/scenario/test_minbw_allocation_placement.py
rename to tempest/scenario/test_network_qos_placement.py
index 1dc18c3..db4751b 100644
--- a/tempest/scenario/test_minbw_allocation_placement.py
+++ b/tempest/scenario/test_network_qos_placement.py
@@ -27,11 +27,13 @@
CONF = config.CONF
-class MinBwAllocationPlacementTest(manager.NetworkScenarioTest):
+class NetworkQoSPlacementTestBase(manager.NetworkScenarioTest):
+ """Base class for Network QoS testing
+
+ Base class for testing Network QoS scenarios involving placement
+ resource allocations.
+ """
credentials = ['primary', 'admin']
- required_extensions = ['port-resource-request',
- 'qos',
- 'qos-bw-minimum-ingress']
# The feature QoS minimum bandwidth allocation in Placement API depends on
# Granular resource requests to GET /allocation_candidates and Support
# allocation candidates with nested resource providers features in
@@ -46,21 +48,18 @@
compute_min_microversion = '2.72'
compute_max_microversion = 'latest'
- INGRESS_RESOURCE_CLASS = "NET_BW_IGR_KILOBIT_PER_SEC"
INGRESS_DIRECTION = 'ingress'
+ BW_RESOURCE_CLASS = "NET_BW_IGR_KILOBIT_PER_SEC"
- SMALLEST_POSSIBLE_BW = 1
# For any realistic inventory value (that is inventory != MAX_INT) an
# allocation candidate request of MAX_INT is expected to be rejected, see:
# https://github.com/openstack/placement/blob/master/placement/
# db/constants.py#L16
PLACEMENT_MAX_INT = 0x7FFFFFFF
- BANDWIDTH_1 = 1000
- BANDWIDTH_2 = 2000
@classmethod
def setup_clients(cls):
- super(MinBwAllocationPlacementTest, cls).setup_clients()
+ super().setup_clients()
cls.placement_client = cls.os_admin.placement_client
cls.networks_client = cls.os_admin.networks_client
cls.subnets_client = cls.os_admin.subnets_client
@@ -69,7 +68,31 @@
cls.qos_client = cls.os_admin.qos_client
cls.qos_min_bw_client = cls.os_admin.qos_min_bw_client
cls.flavors_client = cls.os_adm.flavors_client
- cls.servers_client = cls.os_adm.servers_client
+ cls.servers_client = cls.os_primary.servers_client
+
+ def _create_flavor_to_resize_to(self):
+ old_flavor = self.flavors_client.show_flavor(
+ CONF.compute.flavor_ref)['flavor']
+ new_flavor = self.flavors_client.create_flavor(**{
+ 'ram': old_flavor['ram'],
+ 'vcpus': old_flavor['vcpus'],
+ 'name': old_flavor['name'] + 'extra',
+ 'disk': old_flavor['disk'] + 1
+ })['flavor']
+ self.addCleanup(test_utils.call_and_ignore_notfound_exc,
+ self.flavors_client.delete_flavor, new_flavor['id'])
+ return new_flavor
+
+
+class MinBwAllocationPlacementTest(NetworkQoSPlacementTestBase):
+
+ required_extensions = ['port-resource-request',
+ 'qos',
+ 'qos-bw-minimum-ingress']
+
+ SMALLEST_POSSIBLE_BW = 1
+ BANDWIDTH_1 = 1000
+ BANDWIDTH_2 = 2000
@classmethod
def skip_checks(cls):
@@ -143,20 +166,20 @@
def _check_if_allocation_is_possible(self):
alloc_candidates = self.placement_client.list_allocation_candidates(
- resources1='%s:%s' % (self.INGRESS_RESOURCE_CLASS,
+ resources1='%s:%s' % (self.BW_RESOURCE_CLASS,
self.SMALLEST_POSSIBLE_BW))
if len(alloc_candidates['provider_summaries']) == 0:
self.fail('No allocation candidates are available for %s:%s' %
- (self.INGRESS_RESOURCE_CLASS, self.SMALLEST_POSSIBLE_BW))
+ (self.BW_RESOURCE_CLASS, self.SMALLEST_POSSIBLE_BW))
# Just to be sure check with impossible high (placement max_int),
# allocation
alloc_candidates = self.placement_client.list_allocation_candidates(
- resources1='%s:%s' % (self.INGRESS_RESOURCE_CLASS,
+ resources1='%s:%s' % (self.BW_RESOURCE_CLASS,
self.PLACEMENT_MAX_INT))
if len(alloc_candidates['provider_summaries']) != 0:
self.fail('For %s:%s there should be no available candidate!' %
- (self.INGRESS_RESOURCE_CLASS, self.PLACEMENT_MAX_INT))
+ (self.BW_RESOURCE_CLASS, self.PLACEMENT_MAX_INT))
def _boot_vm_with_min_bw(self, qos_policy_id, status='ACTIVE'):
wait_until = (None if status == 'ERROR' else status)
@@ -166,7 +189,7 @@
server = self.create_server(networks=[{'port': port['id']}],
wait_until=wait_until)
waiters.wait_for_server_status(
- client=self.os_primary.servers_client, server_id=server['id'],
+ client=self.servers_client, server_id=server['id'],
status=status, ready_wait=False, raise_on_error=False)
return server, port
@@ -178,10 +201,10 @@
bw_resource_in_alloc = False
allocation_rp = None
for rp, resources in allocations.items():
- if self.INGRESS_RESOURCE_CLASS in resources['resources']:
+ if self.BW_RESOURCE_CLASS in resources['resources']:
self.assertEqual(
min_kbps,
- resources['resources'][self.INGRESS_RESOURCE_CLASS])
+ resources['resources'][self.BW_RESOURCE_CLASS])
bw_resource_in_alloc = True
allocation_rp = rp
if min_kbps:
@@ -267,9 +290,9 @@
self._assert_allocation_is_as_expected(server['id'],
[valid_port['id']])
- self.servers_client.migrate_server(server_id=server['id'])
+ self.os_adm.servers_client.migrate_server(server_id=server['id'])
waiters.wait_for_server_status(
- client=self.os_primary.servers_client, server_id=server['id'],
+ client=self.servers_client, server_id=server['id'],
status='VERIFY_RESIZE', ready_wait=False, raise_on_error=False)
# TODO(lajoskatona): Check that the allocations are ok for the
@@ -277,9 +300,10 @@
self._assert_allocation_is_as_expected(server['id'],
[valid_port['id']])
- self.servers_client.confirm_resize_server(server_id=server['id'])
+ self.os_adm.servers_client.confirm_resize_server(
+ server_id=server['id'])
waiters.wait_for_server_status(
- client=self.os_primary.servers_client, server_id=server['id'],
+ client=self.servers_client, server_id=server['id'],
status='ACTIVE', ready_wait=False, raise_on_error=True)
self._assert_allocation_is_as_expected(server['id'],
[valid_port['id']])
@@ -304,21 +328,12 @@
self._assert_allocation_is_as_expected(server['id'],
[valid_port['id']])
- old_flavor = self.flavors_client.show_flavor(
- CONF.compute.flavor_ref)['flavor']
- new_flavor = self.flavors_client.create_flavor(**{
- 'ram': old_flavor['ram'],
- 'vcpus': old_flavor['vcpus'],
- 'name': old_flavor['name'] + 'extra',
- 'disk': old_flavor['disk'] + 1
- })['flavor']
- self.addCleanup(test_utils.call_and_ignore_notfound_exc,
- self.flavors_client.delete_flavor, new_flavor['id'])
+ new_flavor = self._create_flavor_to_resize_to()
self.servers_client.resize_server(
server_id=server['id'], flavor_ref=new_flavor['id'])
waiters.wait_for_server_status(
- client=self.os_primary.servers_client, server_id=server['id'],
+ client=self.servers_client, server_id=server['id'],
status='VERIFY_RESIZE', ready_wait=False, raise_on_error=False)
# TODO(lajoskatona): Check that the allocations are ok for the
@@ -328,7 +343,7 @@
self.servers_client.confirm_resize_server(server_id=server['id'])
waiters.wait_for_server_status(
- client=self.os_primary.servers_client, server_id=server['id'],
+ client=self.servers_client, server_id=server['id'],
status='ACTIVE', ready_wait=False, raise_on_error=True)
self._assert_allocation_is_as_expected(server['id'],
[valid_port['id']])
diff --git a/tempest/tests/lib/services/network/test_qos_minimum_packet_rate_rules_client.py b/tempest/tests/lib/services/network/test_qos_minimum_packet_rate_rules_client.py
new file mode 100644
index 0000000..3cc3de3
--- /dev/null
+++ b/tempest/tests/lib/services/network/test_qos_minimum_packet_rate_rules_client.py
@@ -0,0 +1,135 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+
+import copy
+
+from tempest.lib.services.network import qos_minimum_packet_rate_rules_client
+from tempest.tests.lib import fake_auth_provider
+from tempest.tests.lib.services import base
+
+
+class TestQosMinimumPacketRateRulesClient(base.BaseServiceTest):
+
+ FAKE_QOS_POLICY_ID = "f1011b08-1297-11e9-a1e7-c7e6825a2616"
+ FAKE_MIN_PPS_RULE_ID = "e758c89e-1297-11e9-a6cf-cf46a71e6699"
+
+ FAKE_MIN_PPS_RULE_REQUEST = {
+ 'qos_policy_id': FAKE_QOS_POLICY_ID,
+ 'min_kpps': 1000,
+ 'direction': 'ingress'
+ }
+
+ FAKE_MIN_PPS_RULE_RESPONSE = {
+ 'minimum_packet_rate_rule': {
+ 'id': FAKE_MIN_PPS_RULE_ID,
+ 'min_kpps': 1000,
+ 'direction': 'ingress'
+ }
+ }
+
+ FAKE_MIN_PPS_RULES = {
+ 'minimum_packet_rate_rules': [
+ FAKE_MIN_PPS_RULE_RESPONSE['minimum_packet_rate_rule']
+ ]
+ }
+
+ def setUp(self):
+ super(TestQosMinimumPacketRateRulesClient, self).setUp()
+ fake_auth = fake_auth_provider.FakeAuthProvider()
+ self.qos_min_pps_client = qos_minimum_packet_rate_rules_client.\
+ QosMinimumPacketRateRulesClient(fake_auth, "network", "regionOne")
+
+ def _test_create_minimum_packet_rate_rule(self, bytes_body=False):
+ self.check_service_client_function(
+ self.qos_min_pps_client.create_minimum_packet_rate_rule,
+ "tempest.lib.common.rest_client.RestClient.post",
+ self.FAKE_MIN_PPS_RULE_RESPONSE,
+ bytes_body,
+ 201,
+ **self.FAKE_MIN_PPS_RULE_REQUEST
+ )
+
+ def _test_list_minimum_packet_rate_rules(self, bytes_body=False):
+ self.check_service_client_function(
+ self.qos_min_pps_client.list_minimum_packet_rate_rules,
+ "tempest.lib.common.rest_client.RestClient.get",
+ self.FAKE_MIN_PPS_RULES,
+ bytes_body,
+ 200,
+ qos_policy_id=self.FAKE_QOS_POLICY_ID
+ )
+
+ def _test_show_minimum_packet_rate_rule(self, bytes_body=False):
+ self.check_service_client_function(
+ self.qos_min_pps_client.show_minimum_packet_rate_rule,
+ "tempest.lib.common.rest_client.RestClient.get",
+ self.FAKE_MIN_PPS_RULE_RESPONSE,
+ bytes_body,
+ 200,
+ qos_policy_id=self.FAKE_QOS_POLICY_ID,
+ rule_id=self.FAKE_MIN_PPS_RULE_ID
+ )
+
+ def _test_update_qos_polcy(self, bytes_body=False):
+ update_kwargs = {
+ "min_kpps": "20000"
+ }
+
+ resp_body = {
+ "minimum_packet_rate_rule": copy.deepcopy(
+ self.FAKE_MIN_PPS_RULE_RESPONSE['minimum_packet_rate_rule']
+ )
+ }
+ resp_body["minimum_packet_rate_rule"].update(update_kwargs)
+
+ self.check_service_client_function(
+ self.qos_min_pps_client.update_minimum_packet_rate_rule,
+ "tempest.lib.common.rest_client.RestClient.put",
+ resp_body,
+ bytes_body,
+ 200,
+ qos_policy_id=self.FAKE_QOS_POLICY_ID,
+ rule_id=self.FAKE_MIN_PPS_RULE_ID,
+ **update_kwargs)
+
+ def test_create_minimum_packet_rate_rule_with_str_body(self):
+ self._test_create_minimum_packet_rate_rule()
+
+ def test_create_minimum_packet_rate_rule_with_bytes_body(self):
+ self._test_create_minimum_packet_rate_rule(bytes_body=True)
+
+ def test_update_minimum_packet_rate_rule_with_str_body(self):
+ self._test_update_qos_polcy()
+
+ def test_update_minimum_packet_rate_rule_with_bytes_body(self):
+ self._test_update_qos_polcy(bytes_body=True)
+
+ def test_show_minimum_packet_rate_rule_with_str_body(self):
+ self._test_show_minimum_packet_rate_rule()
+
+ def test_show_minimum_packet_rate_rule_with_bytes_body(self):
+ self._test_show_minimum_packet_rate_rule(bytes_body=True)
+
+ def test_delete_minimum_packet_rate_rule(self):
+ self.check_service_client_function(
+ self.qos_min_pps_client.delete_minimum_packet_rate_rule,
+ "tempest.lib.common.rest_client.RestClient.delete",
+ {},
+ status=204,
+ qos_policy_id=self.FAKE_QOS_POLICY_ID,
+ rule_id=self.FAKE_MIN_PPS_RULE_ID)
+
+ def test_list_minimum_packet_rate_rule_with_str_body(self):
+ self._test_list_minimum_packet_rate_rules()
+
+ def test_list_minimum_packet_rate_rule_with_bytes_body(self):
+ self._test_list_minimum_packet_rate_rules(bytes_body=True)