commit 648962989dfa70703a35f2aa0597c4f1da9aecf4
author Andrea Frittoli <andrea.frittoli@hp.com> Thu Mar 12 16:29:59 2015 +0000
committer Andrea Frittoli <andrea.frittoli@hp.com> Fri Mar 06 13:15:55 2015 +0000
tree 2d986e37738e4609e6efc37d0c8d8a1fceb5ca26
parent e4414523cd40c776b94b5b9f7ddbc83277c07cec

Copy the default params dict to avoid race

The params dict passed to get_default_credentials should be
copied from DEFAULT_PARAMS, otherwise a race may happen during
unit tests which causes the wrong params to be passed in.

Closes-bug: #1431408
Change-Id: Ib58c74de0b846f6b5629067866247cfad9a63a83

tempest/common/cred_provider.py

diff --git a/tempest/common/cred_provider.py b/tempest/common/cred_provider.py
index 4d66ffc..bff9a0a 100644
--- a/tempest/common/cred_provider.py
+++ b/tempest/common/cred_provider.py
@@ -53,7 +53,7 @@
     if identity_version == 'v3':
         conf_attributes.append('domain_name')
     # Read the parts of credentials from config
-    params = DEFAULT_PARAMS
+    params = DEFAULT_PARAMS.copy()
     section, prefix = CREDENTIAL_TYPES[credential_type]
     for attr in conf_attributes:
         _section = getattr(CONF, section)