)]}'
{
  "commit": "5267263f4e4f8505c4c972fff2fd6f31831f15b2",
  "tree": "cd40861d08a392086c5cab7faf8ecfab5f345190",
  "parents": [
    "f4bf8e06f4b4218244bc8016a77a7a38327a6ad1"
  ],
  "author": {
    "name": "Leo Henken",
    "email": "lh236s@att.com",
    "time": "Fri Aug 02 11:42:52 2019 -0500"
  },
  "committer": {
    "name": "Oleh Hryhorov",
    "email": "ohryhorov@mirantis.com",
    "time": "Sun Jan 08 12:06:02 2023 +0000"
  },
  "message": "Fix test_novnc to adequately validate websocket upgrade\n\nCurrently, test_novnc validates the websocket upgrade by verifying\nthat the websocket response reports a protocol switch and that the\nresponse includes a server name specified in the configuration\nfield vnc_server_header. This explicit server name configuration\nfield introduces a security concern and convolutes the code base.\n\nHTTP RFC7231 (https://tools.ietf.org/html/rfc7231) section 6.2.2\nsays that when switching protocols, the response \"MUST generate\nan Upgrade header field that indicates which protocols will be\nswitched to\".\n\nThis patchset uses this required Upgrade field to validate the\nwebsocket upgrade instead of an environment-based configuration\nfield, making the code base cleaner, safer, and more reliable.\n\nvnc_server_header is deprecated and necessary release notes are\ncreated.\n\nChange-Id: I5d3c9bdd0d20a15ade672f276dd0f24b654e3de5\nCloses-bug: #1838777\nCloses-bug: #1840788\n",
  "tree_diff": [
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "d7e144da0e4b430f0422e7a5f3b62b9c44eadc16",
      "new_mode": 33188,
      "new_path": "releasenotes/notes/deprecate-vnc-server-header-529f07d592aefb62.yaml"
    },
    {
      "type": "modify",
      "old_id": "1dfd0f953bfe8f11ad553742ddc6ed5bece10d79",
      "old_mode": 33188,
      "old_path": "tempest/api/compute/servers/test_novnc.py",
      "new_id": "2fc94a956d29494172c423b118b525e6287b7460",
      "new_mode": 33188,
      "new_path": "tempest/api/compute/servers/test_novnc.py"
    },
    {
      "type": "modify",
      "old_id": "dbfc59dc00ff79f51df8b907da10a8221191f55f",
      "old_mode": 33188,
      "old_path": "tempest/config.py",
      "new_id": "29fc6dcf1409996abb231054d593a415a91c925d",
      "new_mode": 33188,
      "new_path": "tempest/config.py"
    }
  ]
}