commit 3059a09e24529f3949b918ae095d4120e957c07f
author John Warren <jswarren@us.ibm.com> Mon Aug 31 15:34:49 2015 -0400
committer John Warren <jswarren@us.ibm.com> Wed Sep 02 15:22:10 2015 -0400
tree 8b3883bbd82a8173c58da41b1a2b1a9aa7e50b07
parent ebaf245369c28f6571dc317ec60272022cfba761

Add hacking check for testtools.skip

Adding hacking check for testtools.skip decorator as described
in the bug referenced below.

Closes-Bug: #1490590
Change-Id: I9c456bb8b57a54fbcd1cd5249eec2292916d4ff9

tempest/tests/test_hacking.py

diff --git a/tempest/tests/test_hacking.py b/tempest/tests/test_hacking.py
index 9bc9cfe..62d2aee 100644
--- a/tempest/tests/test_hacking.py
+++ b/tempest/tests/test_hacking.py
@@ -138,3 +138,11 @@
 
         self.assertEqual(0, len(list(checks.no_mutable_default_args(
             "defined, undefined = [], {}"))))
+
+    def test_no_testtools_skip_decorator(self):
+        self.assertEqual(1, len(list(checks.no_testtools_skip_decorator(
+            " @testtools.skip('Bug xxx')"))))
+        self.assertEqual(0, len(list(checks.no_testtools_skip_decorator(
+            " @testtools.skipUnless(CONF.something, 'msg')"))))
+        self.assertEqual(0, len(list(checks.no_testtools_skip_decorator(
+            " @testtools.skipIf(CONF.something, 'msg')"))))