commit 2e24c3e1baa657bab7cb059ef5b66df4f4103a4d
author zhufl <zhu.fanglei@zte.com.cn> Thu Nov 24 14:46:42 2016 +0800
committer zhufl <zhu.fanglei@zte.com.cn> Thu Nov 24 17:38:07 2016 +0800
tree 557882f0ee99507b168bb6f1b02e515dac6ed7fc
parent 86cfa35b84be972802170aa78b8f0f1adadf21df

Use names containing "non-existing" as non-existing resource names

In test_list_servers_by_non_existing_flavor, 1234 is used as
non_existing_flavor, but it is not strange if someone happens
to use 1234 as flavor id in his environment.

Besides, we can use names containing 'non-existing' instead
of a hard-coded strange name for non-existing image/server/flavor
names, which will make code looks more clear.

Change-Id: I97e5a8723a77b5e5626ec20b439a5e6ce729d511

tempest/api/compute/servers/test_list_servers_negative.py

diff --git a/tempest/api/compute/servers/test_list_servers_negative.py b/tempest/api/compute/servers/test_list_servers_negative.py
index fcd5a24..5a35b4e 100644
--- a/tempest/api/compute/servers/test_list_servers_negative.py
+++ b/tempest/api/compute/servers/test_list_servers_negative.py
@@ -66,8 +66,7 @@
     @test.idempotent_id('ff01387d-c7ad-47b4-ae9e-64fa214638fe')
     def test_list_servers_by_non_existing_image(self):
         # Listing servers for a non existing image returns empty list
-        non_existing_image = '1234abcd-zzz0-aaa9-ppp3-0987654abcde'
-        body = self.client.list_servers(image=non_existing_image)
+        body = self.client.list_servers(image='non_existing_image')
         servers = body['servers']
         self.assertEqual([], servers)
 
@@ -75,8 +74,7 @@
     @test.idempotent_id('5913660b-223b-44d4-a651-a0fbfd44ca75')
     def test_list_servers_by_non_existing_flavor(self):
         # Listing servers by non existing flavor returns empty list
-        non_existing_flavor = 1234
-        body = self.client.list_servers(flavor=non_existing_flavor)
+        body = self.client.list_servers(flavor='non_existing_flavor')
         servers = body['servers']
         self.assertEqual([], servers)
 
@@ -84,8 +82,7 @@
     @test.idempotent_id('e2c77c4a-000a-4af3-a0bd-629a328bde7c')
     def test_list_servers_by_non_existing_server_name(self):
         # Listing servers for a non existent server name returns empty list
-        non_existing_name = 'junk_server_1234'
-        body = self.client.list_servers(name=non_existing_name)
+        body = self.client.list_servers(name='non_existing_server_name')
         servers = body['servers']
         self.assertEqual([], servers)
 
@@ -93,8 +90,7 @@
     @test.idempotent_id('fcdf192d-0f74-4d89-911f-1ec002b822c4')
     def test_list_servers_status_non_existing(self):
         # Return an empty list when invalid status is specified
-        non_existing_status = 'BALONEY'
-        body = self.client.list_servers(status=non_existing_status)
+        body = self.client.list_servers(status='non_existing_status')
         servers = body['servers']
         self.assertEqual([], servers)