remove log_console_of_servers from get_remote_client
This is never used by any caller of this function, and just causes
confusion. It also explains where console logs in scenario tests are
not as useful as they could be because we never can scope the console
logs to the guest that failed.
Change-Id: I9ff86a5b1c8c31ad4bb9b86fcda59cfeae954ef2
diff --git a/tempest/scenario/manager.py b/tempest/scenario/manager.py
index e5e0d16..afd469b 100644
--- a/tempest/scenario/manager.py
+++ b/tempest/scenario/manager.py
@@ -344,17 +344,13 @@
return secgroup
- def get_remote_client(self, server_or_ip, username=None, private_key=None,
- log_console_of_servers=None):
+ def get_remote_client(self, server_or_ip, username=None, private_key=None):
"""Get a SSH client to a remote server
@param server_or_ip a server object as returned by Tempest compute
client or an IP address to connect to
@param username name of the Linux account on the remote server
@param private_key the SSH private key to use
- @param log_console_of_servers a list of server objects. Each server
- in the list will have its console printed in the logs in case the
- SSH connection failed to be established
@return a RemoteClient object
"""
if isinstance(server_or_ip, six.string_types):
@@ -391,10 +387,7 @@
if caller:
message = '(%s) %s' % (caller, message)
LOG.exception(message)
- # If we don't explicitly set for which servers we want to
- # log the console output then all the servers will be logged.
- # See the definition of _log_console_output()
- self._log_console_output(log_console_of_servers)
+ self._log_console_output()
raise
return linux_client