commit 1bc49b951c63d3839e667fe95f684257f193197a
author Matthew Treinish <mtreinish@kortar.org> Thu Oct 08 11:10:05 2015 -0400
committer Matthew Treinish <mtreinish@kortar.org> Fri Oct 09 16:29:55 2015 -0400
tree 9071b66dda36f92b70858e68d2c409f96eff5783
parent ba8c22d7127038f23cde61e66000bc3c76e8b8b8

Handle exceptions from plugins gracefully

If a tempest plugin is poorly constructed and raises an exception
during register_opts this can interfere with the rest of tempest
running correctly. This commit makes the tempest plugin handling
a bit more defensive so things don't crash if a plugin raises an
exception, instead the error is logged and tempest moves on.

Change-Id: Ic133eee1cced5ca3c53334d3d30c7b0b043ff789

tempest/test_discover/plugins.py

diff --git a/tempest/test_discover/plugins.py b/tempest/test_discover/plugins.py
index 640b004..58a9905 100644
--- a/tempest/test_discover/plugins.py
+++ b/tempest/test_discover/plugins.py
@@ -88,7 +88,11 @@
 
     def register_plugin_opts(self, conf):
         for plug in self.ext_plugins:
-            plug.obj.register_opts(conf)
+            try:
+                plug.obj.register_opts(conf)
+            except Exception:
+                LOG.exception('Plugin %s raised an exception trying to run '
+                              'register_opts' % plug.name)
 
     def get_plugin_options_list(self):
         plugin_options = []