)]}' { "log": [ { "commit": "cacbd211250d355bcbb2bbf049cfb4bd8c94ee04", "tree": "d335d4ed400263a517a5ba15af058544d96e2755", "parents": [ "2238c69f46defb4a2328a0e5c3a4d5a3c23fea36" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Oct 21 12:30:17 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Oct 21 17:51:18 2018 +0000" }, "message": "fix: Rename test classes causing accidental skip\n\nThis patch set renames two classes that are neutron plugin\nrbac tests but don\u0027t end in the appropriate suffix of\n\"PluginRbacTest\" which is used by .zuul.yaml to correctly execute\nthe tests [0].\n\nThis means that, in effect, these tests aren\u0027t being run in any\njobs. This patch set resolves the issue.\n\nIn a follow up patch set a hacking rule will be added to enforce\ncorrect naming for plugin rbac tests.\n\n[0] https://github.com/openstack/patrole/blob/0c7f83ea1716462737a40cc32f27b95abf4557af/.zuul.yaml#L168\n\nChange-Id: Ieac5ebf70eefcebf1aebc26da95d58fcd68a202e\n" }, { "commit": "2238c69f46defb4a2328a0e5c3a4d5a3c23fea36", "tree": "cf00dca107b6b58a397938cc0f750d261d09c11a", "parents": [ "0c7f83ea1716462737a40cc32f27b95abf4557af" ], "author": { "name": "Cédric Ollivier", "email": "ollivier.cedric@gmail.com", "time": "Sun Oct 21 15:22:38 2018 +0200" }, "committer": { "name": "Cédric Ollivier", "email": "ollivier.cedric@gmail.com", "time": "Sun Oct 21 15:22:38 2018 +0200" }, "message": "Fix test_update_address_scope_shared\n\ntest_update_address_scope_shared currently fails as shared address\nscope can\u0027t be unshared [1].\n\nIt would have detected in gates if neutron-tempest-plugin was\ninstalled [2] (as it\u0027s in opnfv/functest-smoke:latest).\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/address_scope_db.py#L87\n[2] http://logs.openstack.org/47/599047/3/check/patrole-admin/11872d4/job-output.txt.gz\n\nChange-Id: I72f0cde1dab2d0a1949b55490375e8441394353d\nSigned-off-by: Cédric Ollivier \u003collivier.cedric@gmail.com\u003e\n" }, { "commit": "0c7f83ea1716462737a40cc32f27b95abf4557af", "tree": "b65bb1bde2ce84da6865da30163a6cac7d828db3", "parents": [ "28c9c3a2c7c3d07b7f12d6c8e4ad33853e27be3f", "1daa06a5b84e5fe34bac7309a729731c946604c1" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Oct 19 20:41:24 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Oct 19 20:41:24 2018 +0000" }, "message": "Merge \"Use tempest.common.identity.identity_utils for project management\"" }, { "commit": "28c9c3a2c7c3d07b7f12d6c8e4ad33853e27be3f", "tree": "513dd53564ee0e8b2ccb15f3f05adde4f3b4e5e9", "parents": [ "69250959929142c8da9bd2f9aaea47dbe66115fe" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Wed Oct 17 11:38:34 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Wed Oct 17 11:38:34 2018 -0500" }, "message": "Fix create_rbac_policy tenant_id and network_id usage\n\nThis patchset fixes mistake where we pass params, but use their origin.\n\nChange-Id: I4c73aaeba1907987306b210d2afef5b6a395e68b\n" }, { "commit": "1daa06a5b84e5fe34bac7309a729731c946604c1", "tree": "ff2b7aae1cd850df58358c0d06178e30e23232cb", "parents": [ "842845eaef1de6595e96ad253d0666555ce083f1" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Aug 31 13:56:08 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Oct 13 22:36:02 2018 +0000" }, "message": "Use tempest.common.identity.identity_utils for project management\n\nThis uses identity_utils from tempest.common.identity for\nproject creation/deletion in non-identity tests:\n\n A client that abstracts v2 and v3 identity operations.\n\n This can be used for creating and tearing down projects in tests.\n It should not be used for testing identity features.\n\nThis is a common pattern in Tempest and should be used in Patrole, too.\n\nChange-Id: Id87294bd19c7abd92d202b5ba6b49e4aac6c7e42\n" }, { "commit": "69250959929142c8da9bd2f9aaea47dbe66115fe", "tree": "575becbf652a0da1c144a353257ca2b62ec335cf", "parents": [ "7fa1f735fa66ae49589950201755c1fa5db3ae6d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Jul 29 13:08:54 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Oct 12 14:26:05 2018 +0000" }, "message": "Add volume create from image test\n\nThis patch set adds tests for the following policy:\n\n\"volume:create_from_image\" [0]\n\nNote that this is mutually exclusive with \"volume:create\" [1]\nso multi-policy is not needed for the new test:\ntest_create_volume_from_image\n\n[0] https://github.com/openstack/cinder/blob/fe69f679369057a7c381178f770bf68d0bc1cee0/cinder/policies/volumes.py#L52\n[1] https://github.com/openstack/cinder/blob/4bb00dbcf6af2f140694eb535696f0f6fe3ae80e/cinder/volume/api.py#L210\n\nChange-Id: I27bdefa57ed60e9fb1764a65afec117e86e71cee\n" }, { "commit": "7fa1f735fa66ae49589950201755c1fa5db3ae6d", "tree": "4b787f0ce23edd7d249caf122de61ba9aa03080e", "parents": [ "517183edd3e4032f396c653bc67d2a092c438da0", "8dd5f1990183b7bb9ca44e98c2e9e6e6b1bd82af" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Oct 12 12:22:12 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Oct 12 12:22:12 2018 +0000" }, "message": "Merge \"Remove invalid exception RbacConflictingPolicies\"" }, { "commit": "722455f9fe489511459c57d1331b4eaafb6baf19", "tree": "8ea22fdf2d18acfd3ea2ef8b3672eea5b8a48b43", "parents": [ "59f538fdbdf650154779028747285a5e35fa2d17", "dcd153a2a0db5c91468d106deb25c692779db770" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Oct 09 11:09:40 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Oct 09 11:09:40 2018 +0000" }, "message": "Merge \"Remove extra_attr kwarg from RbacMalformedResponse\"" }, { "commit": "8dd5f1990183b7bb9ca44e98c2e9e6e6b1bd82af", "tree": "7ea181dcf368a8ac378d902a1b7c5a6531543a91", "parents": [ "91e33c6ef17af701ed230802da6eee256bcc4884" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Oct 05 21:29:25 2018 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Oct 06 01:22:00 2018 +0000" }, "message": "Remove invalid exception RbacConflictingPolicies\n\nThis patch set drops RbacConflictingPolicies from Patrole because\nits intention is 1) flawed and 2) the way it is being used is\ninvalid.\n\nFirst, there is no documented case where conflicting policies\nexists in OpenStack, so the intention behind the exception class\nis flawed.\n\nSecond, the exception is only used in one test in\ntest_server_rbac. It catches a ServerFault (500) and re-raises\nthe exception is a pseudo-Forbidden exception. This is very bad\nbecause if Nova raises a 500 on a policy exception then this is\na Nova bug. There is no valid use case where a ServerFault from\nNova should ever be treated as a successful test scenario.\n\nChange-Id: I495b10ccf7b0df523b2551c49ea4db07e5bcaf79\n" }, { "commit": "59f538fdbdf650154779028747285a5e35fa2d17", "tree": "9bb4e0d069ab1eb382b4fdb06eed6c2dbf55671b", "parents": [ "91e33c6ef17af701ed230802da6eee256bcc4884" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Aug 22 23:34:40 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Oct 04 17:23:16 2018 +0100" }, "message": "Replace rule/expected_error_code with non-deprecated versions\n\nThis patch set replaces deprecated occurrences of rule with\nrules and expected_error_code with expected_error_codes in\nrbac_rule_validation.action decorator.\n\nAlong with removing the parameters from the decorator, all the\nAPI tests have been changed to use the non-deprecated parameters\ninstead. Unit tests have also been updated.\n\nChange-Id: I6485b6c57795b5fe75e2b339d5c9720da30be564\n" }, { "commit": "91e33c6ef17af701ed230802da6eee256bcc4884", "tree": "bc4d4a816381dd44ee20d6b93c27046672276d8b", "parents": [ "a90168ec8715f1dbcf17c99277f62777595ba721", "5f25db5cad23ba8fb1acee49942cd75527841663" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Oct 03 19:16:04 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Oct 03 19:16:04 2018 +0000" }, "message": "Merge \"Add tests to cover neutron-agents\"" }, { "commit": "a90168ec8715f1dbcf17c99277f62777595ba721", "tree": "29208f588519db36ac446ddae7062727d8215116", "parents": [ "40c450d0882ab55cd667bb24e6751898b5ab2aab", "d646a4cfa5b019c4e127c8264305ea80bf5e06a7" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Oct 02 23:01:31 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Oct 02 23:01:31 2018 +0000" }, "message": "Merge \"Add tests to cover policy_bandwidth_limit_rule\"" }, { "commit": "5f25db5cad23ba8fb1acee49942cd75527841663", "tree": "e74c9d1a7d3db70e5308e676c33cee7ec3a9346c", "parents": [ "a3c15da1cd0d74d17727056dd72103fc915ab86d" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Mon Sep 10 14:40:22 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Sun Sep 30 14:50:37 2018 -0500" }, "message": "Add tests to cover neutron-agents\n\nThis patch adds tests to cover next policies:\n\n\u0027get_l3-agents\u0027 [0]\n\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#list-l3-agents-hosting-a-router\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I79310ce3b072976cff46335e233c219625c5b686\nStory: 2002641\nTask: 22312\n" }, { "commit": "40c450d0882ab55cd667bb24e6751898b5ab2aab", "tree": "33b75965854b1fe2e80e944f1945ea29e6cb5057", "parents": [ "f014bf134b78d84bee6c361b7390c95d9489440d", "b485953e54581e9b73a86efd28a7d295f3b12db0" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Sep 28 21:59:21 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Sep 28 21:59:21 2018 +0000" }, "message": "Merge \"Include README for neutron + plugin tests\"" }, { "commit": "0fe2e39140ff038ce66f43a478fc792e8a271fe2", "tree": "2853dfe171c292b4699626503d0ab4f1e1d83ddb", "parents": [ "404199107e1cf7443b8eb6667c5d177fe549a135", "433bf50679fdf6606a7af53380491287b69e4203" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Sep 27 22:30:39 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Sep 27 22:30:39 2018 +0000" }, "message": "Merge \"Add tests to cover policy_minimum_bandwidth_rule\"" }, { "commit": "404199107e1cf7443b8eb6667c5d177fe549a135", "tree": "363a5bb2cf18d09ca2b11888395c639fbdaaa166", "parents": [ "8c04bd87800ff8c428b58f0d8b990689916eff9e", "ef7047df40b674c72635b9dac9d7e6e1f22e9a86" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Sep 27 22:23:32 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Sep 27 22:23:32 2018 +0000" }, "message": "Merge \"Use oslo_policy.policy.Rules.load to load rules\"" }, { "commit": "dcd153a2a0db5c91468d106deb25c692779db770", "tree": "4278ccfcd544d04b74ae0d5ad14133813e7cb26a", "parents": [ "787fbd72542c233a66309c1700fad9645d01a394" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Sep 23 21:15:54 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Sep 23 21:15:54 2018 -0400" }, "message": "Remove extra_attr kwarg from RbacMalformedResponse\n\nThis patch set removes extra_attr kwarg from RbacMalformedResponse\nexception because it is unclear how unauthorized policy enforcement\ncould result in an extra attribute being injected into a response\nbody. For such an edge case to even be allowed, there would have\nto be a documented example of this. Besides, no test case even\nmakes use of it, meaning that it is not something we should\neven support.\n\nChange-Id: I8f63720fe02d63360a7e40c836d55b56eb657156\nStory: 2003843\nTask: 26634\n" }, { "commit": "b485953e54581e9b73a86efd28a7d295f3b12db0", "tree": "097c6713f33781c620b50bc86770bbfe97c73034", "parents": [ "337a574ad88b9158a77d18548b6fe809e4c8f353" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 12 10:11:45 2018 -0600" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Sep 21 13:47:39 2018 +0000" }, "message": "Include README for neutron + plugin tests\n\nThis patch set adds a README under\npatrole_tempest_plugin/tests/api/network to explain that\nPatrole supports testing RBAC policies for Neutron as well as\n(some) associated extensions and plugins.\n\nChange-Id: I80e5fd027becbb9c21212fbfe2b59b9708a51bb2\n" }, { "commit": "787fbd72542c233a66309c1700fad9645d01a394", "tree": "66b6c11f41ed360d83a64412e79b6d3085aa3ea2", "parents": [ "abd981d56d1a73ee781297353984bb1ff6c2abed", "849acef2b2d1251aeb02f9300c9e1b10cdb842e0" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Sep 20 00:19:40 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Sep 20 00:19:40 2018 +0000" }, "message": "Merge \"Adds tests to cover address scopes\"" }, { "commit": "abd981d56d1a73ee781297353984bb1ff6c2abed", "tree": "fc4052522b455d3fa873a8d68d23b06f20a492ce", "parents": [ "96cb119fe968eafe77e52e6f4b1cc0740c31f5e4", "56bb7312713634ad7d99090b167b56c6d84b0852" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Sep 19 22:16:54 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Sep 19 22:16:54 2018 +0000" }, "message": "Merge \"Add tests to cover policy_dscp_marking_rule\"" }, { "commit": "433bf50679fdf6606a7af53380491287b69e4203", "tree": "2755a41981070e18d541119c1710364442391a6e", "parents": [ "56bb7312713634ad7d99090b167b56c6d84b0852" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Mon Aug 20 13:42:20 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Wed Sep 19 11:24:03 2018 -0500" }, "message": "Add tests to cover policy_minimum_bandwidth_rule\n\nThis patch set adds tests to cover the policy_minimum_bandwidth_rule API [0].\nTest creates, showes, updates and deletes policy_minimum_bandwidth_rule.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#qos-minimum-bandwidth-rules\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: Ice4d20d20320f70ea0a8332bb53f1ebcde2c7a84\nDepends-On: https://review.openstack.org/#/c/592762/\nStory: 2002641\nTask: 22321\n" }, { "commit": "96cb119fe968eafe77e52e6f4b1cc0740c31f5e4", "tree": "74a56e62e3ea6b6871ff06099c7b211f3962de7c", "parents": [ "f2bbb107f24ff7d9d9117ac6c30c7d28aed25791", "062fb157b80c037940fc4b227d78c258c3593f45" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Sep 19 14:58:12 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Sep 19 14:58:12 2018 +0000" }, "message": "Merge \"Add support for multiple policy files\"" }, { "commit": "d646a4cfa5b019c4e127c8264305ea80bf5e06a7", "tree": "e9d152d4a3335c80a72b324de488a33512b6ba04", "parents": [ "56bb7312713634ad7d99090b167b56c6d84b0852" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Mon Aug 20 14:34:55 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "myakovliev@mirantis.com", "time": "Mon Sep 17 20:46:07 2018 +0000" }, "message": "Add tests to cover policy_bandwidth_limit_rule\n\nThis patch set adds tests to cover the policy_bandwidth_limit_rule API [0].\nTest creates, showes, updates and deletes policy_bandwidth_limit_rule.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#qos-minimum-bandwidth-rules\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I0f4b61c9f906fe61537144ef0274c19895e7134e\nDepends-On: https://review.openstack.org/#/c/592762/\nStory: 2002641\nTask: 22319\n" }, { "commit": "8c04bd87800ff8c428b58f0d8b990689916eff9e", "tree": "3eee77c1e29d35190b8229976864915ba874a523", "parents": [ "787fbd72542c233a66309c1700fad9645d01a394" ], "author": { "name": "Chi Lo", "email": "cl566n@att.com", "time": "Fri Jun 01 16:21:50 2018 -0500" }, "committer": { "name": "Chi Lo", "email": "cl566n@att.com", "time": "Sun Sep 16 06:31:39 2018 -0500" }, "message": "Add granularity for volume_extension:volume_type_encryption\n\nUse granular rules:\nvolume_extension:volume_type_encryption:create\nvolume_extension:volume_type_encryption:delete\nvolume_extension:volume_type_encryption:update\nvolume_extension:volume_type_encryption:get\n\nfor the corresponding create, delete, update, and\nget volume_type_encryption test cases.\n\nDepends-On: Iba58e785df934d1c4175c0877d266193ac0167b7\n\nChange-Id: Ie5159166505d9bee3e99ca0d51949f6391c569b9\n" }, { "commit": "ef7047df40b674c72635b9dac9d7e6e1f22e9a86", "tree": "0453f41821f0e6260c5b767c964a1950cf829fe5", "parents": [ "062fb157b80c037940fc4b227d78c258c3593f45" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Tue Sep 11 14:48:55 2018 -0500" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Wed Sep 12 18:26:21 2018 -0500" }, "message": "Use oslo_policy.policy.Rules.load to load rules\n\nRe-using Rules.load function makes it possible to support parsing\ncustom YAML policy files, the new policy file extension since Ocata.\n\nChange-Id: I9c7645a0f9b04609921a5ea607b203e8215fc32b\n" }, { "commit": "e9a135573735928c56c19acc92acb2923dec7686", "tree": "0c8a811b9e5328f54b9489420509bf88b44939a9", "parents": [ "337a574ad88b9158a77d18548b6fe809e4c8f353" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 12 10:16:38 2018 -0600" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 12 10:20:48 2018 -0600" }, "message": "Include README in patrole_tempest_plugin/tests/api via symlink\n\nThis patch set adds a symlink from patrole_tempest_plugin/tests/api/\nREADME.rst to the RBAC field guide under the docs/ folder. This is\nthe same thing Tempest does with its README file under its tempest/api\npath: [0]\n\n[0] https://github.com/openstack/tempest/tree/master/tempest/api\n\nChange-Id: I0fb776b52828ceaa834885a8d097eb53efce0ba0\n" }, { "commit": "337a574ad88b9158a77d18548b6fe809e4c8f353", "tree": "7637619706ec753d1a5241f00815385626a3815d", "parents": [ "219f6d2b1edd24d9d577c21b6610ea295c2e09da", "24961a80e58fae2a4352254140015ff76dabe8fb" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Sep 11 22:47:13 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Sep 11 22:47:13 2018 +0000" }, "message": "Merge \"Add test for create_subnetpool:is_default\"" }, { "commit": "219f6d2b1edd24d9d577c21b6610ea295c2e09da", "tree": "1385277011e96e724307c2a6e3e8f9f20bad942e", "parents": [ "f82dee3e42f17bc167cb26d75ce97fb6048d9978", "e3b252740221d075bc9fdc514eaa3d89f4400551" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Sep 11 22:14:05 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Sep 11 22:14:05 2018 +0000" }, "message": "Merge \"Adds tests to cover QOS policy\"" }, { "commit": "062fb157b80c037940fc4b227d78c258c3593f45", "tree": "77799307a5654192911b2b47fd2379bf313963d1", "parents": [ "a3c15da1cd0d74d17727056dd72103fc915ab86d" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Thu Sep 06 20:51:57 2018 -0500" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Tue Sep 11 12:22:55 2018 -0500" }, "message": "Add support for multiple policy files\n\nMost of the neutron plugins provide an updated version of policy.json\nfile with full list of rules, but at the same time there are a lot of\nother plugins which provide their own policy files and store them in\nthe policy.d/ folder: neutron-fwaas, networking-bgpvpn, vmware-nsx,\nect...\nTo implement the tests for such plugins the Patrole should be able to\nload and merge multiple policy files for any of the services.\n\nModify the discover_policy_files function to discover all policy files\nfor each of the services. Using glob.glob() function makes it possible\nto use patterns like \u0027*.json\u0027 to discover the policy files.\nModify the _get_policy_data function to load a data from all discovered\npolicy files for a service.\n\nUpdate the unit test according to the changes.\n\nChange-Id: Ib24f3d6d7a5ffdeaecce579af9795fd897dce872\n" }, { "commit": "194752f1b5304e90e0e2911324f93cbe0169a1f3", "tree": "93799978b43a147d6919661d9ff22716b1af4426", "parents": [ "a3c15da1cd0d74d17727056dd72103fc915ab86d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Sep 10 11:43:38 2018 -0600" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Sep 10 13:47:30 2018 -0600" }, "message": "Remove deprecated patrole.enable_rbac configuration option\n\nThis patch set removes deprecated [patrole].enable_rbac\nconfiguration option. It is better to use an appropriate\ntest regex to skip Patrole tests.\n\nChange-Id: I639f3215f7aff8a85bc97dc55c1d97be3123e003\n" }, { "commit": "a3d7311588f4cfce5d4deaffd60e0d90cdc5e8e3", "tree": "fb33ad330fa6739896de2e0586c447e9b5d43785", "parents": [ "11376ab7ff60d9a4a4e8f63d905e1ee20c4ba042" ], "author": { "name": "Vishakha Agarwal", "email": "agarwalvishakha18@gmail.com", "time": "Mon Sep 03 16:12:55 2018 +0530" }, "committer": { "name": "Vishakha Agarwal", "email": "agarwalvishakha18@gmail.com", "time": "Mon Sep 03 16:14:38 2018 +0530" }, "message": "Remove unused config.CONF\n\nThis is to remove unused config.CONF\nto keep code clean.\n\nChange-Id: I011151aaadf18c7991861a3535af52b1581fdcbd\n" }, { "commit": "24961a80e58fae2a4352254140015ff76dabe8fb", "tree": "159eb3bc016a3b906f9ed52bc40bd2808177ee8e", "parents": [ "842845eaef1de6595e96ad253d0666555ce083f1" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Tue Jul 17 16:02:10 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "myakovliev@mirantis.com", "time": "Fri Aug 31 03:47:59 2018 +0000" }, "message": "Add test for create_subnetpool:is_default\n\nhttps://storyboard.openstack.org/#!/story/2002641\n\nStory: 2002641\nTask: 22301\nChange-Id: I49311242a54dd47c70774b19aafa083f7cf9fc5c\nDepends-On: https://review.openstack.org/#/c/583707\n" }, { "commit": "11376ab7ff60d9a4a4e8f63d905e1ee20c4ba042", "tree": "ff02f3c804f56b5155a743238c44876968fd6430", "parents": [ "842845eaef1de6595e96ad253d0666555ce083f1" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Mon Aug 06 15:34:22 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Aug 31 02:35:46 2018 +0000" }, "message": "Limit exception handling to calls within override_role\n\nMotivation: prevents false positives caused by test\nexceptions matching the expected exception before or\nafter the ``override_role`` context is called.\n\nThis patchset changes expected_error_codes behavior [0] by checking\nerrors explicitly outside the override_role context. This is done\nby introducing a new function to rbac_rule_validation that is\nused for validating that the expected exception isn\u0027t raised too\nearly (before ``override_role`` call) or too late (after\n``override_call``) or at all (which is a bad test).\n\nThis means that exceptions raised prior to override_role\ncall result in failure. The same goes for exceptions raised\nafter override_role -- except for those that are an instance\nof BasePatroleException (which is valid for things like\nRbacMalformedResponse getting raised intentionally).\n\nThe new exception that is introduced is called\nRbacOverrideRoleException.\n\nUnit tests are added for all validation scenarios described\nabove.\n\n[0] https://storyboard.openstack.org/#!/story/2003297\nStory: 2003297\nTask: 24246\n\nCo-Authored-By: Felipe Monteiro \u003cfelipe.monteiro@att.com\u003e\nChange-Id: Iae9a58640463093f6dda20d40261b20051be2820\n" }, { "commit": "e3b252740221d075bc9fdc514eaa3d89f4400551", "tree": "6eb2fd3407f102ae3940670685f8df4341cbbfea", "parents": [ "bfcf1cc50e05c765f852044c679984c67589d736" ], "author": { "name": "jessegler", "email": "jess.egler@gmail.com", "time": "Mon Aug 20 18:52:55 2018 -0500" }, "committer": { "name": "jessegler", "email": "jess.egler@gmail.com", "time": "Wed Aug 29 17:54:13 2018 -0500" }, "message": "Adds tests to cover QOS policy\n\nThis patch set adds tests to cover the QOS policy API [0].\nTests create_policy, get_policy, update_policy, delete_policy.\nPart of the \"Increase Neutron RBAC Coverage\" initiative [1].\n\n[0] https://developer.openstack.org/api-ref/network/v2/#qos-policies-qos\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: Ie9d3365c6a39e16ca2e920d180e4f8fbb060daa3\nStory: 2002641\nTask: 22318\n" }, { "commit": "849acef2b2d1251aeb02f9300c9e1b10cdb842e0", "tree": "1038e59952e0678418108882c7fc074ff4c8b545", "parents": [ "f4cb74ce470b247f3f0e600200f9d893defbc738" ], "author": { "name": "jessegler", "email": "jess.egler@gmail.com", "time": "Fri Aug 24 17:23:11 2018 -0500" }, "committer": { "name": "jessegler", "email": "jess.egler@gmail.com", "time": "Wed Aug 29 16:49:37 2018 -0500" }, "message": "Adds tests to cover address scopes\n\nThis patch set adds tests to cover the address scopes API [0].\nTests create_address_scope, create_address_scope:shared, get_address_scope,\nupdate_address_scope, update_address_scope:shared, delete_address_scope.\nPart of the \"Increase Neutron RBAC Coverage\" initiative [1].\n\n[0] https://developer.openstack.org/api-ref/network/v2/#address-scopes\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I3f315f6cf6bd880a5add97b5928b853b1ea2e811\nStory: 2002641\nTask: 22302\n" }, { "commit": "56bb7312713634ad7d99090b167b56c6d84b0852", "tree": "99b7d8396ab48975faa412a2ef31bff14757e76f", "parents": [ "9ee07cf523583ffa0b6988de54c8dfe9b7e6e645" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Thu Aug 16 18:34:10 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Tue Aug 28 15:15:49 2018 -0500" }, "message": "Add tests to cover policy_dscp_marking_rule\n\nThis patch set adds tests to cover the policy_dscp_marking_rule API [0].\nTest creates, showes, updates and deletes policy_dscp_marking_rule.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#qos-dscp-marking-rules\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I34e6276784828c518513c5fe9caf1eee1669658a\nStory: 2002641\nTask: 22320\n" }, { "commit": "842845eaef1de6595e96ad253d0666555ce083f1", "tree": "7fd1bc429b88e420370ae30ea4fb1a7b1428a065", "parents": [ "f4cb74ce470b247f3f0e600200f9d893defbc738", "63d8602d359bf5f9492bf1f58c9edba89f01dd7f" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Aug 24 19:49:39 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Aug 24 19:49:39 2018 +0000" }, "message": "Merge \"Add tests to cover flavor_service_profile\"" }, { "commit": "2b93778e8cb0fe11f4b009a5b70df8efb92854c0", "tree": "be8285cbc812ea8355b0b6ffbf51897cf25756c8", "parents": [ "33d0583e054002d684053c4390ae13a0563c7e95", "98437d41a1f34db48422310a3d73de8149147c86" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Aug 22 05:32:18 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Aug 22 05:32:18 2018 +0000" }, "message": "Merge \"Remove override of \u0027expected_error_codes\u0027 with defaults\"" }, { "commit": "64f3943dadf34214192a7550e8a0dc9a34eb5173", "tree": "0129e1eb91cac59a808e6b06ce5e0e56c7ee3947", "parents": [ "031b182470a33065e868b916e6a11f2dec8244ae", "0f45285601808eab599e5d31887e9503e17a8392" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Aug 22 01:06:53 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Aug 22 01:06:53 2018 +0000" }, "message": "Merge \"Remove the usage of deprecated arg \u0027expected_error_code\u0027\"" }, { "commit": "98437d41a1f34db48422310a3d73de8149147c86", "tree": "10ee4a74e38101d836928cd3192018223ca4fd29", "parents": [ "b1e9d7a69337ccaa2395437e120e80bac4b5d662" ], "author": { "name": "ghanshyam", "email": "gmann@ghanshyammann.com", "time": "Fri Aug 17 08:51:43 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 21 18:50:02 2018 +0000" }, "message": "Remove override of \u0027expected_error_codes\u0027 with defaults\n\n\u0027expected_error_codes\u0027 are filled with defaults error code[1]\nin base class which is nothing but to fill required number\nof error codes with 403.\n\nFew tests override the \u0027expected_error_codes\u0027 with 403 itself which\nis confusing and inconsistent with other tests.\n\nThis commit removes those default overridden values.\n\n[1] https://github.com/openstack/patrole/blob/a6371ed510b318183e1c2cbafcc97bd85f6625f8/patrole_tempest_plugin/rbac_rule_validation.py#L286\n\nChange-Id: If607755fc09c392566fffad8f46e5f37cd33c2d2\n" }, { "commit": "0f45285601808eab599e5d31887e9503e17a8392", "tree": "5b7f96c685c9cc6f2eb921515bf7ca97e913f3b8", "parents": [ "b1e9d7a69337ccaa2395437e120e80bac4b5d662" ], "author": { "name": "ghanshyam", "email": "gmann@ghanshyammann.com", "time": "Fri Aug 17 09:30:07 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 21 18:49:53 2018 +0000" }, "message": "Remove the usage of deprecated arg \u0027expected_error_code\u0027\n\n\u0027expected_error_code\u0027 arg to rbac_rule_validation.action is\ndeprecated in favor of \u0027expected_error_codes\u0027.\n\nMany test use the old deprecated arg and that\u0027s why the warning. We\nshould cleanup the usage in patrole to avoid the confusion and make\nall test to latest interface.\n\nThis commit migrate those usage to new arg and leave the deprecated\narg as it is which can be removed completely after deprecation phase.\n\nChange-Id: Ie284ae74ce6480a59406aecfe341d579142bd625\n" }, { "commit": "031b182470a33065e868b916e6a11f2dec8244ae", "tree": "4954b3f370976abc43fd36fb0f74e3faa6aa70e6", "parents": [ "b1e9d7a69337ccaa2395437e120e80bac4b5d662" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Sat Jul 28 13:14:24 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 21 18:49:12 2018 +0000" }, "message": "Add tests to cover RBAC policies\n\nThis patch set adds tests to cver the neutron RBAC policies API [0].\nTest gets, creates, updates, and deletes RBAC policies.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#rbac-policies\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I37e07c1b37a4630024d45dc9e5ade25ef31c703a\nStory: 2002641\nTask: 22322\n" }, { "commit": "6bffc5c5c6d1a52793e1e2091f4e87b2edac8f31", "tree": "deb60b61fb01e112115f244effa1cd72fbe81f9a", "parents": [ "d063b409bb7a3d056ac9d55bb6200b1076e71422" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Aug 19 22:54:33 2018 +0100" }, "committer": { "name": "Ghanshyam Mann", "email": "gmann@ghanshyammann.com", "time": "Tue Aug 21 05:53:38 2018 +0000" }, "message": "Skip the deprecated API extensions policy tests\n\nA new policy feature flag called\n``[policy_feature_flag].removed_nova_policies_stein``\nhas been added to Patrole\u0027s config to handle Nova API\nextension policies removed in Stein [0].\n\nThe policy feature flag is applied to tests that validate\nresponse bodies for expected attributes previously returned\nfor the following policies that passed authorization:\n\n - os_compute_api:os-config-drive\n - os_compute_api:os-extended-availability-zone\n - os_compute_api:os-extended-status\n - os_compute_api:os-extended-volumes\n - os_compute_api:os-keypairs\n - os_compute_api:os-server-usage\n - os_compute_api:os-flavor-rxtx\n - os_compute_api:os-flavor-access (only from /flavors APIs)\n - os_compute_api:image-size\n\nNote that not all removed policies are included above because\ntest coverage is missing for them (like\nos_compute_api:os-security-groups).\n\nAlso fixes test flows associated with image_size tests:\n\n* endpoints are list images with details and show image (not\n list image)\n* both tests should check for OS-EXT-IMG-SIZE:size attribute\n\n[0] https://review.openstack.org/#/c/586872/8\n\nStory: 2003501\n\nChange-Id: Ia6f8d255a540f7063beedd80a3ca1833f3987490\n" }, { "commit": "d063b409bb7a3d056ac9d55bb6200b1076e71422", "tree": "0aa9261b3cc274b7bb8a06f36a3e23d41944f516", "parents": [ "9ee07cf523583ffa0b6988de54c8dfe9b7e6e645", "04b26288b36564fb6498e4457b69b879aec23b99" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Aug 17 09:29:36 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Aug 17 09:29:36 2018 +0000" }, "message": "Merge \"Add tests to cover trunks\"" }, { "commit": "63d8602d359bf5f9492bf1f58c9edba89f01dd7f", "tree": "a045c6f5fa43d7738bd0235207951a0ea9073e44", "parents": [ "bfcf1cc50e05c765f852044c679984c67589d736" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Fri Aug 10 14:01:15 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Sat Aug 11 09:12:54 2018 -0500" }, "message": "Add tests to cover flavor_service_profile\n\nThis patch set adds tests to cover the flavor_service_profile API [0].\nTest creates and deletes flavor_service_profile.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#associate-flavor-with-a-service-profile\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I22b0467f698d548abb85f45c993bbe0165eb21b1\nStory: 2002641\nTask: 22324\n" }, { "commit": "bfcf1cc50e05c765f852044c679984c67589d736", "tree": "e699e9205211f01cadf484cf0aff1a71fae6acda", "parents": [ "c5dd1b4ef30f7d30b5424f75b850880352fba16d", "73d9f957b36eb68525655730fab48dc653f950cf" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Aug 10 17:21:34 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Aug 10 17:21:34 2018 +0000" }, "message": "Merge \"Add tests to cover flavors\"" }, { "commit": "73d9f957b36eb68525655730fab48dc653f950cf", "tree": "17d106d0c98df73612ba0f4d3895dcda78a89f2f", "parents": [ "1d829781df157bc4a11b2489054997f09b4c54ee" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Sat Jul 28 11:03:32 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "myakovliev@mirantis.com", "time": "Thu Aug 09 21:17:42 2018 +0000" }, "message": "Add tests to cover flavors\n\nThis patch set adds tests to cver the flavors API [0].\nTest lists, gets, creates, updates, and deletes flavors.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#networking-flavors-framework-v2-0-current-flavor-service-profile\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I526d1567b715c0a57e73fa6645d8a98b9b45c62e\nStory: 2002641\nTask: 22316\n" }, { "commit": "c5dd1b4ef30f7d30b5424f75b850880352fba16d", "tree": "d201d5f2995b1ac1e358bf0770af63147d46c1d9", "parents": [ "2cc271c75a85cf393b06b2054c302c3ce5ba7187", "a137576f949ff8c3ee1671bd3252a8f5c30219fa" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Aug 09 05:03:24 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Aug 09 05:03:24 2018 +0000" }, "message": "Merge \"Improve tests for test_volume_basic_crud.py\"" }, { "commit": "2cc271c75a85cf393b06b2054c302c3ce5ba7187", "tree": "e69b07c7321c4599f7585a55bd0a1b7b650363c6", "parents": [ "3e98fe47b54dd75365e158e884ee7406a703c7d4" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Wed Aug 01 16:29:42 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "myakovliev@mirantis.com", "time": "Tue Aug 07 18:34:32 2018 +0000" }, "message": "Add tests to cover auto_allocated_topology\n\nThis patch set adds tests to cver the neutron auto allocated topology API [0].\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#id877\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I2341be8aa8c9057069dff24dfe718b6239e68817\nStory: 2002641\nTask: 22325\n" }, { "commit": "04b26288b36564fb6498e4457b69b879aec23b99", "tree": "393abaa3ef8e627bd93d6dc3a123b6d6f8c615af", "parents": [ "3e98fe47b54dd75365e158e884ee7406a703c7d4" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Mon Jul 23 12:13:02 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 07 00:57:22 2018 +0000" }, "message": "Add tests to cover trunks\n\nThis patch set adds tests to cver the neutron trunks API [0].\nTest lists, gets, creates, updates, and deletes trunks.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#trunk-networking\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nStory: 2002641\nTask: 22326\nChange-Id: Ie59f02f5ecc1d04a16fb178444f231e4791e2079\n" }, { "commit": "3e98fe47b54dd75365e158e884ee7406a703c7d4", "tree": "bf2d0480d34421a3fef091939d2e01c608aec386", "parents": [ "1d829781df157bc4a11b2489054997f09b4c54ee" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Thu Aug 02 17:25:53 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "myakovliev@mirantis.com", "time": "Sat Aug 04 19:59:24 2018 +0000" }, "message": "Update segments rbac tests with error codes\n\nThis patchset updates tests with exact codes to prevent\nfalse positive results.\n\nChange-Id: I7d7f640c9adda06767eabb657fe739748a2beaf2\n" }, { "commit": "1d829781df157bc4a11b2489054997f09b4c54ee", "tree": "f2c8e15b981e7a082d4f7b33544e1e6022733540", "parents": [ "caffc23980285e4864085976fb482ca04d1ca7d2" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Fri Aug 03 14:37:37 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Sat Aug 04 11:40:51 2018 -0500" }, "message": "Reset ntp_client cached token in override_role context\n\nAs bug [0] shows we have incorrect behaviour with client, when its\nallowed to perform forbidden action beacause of cached token.\nThis patchset expands RbacUtilsMixin with `get_auth_providers` so\nwe can define additional auth_providers on testcase level.\nUsing it we reset cached auth data for neutron-tempest-plugin\nclient in *PluginRbacTest tests.\n\n[0] https://storyboard.openstack.org/#!/story/2003296\n\nChange-Id: Ie444f1e0be1c9a5ff7fc8a968269b73f510685e3\nStory: 2003296\nTask: 24245\n" }, { "commit": "a137576f949ff8c3ee1671bd3252a8f5c30219fa", "tree": "a28cc4021de0a0d2025d2782f955664b24e3aea1", "parents": [ "caffc23980285e4864085976fb482ca04d1ca7d2" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Jul 29 12:58:05 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Aug 04 05:20:08 2018 +0000" }, "message": "Improve tests for test_volume_basic_crud.py\n\nThis patch set addresses some quality of life improvements for\ntest_volume_basic_crud.py:\n\n* missing waiters\n* insufficient test granularity\n* add missing volume:get_all test (which is a fundamental API action)\n\n* Missing waiter is added for delete volume test.\n* create_volume test is broken up to be more granular, such that the\n waiter is outside the contextmanager inside which the role is switched.\n* test_list_volumes_with_details is added for complete coverage for the\n \"volume:get_all\" policy\n\nChange-Id: I5e11956afab2860a4d4fe0b8bc186b9fa967ce99\n" }, { "commit": "caffc23980285e4864085976fb482ca04d1ca7d2", "tree": "5dfccb57d6380b4167fbdb3148e86b21eda3901b", "parents": [ "839034139e8d47340f1edd75404bdbceb26e77bc", "d067148212ef95b938af5edbec359fa49156ddee" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Aug 02 18:16:31 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Aug 02 18:16:32 2018 +0000" }, "message": "Merge \"Add tests to cover segments\"" }, { "commit": "839034139e8d47340f1edd75404bdbceb26e77bc", "tree": "57dcd0feec8c43e3d0e8c4fa9908e831dc6bd872", "parents": [ "9af45b13bca3564e758d0bd5ee83be9272dbb8e2" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Jul 09 16:33:55 2018 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Jul 31 02:15:49 2018 -0400" }, "message": "Deprecate enable_rbac configuration option\n\nThe ``[patrole].enable_rbac`` option is deprecated and will be removed\nduring the \"S\" release. This is a legacy option that was meaningful\ndownstream when Patrole was a suite of tests inside Tempest itself. Now\nthat Patrole exists upstream as a Tempest plugin, it is paradoxical to\ninstall the Patrole plugin yet have an option that allows all Patrole\ntests to be skipped. This option is at odds with current Patrole\narchitecture.\n\nTo skip RBAC tests going forward, with Patrole Tempest plugin already\ninstalled, use an appropriate regex.\n\nChange-Id: I0cc39184c7891fb9133a45488a36ba220592915f\n" }, { "commit": "9af45b13bca3564e758d0bd5ee83be9272dbb8e2", "tree": "49057c741c0b9aea004fd4c5d034d173aff15fe0", "parents": [ "933c8922ef1c3b06c0a64391077c5ed82097a2ab", "d48d892355069aa8540d3b85d9a1c3dd5f7eda9d" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Jul 30 17:39:48 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Jul 30 17:39:48 2018 +0000" }, "message": "Merge \"Remove misleading todo from config.py\"" }, { "commit": "d48d892355069aa8540d3b85d9a1c3dd5f7eda9d", "tree": "c8309d9ae3d359a6a59b592a8d8a27f347cfa054", "parents": [ "05a73499ce2eabb1f68013304d23ae09e38ba29c" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Jul 29 02:07:49 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Jul 29 02:07:49 2018 -0400" }, "message": "Remove misleading todo from config.py\n\nThis patch set removes a misleading todo from config.py which\nsuggests that it might be possible to leverage Keystone\u0027s\nPolicy API to derive policy information from remote hosts. But\nthis is not possible as the Policy API is deprecated [0].\n\nIf we want to get policy information from a remote host we will\nneed to pursue some SSH alternative instead, but this is not\nplanned anytime soon.\n\n[0] https://docs.openstack.org/releasenotes/keystone/queens.html#deprecation-notes\n\nChange-Id: I8a4da457c2d40ebddbfe5492dc1cbba87288c0da\n" }, { "commit": "d067148212ef95b938af5edbec359fa49156ddee", "tree": "996c038134eb1ac34b7d74e9f50273e381d41cdd", "parents": [ "05a73499ce2eabb1f68013304d23ae09e38ba29c" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Mon Jul 23 12:13:02 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Fri Jul 27 18:01:16 2018 -0500" }, "message": "Add tests to cover segments\n\nThis patch set adds tests to cver the neutron segments API [0].\nTest lists, gets, creates, updates, and deletes segments.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#segments\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nStory: 2002641\nTask: 22306\nChange-Id: I8eef0dcd5355d6212ead2bcb109f23ca0b613109\n" }, { "commit": "933c8922ef1c3b06c0a64391077c5ed82097a2ab", "tree": "7fce291610ef8fbb2366b324ac04a0c9f827d61f", "parents": [ "1f923a1ae5dfb4c4441ab019eb39b0e6ef36e0e3", "2ee0db0726f80ffe0c29a5b24c91c06b988612b9" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Jul 27 22:48:52 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Jul 27 22:48:52 2018 +0000" }, "message": "Merge \"Add list backups with details for backup:backup_project_attribute\"" }, { "commit": "1f923a1ae5dfb4c4441ab019eb39b0e6ef36e0e3", "tree": "5d0bf04afe3fb68275b3034e82257222e672b59d", "parents": [ "05a73499ce2eabb1f68013304d23ae09e38ba29c", "9d45e40db03daf4be48b3ce2dab607bf50a2d6c6" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Jul 27 22:48:50 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Jul 27 22:48:50 2018 +0000" }, "message": "Merge \"Adds create_network tests for missing policy actions\"" }, { "commit": "2ee0db0726f80ffe0c29a5b24c91c06b988612b9", "tree": "80c509f35e7c6ee9f2c8d1c784f11a9aaa1ae7a4", "parents": [ "05a73499ce2eabb1f68013304d23ae09e38ba29c" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Jul 08 22:19:05 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jul 27 00:29:31 2018 -0400" }, "message": "Add list backups with details for backup:backup_project_attribute\n\nThis patchset adds an RBAC test for validating that\n\"backup:backup_project_attribute\" is included in response body\nfor listing backups with details following successful policy\nauthorization. The policy in code documentation indicates that\nthis API enforces this policy [0] and the policy is enforced in\nthe code here [1]. The expected attribute comes from [2].\n\n[0] https://github.com/openstack/cinder/blob/8f7bc140052091d141e2cf436e989aa2d15dd6f4/cinder/api/v3/backups.py#L89\n[1] https://github.com/openstack/cinder/blob/8f7bc140052091d141e2cf436e989aa2d15dd6f4/cinder/policies/backups.py#L57\n[2] https://github.com/openstack/cinder/blob/8f7bc140052091d141e2cf436e989aa2d15dd6f4/cinder/api/v3/backups.py#L64\n\nChange-Id: I8285b25b97de90e1911adf5e97ffd051d10adf90\n" }, { "commit": "05a73499ce2eabb1f68013304d23ae09e38ba29c", "tree": "c99cf741bdba4230196ea26488e13a1a25a2b25d", "parents": [ "e737900e609783ff172dc86253f3af60e243be62", "1884c572ee472c4dfeb955f66c61a7a73474f682" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Jul 27 03:35:48 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Jul 27 03:35:48 2018 +0000" }, "message": "Merge \"Increase test stability of backup RBAC tests\"" }, { "commit": "9d45e40db03daf4be48b3ce2dab607bf50a2d6c6", "tree": "0b4dfa88a1783438d93a94856d7d64c80365ec76", "parents": [ "e0c5c24e3bca25349894b8055589d88a16f4b894" ], "author": { "name": "jessegler", "email": "jess.egler@gmail.com", "time": "Tue Jul 17 13:54:41 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Jul 26 22:45:01 2018 -0400" }, "message": "Adds create_network tests for missing policy actions\n\n\u0027create_network:is_default\u0027\n\u0027create_network:provider:physical_network\u0027\n\nStory: 2002641\nTask: 22303\n\nChange-Id: I1aaa9b4cd9e0f34522e2e61191d1bae20ad6da48\n" }, { "commit": "f8d1c74f51657cac279cf249ab47c782d1ec78db", "tree": "3abd4c13d37bcdc1b3440b6385b3c4ffdd435d04", "parents": [ "2a21633949555a79a34afe306d6ab299489a14a6" ], "author": { "name": "jessegler", "email": "jess.egler@gmail.com", "time": "Thu Jul 19 14:32:05 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Jul 22 02:14:40 2018 +0000" }, "message": "Adds the following tests for update_network:\n\n\u0027update_network:provider:network_type\u0027\n\u0027update_network:provider:physical_network\u0027\n\u0027update_network:provider:segmentation_id\u0027\n\nhttps://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I693746f2e2b816a1573b41a9e089ab9b7dd1e44a\n" }, { "commit": "1884c572ee472c4dfeb955f66c61a7a73474f682", "tree": "999e6dc41fad2c37b53f18208d8cee7e59462956", "parents": [ "2a21633949555a79a34afe306d6ab299489a14a6" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Mar 26 01:25:36 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jul 20 21:22:35 2018 +0000" }, "message": "Increase test stability of backup RBAC tests\n\nThis is to increase test stability of backup RBAC tests which\nfail not only due to the rather error-prone nature of backing\nup volumes, but also because of data race conditions and\nmissing clean ups.\n\nThis adds some waiters following certain backup actions. This\nalso adds a clean up of the volume that is created when restoring\na backup [0].\n\nAdditional waiters are also added for waiting for volumes to\nbecome available following backup (because they briefly\ngo into backing-up status) [1].\n\n[0] https://developer.openstack.org/api-ref/block-storage/v3/index.html#restore-a-backup\n[1] https://review.openstack.org/#/c/569917/8\n\nChange-Id: Ifce15f69fcca38005b40785c42231ca164917345\n" }, { "commit": "07a79551e87c5fca43779578dcfe06afe5cf9c2b", "tree": "728f7bb13d3b90ffd7b05c2603d12f9dcca115de", "parents": [ "51299a14146ec4f80fdd4eb42819dd0a4b8d5ee3", "299b9d467db7495835352e633538432685428d7d" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Jul 18 19:01:37 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Jul 18 19:01:37 2018 +0000" }, "message": "Merge \"Bump hacking to 1.1.0\"" }, { "commit": "51299a14146ec4f80fdd4eb42819dd0a4b8d5ee3", "tree": "9f6655b634cd87238cafadf4c53d1f48d7009f2a", "parents": [ "561d028a636fc0982f57319a2fb78039dc9c700c" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Jun 28 20:03:27 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Jul 18 01:18:35 2018 +0000" }, "message": "Improve exception that is raised following invalid service\n\nThis patchset changes the exception that is raised following\nan invalid service being passed in for testing. Instead of\na NotFound getting raised (which doesn\u0027t make sense), the\noriginal exception, RbacInvalidServiceException, is raised\ninstead. In addition \"Exception\" is appended to the original\nexception name for greater clarity and consistency with other\nexception names.\n\nThis patchset is similar to [0] which aims to simplify and\nconsolidate how service input is validated.\n\n[0] https://review.openstack.org/#/c/577963/\n\nChange-Id: Ib91a6581f89a528630d756840176b0e16663fa6f\n" }, { "commit": "561d028a636fc0982f57319a2fb78039dc9c700c", "tree": "9640832baa3e3c45b498698daf34dd6d751cb2c7", "parents": [ "2e45d9b6929b3538d6d7b5bb04e95b3f822cdd7b" ], "author": { "name": "ghanshyam", "email": "gmann@ghanshyammann.com", "time": "Tue Jul 17 04:45:49 2018 +0000" }, "committer": { "name": "ghanshyam", "email": "gmann@ghanshyammann.com", "time": "Tue Jul 17 04:45:49 2018 +0000" }, "message": "Cap additional nova-network tests at Queens\n\nAs noted in I7aea99d7c1818b8edcda41ba4eaa062a8ea069eb, nova is working\non removing the nova-network only compute REST APIs in the Rocky\nrelease, which means any requests to those APIs after Queens will result\nin a 410 response, regardless of microversion or whether or not neutron\nis being used.\n\nThe os-floating-ips-bulk API is being removed in nova change\nI89d081108b398d8efba9636279088c61349b21e6. As a result,\nos-floating-ips-bulk tests will no longer works against Rocky+ versions\nof nova. Skip this test using the check added in the previous change.\n\nRelated to blueprint remove-nova-network\n\nChange-Id: I1a2accebce29c3be6acec7ede67b1250552a42ca\n" }, { "commit": "e0c5c24e3bca25349894b8055589d88a16f4b894", "tree": "7caf91d8bf0abd776741c255fd82f4de5fe8b2df", "parents": [ "94986d7e3c25b842f90036d6971f103403f0c3f2", "c0cb7eb2d49213afa209de87dfbeb376775c3977" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Jul 10 20:57:10 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Jul 10 20:57:10 2018 +0000" }, "message": "Merge \"multi policy: Fix logging issues with multiple policies\"" }, { "commit": "94986d7e3c25b842f90036d6971f103403f0c3f2", "tree": "4f5592f69cf0061c5f4323c5125e967c705b8c37", "parents": [ "f800a1c5ca672033cd9e283c82972b87d0911648", "f16b6b3a1df654cfc98256ab1dd92ad4e719c369" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Jul 10 19:54:19 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Jul 10 19:54:19 2018 +0000" }, "message": "Merge \"Update overpermission/underpermission rbac exceptions\"" }, { "commit": "299b9d467db7495835352e633538432685428d7d", "tree": "ff87cc98ff516c1a61b3119b65865dc6885cea8b", "parents": [ "556094d276d79b7f320e5557aee93d7f029a1363" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jul 06 23:00:24 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Jul 10 18:40:19 2018 +0000" }, "message": "Bump hacking to 1.1.0\n\nhacking 1.0+ adds a couple of additional checks that are helpful as part\nof the transition to Python 3. However, hacking 1.1.0 incorporated\nflake8 2.6.x, which transitioned from pep8 to pycodestyle. Tempest\nprovides some hacking extensions and these use pep8 imports. As things\nstand, projects that wish to use these hacking extensions must either\nconstrain themselves to the same older hacking versions or install pep8\nmanually. Neither of these approaches is particularly attractive so\ninstead transition to hacking 1.1.0 ourselves. This has the benefit of\ngiving us the additional checks for Python 3.\n\nBased off https://review.openstack.org/#/c/580634/1/\n\nChange-Id: I8ed5aa0ccd02a792d26d3bef1949a7e1a3f600ed\n" }, { "commit": "4671e3909def0fa75c7cdea2ea44b02f0fdd48fd", "tree": "61fe6a007f22f0253438e5dcc46edf98de84eeb1", "parents": [ "a85698bcb8d2be09359aa575f3a5e5e6d4eee73c", "1bed58be501ac22ef8f6c01f1e1e77fe2c6129a8" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Jul 04 02:53:53 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Jul 04 02:53:53 2018 +0000" }, "message": "Merge \"Add fixed ip cleanup to test_add_fixed_ip\"" }, { "commit": "f16b6b3a1df654cfc98256ab1dd92ad4e719c369", "tree": "d757fcb089c63b21c7fffd8db1f8fc94c6f6e942", "parents": [ "556094d276d79b7f320e5557aee93d7f029a1363" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Jun 28 19:32:59 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jun 29 04:51:33 2018 +0000" }, "message": "Update overpermission/underpermission rbac exceptions\n\nThis patchset updates rbac_exceptions by bringing the concept\nof under-permission and over-permission together. An over-permission\noccurs when an unauthorized role is allowed to perform an action\nand an under-permission occurs when an authorized role is not\nallowed to perform an action. Both of these are important failure\nscenarios.\n\nCurrent Patrole has an RbacOverPermission Exception but uses\na \"Forbidden\" as a pseudonym for the under-permission version\nbut this is not ideal for the following reasons:\n\n* Patrole can expect a 404 Not Found due to Neutron policy enforcement [0]\n* The naming is inconsistent with RbacOverPermission\n* It should have a Patrole wrapper exception (NotFound is used directly\n from Tempest)\n\nSo, this patchset:\n\n* renames RbacOverPermission to RbacOverPermissionException\n* replaces Forbidden exception with RbacUnderPermissionException\n* updates documentation, docstrings and unit tests\n\nIn addition, this patchset introduces a new exception called\nRbacExpectedWrongException which is raised when the expected\nexception does not match the actual exception and both are instances\nof 403 and 404, which means that the RBAC test uses the wrong\nexpected_error_codes.\n\nChange-Id: I681610448cbe0269f02c34ea6afaaaf29c306121\n" }, { "commit": "a85698bcb8d2be09359aa575f3a5e5e6d4eee73c", "tree": "a8f3f18c3ee0b6ed980cb4820a6aef25f1770265", "parents": [ "2ed9feac24eb6cf1919effe95313fe703486a2e3", "f5ed588fb55a9a4fc1f03e7f1e344266d9742b4f" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Jun 28 23:24:51 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Jun 28 23:24:51 2018 +0000" }, "message": "Merge \"trivial: Drop empty services folder under patrole_tempest_plugin\"" }, { "commit": "2ed9feac24eb6cf1919effe95313fe703486a2e3", "tree": "75637309ae72b987b0d51ba0a032520b11a2e485", "parents": [ "a6371ed510b318183e1c2cbafcc97bd85f6625f8", "318fa3b80c8d3ff49ec3d26db98d063530e65b35" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Jun 27 17:29:19 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Jun 27 17:29:19 2018 +0000" }, "message": "Merge \"Use tempest-multinode-full parent for multinode Zuul jobs\"" }, { "commit": "a6371ed510b318183e1c2cbafcc97bd85f6625f8", "tree": "1afd60ae5b235491f6c44feaaa549f7a1f7f791e", "parents": [ "556094d276d79b7f320e5557aee93d7f029a1363", "d91c1242c3396594495d2bd905bc42b24a8f29ba" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Jun 27 17:03:16 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Jun 27 17:03:16 2018 +0000" }, "message": "Merge \"Change Neutron tests to use multi-policy support\"" }, { "commit": "d91c1242c3396594495d2bd905bc42b24a8f29ba", "tree": "d3a712fd1731701910803fe6e5fca5ea905755e0", "parents": [ "e965f90cafe8b45913ab51782afcc9c7c47a9fed" ], "author": { "name": "Cliff Parsons", "email": "cliff.parsons@att.com", "time": "Fri Jun 15 00:50:33 2018 -0500" }, "committer": { "name": "Cliff Parsons", "email": "cliff.parsons@att.com", "time": "Tue Jun 26 16:39:35 2018 +0000" }, "message": "Change Neutron tests to use multi-policy support\n\nThis change changes the test cases that require multi-policy and\nmultiple error code handling.\n\nPartially Implements: bp rbac-testing-multiple-policies\nStory: 2002620\n\nChange-Id: I40df70f7cd7c7f30822010323c5dd02697d50d2b\n" }, { "commit": "f5ed588fb55a9a4fc1f03e7f1e344266d9742b4f", "tree": "5c83134faf6f60c191c9e575a86d8185b099048c", "parents": [ "556094d276d79b7f320e5557aee93d7f029a1363" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Jun 25 21:29:11 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Jun 25 21:29:11 2018 -0400" }, "message": "trivial: Drop empty services folder under patrole_tempest_plugin\n\nThis patchset drops the empty services folder under\npatrole_tempest_plugin. While it is part of the cookie cutter\nTempest plugin setup, it is currently empty and serves no\npurpose in Patrole. If in the future we decide to add service\nclients there, we can reintroduce the folder. But there is\nno purpose in keeping around an empty folder -- it just\nincreases clutter.\n\nChange-Id: Ibf83a73f5dc2c38d737359221e9974a6562846a6\n" }, { "commit": "556094d276d79b7f320e5557aee93d7f029a1363", "tree": "ce280f2cd05bc190de13bfb0d2b5539c3afa7d7a", "parents": [ "e965f90cafe8b45913ab51782afcc9c7c47a9fed", "e7679f7f2d43e40f2d3399c495fba3e9be476acd" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Sat Jun 23 01:34:32 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Sat Jun 23 01:34:32 2018 +0000" }, "message": "Merge \"Fix Neutron-related return values on some list APIs\"" }, { "commit": "318fa3b80c8d3ff49ec3d26db98d063530e65b35", "tree": "0f93d9b2e6e18d5b5294a06dac0dd2b8e4c7e47d", "parents": [ "8f45b364f722fa87be0e572108f98fc3d402a23c" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Jun 19 16:53:33 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Jun 20 00:25:06 2018 -0400" }, "message": "Use tempest-multinode-full parent for multinode Zuul jobs\n\nThis patchset uses the recently added [0] tempest-multinode-full\nparent for multinode Patrole Zuulv3 jobs. This patchset also\nfixes some trivial docstring errors related to [1].\n\n[0] https://review.openstack.org/#/c/545724/\n[1] https://review.openstack.org/#/c/570262/\n\nChange-Id: Ib13663b582f0c57a28ec4b18129b83ab5ba95cfe\n" }, { "commit": "c0cb7eb2d49213afa209de87dfbeb376775c3977", "tree": "1719f342fed721ea8c7c888a7cf0102ec8980f1e", "parents": [ "25e2e71b95034743ddf26520ff369d941f39e2b3" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Jun 19 19:50:36 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Jun 19 19:50:36 2018 -0400" }, "message": "multi policy: Fix logging issues with multiple policies\n\nThis patchset mostly aims to fix logging issues surrounding\nmultiple policies introduced by [0]. Some of the LOG messages\nstill only log `rule` arg when they should log all the `rules`\narg instead to capture all the policies being enforced.\n\nIn addition, this patchset:\n\n* corrects docstring formatting with rbac_rule_validation following [1]\n* changes unit tests in test_rbac_rule_validation to test non-deprecated\n arg `rules` instead of `rule` (tests also exist for ensuring that\n `rule` is handled correctly until it is finally removed from code)\n* rewords some log messages to better conform to multi policy support\n\n[0] https://review.openstack.org/#/c/554764/\n[1] https://review.openstack.org/#/c/570262/\n\nPartially Implements: bp rbac-testing-multiple-policies\nStory: 2002620\nTask: 22250\n\nChange-Id: I3df69d5a476416378bde14ee6a258ff5ed40e363\n" }, { "commit": "25e2e71b95034743ddf26520ff369d941f39e2b3", "tree": "f8319d9d6e76f0c5ab207223ac1c848394b1cbf0", "parents": [ "8f45b364f722fa87be0e572108f98fc3d402a23c", "bc865dfecc319cbca8aeb31687ee0ba6dcea9d12" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Jun 19 22:32:34 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Jun 19 22:32:34 2018 +0000" }, "message": "Merge \"Fix test_volume_upload BadRequest error\"" }, { "commit": "8f45b364f722fa87be0e572108f98fc3d402a23c", "tree": "1b08659d0a596cd79914c7e8938b5688a9019241", "parents": [ "f50f6f1384040ee4a1fa806bb9a39bfd6cf429e5", "35a77113fccfd5659c123adb2cc142836cdd764d" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Jun 19 20:10:28 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Jun 19 20:10:28 2018 +0000" }, "message": "Merge \"Add support for handling multiple error codes\"" }, { "commit": "1bed58be501ac22ef8f6c01f1e1e77fe2c6129a8", "tree": "c2e5e79630ccd6bc08a1a6bb4ef1575c4fdfd26e", "parents": [ "ffc1ad8556b3aee842db5345ee4080d8cae7c303" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Jun 18 21:57:53 2018 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Jun 18 21:57:53 2018 +0100" }, "message": "Add fixed ip cleanup to test_add_fixed_ip\n\nThere is a data race on clean up with the test test_add_fixed_ip\nbecause it can currently fail during resource_cleanup [0] with:\n\"One or more ports have an IP allocation from this subnet.\"\n\n[0] http://logs.openstack.org/36/575536/4/gate/patrole-admin/ccf48f1/testr_results.html.gz\n\nChange-Id: I71099c62cb9c49739ec21579f24d4fd8a9cbf432\n" }, { "commit": "6962e8afa2de51821c6392df6ae08d8ebec64299", "tree": "41a43c737bf262e6e264204311229ba6b47db0f3", "parents": [ "2fc2929882c211682219c5ab71f06e5954fc7b53", "ece376d3a4f760b8493e7d7d02f5174d01cdc7d3" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Jun 18 17:49:41 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Jun 18 17:49:41 2018 +0000" }, "message": "Merge \"Remove duplicate test_unmanage_volume test\"" }, { "commit": "e7679f7f2d43e40f2d3399c495fba3e9be476acd", "tree": "a8a7e250b1e6fdc0045c75065b3b2b87a24c1aaa", "parents": [ "6962e8afa2de51821c6392df6ae08d8ebec64299" ], "author": { "name": "Cliff Parsons", "email": "cliff.parsons@att.com", "time": "Sat Jun 16 18:42:29 2018 -0500" }, "committer": { "name": "Cliff Parsons", "email": "cliff.parsons@att.com", "time": "Sun Jun 17 19:47:36 2018 -0500" }, "message": "Fix Neutron-related return values on some list APIs\n\nThere are a handful of APIs in Neutron where instead of returning\nan error code for a disallowed role, it returns an empty list. The\ntest cases for these APIs does not currently handle this.\n\nChange-Id: Ice15b4d27dae72963281a31ba58fee1f373a9690\n" }, { "commit": "35a77113fccfd5659c123adb2cc142836cdd764d", "tree": "b35dbf96aaec39fd83b3d07f7672b3bbbc8b4983", "parents": [ "2fc2929882c211682219c5ab71f06e5954fc7b53" ], "author": { "name": "Cliff Parsons", "email": "cliff.parsons@att.com", "time": "Mon May 07 14:03:40 2018 -0500" }, "committer": { "name": "Cliff Parsons", "email": "cliff.parsons@att.com", "time": "Sun Jun 17 04:37:17 2018 +0000" }, "message": "Add support for handling multiple error codes\n\nPatrole currently cannot handle the scenario where two possible\nerror codes can returned by Neutron policy enforcement for a\nfailed policy check (403 Forbidden and 404 NotFound), depending\non what role is being tested. Patrole framework can only handle\none expected_exception.\n\nThis change builds upon the recent multi-policy support to allow\nthe tester to specify multiple policy actions for one API test.\nFor each policy action, the tester would need to specify an\nerror code that is expected if the action should fail. If multiple\npolicy actions fail, the error code for the first policy action\nthat fails will be expected to be returned from the service.\n\nThis handles the cases in Neutron where Neutron may use a second\npolicy rule to determine whether or not to return a 403 error\ncode or a 404 error code. The tester is expected to list out\nwhich policy rules are being tested by the API endpoint test.\n\nChange-Id: I5cd861e184da90bb27f8ba454c94fa4d4f99c269\nCloses-Bug: #1772710\n" }, { "commit": "2fc2929882c211682219c5ab71f06e5954fc7b53", "tree": "cbd212581aefb64e4f4b99a8769c03a784f6d29c", "parents": [ "ffc1ad8556b3aee842db5345ee4080d8cae7c303" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jun 15 18:26:27 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Jun 16 16:20:16 2018 -0400" }, "message": "Gate fix: Rename Member (legacy) to member role\n\nDue to a recent change [0], Member role is no longer\nbeing found, as it has been renamed to member. This is\ncausing all the member-based gates to fail. Because \"Member\"\nis legacy [1], this patchset uses \"member\" instead of \"Member\"\nduring the devstack Patrole plugin for master. For n-1\nand n-2 releases \"Member\" is still used.\n\nThis patchset also specifies which role was not found in\nthe system while trying to resolve roles CONF.identity.admin_role\nand CONF.patrole.rbac_test_role in order to make debugging\neasier.\n\n[0] https://review.openstack.org/#/c/572243/\n[1] http://git.openstack.org/cgit/openstack-dev/devstack/tree/lib/keystone#n355\n\nChange-Id: I7b59bab164041b26ed8a1a798546e493f22f6edd\n" }, { "commit": "ffc1ad8556b3aee842db5345ee4080d8cae7c303", "tree": "236a15893591e159e1102be706b5971deb3f82b3", "parents": [ "cd61bb685becf1f25f373067d683b1a15824e94a", "57ab8c46f2e2082c71d1e23f96f57472d5e216a0" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Jun 15 02:38:21 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Jun 15 02:38:21 2018 +0000" }, "message": "Merge \"Remove duplicate subnet tests fromt test_networks_rbac module\"" }, { "commit": "cd61bb685becf1f25f373067d683b1a15824e94a", "tree": "0eeeb3c8e269f833eebf2531ad02ea7f90ae5a8b", "parents": [ "5da0aad1996835066a038194cd3811c52b222f60", "383960df5710c599334532c0177cbefee9c49d33" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Jun 15 01:27:38 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Jun 15 01:27:38 2018 +0000" }, "message": "Merge \"Drop old README file\"" }, { "commit": "5da0aad1996835066a038194cd3811c52b222f60", "tree": "f263e151a5fbb25a57fa050ec4ce695016741ddd", "parents": [ "c9bc9db4b45b8112cee9d8e06304e620d0a5c13c" ], "author": { "name": "Rick Bartra", "email": "rb560u@att.com", "time": "Tue Jun 12 14:28:50 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Jun 14 11:26:21 2018 -0400" }, "message": "Gate fix: Cap nova-network tests at Queens\n\nNova is working on removing the nova-network only\ncompute REST APIs in the Rocky release, which means\nany requests to those APIs after Queens will result\nin a 410 response, regardless of microversion or\nwhether or not neutron is being used.\n\nThe os-virtual-interfaces API is being removed in\nnova change: https://review.openstack.org/569923/\n\nAs a result, os-virtual-interfaces tests will no longer\nworks against Rocky+ versions of nova.\n\nnova-network tests are skipped by adding\n`depends_on_nova_network \u003d True` to the test class. The\nbase compute API class does a check to determine, based\non the max compute API microversion, which release is\nbeing tested and if Rocky+ the nova-network specific\ntests will be skipped.\n\nSubsequent nova-network specific tests will be skipped\nas the API removal changes are proposed in nova.\n\nRelated to blueprint remove-nova-network\n\nChange-Id: I1d8d9aba6f44ee451e8e4d93a3e5bf5e70f7bbb3\n" }, { "commit": "c9bc9db4b45b8112cee9d8e06304e620d0a5c13c", "tree": "651896d395176ecd9b15f367a842e553beac81fb", "parents": [ "8d99172e2a55a2292ea0b733b43a4a7daefe5af3", "3056b9865bae5920dbd82e38f7b981fd497381d6" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Sun Jun 10 18:04:38 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Sun Jun 10 18:04:38 2018 +0000" }, "message": "Merge \"Wait for interface to detach for all interface tests\"" }, { "commit": "383960df5710c599334532c0177cbefee9c49d33", "tree": "096bb1e83730d2898933c7ad01a9d26489309d07", "parents": [ "8d99172e2a55a2292ea0b733b43a4a7daefe5af3" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Jun 10 13:39:05 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Jun 10 13:39:05 2018 -0400" }, "message": "Drop old README file\n\nThis patchset drops an old README file (not the main README file)\nthat contains no content. If we want to include README content\nunder patrole_tempest_plugin package we can do so later, but we\nshould not keep an empty documentation page around for nothing.\n\nChange-Id: I7e524e849a02732e70c5109795f422ac7f7cba25\n" }, { "commit": "8d99172e2a55a2292ea0b733b43a4a7daefe5af3", "tree": "ba9a5c083444429aa535903b9fa442abd4e31fb0", "parents": [ "d0ddf7d45044b2c8a9395a8f0df0c6c6adec9399", "8251477dde1d12d9b325ed3f9ab8caa047f25b93" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Sun Jun 10 05:11:29 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Sun Jun 10 05:11:29 2018 +0000" }, "message": "Merge \"Refactor `test_confirm_resize_server` to pass for all roles\"" }, { "commit": "ece376d3a4f760b8493e7d7d02f5174d01cdc7d3", "tree": "a532d787b8c228fc5d1040eb9f9a696bcbce1ac1", "parents": [ "9f42552b1aeb615cc7c705156fe0392184e581e8" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Jun 09 23:01:55 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Jun 09 23:01:55 2018 -0400" }, "message": "Remove duplicate test_unmanage_volume test\n\nThis patchset removes the duplicate test_umanage_volume test\nfrom test_volume_actions_rbac [0] because it is more appropriate\nto keep it in test_volumes_manage_rbac [1]. Besides the latter\nimplementation is more robust.\n\n[0] https://github.com/openstack/patrole/blob/1f2ba24f4df09ba3711aa520bdf1bedb63e7797a/patrole_tempest_plugin/tests/api/volume/test_volume_actions_rbac.py#L147\n[1] https://github.com/openstack/patrole/blob/7676a21077b5d8078f5beb32f7186970f02fc1a1/patrole_tempest_plugin/tests/api/volume/test_volumes_manage_rbac.py#L113\n\nChange-Id: I96705df2cfaf9e0885e53de15675581508dd7c3c\n" }, { "commit": "57ab8c46f2e2082c71d1e23f96f57472d5e216a0", "tree": "f0f44d49c174213c7649318287668bb5d234ff8b", "parents": [ "9f42552b1aeb615cc7c705156fe0392184e581e8" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Jun 09 22:16:59 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Jun 09 22:16:59 2018 -0400" }, "message": "Remove duplicate subnet tests fromt test_networks_rbac module\n\nThis patchset simply removes duplicate subnet tests from\ntest_networks_rbac [0] as they are already covered in\ntest_subnets_rbac [1].\n\n[0] e.g. https://github.com/openstack/patrole/blob/d0ddf7d45044b2c8a9395a8f0df0c6c6adec9399/patrole_tempest_plugin/tests/api/network/test_networks_rbac.py#L300\n[1] e.g. https://github.com/openstack/patrole/blob/d0ddf7d45044b2c8a9395a8f0df0c6c6adec9399/patrole_tempest_plugin/tests/api/network/test_subnets_rbac.py#L42\n\nChange-Id: Iea9eb984b06ab49822cf56021df3739c30a97d03\n" }, { "commit": "3056b9865bae5920dbd82e38f7b981fd497381d6", "tree": "659de49873f7c41fcff42b192351982d4d48d99d", "parents": [ "ea1c9e7cffb4b822d510d46dcaef76fab5999f20" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu May 31 23:23:49 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Jun 09 15:21:01 2018 +0000" }, "message": "Wait for interface to detach for all interface tests\n\nThis patchset waits for interfaces to detach during\ntest clean up in MiscPolicyActionsNetworkRbacTest.\nThis is a follow up to [0], which missed clean up\nfor certain tests.\n\n[0] I7b1a095bb73f4814b756f9493f9e353a8f98e7da\n\nChange-Id: I041aaa7dce53f920b014c1cb586dc6bb3c10b489\n" }, { "commit": "d0ddf7d45044b2c8a9395a8f0df0c6c6adec9399", "tree": "8b991d5ac23c25a11f016af284098de25dbcb5b4", "parents": [ "ea1c9e7cffb4b822d510d46dcaef76fab5999f20" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu May 31 02:04:11 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Jun 09 14:44:08 2018 +0000" }, "message": "Add RBAC tests for identity v3 application credentials API\n\nThis patchset adds RBAC tests for identity v3 application\ncredentials API [0], which enforces the following policies: [1].\n\n[0] https://developer.openstack.org/api-ref/identity/v3/index.html#application-credentials\n[1] https://github.com/openstack/keystone/blob/master/keystone/common/policies/application_credential.py\n\nChange-Id: I986e245a0bf7c4c37089a4a2dae7d9067c74162b\n" }, { "commit": "8251477dde1d12d9b325ed3f9ab8caa047f25b93", "tree": "23f63cb781bc8894719341232fe48009faad09b1", "parents": [ "ea1c9e7cffb4b822d510d46dcaef76fab5999f20" ], "author": { "name": "Rick Bartra", "email": "rb560u@att.com", "time": "Thu May 31 15:19:04 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Jun 09 14:43:49 2018 +0000" }, "message": "Refactor `test_confirm_resize_server` to pass for all roles\n\n`test_confirm_resize_server` fails for roles that do not have\npermission to perform the confirm resize API. It fails since\nthe cleanup tries to resize a server that is already in the resized\nstate [1]. This PS conditionally adds resize to addCleanup based on the\nstate of the server.\n\n[1] `Details: {u\u0027message\u0027: u\"Cannot \u0027resize\u0027 instance\ncb7c5ddc-959e-4238-9f79-a1963e60228f while it is in vm_state resized\",\nu\u0027code\u0027: 409}`\n\nChange-Id: I1abb13742ed931f15d6ae18ccdc6d790b41a02bf\n" }, { "commit": "ea1c9e7cffb4b822d510d46dcaef76fab5999f20", "tree": "3696d739de5d724192dded484984cd408dae11de", "parents": [ "3c9da68af76c27430224715a3e1e7ce6aba90a8e", "66d54a926674c1c60a2c0f3586b3dd6e938e2b89" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Sat Jun 09 14:27:06 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Sat Jun 09 14:27:06 2018 +0000" }, "message": "Merge \"Docs: Add requirements authority module to documentation\"" } ], "next": "3c9da68af76c27430224715a3e1e7ce6aba90a8e" }