)]}' { "log": [ { "commit": "4ae79ba52b15eb715a23070455547983ed0790da", "tree": "b66ce51cf68efc951ba13ceaeb26eebcce4d86cf", "parents": [ "35062ad4152901fb04bb67a9a65dd0b3247ec308" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Mon May 13 08:09:52 2019 -0500" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Thu May 16 15:02:41 2019 +0000" }, "message": "Add nosec in get_free_segmentation_id function\n\npep8 job fails due to bandit check with an error:\n [B311:blacklist] Standard pseudo-random generators are not suitable \n for security/cryptographic purposes.\n\nBut using the standard random function in the get_free_segmentation_id \nfunction is suitable, so adding #nosec comment should unbblock the gate.\n\nChange-Id: Iad8e376c503a32300b3e0b504f47a0c81e53a7a8\n" }, { "commit": "b3ee7cbc150eada7c35691189a392043996ada0a", "tree": "52b0ee9796fc0fbb574a9de52a01a5fcb3824d1c", "parents": [ "27fdf563f0a8e5d3686b1cde087520ee4bb40772" ], "author": { "name": "ghanshyam", "email": "gmann@ghanshyammann.com", "time": "Thu Apr 04 15:57:22 2019 +0000" }, "committer": { "name": "Ghanshyam Mann", "email": "gmann@ghanshyammann.com", "time": "Sat Apr 27 15:35:55 2019 +0000" }, "message": "make Patrole to run for shared network env\n\nDevstack added to create the shared network for tempest testing\nwhich makes sure tempest and other testing part works fine when\ntesting env has shared network.\n\n- https://github.com/openstack-dev/devstack/blob/683454f319246c3bda088b5e0325c5673263ce08/lib/tempest#L259\n\nNow patrole started failing because of the above shared network.\nDetails: {u\u0027message\u0027: u\u0027Multiple possible networks found, use a\nNetwork ID to be more specific.\u0027, u\u0027code\u0027: 409}\n\nhttp://logs.openstack.org/55/648255/1/check/patrole-admin/63b6639/testr_results.html.gz\n\nWhen patrol tests call create_tesrt_server, network id is not passed\nas kwargs which means it reply on tempest to add the network id for\ncreating the server[1]. Tempest fail to add the network id because it\nrelies on used credential to have the network created for them[2].\n\nWe should create the network for requested credential using\nset_network_resources() method.\n\nFollowing tests are skipped due to their failure due to bad request error:\n- test_update_network_provider_network_type[id-d064ef96-662b-47b6-94b7-9106dcd7ba8c]\n- test_update_network_provider_physical_network[id-e3a55660-f75c-494e-a1b1-a8b36cc789ef]\n- test_update_network_provider_segmentation_id[id-f6164228-b670-45fd-9ff9-b101930318c7]\n\n[1] https://github.com/openstack/tempest/blob/75ea3dbaf9d459f6b1e72644bfa73520142e17d1/tempest/api/compute/base.py#L234\n[2] https://github.com/openstack/tempest/blob/3639f91c36dbbcc8ecf9373aeb0cec83af468b81/tempest/lib/common/fixed_network.py#L95\n\nStory: 2005369\nTask: 30345\n\nChange-Id: I1281aa090c167c1e3e401a1707d196a69e7b5cd2\n" }, { "commit": "e0dfd1313f0ff306870f2093673502804a880c28", "tree": "4c5dc7811a8030a9634ca0ea69c279d933beb68e", "parents": [ "1a53003aacf3b6e73830b90ee1c676055f7717a3", "2db8338f6b59b83cc15a461a79b3df8e3bb75caf" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Mar 11 21:02:27 2019 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Mar 11 21:02:27 2019 +0000" }, "message": "Merge \"Do not use self in classmethod\"" }, { "commit": "1a53003aacf3b6e73830b90ee1c676055f7717a3", "tree": "f942a23fb0a7a1a3242a758351b760e4412133e2", "parents": [ "4e79004730f2e180b56cfce1f5c885d30ffcd8d5" ], "author": { "name": "AbhishekJ", "email": "abhishekjaiswal.kol@gmail.com", "time": "Mon Jan 14 15:38:48 2019 +0530" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Mon Mar 11 16:43:57 2019 +0000" }, "message": "Compute test are failing due not explicitly passing Network information\n\nStory: 2004770\nTask: 28889\n\nChange-Id: Id8bc72420b8d6e08788be04136546960064d7fb1\n" }, { "commit": "2db8338f6b59b83cc15a461a79b3df8e3bb75caf", "tree": "c80ea7180e1f529d58357fd5cecec3caaeab89f3", "parents": [ "4e79004730f2e180b56cfce1f5c885d30ffcd8d5" ], "author": { "name": "zhufl", "email": "zhu.fanglei@zte.com.cn", "time": "Mon Mar 11 14:23:07 2019 +0800" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Mon Mar 11 13:31:58 2019 +0000" }, "message": "Do not use self in classmethod\n\ncls should be used in classmethod, instead of self.\n\nChange-Id: I0e997c248f83a5a63e64b8522f2fee0f48f57449\n" }, { "commit": "78e7f57fdbfddd0e7d2c53feaacd5284730cf1d0", "tree": "dfb8c8c515b4e9d86a80030c9c3d8cb6ee7c5036", "parents": [ "d3d77ef10c3e2d32d62ebd93870d82f3725e1a8c" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Sun Feb 03 10:35:01 2019 -0600" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Tue Feb 05 20:16:50 2019 -0600" }, "message": "Refactoring RbacUtils part 3 - documentation\n\nChange the documnentation according to new RbacUtilsMixin\n\nStory: 2002604\nTask: 22223\n\nChange-Id: I30ab8ea002f9312a5b50e2f2c511ed321a679c00\n" }, { "commit": "d3d77ef10c3e2d32d62ebd93870d82f3725e1a8c", "tree": "0d393a01b8a61086760df9caccc9ca7ed4566f21", "parents": [ "ace8ea37c8e05615b7437d27b4ba2a22ac656bb0" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Sat Feb 02 09:34:52 2019 -0600" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Tue Feb 05 20:15:56 2019 -0600" }, "message": "Refactoring RbacUtils part 2 api tests\n\nThe override_role function no longer needs test_obj parameter.\nAlso removing self.rbac_utils variable.\n\nStory: 2002604\nTask: 22223\n\nChange-Id: I1ee95e3051d7bd27f73df818fa2b64caa07c1ed2\n" }, { "commit": "ace8ea37c8e05615b7437d27b4ba2a22ac656bb0", "tree": "2019061b1b773aa0c7ab85f61dc236693a0317b9", "parents": [ "9866753ca8a3344d3335e8763f680db935802ce3" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Mon Nov 19 16:25:10 2018 -0600" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Tue Feb 05 09:44:37 2019 -0600" }, "message": "Refactoring RbacUtils\n\nRemove RbacUtils class and move all functionality to RbacUtilsMixin.\n\nStory: 2002604\nTask: 22223\n\nChange-Id: If476be8fd3df78b28669ca940ebeb288af534899\n" }, { "commit": "9866753ca8a3344d3335e8763f680db935802ce3", "tree": "4c1eefb7c0663b5eb05364e244e22de07df8a04e", "parents": [ "5a563119694d7c69d955f08fba02667420cf0abf", "7a308a0f1373fa822fbd14029a8847e6ae150546" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Feb 05 09:31:02 2019 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Feb 05 09:31:02 2019 +0000" }, "message": "Merge \"Fix Policy action \"get_flavors\" not found\"" }, { "commit": "5a563119694d7c69d955f08fba02667420cf0abf", "tree": "31aef6965f97cc74d229d592de4f71da82608bd6", "parents": [ "11e0c66cf8e6613deebd8c360622fdbc4563f2e8", "2a0fb1f941a4442d46fc5a6075eb5132a6866c3f" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Feb 05 09:31:01 2019 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Feb 05 09:31:01 2019 +0000" }, "message": "Merge \"Fix Policy action \"get_network_ip_availabilities\" not found\"" }, { "commit": "7a308a0f1373fa822fbd14029a8847e6ae150546", "tree": "a79e2c0b211b80860c2a0ae89768fb4f75c06846", "parents": [ "2daa5e6017e0619087f192371b2b003ff9f030bb" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Thu Jan 31 10:32:15 2019 -0600" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Thu Jan 31 10:46:02 2019 -0600" }, "message": "Fix Policy action \"get_flavors\" not found\n\nThe \"get_flavors\" policy has been removed since the Neutron uses policy\nin code.\nPatrole should test against the \"get_flavor\" policy and use the\n\"override_role_and_validate_list\" function for validation.\n\nChange-Id: Ibbe4e7e3dec27c56d4fd8990b77910866a694a3e\n" }, { "commit": "2a0fb1f941a4442d46fc5a6075eb5132a6866c3f", "tree": "1d37ea5322dfb350a56f6ea1d2545017707dd38d", "parents": [ "2daa5e6017e0619087f192371b2b003ff9f030bb" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Thu Jan 31 10:43:27 2019 -0600" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Thu Jan 31 10:45:28 2019 -0600" }, "message": "Fix Policy action \"get_network_ip_availabilities\" not found\n\nThe \"get_network_ip_availabilities\" policy has been removed since the Neutron\nuses policy in code.\nPatrole should test the \"get_network_ip_availability\" policy.\n\nChange-Id: I068c96442f757eb765d147e161584c13f50bfe90\n" }, { "commit": "19e3becfc73cf02df18de42742ac1d90e8d29ac6", "tree": "4a8440d1fef88688b828ea8767d8d10891d8e21d", "parents": [ "2daa5e6017e0619087f192371b2b003ff9f030bb" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Mon Jan 07 11:59:41 2019 -0600" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Thu Jan 31 08:20:44 2019 -0600" }, "message": "Support implied rules\n\nUsing keystone API[0] to get all role inference rules and makes it\npossible to extend the used list of roles with implied roles.\n\n[0] https://developer.openstack.org/api-ref/identity/v3/#list-all-role-inference-rules\nChange-Id: Ia57351f3b21a82f4556ec61323abd295b427fc1e\n" }, { "commit": "588e806772c7d739c8fc9035e3692d0b89642620", "tree": "f4383e8695df75bb7cd763feff5ba9c52a0c062c", "parents": [ "12afdade52ead4bae4c82874e4e8962a9ce76af3" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jun 08 21:57:38 2018 -0400" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Wed Jan 30 02:26:01 2019 +0000" }, "message": "Fix instability with volume attachment RBAC tests\n\nThis patchset fixes instability with volume attachment\nRBAC tests. The tests are currently failing due to volumes\nfailing to reach the expected statuses due to insufficiently\nrobust waiters or due to sharing of class-wide resources\n(volumes, servers) [0]. Lack of resource idempotency is likely\ncompounding waiter issues.\n\nSo this patchset resolves the issue by creating a volume/server\nper test and removing the shared class-wide versions. It also\nadds a `wait_for_server_volume_swap` call to\n`test_update_volume_attachment` which was previously missing\neven though the test does a volume swap.\n\nFinally, the test `test_create_volume_attachment` now\nmore atomically tests `attach_volume` API action by\ncalling the API directly in the contextmanager (while\nthe role is overridden) and only afterward invokes the\nwaiter to wait for the volume status to change.\n\n[0] e.g. http://logs.openstack.org/21/571621/1/check/patrole-multinode-admin/395b4fb/job-output.txt.gz#_2018-06-01_04_06_10_109536\n\nChange-Id: Ib78ccc3cad7689c0c5a7daf10ec5eeb2ee7a03ab\n" }, { "commit": "12afdade52ead4bae4c82874e4e8962a9ce76af3", "tree": "62331e30bedc67c3fd2bb045c1f41aaf6acc79ea", "parents": [ "ead6d4a9601299cae59189660079c8586fb8c3ec", "427c74c3f97f4577e944a89d82045ba63e5e8d4b" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Jan 30 00:55:40 2019 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Jan 30 00:55:40 2019 +0000" }, "message": "Merge \"Fix the misspelling of \"available\"\"" }, { "commit": "587f2822436479c91fedd94d79dfb9b602512be7", "tree": "b8a3a7d72cefd7aab956166e1c058277dcda4a37", "parents": [ "cc05c1a9ce110e1d995d108bb3fbaea5302fac75", "0868ded0eb9cab34948e40311bc8723ee1fd0b07" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Jan 29 20:02:09 2019 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Jan 29 20:02:09 2019 +0000" }, "message": "Merge \"dict_object.keys() is not required for *in* operator\"" }, { "commit": "cc05c1a9ce110e1d995d108bb3fbaea5302fac75", "tree": "fe10ba5da0d67debb5d03828290efce17750daff", "parents": [ "55e5dfe640e1d8bdc5250c17420fcc5a3fca7b3f", "6da06edd6242f4029db2d427224b64337ea2217d" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Jan 29 06:29:18 2019 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Jan 29 06:29:18 2019 +0000" }, "message": "Merge \"Use the canonical URL for repositories (git.openstack.org)\"" }, { "commit": "55e5dfe640e1d8bdc5250c17420fcc5a3fca7b3f", "tree": "8103fa68c8840129744e3b44c12a68776923b92e", "parents": [ "cd2c5fdbb9c4565b9e0ca30009e567e013587048" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Mon Jan 07 11:59:41 2019 -0600" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Mon Jan 28 07:45:07 2019 -0600" }, "message": "Fix OverPermission exception for keystone tests\n\nExtend the roles in `access_token` according to the implementation[0]\nof the bp basic-default-roles:\n `admin` implies `member` implies `reader`\nSupport deprecated rules.\n\n[0] Ie18a269e3d1075d955fe494acaf634a393c6bd7b\n\nChange-Id: I0d0de2a20b03548a7e5dab1ee7af7b72651abcb6\nStory: 2004709\nTask: 28740\n" }, { "commit": "427c74c3f97f4577e944a89d82045ba63e5e8d4b", "tree": "f9f21be17b8833f5b50c0067cf47f8b1ed45a5c7", "parents": [ "cd2c5fdbb9c4565b9e0ca30009e567e013587048" ], "author": { "name": "lijunjie", "email": "lijunjie@cloudin.cn", "time": "Tue Jan 22 13:42:19 2019 +0800" }, "committer": { "name": "lijunjie", "email": "lijunjie@cloudin.cn", "time": "Tue Jan 22 13:42:19 2019 +0800" }, "message": "Fix the misspelling of \"available\"\n\nChange-Id: I28cae6422c0d4b63b386dd7454202eeada2bb7c3\n" }, { "commit": "6da06edd6242f4029db2d427224b64337ea2217d", "tree": "3d8b799824900b5d7e8299174c1e97c9dac2624e", "parents": [ "89d5d18234c4b6a7fa4c0ab9fe2d46351350cf7a" ], "author": { "name": "Luigi Toscano", "email": "ltoscano@redhat.com", "time": "Mon Jan 07 17:50:41 2019 +0100" }, "committer": { "name": "Luigi Toscano", "email": "ltoscano@redhat.com", "time": "Mon Jan 07 17:50:41 2019 +0100" }, "message": "Use the canonical URL for repositories (git.openstack.org)\n\n- When the URL refers to cloning or using git repositories, use the\n cloning URL (https://git.openstack.org/\u003cnamespace\u003e/\u003cproject\u003e)\n- When the URL refers to the browsable version of the repository, point to\n the cgit frontend (https://git.openstack.org/cgit/\u003cnamespace\u003e/\u003cproject\u003e)\n\nChange-Id: Iaeaa153a05aa85b9cf7451ae3c28aec56722222c\n" }, { "commit": "0868ded0eb9cab34948e40311bc8723ee1fd0b07", "tree": "1ddd41cec432a5a7f9f9a688489286169f569cc9", "parents": [ "89d5d18234c4b6a7fa4c0ab9fe2d46351350cf7a" ], "author": { "name": "Manik Bindlish", "email": "manikbindlish19@gmail.com", "time": "Thu Dec 20 08:44:50 2018 +0000" }, "committer": { "name": "Manik Bindlish", "email": "manikbindlish19@gmail.com", "time": "Thu Dec 20 08:44:50 2018 +0000" }, "message": "dict_object.keys() is not required for *in* operator\n\ncleanup of .keys() from dict_object.keys() *in* operator\n\nChange-Id: I76b92514c6740a57bc7134015ac6197393913b25\n" }, { "commit": "0a824743b58aab277e7a457841a37998a176b844", "tree": "10f71dc095dce1702f9c1de1b5703084f0ecf26e", "parents": [ "fe6ad6b44c032e98e9d6c9d3aebe3c608285e634" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Thu Oct 11 14:38:16 2018 -0500" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Fri Nov 30 07:18:39 2018 -0600" }, "message": "Rbac tests for Neutron list actions\n\nAdd RBAC tests for\n * list_routers [0]\n * list_subnetpools [1]\n * list_networks [2]\n * list_ports [3]\n * list_trunks [4]\n * list_address_scopes [5]\n * list_floatingips [6]\n * list_rbac_policies [8]\n * list_metering_labels [10]\n * list_metering_label_rules [11]\n * list_qos_policies [12]\n * list_dscp_marking_rules [13]\n * list_agents [14]\n * list_segments [15]\n\nUpdate RBAC tests to use validate_list function for:\n * list_subnets [7]\n * list_security_groups [9]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#list-routers\n[1] https://developer.openstack.org/api-ref/network/v2/index.html#list-subnet-pools\n[2] https://developer.openstack.org/api-ref/network/v2/index.html#list-networks\n[3] https://developer.openstack.org/api-ref/network/v2/index.html#list-ports\n[4] https://developer.openstack.org/api-ref/network/v2/index.html#list-trunks\n[5] https://developer.openstack.org/api-ref/network/v2/index.html#list-address-scopes\n[6] https://developer.openstack.org/api-ref/network/v2/index.html#list-floating-ips\n[7] https://developer.openstack.org/api-ref/network/v2/index.html#list-subnets\n[8] https://developer.openstack.org/api-ref/network/v2/index.html#list-rbac-policies\n[9] https://developer.openstack.org/api-ref/network/v2/index.html#list-security-groups\n[10] https://developer.openstack.org/api-ref/network/v2/index.html#list-metering-labels\n[11] https://developer.openstack.org/api-ref/network/v2/index.html#list-metering-label-rules\n[12] https://developer.openstack.org/api-ref/network/v2/index.html#list-qos-policies\n[13] https://developer.openstack.org/api-ref/network/v2/index.html#list-dscp-marking-rules-for-qos-policy\n[14] https://developer.openstack.org/api-ref/network/v2/index.html#list-all-agents\n[15] https://developer.openstack.org/api-ref/network/v2/index.html#list-segments\n\nChange-Id: I0dae01a3271efe6d3469718976c471416279e337\n" }, { "commit": "fe6ad6b44c032e98e9d6c9d3aebe3c608285e634", "tree": "7607e6d46028c250b2e104da401abff7fa80af6c", "parents": [ "22e29716a11800ed84fe9958254caebae0f7031a", "a261a2f446c5dea91466a866796f39234ad206a0" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Nov 30 05:40:11 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Nov 30 05:40:11 2018 +0000" }, "message": "Merge \"Add tests to cover network ip availability API\"" }, { "commit": "22e29716a11800ed84fe9958254caebae0f7031a", "tree": "1af7534908e9ffdae130d5a7db923cbde5190560", "parents": [ "3d6fd8ec33b020dd808dce2301812884dc610586" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Fri Jul 27 22:53:56 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "myakovliev@mirantis.com", "time": "Wed Nov 28 20:09:31 2018 +0000" }, "message": "Add tests to cover trunks subports\n\nThis patch set adds tests to cover the neutron subports API [0].\nTest adds, gets, removes trunks subports.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#add-subports-to-trunk\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I5ddefe2df23b4888ce6706a27784c461f9af1614\nStory: 2002641\nTask: 22328\n" }, { "commit": "3d6fd8ec33b020dd808dce2301812884dc610586", "tree": "be2627fd20544fc50bd35f14e61edcc384f47630", "parents": [ "1d91ee101031602e618d464b14cdf4146ab8bc7e", "02f6606b42888b0fe56a98dc028e3507264f4221" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Nov 28 17:11:38 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Nov 28 17:11:38 2018 +0000" }, "message": "Merge \"Add List Available Zones test cases for RBAC.\"" }, { "commit": "1d91ee101031602e618d464b14cdf4146ab8bc7e", "tree": "6359d0eb3ab13fe36975f25c8afbaf48a75bee47", "parents": [ "cb4c749be7676eb0bfa6062c70898ab5d79c9319", "bab9e9467ce8bba3ce001414221e72cae8267d9d" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Nov 28 17:11:37 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Nov 28 17:11:37 2018 +0000" }, "message": "Merge \"Helper for validating RBAC list actions\"" }, { "commit": "02f6606b42888b0fe56a98dc028e3507264f4221", "tree": "1bb2dc164a1b37b33efb3f14acab11a23e5f7505", "parents": [ "bab9e9467ce8bba3ce001414221e72cae8267d9d" ], "author": { "name": "Goutham Pratapa", "email": "lakshmi.pratapa@imaginea.com", "time": "Fri Sep 28 20:16:57 2018 +0530" }, "committer": { "name": "Goutham Pratapa", "email": "lakshmi.pratapa@imaginea.com", "time": "Tue Nov 27 15:01:50 2018 +0530" }, "message": "Add List Available Zones test cases for RBAC.\n\nThis commit includes list available zones tests for RBAC\nThe operation is only\n- List available zones\n\nDepends-On: I7e5e706c44136e0b565f3ee18e15f1166d82040d\n\nChange-Id: I39b10e06d9bcbf6fa939ee4603e830bb935e716b\n" }, { "commit": "0e4fc01c2fa42e66af6547e6bd396c754e6d3b48", "tree": "fd3935c27b0eab7144906e2e41a960032722d349", "parents": [ "a6dbdd59b011419392bcbeac16c8a2d67de52c9f", "0710e5d6c85a89c1490993609a3ae7bfa34e4181" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Nov 21 22:54:17 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Nov 21 22:54:17 2018 +0000" }, "message": "Merge \"Validate omission of expected_error_codes defaults to 403\"" }, { "commit": "b5d01cc3b563ba2d37de3e7df19bb18e3986d301", "tree": "339d6866d692a85c93de85a4780bed4ec7486439", "parents": [ "8f0f407c336d13d904bfb4708c0dac2cd4615000" ], "author": { "name": "zhufl", "email": "zhu.fanglei@zte.com.cn", "time": "Mon Nov 19 14:35:27 2018 +0800" }, "committer": { "name": "zhufl", "email": "zhu.fanglei@zte.com.cn", "time": "Mon Nov 19 14:38:28 2018 +0800" }, "message": "Add missing ws seperator between words\n\nThis is to add missing ws seperator between words.\n\nChange-Id: I686ac43070c783de7e7c7704351558d471531f1a\n" }, { "commit": "a261a2f446c5dea91466a866796f39234ad206a0", "tree": "b011447bc714b3dce23dd9c60ff140e8532f306e", "parents": [ "bab9e9467ce8bba3ce001414221e72cae8267d9d" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Wed Sep 05 14:27:22 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "myakovliev@mirantis.com", "time": "Thu Nov 15 21:38:58 2018 +0000" }, "message": "Add tests to cover network ip availability API\n\nThis patch set adds tests to cover the neutron network_ip_availability API [0].\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#network-ip-availability-and-usage-stats\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: Idddf5a8bf5214b1fbc079fcf2f5b1a4c2a889a57\nStory: 2002641\nTask: 22304\n" }, { "commit": "b68763ccd773f429b98ba055ad7a9d5b1f797dc2", "tree": "43866ffd9961c9bae8667c5855e9953d53af945d", "parents": [ "0464e81c98b1d71d0bd42ce520013cd0ac1c8bac" ], "author": { "name": "jessegler", "email": "jess.egler@gmail.com", "time": "Tue Aug 28 14:17:15 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 14 23:23:07 2018 +0000" }, "message": "Add tests to cover service_profile\n\nThis patch set adds test to cover the service_profile API [0].\nTests create_service_profile, get_service_profile,\nupdate_service_profile, delete_service_profile.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/#networking-flavors-framework-v2-0-current-flavor-service-profile\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nCo-Authored-By: Mykola Yakovliev \u003cvegasq@gmail.com\u003e\nChange-Id: I57c6d44eaa891e83931924f0d802ccd79a79439b\nStory: 2002641\nTask: 22317\n" }, { "commit": "bab9e9467ce8bba3ce001414221e72cae8267d9d", "tree": "87eb21da37b3e9ac14b382bc1de4d6175d2416cf", "parents": [ "0464e81c98b1d71d0bd42ce520013cd0ac1c8bac" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Thu Oct 11 14:04:48 2018 -0500" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Wed Nov 14 12:58:52 2018 -0600" }, "message": "Helper for validating RBAC list actions\n\nList RBAC actions typically perform soft authorization checks meaning\nthat the response bodies omit resources that the user isn\u0027t authorized\nto see.\nFor example, if an admin user creates a user, member role might not be\nable to see that user when listing all the users in a tenant,\ndepending on the RBAC rule.\nThis patch set adds override_role_and_validate_list function to\nRbacUtils to validate RBAC flows for API list actions.\n\nChange-Id: I5f39efc8aa0004d4ad435cbd6b8fb037c33832d6\n" }, { "commit": "0710e5d6c85a89c1490993609a3ae7bfa34e4181", "tree": "e139303103999725e8b98182a58331ba624afd20", "parents": [ "825d79452c5b6da8cd68e897d83a280561dcbb90" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Aug 17 10:29:45 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 14 05:42:46 2018 +0000" }, "message": "Validate omission of expected_error_codes defaults to 403\n\nAdd a test that checks that the omission of expected_error_codes\ndefaults to [403] * len(rules). This helps to validate the recent\nchange: https://review.openstack.org/#/c/592935/\n\nChange-Id: I0faa89ab22ab6f811c3d927f76cfb20c2d63012a\n" }, { "commit": "0464e81c98b1d71d0bd42ce520013cd0ac1c8bac", "tree": "3e15ed5b9a572016927f8cec567b1fbba1f8fe18", "parents": [ "c81c1fb18977a93c5e1213182350fa780839b2aa" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Nov 08 01:08:07 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 14 01:16:00 2018 +0000" }, "message": "requirements authority: Use better exception/return code\n\nThis patch set makes some minor modifications to the requirements\nauthority module:\n\n* return {} instead of None in RequirementsParser.parse since\n its return type is dict\n* raise RbacParsingException if an invalid rule is passed to\n RequirementsAuthority.allowed since KeyError is a builtin type\n and is not specific enough\n* change the exception message raise for the above case -- \"API\"\n is not the right word; the word should be \"rule name\" as that\n is what is being keyed into the roles_dict\n\nChange-Id: Ia4408c0745d2b5ddb1c73c1eb9a6316ae0c1f646\n" }, { "commit": "c81c1fb18977a93c5e1213182350fa780839b2aa", "tree": "abb48b15e9ce5f4f387091f43968a003d6e0c1ae", "parents": [ "ba9829d5478305b3319cb713d8a28c1893c120cc", "2a5f41e83f258e2d679d5c7312e7527466cdccec" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Nov 13 23:23:07 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Nov 13 23:23:07 2018 +0000" }, "message": "Merge \"Fix error codes for test_delete_flavor_service_profile\"" }, { "commit": "ba9829d5478305b3319cb713d8a28c1893c120cc", "tree": "3e6038b5ac749de8aa64e8c030096f059436dcdd", "parents": [ "f7c54efb7f0ebc8044140d2876ad5ccebd52e669", "d02a8d836c560a3571b0a2f17f102e25bc7c5301" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Nov 13 22:26:25 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Nov 13 22:26:26 2018 +0000" }, "message": "Merge \"RequirementsAuthority multi role support enhancement\"" }, { "commit": "f7c54efb7f0ebc8044140d2876ad5ccebd52e669", "tree": "1998c76b7fdb8fea93d412f28e8aca6b1f975831", "parents": [ "3230e20d4c999a97cb30b696ef93170b6be59c84", "bbbdd9391d3f4fce0277ae24393d6e1ee183430f" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Nov 13 21:47:04 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Nov 13 21:47:04 2018 +0000" }, "message": "Merge \"refactor: Rename PluginRbacTest \u003d\u003e ExtRbacTest\"" }, { "commit": "5d59810ae813e5ce0f4008c416f3f779cb49e7fd", "tree": "066279783fb469e1bfc0e14849404c20828a81d2", "parents": [ "a5f5590e2997fb2fbbb135cd2c38a9ef5bd4a5d2", "74f8e7d97fffd6909ead4f362b7f956e64fb2768" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Nov 09 18:33:23 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Nov 09 18:33:23 2018 +0000" }, "message": "Merge \"refactor: Break up RbacMalformedException into discrete exceptions\"" }, { "commit": "d02a8d836c560a3571b0a2f17f102e25bc7c5301", "tree": "ea06f52eac491355b12bd1890020259f249b242b", "parents": [ "a5f5590e2997fb2fbbb135cd2c38a9ef5bd4a5d2" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Tue Oct 30 21:35:20 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Nov 08 14:44:09 2018 +0000" }, "message": "RequirementsAuthority multi role support enhancement\n\nThis patchset eliminates different behaviour between\npolicy_authority and requirements_authority.\n\nProblem description:\n\n`rbac_test_roles \u003d [member,]`\n\nPolicy authority:\n\n`update_port: role:member and role:viewer`\n\nResults in 403/False (we are member but not viewer).\n\nRequirements authority:\n\n```\nreq_auth:\n update_port:\n - member\n - viewer\n```\n\nResults in 200/True (member in update_port list).\n\nProposed solution:\n\nChange requirements_authority file sytax to support\ncomma separated roles to be considered as logical and.\n\nDepends-On: https://review.openstack.org/#/c/606110/\nChange-Id: I2e2a4a2020f5e85af15f1836d69386bc91a2d2ec\nCo-Authored-By: Felipe Monteiro \u003cfelipe.monteiro@att.com\u003e\n" }, { "commit": "2a5f41e83f258e2d679d5c7312e7527466cdccec", "tree": "5ce6f293bd2b4714671d1db8f2f48705a41d44dc", "parents": [ "a5f5590e2997fb2fbbb135cd2c38a9ef5bd4a5d2" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 07 19:35:40 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 07 19:35:40 2018 -0500" }, "message": "Fix error codes for test_delete_flavor_service_profile\n\nThis patch set fixes the expected error codes for test\n`test_delete_flavor_service_profile`. Like other delete\ntests for Neutron it enforces delete_* and get_* policy.\n\nChange-Id: I4e67e0cd3190794741ea84131de3cbab6c28eb4f\n" }, { "commit": "74f8e7d97fffd6909ead4f362b7f956e64fb2768", "tree": "b4610969494bdffa72729533ea229db3fc5b0d17", "parents": [ "742b73767ba6eb14fd60a5aeebe52bae9cf0c58c" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Sep 30 12:33:49 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 07 16:23:51 2018 -0500" }, "message": "refactor: Break up RbacMalformedException into discrete exceptions\n\nThis patch set breaks up RbacMalformedException into the following\ndiscrete exceptions:\n\n* RbacMissingAttributeResponseBody\n* RbacPartialResponseBody\n* RbacEmptyResponseBody\n\nEach of the exception classes deals with a different type of\nfailure related to a soft authorization failure [0] which\nmeans that a failure occurred server side related to RBAC\nauthorization, but the result of which an incomplete, partial\nor empty response body (with a 2xx status code).\n\n* incomplete means that the response body (for show or list)\n is missing certain attributes\n* partial means that a list response only returned a subset of\n the possible results available.\n* empty means that the show or list response body is entirely\n empty\n\nBecause RbacMalformedException is not part of a stable library\nit is removed altogether; we do not need to deprecate it.\n\n[0] http://git.openstack.org/cgit/openstack/patrole/tree/doc/source/rbac-overview.rst#n232\n\nStory: 2003843\nTask: 26633\nChange-Id: I2c76c3c4d226e4877fc9d1e93707edfc230a1be4\n" }, { "commit": "596bebd246d96cdab20b131413084e5a6eead946", "tree": "08745eaf2d09e7244aab467489735489a1896e07", "parents": [ "742b73767ba6eb14fd60a5aeebe52bae9cf0c58c" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Wed Nov 07 10:46:16 2018 -0600" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Wed Nov 07 10:46:16 2018 -0600" }, "message": "Replace all volume client aliases with _latest suffix\n\nUse aliases with _latest suffix instead of v2 or v3 for clients.\n\nChange-Id: Ie17b9abca60d943bce0b62997b1f58a56963314d\nStory: 2003377\nTask: 24452\n" }, { "commit": "bbbdd9391d3f4fce0277ae24393d6e1ee183430f", "tree": "bfa55a76c9407046990b978278a9421a15e227eb", "parents": [ "742b73767ba6eb14fd60a5aeebe52bae9cf0c58c" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Oct 31 23:28:39 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 07 04:13:25 2018 +0000" }, "message": "refactor: Rename PluginRbacTest \u003d\u003e ExtRbacTest\n\nThis patch set is a follow up on discussion in [0] which\nconcluded that Patrole should not test Neutron plugins.\n\nThe pertinent discussion from [0] is:\n\nPatrole can test Neutron extensions but not plugins in tree\nand that requires renaming the classes\n(.*PluginRbacTest \u003d\u003e .*ExtRbacTest) to make it clearer.\n\nHaving to support all the Neutron plugins in tree is out of scope\nfor Patrole. Clarifying documentation (which will be done in follow\nup) can be added to Patrole documentation to make it clear that\nit will only test \"main\" OpenStack projects, like Tempest.\n\n[0] https://review.openstack.org/#/c/599869/\n\nChange-Id: Iab029f2f875ce2268de12cc2a40e30f2f1a913fe\n" }, { "commit": "415261e3d529b0095f9e15297487cae498a607b2", "tree": "0906491ddc20a4cf411b537eb675b8e0eef7b782", "parents": [ "2c9d9fc243d87045639a073870e980e1e404249c", "e0f35503c90bee01666ee252689738c7c2042ce8" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Nov 07 00:33:28 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Nov 07 00:33:28 2018 +0000" }, "message": "Merge \"Multi role RBAC validation\"" }, { "commit": "3f9401ed50c37f6d9bc56cfb583c71097849c276", "tree": "3ca70e86c5041dcce4d0605e499c637947c1f163", "parents": [ "da3c54b152d1dfe84884e738c5e30fba68cb8148", "2a6d32969fa1f0f09dc2c3b372e318d34cb1c103" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Nov 06 18:06:18 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Nov 06 18:06:18 2018 +0000" }, "message": "Merge \"Add tests to cover auto_allocated_topology\"" }, { "commit": "3932f03700ab5e33b78cc03ecdfaa5ef97a1fc65", "tree": "3d1992d1d093be81f5f940ba6fc4066068abd88b", "parents": [ "5addd6979616ffb95a8e225b1f118ac503091369", "fcd6fcf33c3f62840312dc9b7af8a75263b69dcb" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Nov 05 21:25:56 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Nov 05 21:25:56 2018 +0000" }, "message": "Merge \"Add waiters after creating volume transfer for related tests\"" }, { "commit": "5addd6979616ffb95a8e225b1f118ac503091369", "tree": "674329c325c41838da2e24eb531637bd336c8dd7", "parents": [ "d771e34d2432b914827bbf51340ec9b756b5d82b", "1b49965a9b31fada55a7a93af2881e8a1909f010" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Nov 05 21:02:08 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Nov 05 21:02:08 2018 +0000" }, "message": "Merge \"trivial: Correct base class name in hacking check\"" }, { "commit": "1b49965a9b31fada55a7a93af2881e8a1909f010", "tree": "f08dc3b8a1e06aa0881fd9e7e24d6f15c388fd87", "parents": [ "904a02bef8af64c2a6fb1e0aca67ea9db3f9883f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Oct 31 20:44:50 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Nov 01 10:34:36 2018 -0400" }, "message": "trivial: Correct base class name in hacking check\n\nThis patch set fixes the base class name in a hacking check\nunit test for PluginRbacTest Suffix (P104).\n\nThe passing case should be:\n\n class FakePluginRbacTest(base.BaseFakePluginRbacTest)\n\nNot:\n\n class FakePluginRbacTest(base.BaseFakeRbacTest)\n\nBecause the point is to check that all subclasses that inherit\nfrom class .+PluginRbacTest also end in that suffix.\n\nChange-Id: Ic6306b97bb68c42f51e796d876893f9ac91c67a4\n" }, { "commit": "4877f1d43259de39e9029aea90046351a0c3fb35", "tree": "6cbc84c1769545c4e0384bef0025b90f68ba8f9e", "parents": [ "7267fa45d904170d934ff3245fd5ff5d1a30bd80", "904a02bef8af64c2a6fb1e0aca67ea9db3f9883f" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Nov 01 01:26:55 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Nov 01 01:26:55 2018 +0000" }, "message": "Merge \"hacking: Add hacking rule for plugin rbac test class names\"" }, { "commit": "7267fa45d904170d934ff3245fd5ff5d1a30bd80", "tree": "58aa75981bba46c2e17c9152c4877f55c6232cb9", "parents": [ "c38aca7587f526dbea4b3337b0a4822ae837d4ea", "cacbd211250d355bcbb2bbf049cfb4bd8c94ee04" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Oct 31 23:38:09 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Oct 31 23:38:09 2018 +0000" }, "message": "Merge \"fix: Rename test classes causing accidental skip\"" }, { "commit": "e0f35503c90bee01666ee252689738c7c2042ce8", "tree": "fc80d222332c6925886acec96e4192d30636569d", "parents": [ "c38aca7587f526dbea4b3337b0a4822ae837d4ea" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Wed Sep 26 18:26:57 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "myakovliev@mirantis.com", "time": "Wed Oct 31 20:45:13 2018 +0000" }, "message": "Multi role RBAC validation\n\nThis patchset replaces ``CONF.patrole.rbac_test_role`` with\n``CONF.patrole.rbac_test_roles``, where instead of single role\nwe can specify list of roles to be assigned to test user.\n\nChange-Id: Ia68bcbdbb523dfe7c4abd6107fb4c426a566ae9d\n" }, { "commit": "c38aca7587f526dbea4b3337b0a4822ae837d4ea", "tree": "92f3b63fa25c57b238cc7d99f1da30f208f5eb9b", "parents": [ "f63a8345312c17d04218fe40f9abca9d99774741" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Oct 31 01:21:48 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Oct 31 01:24:24 2018 -0400" }, "message": "Add feature flag for Keystone policies removed in Stein\n\nThis patch set adds a new feature flag called\n``removed_keystone_policies_stein`` under the configuration\ngroup ``[policy-feature-enabled]`` for skipping Keystone\ntests whose policies were removed in Stein. This feature flag\nis currently applied to credentials-related policies, e.g.:\nidentity:[create|update|get|delete]_credential\n\nMore info on removed Keystone policies:\n\nhttps://review.openstack.org/#/c/597187/16\n\nChange-Id: Ibd16e658d0e1367b46a2d6730f2b6970a95ae221\n" }, { "commit": "f63a8345312c17d04218fe40f9abca9d99774741", "tree": "632975c33b08b89b3c0b47451bc383731435150b", "parents": [ "2238c69f46defb4a2328a0e5c3a4d5a3c23fea36", "bf524fbcf5295d521a1200db23d687a4976e9163" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Sat Oct 27 01:57:38 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Sat Oct 27 01:57:38 2018 +0000" }, "message": "Merge \"Deprecate use of v2 roles client in rbac_utils.py\"" }, { "commit": "904a02bef8af64c2a6fb1e0aca67ea9db3f9883f", "tree": "d352613a998a07b2709894ea79eadacc28698117", "parents": [ "cacbd211250d355bcbb2bbf049cfb4bd8c94ee04" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Oct 21 12:54:46 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Oct 21 19:58:48 2018 +0000" }, "message": "hacking: Add hacking rule for plugin rbac test class names\n\nThis patch set introduces a new hacking check called\n`no_plugin_rbac_test_suffix_in_plugin_test_class_name` which\nis responsible for enforcing that all plugin rbac test classes\nend in the correct suffix in order to avoid issues like [0].\n\nBasically, some network plugin rbac tests were skipping because\nthe regex in .zuul.yaml was not selecting them because the\nclasses were improperly named. This is to avoid that regression.\n\nUpdates documentation with P104 - alias for this new hacking\nrule - and adds unit tests to validate its logic.\n\n[0] https://review.openstack.org/#/c/612197/\n\nChange-Id: Ia50edbe5aeb25e57756e9579da8270396bba718c\n" }, { "commit": "cacbd211250d355bcbb2bbf049cfb4bd8c94ee04", "tree": "d335d4ed400263a517a5ba15af058544d96e2755", "parents": [ "2238c69f46defb4a2328a0e5c3a4d5a3c23fea36" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Oct 21 12:30:17 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Oct 21 17:51:18 2018 +0000" }, "message": "fix: Rename test classes causing accidental skip\n\nThis patch set renames two classes that are neutron plugin\nrbac tests but don\u0027t end in the appropriate suffix of\n\"PluginRbacTest\" which is used by .zuul.yaml to correctly execute\nthe tests [0].\n\nThis means that, in effect, these tests aren\u0027t being run in any\njobs. This patch set resolves the issue.\n\nIn a follow up patch set a hacking rule will be added to enforce\ncorrect naming for plugin rbac tests.\n\n[0] https://github.com/openstack/patrole/blob/0c7f83ea1716462737a40cc32f27b95abf4557af/.zuul.yaml#L168\n\nChange-Id: Ieac5ebf70eefcebf1aebc26da95d58fcd68a202e\n" }, { "commit": "2238c69f46defb4a2328a0e5c3a4d5a3c23fea36", "tree": "cf00dca107b6b58a397938cc0f750d261d09c11a", "parents": [ "0c7f83ea1716462737a40cc32f27b95abf4557af" ], "author": { "name": "Cédric Ollivier", "email": "ollivier.cedric@gmail.com", "time": "Sun Oct 21 15:22:38 2018 +0200" }, "committer": { "name": "Cédric Ollivier", "email": "ollivier.cedric@gmail.com", "time": "Sun Oct 21 15:22:38 2018 +0200" }, "message": "Fix test_update_address_scope_shared\n\ntest_update_address_scope_shared currently fails as shared address\nscope can\u0027t be unshared [1].\n\nIt would have detected in gates if neutron-tempest-plugin was\ninstalled [2] (as it\u0027s in opnfv/functest-smoke:latest).\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/address_scope_db.py#L87\n[2] http://logs.openstack.org/47/599047/3/check/patrole-admin/11872d4/job-output.txt.gz\n\nChange-Id: I72f0cde1dab2d0a1949b55490375e8441394353d\nSigned-off-by: Cédric Ollivier \u003collivier.cedric@gmail.com\u003e\n" }, { "commit": "0c7f83ea1716462737a40cc32f27b95abf4557af", "tree": "b65bb1bde2ce84da6865da30163a6cac7d828db3", "parents": [ "28c9c3a2c7c3d07b7f12d6c8e4ad33853e27be3f", "1daa06a5b84e5fe34bac7309a729731c946604c1" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Oct 19 20:41:24 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Oct 19 20:41:24 2018 +0000" }, "message": "Merge \"Use tempest.common.identity.identity_utils for project management\"" }, { "commit": "bf524fbcf5295d521a1200db23d687a4976e9163", "tree": "8bc24696978687781978a55d1aa3bc94d4eeaebe", "parents": [ "28c9c3a2c7c3d07b7f12d6c8e4ad33853e27be3f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Oct 03 09:03:35 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Oct 19 00:27:41 2018 +0000" }, "message": "Deprecate use of v2 roles client in rbac_utils.py\n\nThis patch set deprecates use of the v2 roles client for\nrole overriding operations. This is because the Keystone v2 API\nis deprecated and slated for removal, so Patrole\u0027s use of the\nv2 Tempest roles client is also deprecated and will be\nremoved in a future release. Patrole will only support the v3 Tempest\nroles client for role overriding operations in the future.\n\nChange-Id: I9b201677cf8244b25f3cc8ea3b48a95b2b83b95e\n" }, { "commit": "28c9c3a2c7c3d07b7f12d6c8e4ad33853e27be3f", "tree": "513dd53564ee0e8b2ccb15f3f05adde4f3b4e5e9", "parents": [ "69250959929142c8da9bd2f9aaea47dbe66115fe" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Wed Oct 17 11:38:34 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Wed Oct 17 11:38:34 2018 -0500" }, "message": "Fix create_rbac_policy tenant_id and network_id usage\n\nThis patchset fixes mistake where we pass params, but use their origin.\n\nChange-Id: I4c73aaeba1907987306b210d2afef5b6a395e68b\n" }, { "commit": "1daa06a5b84e5fe34bac7309a729731c946604c1", "tree": "ff2b7aae1cd850df58358c0d06178e30e23232cb", "parents": [ "842845eaef1de6595e96ad253d0666555ce083f1" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Aug 31 13:56:08 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Oct 13 22:36:02 2018 +0000" }, "message": "Use tempest.common.identity.identity_utils for project management\n\nThis uses identity_utils from tempest.common.identity for\nproject creation/deletion in non-identity tests:\n\n A client that abstracts v2 and v3 identity operations.\n\n This can be used for creating and tearing down projects in tests.\n It should not be used for testing identity features.\n\nThis is a common pattern in Tempest and should be used in Patrole, too.\n\nChange-Id: Id87294bd19c7abd92d202b5ba6b49e4aac6c7e42\n" }, { "commit": "69250959929142c8da9bd2f9aaea47dbe66115fe", "tree": "575becbf652a0da1c144a353257ca2b62ec335cf", "parents": [ "7fa1f735fa66ae49589950201755c1fa5db3ae6d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Jul 29 13:08:54 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Oct 12 14:26:05 2018 +0000" }, "message": "Add volume create from image test\n\nThis patch set adds tests for the following policy:\n\n\"volume:create_from_image\" [0]\n\nNote that this is mutually exclusive with \"volume:create\" [1]\nso multi-policy is not needed for the new test:\ntest_create_volume_from_image\n\n[0] https://github.com/openstack/cinder/blob/fe69f679369057a7c381178f770bf68d0bc1cee0/cinder/policies/volumes.py#L52\n[1] https://github.com/openstack/cinder/blob/4bb00dbcf6af2f140694eb535696f0f6fe3ae80e/cinder/volume/api.py#L210\n\nChange-Id: I27bdefa57ed60e9fb1764a65afec117e86e71cee\n" }, { "commit": "7fa1f735fa66ae49589950201755c1fa5db3ae6d", "tree": "4b787f0ce23edd7d249caf122de61ba9aa03080e", "parents": [ "517183edd3e4032f396c653bc67d2a092c438da0", "8dd5f1990183b7bb9ca44e98c2e9e6e6b1bd82af" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Oct 12 12:22:12 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Oct 12 12:22:12 2018 +0000" }, "message": "Merge \"Remove invalid exception RbacConflictingPolicies\"" }, { "commit": "722455f9fe489511459c57d1331b4eaafb6baf19", "tree": "8ea22fdf2d18acfd3ea2ef8b3672eea5b8a48b43", "parents": [ "59f538fdbdf650154779028747285a5e35fa2d17", "dcd153a2a0db5c91468d106deb25c692779db770" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Oct 09 11:09:40 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Oct 09 11:09:40 2018 +0000" }, "message": "Merge \"Remove extra_attr kwarg from RbacMalformedResponse\"" }, { "commit": "8dd5f1990183b7bb9ca44e98c2e9e6e6b1bd82af", "tree": "7ea181dcf368a8ac378d902a1b7c5a6531543a91", "parents": [ "91e33c6ef17af701ed230802da6eee256bcc4884" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Oct 05 21:29:25 2018 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Oct 06 01:22:00 2018 +0000" }, "message": "Remove invalid exception RbacConflictingPolicies\n\nThis patch set drops RbacConflictingPolicies from Patrole because\nits intention is 1) flawed and 2) the way it is being used is\ninvalid.\n\nFirst, there is no documented case where conflicting policies\nexists in OpenStack, so the intention behind the exception class\nis flawed.\n\nSecond, the exception is only used in one test in\ntest_server_rbac. It catches a ServerFault (500) and re-raises\nthe exception is a pseudo-Forbidden exception. This is very bad\nbecause if Nova raises a 500 on a policy exception then this is\na Nova bug. There is no valid use case where a ServerFault from\nNova should ever be treated as a successful test scenario.\n\nChange-Id: I495b10ccf7b0df523b2551c49ea4db07e5bcaf79\n" }, { "commit": "59f538fdbdf650154779028747285a5e35fa2d17", "tree": "9bb4e0d069ab1eb382b4fdb06eed6c2dbf55671b", "parents": [ "91e33c6ef17af701ed230802da6eee256bcc4884" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Aug 22 23:34:40 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Oct 04 17:23:16 2018 +0100" }, "message": "Replace rule/expected_error_code with non-deprecated versions\n\nThis patch set replaces deprecated occurrences of rule with\nrules and expected_error_code with expected_error_codes in\nrbac_rule_validation.action decorator.\n\nAlong with removing the parameters from the decorator, all the\nAPI tests have been changed to use the non-deprecated parameters\ninstead. Unit tests have also been updated.\n\nChange-Id: I6485b6c57795b5fe75e2b339d5c9720da30be564\n" }, { "commit": "2a6d32969fa1f0f09dc2c3b372e318d34cb1c103", "tree": "f46faa1fdefe42aeaf56a838d45ab775bf069531", "parents": [ "40c450d0882ab55cd667bb24e6751898b5ab2aab" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Mon Aug 13 15:37:53 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "myakovliev@mirantis.com", "time": "Thu Oct 04 14:38:09 2018 +0000" }, "message": "Add tests to cover auto_allocated_topology\n\nThis patch set adds tests to cover the neutron auto allocated topology API [0].\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#id877\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I012d7c5b3c6ef1ef5735a1c60e2975094b083fec\nStory: 2002641\n" }, { "commit": "91e33c6ef17af701ed230802da6eee256bcc4884", "tree": "bc4d4a816381dd44ee20d6b93c27046672276d8b", "parents": [ "a90168ec8715f1dbcf17c99277f62777595ba721", "5f25db5cad23ba8fb1acee49942cd75527841663" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Oct 03 19:16:04 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Oct 03 19:16:04 2018 +0000" }, "message": "Merge \"Add tests to cover neutron-agents\"" }, { "commit": "a90168ec8715f1dbcf17c99277f62777595ba721", "tree": "29208f588519db36ac446ddae7062727d8215116", "parents": [ "40c450d0882ab55cd667bb24e6751898b5ab2aab", "d646a4cfa5b019c4e127c8264305ea80bf5e06a7" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Oct 02 23:01:31 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Oct 02 23:01:31 2018 +0000" }, "message": "Merge \"Add tests to cover policy_bandwidth_limit_rule\"" }, { "commit": "5f25db5cad23ba8fb1acee49942cd75527841663", "tree": "e74c9d1a7d3db70e5308e676c33cee7ec3a9346c", "parents": [ "a3c15da1cd0d74d17727056dd72103fc915ab86d" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Mon Sep 10 14:40:22 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Sun Sep 30 14:50:37 2018 -0500" }, "message": "Add tests to cover neutron-agents\n\nThis patch adds tests to cover next policies:\n\n\u0027get_l3-agents\u0027 [0]\n\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#list-l3-agents-hosting-a-router\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I79310ce3b072976cff46335e233c219625c5b686\nStory: 2002641\nTask: 22312\n" }, { "commit": "40c450d0882ab55cd667bb24e6751898b5ab2aab", "tree": "33b75965854b1fe2e80e944f1945ea29e6cb5057", "parents": [ "f014bf134b78d84bee6c361b7390c95d9489440d", "b485953e54581e9b73a86efd28a7d295f3b12db0" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Sep 28 21:59:21 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Sep 28 21:59:21 2018 +0000" }, "message": "Merge \"Include README for neutron + plugin tests\"" }, { "commit": "0fe2e39140ff038ce66f43a478fc792e8a271fe2", "tree": "2853dfe171c292b4699626503d0ab4f1e1d83ddb", "parents": [ "404199107e1cf7443b8eb6667c5d177fe549a135", "433bf50679fdf6606a7af53380491287b69e4203" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Sep 27 22:30:39 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Sep 27 22:30:39 2018 +0000" }, "message": "Merge \"Add tests to cover policy_minimum_bandwidth_rule\"" }, { "commit": "404199107e1cf7443b8eb6667c5d177fe549a135", "tree": "363a5bb2cf18d09ca2b11888395c639fbdaaa166", "parents": [ "8c04bd87800ff8c428b58f0d8b990689916eff9e", "ef7047df40b674c72635b9dac9d7e6e1f22e9a86" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Sep 27 22:23:32 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Sep 27 22:23:32 2018 +0000" }, "message": "Merge \"Use oslo_policy.policy.Rules.load to load rules\"" }, { "commit": "dcd153a2a0db5c91468d106deb25c692779db770", "tree": "4278ccfcd544d04b74ae0d5ad14133813e7cb26a", "parents": [ "787fbd72542c233a66309c1700fad9645d01a394" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Sep 23 21:15:54 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Sep 23 21:15:54 2018 -0400" }, "message": "Remove extra_attr kwarg from RbacMalformedResponse\n\nThis patch set removes extra_attr kwarg from RbacMalformedResponse\nexception because it is unclear how unauthorized policy enforcement\ncould result in an extra attribute being injected into a response\nbody. For such an edge case to even be allowed, there would have\nto be a documented example of this. Besides, no test case even\nmakes use of it, meaning that it is not something we should\neven support.\n\nChange-Id: I8f63720fe02d63360a7e40c836d55b56eb657156\nStory: 2003843\nTask: 26634\n" }, { "commit": "b485953e54581e9b73a86efd28a7d295f3b12db0", "tree": "097c6713f33781c620b50bc86770bbfe97c73034", "parents": [ "337a574ad88b9158a77d18548b6fe809e4c8f353" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 12 10:11:45 2018 -0600" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Sep 21 13:47:39 2018 +0000" }, "message": "Include README for neutron + plugin tests\n\nThis patch set adds a README under\npatrole_tempest_plugin/tests/api/network to explain that\nPatrole supports testing RBAC policies for Neutron as well as\n(some) associated extensions and plugins.\n\nChange-Id: I80e5fd027becbb9c21212fbfe2b59b9708a51bb2\n" }, { "commit": "787fbd72542c233a66309c1700fad9645d01a394", "tree": "66b6c11f41ed360d83a64412e79b6d3085aa3ea2", "parents": [ "abd981d56d1a73ee781297353984bb1ff6c2abed", "849acef2b2d1251aeb02f9300c9e1b10cdb842e0" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Sep 20 00:19:40 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Sep 20 00:19:40 2018 +0000" }, "message": "Merge \"Adds tests to cover address scopes\"" }, { "commit": "abd981d56d1a73ee781297353984bb1ff6c2abed", "tree": "fc4052522b455d3fa873a8d68d23b06f20a492ce", "parents": [ "96cb119fe968eafe77e52e6f4b1cc0740c31f5e4", "56bb7312713634ad7d99090b167b56c6d84b0852" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Sep 19 22:16:54 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Sep 19 22:16:54 2018 +0000" }, "message": "Merge \"Add tests to cover policy_dscp_marking_rule\"" }, { "commit": "433bf50679fdf6606a7af53380491287b69e4203", "tree": "2755a41981070e18d541119c1710364442391a6e", "parents": [ "56bb7312713634ad7d99090b167b56c6d84b0852" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Mon Aug 20 13:42:20 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Wed Sep 19 11:24:03 2018 -0500" }, "message": "Add tests to cover policy_minimum_bandwidth_rule\n\nThis patch set adds tests to cover the policy_minimum_bandwidth_rule API [0].\nTest creates, showes, updates and deletes policy_minimum_bandwidth_rule.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#qos-minimum-bandwidth-rules\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: Ice4d20d20320f70ea0a8332bb53f1ebcde2c7a84\nDepends-On: https://review.openstack.org/#/c/592762/\nStory: 2002641\nTask: 22321\n" }, { "commit": "96cb119fe968eafe77e52e6f4b1cc0740c31f5e4", "tree": "74a56e62e3ea6b6871ff06099c7b211f3962de7c", "parents": [ "f2bbb107f24ff7d9d9117ac6c30c7d28aed25791", "062fb157b80c037940fc4b227d78c258c3593f45" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Sep 19 14:58:12 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Sep 19 14:58:12 2018 +0000" }, "message": "Merge \"Add support for multiple policy files\"" }, { "commit": "d646a4cfa5b019c4e127c8264305ea80bf5e06a7", "tree": "e9d152d4a3335c80a72b324de488a33512b6ba04", "parents": [ "56bb7312713634ad7d99090b167b56c6d84b0852" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Mon Aug 20 14:34:55 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "myakovliev@mirantis.com", "time": "Mon Sep 17 20:46:07 2018 +0000" }, "message": "Add tests to cover policy_bandwidth_limit_rule\n\nThis patch set adds tests to cover the policy_bandwidth_limit_rule API [0].\nTest creates, showes, updates and deletes policy_bandwidth_limit_rule.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#qos-minimum-bandwidth-rules\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I0f4b61c9f906fe61537144ef0274c19895e7134e\nDepends-On: https://review.openstack.org/#/c/592762/\nStory: 2002641\nTask: 22319\n" }, { "commit": "8c04bd87800ff8c428b58f0d8b990689916eff9e", "tree": "3eee77c1e29d35190b8229976864915ba874a523", "parents": [ "787fbd72542c233a66309c1700fad9645d01a394" ], "author": { "name": "Chi Lo", "email": "cl566n@att.com", "time": "Fri Jun 01 16:21:50 2018 -0500" }, "committer": { "name": "Chi Lo", "email": "cl566n@att.com", "time": "Sun Sep 16 06:31:39 2018 -0500" }, "message": "Add granularity for volume_extension:volume_type_encryption\n\nUse granular rules:\nvolume_extension:volume_type_encryption:create\nvolume_extension:volume_type_encryption:delete\nvolume_extension:volume_type_encryption:update\nvolume_extension:volume_type_encryption:get\n\nfor the corresponding create, delete, update, and\nget volume_type_encryption test cases.\n\nDepends-On: Iba58e785df934d1c4175c0877d266193ac0167b7\n\nChange-Id: Ie5159166505d9bee3e99ca0d51949f6391c569b9\n" }, { "commit": "ef7047df40b674c72635b9dac9d7e6e1f22e9a86", "tree": "0453f41821f0e6260c5b767c964a1950cf829fe5", "parents": [ "062fb157b80c037940fc4b227d78c258c3593f45" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Tue Sep 11 14:48:55 2018 -0500" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Wed Sep 12 18:26:21 2018 -0500" }, "message": "Use oslo_policy.policy.Rules.load to load rules\n\nRe-using Rules.load function makes it possible to support parsing\ncustom YAML policy files, the new policy file extension since Ocata.\n\nChange-Id: I9c7645a0f9b04609921a5ea607b203e8215fc32b\n" }, { "commit": "e9a135573735928c56c19acc92acb2923dec7686", "tree": "0c8a811b9e5328f54b9489420509bf88b44939a9", "parents": [ "337a574ad88b9158a77d18548b6fe809e4c8f353" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 12 10:16:38 2018 -0600" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 12 10:20:48 2018 -0600" }, "message": "Include README in patrole_tempest_plugin/tests/api via symlink\n\nThis patch set adds a symlink from patrole_tempest_plugin/tests/api/\nREADME.rst to the RBAC field guide under the docs/ folder. This is\nthe same thing Tempest does with its README file under its tempest/api\npath: [0]\n\n[0] https://github.com/openstack/tempest/tree/master/tempest/api\n\nChange-Id: I0fb776b52828ceaa834885a8d097eb53efce0ba0\n" }, { "commit": "337a574ad88b9158a77d18548b6fe809e4c8f353", "tree": "7637619706ec753d1a5241f00815385626a3815d", "parents": [ "219f6d2b1edd24d9d577c21b6610ea295c2e09da", "24961a80e58fae2a4352254140015ff76dabe8fb" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Sep 11 22:47:13 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Sep 11 22:47:13 2018 +0000" }, "message": "Merge \"Add test for create_subnetpool:is_default\"" }, { "commit": "219f6d2b1edd24d9d577c21b6610ea295c2e09da", "tree": "1385277011e96e724307c2a6e3e8f9f20bad942e", "parents": [ "f82dee3e42f17bc167cb26d75ce97fb6048d9978", "e3b252740221d075bc9fdc514eaa3d89f4400551" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Sep 11 22:14:05 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Sep 11 22:14:05 2018 +0000" }, "message": "Merge \"Adds tests to cover QOS policy\"" }, { "commit": "062fb157b80c037940fc4b227d78c258c3593f45", "tree": "77799307a5654192911b2b47fd2379bf313963d1", "parents": [ "a3c15da1cd0d74d17727056dd72103fc915ab86d" ], "author": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Thu Sep 06 20:51:57 2018 -0500" }, "committer": { "name": "Sergey Vilgelm", "email": "sergey@vilgelm.info", "time": "Tue Sep 11 12:22:55 2018 -0500" }, "message": "Add support for multiple policy files\n\nMost of the neutron plugins provide an updated version of policy.json\nfile with full list of rules, but at the same time there are a lot of\nother plugins which provide their own policy files and store them in\nthe policy.d/ folder: neutron-fwaas, networking-bgpvpn, vmware-nsx,\nect...\nTo implement the tests for such plugins the Patrole should be able to\nload and merge multiple policy files for any of the services.\n\nModify the discover_policy_files function to discover all policy files\nfor each of the services. Using glob.glob() function makes it possible\nto use patterns like \u0027*.json\u0027 to discover the policy files.\nModify the _get_policy_data function to load a data from all discovered\npolicy files for a service.\n\nUpdate the unit test according to the changes.\n\nChange-Id: Ib24f3d6d7a5ffdeaecce579af9795fd897dce872\n" }, { "commit": "194752f1b5304e90e0e2911324f93cbe0169a1f3", "tree": "93799978b43a147d6919661d9ff22716b1af4426", "parents": [ "a3c15da1cd0d74d17727056dd72103fc915ab86d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Sep 10 11:43:38 2018 -0600" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Sep 10 13:47:30 2018 -0600" }, "message": "Remove deprecated patrole.enable_rbac configuration option\n\nThis patch set removes deprecated [patrole].enable_rbac\nconfiguration option. It is better to use an appropriate\ntest regex to skip Patrole tests.\n\nChange-Id: I639f3215f7aff8a85bc97dc55c1d97be3123e003\n" }, { "commit": "a3d7311588f4cfce5d4deaffd60e0d90cdc5e8e3", "tree": "fb33ad330fa6739896de2e0586c447e9b5d43785", "parents": [ "11376ab7ff60d9a4a4e8f63d905e1ee20c4ba042" ], "author": { "name": "Vishakha Agarwal", "email": "agarwalvishakha18@gmail.com", "time": "Mon Sep 03 16:12:55 2018 +0530" }, "committer": { "name": "Vishakha Agarwal", "email": "agarwalvishakha18@gmail.com", "time": "Mon Sep 03 16:14:38 2018 +0530" }, "message": "Remove unused config.CONF\n\nThis is to remove unused config.CONF\nto keep code clean.\n\nChange-Id: I011151aaadf18c7991861a3535af52b1581fdcbd\n" }, { "commit": "24961a80e58fae2a4352254140015ff76dabe8fb", "tree": "159eb3bc016a3b906f9ed52bc40bd2808177ee8e", "parents": [ "842845eaef1de6595e96ad253d0666555ce083f1" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Tue Jul 17 16:02:10 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "myakovliev@mirantis.com", "time": "Fri Aug 31 03:47:59 2018 +0000" }, "message": "Add test for create_subnetpool:is_default\n\nhttps://storyboard.openstack.org/#!/story/2002641\n\nStory: 2002641\nTask: 22301\nChange-Id: I49311242a54dd47c70774b19aafa083f7cf9fc5c\nDepends-On: https://review.openstack.org/#/c/583707\n" }, { "commit": "11376ab7ff60d9a4a4e8f63d905e1ee20c4ba042", "tree": "ff02f3c804f56b5155a743238c44876968fd6430", "parents": [ "842845eaef1de6595e96ad253d0666555ce083f1" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Mon Aug 06 15:34:22 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Aug 31 02:35:46 2018 +0000" }, "message": "Limit exception handling to calls within override_role\n\nMotivation: prevents false positives caused by test\nexceptions matching the expected exception before or\nafter the ``override_role`` context is called.\n\nThis patchset changes expected_error_codes behavior [0] by checking\nerrors explicitly outside the override_role context. This is done\nby introducing a new function to rbac_rule_validation that is\nused for validating that the expected exception isn\u0027t raised too\nearly (before ``override_role`` call) or too late (after\n``override_call``) or at all (which is a bad test).\n\nThis means that exceptions raised prior to override_role\ncall result in failure. The same goes for exceptions raised\nafter override_role -- except for those that are an instance\nof BasePatroleException (which is valid for things like\nRbacMalformedResponse getting raised intentionally).\n\nThe new exception that is introduced is called\nRbacOverrideRoleException.\n\nUnit tests are added for all validation scenarios described\nabove.\n\n[0] https://storyboard.openstack.org/#!/story/2003297\nStory: 2003297\nTask: 24246\n\nCo-Authored-By: Felipe Monteiro \u003cfelipe.monteiro@att.com\u003e\nChange-Id: Iae9a58640463093f6dda20d40261b20051be2820\n" }, { "commit": "e3b252740221d075bc9fdc514eaa3d89f4400551", "tree": "6eb2fd3407f102ae3940670685f8df4341cbbfea", "parents": [ "bfcf1cc50e05c765f852044c679984c67589d736" ], "author": { "name": "jessegler", "email": "jess.egler@gmail.com", "time": "Mon Aug 20 18:52:55 2018 -0500" }, "committer": { "name": "jessegler", "email": "jess.egler@gmail.com", "time": "Wed Aug 29 17:54:13 2018 -0500" }, "message": "Adds tests to cover QOS policy\n\nThis patch set adds tests to cover the QOS policy API [0].\nTests create_policy, get_policy, update_policy, delete_policy.\nPart of the \"Increase Neutron RBAC Coverage\" initiative [1].\n\n[0] https://developer.openstack.org/api-ref/network/v2/#qos-policies-qos\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: Ie9d3365c6a39e16ca2e920d180e4f8fbb060daa3\nStory: 2002641\nTask: 22318\n" }, { "commit": "849acef2b2d1251aeb02f9300c9e1b10cdb842e0", "tree": "1038e59952e0678418108882c7fc074ff4c8b545", "parents": [ "f4cb74ce470b247f3f0e600200f9d893defbc738" ], "author": { "name": "jessegler", "email": "jess.egler@gmail.com", "time": "Fri Aug 24 17:23:11 2018 -0500" }, "committer": { "name": "jessegler", "email": "jess.egler@gmail.com", "time": "Wed Aug 29 16:49:37 2018 -0500" }, "message": "Adds tests to cover address scopes\n\nThis patch set adds tests to cover the address scopes API [0].\nTests create_address_scope, create_address_scope:shared, get_address_scope,\nupdate_address_scope, update_address_scope:shared, delete_address_scope.\nPart of the \"Increase Neutron RBAC Coverage\" initiative [1].\n\n[0] https://developer.openstack.org/api-ref/network/v2/#address-scopes\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I3f315f6cf6bd880a5add97b5928b853b1ea2e811\nStory: 2002641\nTask: 22302\n" }, { "commit": "56bb7312713634ad7d99090b167b56c6d84b0852", "tree": "99b7d8396ab48975faa412a2ef31bff14757e76f", "parents": [ "9ee07cf523583ffa0b6988de54c8dfe9b7e6e645" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Thu Aug 16 18:34:10 2018 -0500" }, "committer": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Tue Aug 28 15:15:49 2018 -0500" }, "message": "Add tests to cover policy_dscp_marking_rule\n\nThis patch set adds tests to cover the policy_dscp_marking_rule API [0].\nTest creates, showes, updates and deletes policy_dscp_marking_rule.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#qos-dscp-marking-rules\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I34e6276784828c518513c5fe9caf1eee1669658a\nStory: 2002641\nTask: 22320\n" }, { "commit": "842845eaef1de6595e96ad253d0666555ce083f1", "tree": "7fd1bc429b88e420370ae30ea4fb1a7b1428a065", "parents": [ "f4cb74ce470b247f3f0e600200f9d893defbc738", "63d8602d359bf5f9492bf1f58c9edba89f01dd7f" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Aug 24 19:49:39 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Aug 24 19:49:39 2018 +0000" }, "message": "Merge \"Add tests to cover flavor_service_profile\"" }, { "commit": "2b93778e8cb0fe11f4b009a5b70df8efb92854c0", "tree": "be8285cbc812ea8355b0b6ffbf51897cf25756c8", "parents": [ "33d0583e054002d684053c4390ae13a0563c7e95", "98437d41a1f34db48422310a3d73de8149147c86" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Aug 22 05:32:18 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Aug 22 05:32:18 2018 +0000" }, "message": "Merge \"Remove override of \u0027expected_error_codes\u0027 with defaults\"" }, { "commit": "64f3943dadf34214192a7550e8a0dc9a34eb5173", "tree": "0129e1eb91cac59a808e6b06ce5e0e56c7ee3947", "parents": [ "031b182470a33065e868b916e6a11f2dec8244ae", "0f45285601808eab599e5d31887e9503e17a8392" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Wed Aug 22 01:06:53 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Aug 22 01:06:53 2018 +0000" }, "message": "Merge \"Remove the usage of deprecated arg \u0027expected_error_code\u0027\"" }, { "commit": "98437d41a1f34db48422310a3d73de8149147c86", "tree": "10ee4a74e38101d836928cd3192018223ca4fd29", "parents": [ "b1e9d7a69337ccaa2395437e120e80bac4b5d662" ], "author": { "name": "ghanshyam", "email": "gmann@ghanshyammann.com", "time": "Fri Aug 17 08:51:43 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 21 18:50:02 2018 +0000" }, "message": "Remove override of \u0027expected_error_codes\u0027 with defaults\n\n\u0027expected_error_codes\u0027 are filled with defaults error code[1]\nin base class which is nothing but to fill required number\nof error codes with 403.\n\nFew tests override the \u0027expected_error_codes\u0027 with 403 itself which\nis confusing and inconsistent with other tests.\n\nThis commit removes those default overridden values.\n\n[1] https://github.com/openstack/patrole/blob/a6371ed510b318183e1c2cbafcc97bd85f6625f8/patrole_tempest_plugin/rbac_rule_validation.py#L286\n\nChange-Id: If607755fc09c392566fffad8f46e5f37cd33c2d2\n" }, { "commit": "0f45285601808eab599e5d31887e9503e17a8392", "tree": "5b7f96c685c9cc6f2eb921515bf7ca97e913f3b8", "parents": [ "b1e9d7a69337ccaa2395437e120e80bac4b5d662" ], "author": { "name": "ghanshyam", "email": "gmann@ghanshyammann.com", "time": "Fri Aug 17 09:30:07 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 21 18:49:53 2018 +0000" }, "message": "Remove the usage of deprecated arg \u0027expected_error_code\u0027\n\n\u0027expected_error_code\u0027 arg to rbac_rule_validation.action is\ndeprecated in favor of \u0027expected_error_codes\u0027.\n\nMany test use the old deprecated arg and that\u0027s why the warning. We\nshould cleanup the usage in patrole to avoid the confusion and make\nall test to latest interface.\n\nThis commit migrate those usage to new arg and leave the deprecated\narg as it is which can be removed completely after deprecation phase.\n\nChange-Id: Ie284ae74ce6480a59406aecfe341d579142bd625\n" }, { "commit": "031b182470a33065e868b916e6a11f2dec8244ae", "tree": "4954b3f370976abc43fd36fb0f74e3faa6aa70e6", "parents": [ "b1e9d7a69337ccaa2395437e120e80bac4b5d662" ], "author": { "name": "Mykola Yakovliev", "email": "VegasQ@gmail.com", "time": "Sat Jul 28 13:14:24 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 21 18:49:12 2018 +0000" }, "message": "Add tests to cover RBAC policies\n\nThis patch set adds tests to cver the neutron RBAC policies API [0].\nTest gets, creates, updates, and deletes RBAC policies.\nPart of \"Increase Neutron RBAC Coverage\" initiative [1]\n\n[0] https://developer.openstack.org/api-ref/network/v2/index.html#rbac-policies\n[1] https://storyboard.openstack.org/#!/story/2002641\n\nChange-Id: I37e07c1b37a4630024d45dc9e5ade25ef31c703a\nStory: 2002641\nTask: 22322\n" }, { "commit": "6bffc5c5c6d1a52793e1e2091f4e87b2edac8f31", "tree": "deb60b61fb01e112115f244effa1cd72fbe81f9a", "parents": [ "d063b409bb7a3d056ac9d55bb6200b1076e71422" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Aug 19 22:54:33 2018 +0100" }, "committer": { "name": "Ghanshyam Mann", "email": "gmann@ghanshyammann.com", "time": "Tue Aug 21 05:53:38 2018 +0000" }, "message": "Skip the deprecated API extensions policy tests\n\nA new policy feature flag called\n``[policy_feature_flag].removed_nova_policies_stein``\nhas been added to Patrole\u0027s config to handle Nova API\nextension policies removed in Stein [0].\n\nThe policy feature flag is applied to tests that validate\nresponse bodies for expected attributes previously returned\nfor the following policies that passed authorization:\n\n - os_compute_api:os-config-drive\n - os_compute_api:os-extended-availability-zone\n - os_compute_api:os-extended-status\n - os_compute_api:os-extended-volumes\n - os_compute_api:os-keypairs\n - os_compute_api:os-server-usage\n - os_compute_api:os-flavor-rxtx\n - os_compute_api:os-flavor-access (only from /flavors APIs)\n - os_compute_api:image-size\n\nNote that not all removed policies are included above because\ntest coverage is missing for them (like\nos_compute_api:os-security-groups).\n\nAlso fixes test flows associated with image_size tests:\n\n* endpoints are list images with details and show image (not\n list image)\n* both tests should check for OS-EXT-IMG-SIZE:size attribute\n\n[0] https://review.openstack.org/#/c/586872/8\n\nStory: 2003501\n\nChange-Id: Ia6f8d255a540f7063beedd80a3ca1833f3987490\n" }, { "commit": "d063b409bb7a3d056ac9d55bb6200b1076e71422", "tree": "0aa9261b3cc274b7bb8a06f36a3e23d41944f516", "parents": [ "9ee07cf523583ffa0b6988de54c8dfe9b7e6e645", "04b26288b36564fb6498e4457b69b879aec23b99" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Aug 17 09:29:36 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Aug 17 09:29:36 2018 +0000" }, "message": "Merge \"Add tests to cover trunks\"" } ], "next": "63d8602d359bf5f9492bf1f58c9edba89f01dd7f" }