)]}' { "log": [ { "commit": "a1db761f098c8e17c698f3fa37d7692e7b3d0069", "tree": "e92a21258b3c004b63951b471b90039298f0d7cd", "parents": [ "5ca77494c880232c940a38127e4fdbca10435694", "4ef7e5309c61583fb2a6e48777188aff06620227" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Mar 27 01:25:48 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Mar 27 01:25:48 2018 +0000" }, "message": "Merge \"Remove already-deprecated strict_policy_check option\"" }, { "commit": "5ca77494c880232c940a38127e4fdbca10435694", "tree": "81f7fe692f0201fb61d823016a7df42b7d0e7603", "parents": [ "f1c6757160d89c7115fda36383f2c3846544d04e", "1c8620af7a9cf5b2bf7336592b42bb86d3e44c21" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Mar 26 23:04:26 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Mar 26 23:04:26 2018 +0000" }, "message": "Merge \"Remove deprecated switch_role method\"" }, { "commit": "4ef7e5309c61583fb2a6e48777188aff06620227", "tree": "0a3c947eabf100b82d2b797c4187891efa287ef0", "parents": [ "f1c6757160d89c7115fda36383f2c3846544d04e" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Mar 11 07:17:11 2018 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Mar 26 19:44:15 2018 +0100" }, "message": "Remove already-deprecated strict_policy_check option\n\nThe option ``[patrole].strict_policy_check`` was deprecated\nduring the last release cycle (Queens). This was because the\noption could be set to False in order to skip tests which\nmight result in false positives.\n\nThis PS, then, removes strict_policy_check references in the code,\nupdates documentation, and adds a releasenote.\n\nChange-Id: I7f7eda39c0472bd3d70892c801fc4d14db0c0426\n" }, { "commit": "f1c6757160d89c7115fda36383f2c3846544d04e", "tree": "73194e794049ff461b7bf0a89da11b687c4bc811", "parents": [ "ce61cb0222d318c7f0a60b86cbb401e4340aa0b5", "6da23e69300207a8ede4bf476f971557e597216f" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Mar 26 04:36:47 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Mar 26 04:36:47 2018 +0000" }, "message": "Merge \"Fix tests for snapshots extended_snapshot_attributes policy\"" }, { "commit": "ce61cb0222d318c7f0a60b86cbb401e4340aa0b5", "tree": "df3ecec1c6fd6dfb847cbfbe11cad429b8ff4714", "parents": [ "8669a51af5efb65e53c91187febf2d3bd069fcec", "f918e08ce1380cd3d0dab87850cd6e1d4c9f1e52" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Mar 26 04:11:43 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Mar 26 04:11:43 2018 +0000" }, "message": "Merge \"Add RBAC test for listing snapshots with details\"" }, { "commit": "1c8620af7a9cf5b2bf7336592b42bb86d3e44c21", "tree": "a89370ea6027bf70a2288f5e81829b12a071954d", "parents": [ "2e6c54854eff80268bbd9e21031b201116106c4a" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Feb 25 18:52:22 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Mar 25 04:27:02 2018 +0000" }, "message": "Remove deprecated switch_role method\n\nThis is to remove the deprecated switch_role method from\nrbac_utils module as it has been replaced by override_role\nwhich is a superior way to manipulate the underlying role used\nfor querying API endpoints in Tempest.\n\nChange-Id: Ibaffcd8cd0b62ad792b0ef5f9be4d33ec31e8c7a\n" }, { "commit": "6da23e69300207a8ede4bf476f971557e597216f", "tree": "29092831e304e7d6c2da32507dc5b96fe5a8eff3", "parents": [ "f918e08ce1380cd3d0dab87850cd6e1d4c9f1e52" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Mar 18 05:22:01 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Mar 20 03:22:01 2018 +0000" }, "message": "Fix tests for snapshots extended_snapshot_attributes policy\n\nThis fixes the Patrole test for\n\"volume_extension:extended_snapshot_attributes\" which is\nincorrectly being executed by a create test which is wrong according\nto [0]. Instead, the test should be executed for\nGET /snapshots/{snapshot_id} and GET /snapshots/details. Further, the\ntest should use soft or non-fatal authorization, which was recently\nfixed in Cinder [1].\n\nFinally, the tests should live in test_volumes_snapshots_rbac\nfor the same reason the policy is listed under snapshots family\nof policies in cinder [0].\n\nThe expected attributes for these tests can be found here: [2].\n\n[0] https://github.com/openstack/cinder/blob/831665f59a0d87f2dbf7fa4f7496305977a98b0f/cinder/policies/snapshots.py#L48\n[1] https://review.openstack.org/#/c/553657/1\n[2] https://github.com/openstack/cinder/blob/831665f59a0d87f2dbf7fa4f7496305977a98b0f/cinder/api/contrib/extended_snapshot_attributes.py#L25\n\nChange-Id: I7770148584e10a08b3e133b1793a1533f1728fc1\n" }, { "commit": "f918e08ce1380cd3d0dab87850cd6e1d4c9f1e52", "tree": "d7bd99ce5a578fced03353d37633f574e784de92", "parents": [ "5ca7ada87b319f4371dba58f89671030d1729b3b" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Mar 18 05:11:12 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Mar 18 15:24:33 2018 +0000" }, "message": "Add RBAC test for listing snapshots with details\n\nThis is to add a test for listing snapshots with details\nwhich enforces policy volume:get_all_snapshots [0].\n\n[0] https://github.com/openstack/cinder/blob/831665f59a0d87f2dbf7fa4f7496305977a98b0f/cinder/policies/snapshots.py#L42\n\nChange-Id: I081a39bb890e0937da1cad8fb612634b9c3e42a2\n" }, { "commit": "3f67a3921d5bb2fbd8a85e28ea18158683080a86", "tree": "33ebdb472f537c6d178daf0f00cf04d2e1fc9b37", "parents": [ "748abc9204e11cd0a806e03175672bf4a2eba13c" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Mar 13 02:43:45 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Mar 13 19:51:19 2018 +0000" }, "message": "[Fix Gate] Fix network segments policy test raising 503\n\nThis is to fix the gate by resolving an issue with a Neutron\nsegments policy test class that hardcodes the network segment\nto use gre network type, which may not be supported by the\nunderlying network, resulting in a 503 exception being raised.\nExample stacktrace: [0] and root cause: [1].\n\nAlso renames the class and file to convey that actual policy\nbeing tested.\n\n[0] http://logs.openstack.org/20/547820/7/check/patrole-admin/5f4e495/job-output.txt.gz#_2018-03-12_20_50_15_600175\n[1] http://logs.openstack.org/20/547820/7/check/patrole-admin/5f4e495/controller/logs/screen-neutron-api.txt.gz#_Mar_12_20_50_15_698713\n\nChange-Id: I6e3daef766f0ed5fabcc125f39471d089c9d7218\n" }, { "commit": "318a0bf6028043249fb5bb1c525c243197cd7372", "tree": "fef7940c0ac20b29fa6fddaedd656b2515709de1", "parents": [ "2fb16dac7ad808f5cf220b5bb05513b6b4c04fe3" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Feb 27 06:57:10 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Mar 10 19:31:10 2018 +0000" }, "message": "Remove admin_only kwarg from rbac_rule_validation decorator\n\nThe ``admin_only`` kwarg has been removed from ``rbac_rule_validation``\ndecorator because it is no longer used by any tests. Besides that,\nit should not be used because Patrole is dedicated to RBAC testing and\nan admin-only check is not RBAC because it does not use ``oslo.policy``\nlibrary.\n\nChange-Id: Iee4881a8756cf2f2a0a4520dd450776a4f1e873c\n" }, { "commit": "2fb16dac7ad808f5cf220b5bb05513b6b4c04fe3", "tree": "d0e7a86802f52ee380ce1de6ee2096aa20e956bd", "parents": [ "1a971293c3a60afc5b47b4cba8c04a323ec97298", "6e86fc1e0c7843fc2372b8e6da9c77bd53b25662" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Sat Mar 10 18:27:38 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Sat Mar 10 18:27:38 2018 +0000" }, "message": "Merge \"Increase coverage for volume metadata tests\"" }, { "commit": "6e86fc1e0c7843fc2372b8e6da9c77bd53b25662", "tree": "84d03675d7f03ccfdd925e6992973f886e21ff77", "parents": [ "938471ba9e0d1a0de617aa0068b6242eb677ebcf" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Feb 23 01:20:00 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Mar 10 15:30:41 2018 +0000" }, "message": "Increase coverage for volume metadata tests\n\nImplement complete coverage for the following policies [0]:\n * \"volume:get_volume_metadata\"\n * \"volume_extension:volume_image_metadata\"\n\n[0] https://github.com/openstack/cinder/blob/0ac4af182fdd55d4a97ce283070f7b8e6480540f/cinder/policies/volume_metadata.py\n\nChange-Id: Id5d9b53392859dd4e852c6aea670334c6acc6670\n" }, { "commit": "1a971293c3a60afc5b47b4cba8c04a323ec97298", "tree": "8ba3aad9a6f646b7c33f5ae5816ca3303f735fc2", "parents": [ "f89066a5043a3aca9ac1a4a853b219775bbcacd1", "bb1ebaa69b2214b9298cc8bbb9942e0ab104796b" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Sat Mar 10 02:22:37 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Sat Mar 10 02:22:37 2018 +0000" }, "message": "Merge \"Fix test_limits_rbac not checking for expected response\"" }, { "commit": "bb1ebaa69b2214b9298cc8bbb9942e0ab104796b", "tree": "7d2fd92d72e3825fca238e3f3fe8e9b829527bad", "parents": [ "938471ba9e0d1a0de617aa0068b6242eb677ebcf" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Feb 27 09:15:14 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Feb 27 09:15:14 2018 -0500" }, "message": "Fix test_limits_rbac not checking for expected response\n\nThis is to fix test_show_limits test under test_limits_rbac\nin volume module which is currently expecting a fatal exception\nto be raised by the Cinder server following failed authorization.\nHowever, this assumption is false because this endpoint uses\nnon-fatal authorization [0] to inject additional attributes into\nthe response body following successfuly authorization.\n\nThus, it is necessary Patrole side to verify that the expected\nattributes are present in the response body, as expecting a 403\nis a false assumption.\n\n[0] https://github.com/openstack/cinder/blob/67177026ab510b09644fd4b8b301594aa5482cef/cinder/api/contrib/used_limits.py#L30\n\nChange-Id: I3aae5d8c6c947cf5119f1cdc081dae8179421564\n" }, { "commit": "b437ae159030c90634cd7136af57258025f1a218", "tree": "a7ccd958a29971fd59ff00e49e003e68b6f0e048", "parents": [ "938471ba9e0d1a0de617aa0068b6242eb677ebcf" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Feb 25 14:12:27 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Feb 25 14:12:27 2018 +0000" }, "message": "Add RBAC test for show_encryption_specs_item\n\nThis adds an RBAC test for volume v3 client endpoint\nshow_encryption_specs_item. This was recently added to Tempest\nin [0]. The policy it enforces is\n\"volume_extension:volume_type_encryption\" [1] and it is enforced\nin code here [2].\n\n[0] https://review.openstack.org/#/c/521241/\n[1] https://github.com/openstack/cinder/blob/e75d209177b8b65f28429e64e79b4101dbcf58b3/cinder/policies/volume_type.py#L65\n[2] https://github.com/openstack/cinder/blob/e75d209177b8b65f28429e64e79b4101dbcf58b3/cinder/api/contrib/volume_type_encryption.py#L147\n\nChange-Id: I8518bee5720956eb6c3c280e311458991ff30325\n" }, { "commit": "938471ba9e0d1a0de617aa0068b6242eb677ebcf", "tree": "b05dcdc9b6b63fd54ffe1bc8624ae1cb9833bc10", "parents": [ "6a8c08c3c8ebce3e4400ae21bdb1ee067ff0ef5c" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Feb 20 06:23:17 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Feb 20 04:46:51 2018 +0000" }, "message": "Remove all v2.0 identity API tests\n\nAll of the identity v2.0 API tests have been remvoed from Patrole because\nthe majority of the v2.0 API has been removed from the identity project.\n\nChange-Id: I8501a8e276ce77c5c1bf631177add60d5820ed85\n" }, { "commit": "6a8c08c3c8ebce3e4400ae21bdb1ee067ff0ef5c", "tree": "a2c930517f4bf04c6ba80bce6fc3634086540e0e", "parents": [ "ac2ee131c5480aff4f5bcaa7a6cc4379c1b33d20" ], "author": { "name": "hifzasakhi", "email": "hifza.sakhi@att.com", "time": "Fri Feb 02 22:43:46 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Feb 10 23:53:37 2018 +0000" }, "message": "RBAC tests for group type specs\n\nChange-Id: I033206f288b17b89c345a04bad3b41346916f4e8\nCloses-Bug:#1745871\n" }, { "commit": "ac2ee131c5480aff4f5bcaa7a6cc4379c1b33d20", "tree": "e8350f24e75e3758f9dd0b4ec98f08cfda9145d1", "parents": [ "ea7b25bbf9faada1e41f828ef7e26bcef69fa88a" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Feb 10 23:49:23 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Feb 10 23:49:23 2018 +0000" }, "message": "[Gate fix] Fix attach volume create server test timeout\n\nThis PS unblocks the gate by fixing the timeout error that is\ncurrently being thrown [0] for the test test_create_server_attach_volume\n\n[0] http://logs.openstack.org/44/540544/13/check/patrole-admin/a16eb5a/job-output.txt.gz#_2018-02-07_21_05_40_650426\n\nChange-Id: I100f1e1ce2364c338baeaab00fec2dde327bbe06\n" }, { "commit": "ea7b25bbf9faada1e41f828ef7e26bcef69fa88a", "tree": "41aab34529263f6bb5fa698331d208a5b2e69641", "parents": [ "00b4a100d9dafcef12e46a372ff754058c330455", "2189207ebb5215efdb43a85e84f46b3e1bcf52ba" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Feb 05 22:01:18 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Feb 05 22:01:18 2018 +0000" }, "message": "Merge \"RBAC tests for reset group snapshot status policy\"" }, { "commit": "13051245302b7df86f52c7d22c3821c5d596aef4", "tree": "6a6dac1ec76a8d047ee435e1c2cfc32814b446ba", "parents": [ "88061b72d198b1d245d3ff53df71e3702a48917f", "81a22b102db7b509c35289311abab43de232064c" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Feb 05 16:23:07 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Feb 05 16:23:07 2018 +0000" }, "message": "Merge \"Add test coverage for volume types\"" }, { "commit": "2189207ebb5215efdb43a85e84f46b3e1bcf52ba", "tree": "9bad8edab52877f156becea85793bd343ae7d182", "parents": [ "88061b72d198b1d245d3ff53df71e3702a48917f" ], "author": { "name": "hifzasakhi", "email": "hifza.sakhi@att.com", "time": "Thu Jan 25 22:05:05 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Feb 05 16:13:25 2018 +0000" }, "message": "RBAC tests for reset group snapshot status policy\n\nAdd RBAC tests for missing reset group snapshot\nstatus [0] the API for which was recently introduced\nto Tempest by [1] to the Patrole test suite in [2].\n\n[0] https://github.com/openstack/cinder/blob/master/cinder/policies/group_snapshot_actions.py\n[1] https://review.openstack.org/#/c/495735/\n[2] https://github.com/openstack/patrole/blob/master/patrole_tempest_plugin/tests/api/volume/test_group_snapshots_rbac.py\n\nChange-Id: I0342b39d15f2616e6090248cf028b1add856bec2\nCloses-Bug:#1712723\n" }, { "commit": "88061b72d198b1d245d3ff53df71e3702a48917f", "tree": "2d26e12b3ec8ca0ff3087965d65b0dd4c822525a", "parents": [ "869fe2c804c12da5f224856e9b0e08efa122f358" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Feb 01 21:56:12 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Feb 01 21:59:37 2018 +0000" }, "message": "Add waiter to test_manage_snapshot_rbac to fix data race\n\nThis PS adds a waiter after attempting to manage a snapshot\nin test_manage_snapshot_rbac to avoid data race conditions\ncausing the test to fail during resource_cleanup [0].\n\nThis also adds a clean up to the test which is currently missing.\n\n[0] http://logs.openstack.org/77/537977/1/check/patrole-admin/c4e6884/job-output.txt.gz#_2018-02-01_02_47_26_276336\n\nChange-Id: Ib62a6d7ebbc5af43278c97fedce3a863ecfd3575\n" }, { "commit": "1882e9bffc09fe20dcc186354883c707dc995251", "tree": "aa7ae4f0d31cedc609c904376a67590a97faf7c1", "parents": [ "ba816be61343a4533e2fcd5c0ea3f8bc67511906" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jan 19 11:44:00 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Jan 28 19:49:44 2018 +0000" }, "message": "override_role cleanup: Remove superfluous call in rbac_rule_validation\n\nThis PS cleans up rbac_rule_validation (addressing a TODO) by removing\n_override_role call in rbac_utils which is no longer necessary as all\ntests have migrated over to override_role.\n\nThe call in rbac_rule_validation to _override_role was only needed\nto do a role switch to admin role after test execution to compensate\nfor the limitation in switch_role which did not automatically switch\nrole via a contextmanager (which is what override_role) does.\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I5628886349b22b10b53a3c325fd38bdbaaafafae\n" }, { "commit": "7676a21077b5d8078f5beb32f7186970f02fc1a1", "tree": "5e4c1661cd50de0e1b98174cfbbe1bf286ff228b", "parents": [ "b7c0b9a2159fbca800d21431f991de61d68b649a" ], "author": { "name": "Hifza Sakhi", "email": "hifza.sakhi@att.com", "time": "Wed Jan 24 16:44:17 2018 +0000" }, "committer": { "name": "Hifza Sakhi", "email": "hifza.sakhi@att.com", "time": "Wed Jan 24 16:44:17 2018 +0000" }, "message": "Migrate to override_role for volume module (part 3)\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the volume module. This\nPS handles the remaining modules for volume.\n\nThis PS also removes unnecessary indexing into response bodies.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I7451b7b098b9f751af777fcfad947ebc7a72f5ae\n" }, { "commit": "b7c0b9a2159fbca800d21431f991de61d68b649a", "tree": "23d0182124e4c684a89cfefed091800139984773", "parents": [ "1b8b0b7f5ac10e3dcf514bc7f73475252daf079c", "50d52d7b55447c3916bd7fe079535f8de335f0de" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Jan 23 20:49:16 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Jan 23 20:49:16 2018 +0000" }, "message": "Merge \"Add tests for update group types for volume module\"" }, { "commit": "1b8b0b7f5ac10e3dcf514bc7f73475252daf079c", "tree": "1e1f7800b69af938ea4b3c53f845b63d90fa50c6", "parents": [ "3e123c8108e8d60df9fc835efd2d4bb7fd1c0db3", "e7d7c229c24cc5ce885c8b87d82f678b03db90c7" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Jan 23 17:53:49 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Jan 23 17:53:49 2018 +0000" }, "message": "Merge \"Make create_server tests more policy-granular\"" }, { "commit": "398a09fb14254a8d920837f164e26308238e765a", "tree": "bf18263cd581bde5da11c0322c4bc808cef7d218", "parents": [ "074cb9a0455135e0de5d4950a356639c6501d0b9" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Jan 23 01:39:25 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Jan 23 01:39:25 2018 +0000" }, "message": "Clean up exception message raised by policy authority module\n\nThis PS cleans up an exception message raised by policy authority\nmodule because it is innacurate. When a policy isn\u0027t found,\nthe current message says something like:\n\nPolicy action: group:reset_group_snapshot not found in policy file:\nNone. [0]\n\nHowever, this isn\u0027t very helpful as in this case no custom policy\nfile is used and besides that, the policy in code is used as a source\nfor finding the policy. So the message has been changed to (e.g.):\n\nPolicy action \"group:reset_group_snapshot\" not found in policy file:\nNone or among registered policy in code defaults for service.\n\n[0] http://logs.openstack.org/12/536612/2/check/patrole-admin/7367a52/job-output.txt.gz#_2018-01-23_00_15_27_996109\n\nChange-Id: I754a03d57ae404877ad7521e25bf49a5cc7357b9\n" }, { "commit": "50d52d7b55447c3916bd7fe079535f8de335f0de", "tree": "8e901693bbf29651bc93b8be4eef0e8c528f411a", "parents": [ "074cb9a0455135e0de5d4950a356639c6501d0b9" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Jan 22 22:46:42 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Jan 22 22:46:50 2018 +0000" }, "message": "Add tests for update group types for volume module\n\nThis PS adds a test for update_group_types for the corresponding\nCinder API that was recently added to Tempest [0] and whose policy\nis [1].\n\nThis PS also rearranges some tests in the related class so that\nthe tests are bunched together by policy name.\n\n[0] https://github.com/openstack/tempest/blob/1879cc7aa733f38bc5eba1d126bd320dfeaa1a90/tempest/lib/services/volume/v3/group_types_client.py#L79\n[1] https://github.com/openstack/cinder/blob/280e59c5b6c953228dcba52b21587b82f7f5f93b/cinder/policies/group_types.py#L38\n\nChange-Id: Ie9bf27c9e9c392ebb2011800e5ce5c1450c3df75\n" }, { "commit": "81a22b102db7b509c35289311abab43de232064c", "tree": "01f0e244bf65869ac14ad90a8a532927276342a9", "parents": [ "074cb9a0455135e0de5d4950a356639c6501d0b9" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Dec 09 04:48:17 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Jan 22 22:43:44 2018 +0000" }, "message": "Add test coverage for volume types\n\nThis PS adds coverage for volume types policies, specifically\nthose that test creating, updating and deleting a volume type\nwhich enforces \"volume_extension:types_manage\" [0].\n\n[0] https://github.com/openstack/cinder/blob/4ca4f644008f4c89edc472cacda19050367ba54a/cinder/policies/volume_type.py#L26\n\nChange-Id: I38b88f7ab86635891141cda801b1ec9cf2758431\n" }, { "commit": "e7d7c229c24cc5ce885c8b87d82f678b03db90c7", "tree": "c9f8c2eaf02ebee86399e5c424bbaf2cc447c0c7", "parents": [ "8bd897b7f94bd1726ac5fd97847fffc50fad59ed" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Jan 13 18:20:13 2018 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Jan 18 23:00:22 2018 +0000" }, "message": "Make create_server tests more policy-granular\n\nThis PS makes the tests in test_create_serve rmore policy-granular\nby removing create_test_server from the ``override_role`` contextmanager\nblocks because the function can call many different policies.\n\nChange-Id: I299db38b1ab8f5233de44643aca052b9c34bb7ce\n" }, { "commit": "d67a92cec360fc81e17dd2fe48d8267594cd3ecc", "tree": "87b3872713e0e944299a89899bde0603f1be8446", "parents": [ "ec14d2b66927ea786936b19db0c9c8be8733de5a" ], "author": { "name": "Hifza Sakhi", "email": "hifza.sakhi@att.com", "time": "Wed Jan 17 17:29:51 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Jan 18 20:52:02 2018 +0000" }, "message": "Migrate to override_role for volume module (part 1)\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the volume module. This\nPS handles the first 4 modules for volume.\n\nThis PS also removes unnecessary indexing into response bodies.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I1dbe2b17716c98570faa36da578fd489d9d461df\n" }, { "commit": "ec14d2b66927ea786936b19db0c9c8be8733de5a", "tree": "b7f419d6c15c03655fe0d76aca563d482a994349", "parents": [ "21961d2bd9e7a045556c9a44311064909efb054c", "58590ee95c968f0885e9f10f25c44353add5e408" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Jan 16 23:34:11 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Jan 16 23:34:11 2018 +0000" }, "message": "Merge \"Migrate to override_role for identity v2 module\"" }, { "commit": "21961d2bd9e7a045556c9a44311064909efb054c", "tree": "5799c272fc93dc856c091d3a5eb460f4d77cd288", "parents": [ "e9c5b591900f3ef7a05b6b51fa2eea55527a3871", "6dd2b01870d35b99be700b333ab31f64505525de" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Jan 16 23:34:10 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Jan 16 23:34:10 2018 +0000" }, "message": "Merge \"Add Rbac test for \"group_snapshot\"\"" }, { "commit": "58590ee95c968f0885e9f10f25c44353add5e408", "tree": "f878b2e36319b524e330988f95de8e2033cd7c62", "parents": [ "e9c5b591900f3ef7a05b6b51fa2eea55527a3871" ], "author": { "name": "Shinya Kawabata", "email": "s-kawabata@wx.jp.nec.com", "time": "Tue Jan 16 22:05:37 2018 +0900" }, "committer": { "name": "Shinya Kawabata", "email": "s-kawabata@wx.jp.nec.com", "time": "Tue Jan 16 22:08:25 2018 +0900" }, "message": "Migrate to override_role for identity v2 module\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the identity ve module.\nThis patch handles all the remaining modules for identity v2.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: Ia8c0a465e906239e1572fdda2eceea820328faa8\n" }, { "commit": "da5ef5b67d4061e6e8d2735ff5cb575405343aea", "tree": "64fc9f2eb135d2c605892008de10edd349e16a3c", "parents": [ "7c3179385b6b68b6b4329ce3d935d45974352f47" ], "author": { "name": "Surya Prakash Singh", "email": "surya.singh@nectechnologies.in", "time": "Mon Jan 15 12:34:36 2018 +0530" }, "committer": { "name": "Surya Prakash Singh", "email": "surya.singh@nectechnologies.in", "time": "Mon Jan 15 12:41:19 2018 +0530" }, "message": "Migrate to override_role for network security group tests\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the network security group\ntest in test_security_groups_rbac.py.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I960c7fb10b7be2f2dd0422a4986ba12d5ecffa75\n" }, { "commit": "7c3179385b6b68b6b4329ce3d935d45974352f47", "tree": "8f7e3417ae3dea127512694beecbc55384bfa989", "parents": [ "9d49f7fdcb40739594de84ca36331ff34bb5d6b8", "dbb089525f7f8c63fc3fd174012e9182fd656d8d" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Sat Jan 13 20:11:36 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Sat Jan 13 20:11:36 2018 +0000" }, "message": "Merge \"Migrate to override_role for network multiprovider tests\"" }, { "commit": "9d49f7fdcb40739594de84ca36331ff34bb5d6b8", "tree": "e3a5771880ad701ac1cef279059169e9210a5a46", "parents": [ "4045d3ab937d3b6abe05e54b21d8a0900f557cb1", "d1ce46a22b57db1b3ca78d17bfc438a9a4ae8873" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Jan 12 08:20:47 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Jan 12 08:20:47 2018 +0000" }, "message": "Merge \"Migrate to override_role for image module (part 2)\"" }, { "commit": "4045d3ab937d3b6abe05e54b21d8a0900f557cb1", "tree": "0fe63623fd8bcd1a4cf8a8b7e1cd545d8addc575", "parents": [ "9e513ab6ee958f5edd13dc4bec7945d2b6efe298", "1a7e0cf56741866e448d8e1127ee885448977ba0" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Jan 12 08:20:46 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Jan 12 08:20:46 2018 +0000" }, "message": "Merge \"Migrate to override_role for network port tests\"" }, { "commit": "9e513ab6ee958f5edd13dc4bec7945d2b6efe298", "tree": "391ec713ffe3b294e09980afbbebb5d1be423ef5", "parents": [ "9911766a8b3f614633e55b8b7b018e8cd559dd65", "9da74401d2380bfec1241901fe92218a3df1234d" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Jan 12 06:05:28 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Jan 12 06:05:28 2018 +0000" }, "message": "Merge \"Migrate to override_role for volume module (part 4)\"" }, { "commit": "6dd2b01870d35b99be700b333ab31f64505525de", "tree": "9463c2ce2247d53c3579058171f5270877eb6c00", "parents": [ "422c0573adcb4ef8e48327efaae52ba2046e5a5d" ], "author": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Wed Dec 20 11:14:15 2017 +0530" }, "committer": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Fri Jan 12 09:57:49 2018 +0530" }, "message": "Add Rbac test for \"group_snapshot\"\n\nThis PS adds Rbac test for \"group_snapshot\" policy[0], api-ref[1]\n\n[0]https://github.com/openstack/cinder/blob/0cf910d4345c000e8c306b1cb2b2dd291975cf71/cinder/policies/group_snapshots.py\n[1]https://developer.openstack.org/api-ref/block-storage/v3/#delete-a-consistency-group-snapshot\n\nChange-Id: I83d0f9c7b5e6f4e0dd7449611a11229d5d5de6ed\n" }, { "commit": "9911766a8b3f614633e55b8b7b018e8cd559dd65", "tree": "184b4caf610b7be9c787b05518fe8eed6cda9024", "parents": [ "b9455064583c92e4f2f3fc6bb81c69382899addc", "0eb222030501da9f5d915410da3fbc27268031aa" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Jan 12 03:25:30 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Jan 12 03:25:30 2018 +0000" }, "message": "Merge \"Migrate to override_role for volume module (last)\"" }, { "commit": "d1ce46a22b57db1b3ca78d17bfc438a9a4ae8873", "tree": "d7a03f5da0c90d932e27ca349eb9a005ab1ff370", "parents": [ "211d4f971f5ec8cce91e4bf4e04897708c2fd0d8" ], "author": { "name": "sonu.kumar", "email": "sonu.kumar@nectechnologies.in", "time": "Wed Jan 10 12:38:39 2018 +0530" }, "committer": { "name": "sonu.kumar", "email": "sonu.kumar@nectechnologies.in", "time": "Fri Jan 12 08:53:53 2018 +0530" }, "message": "Migrate to override_role for image module (part 2)\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the image module for\nremaining files.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I971c1a24858a9a505257402ce3bf3cceaf7648b7\n" }, { "commit": "1a7e0cf56741866e448d8e1127ee885448977ba0", "tree": "7b82e8fcab2cf83889460f176065e8047ec8c5e8", "parents": [ "211d4f971f5ec8cce91e4bf4e04897708c2fd0d8" ], "author": { "name": "Nalini Varshney", "email": "nalini.varshney22@gmail.com", "time": "Thu Jan 11 10:40:23 2018 +0530" }, "committer": { "name": "Nalini Varshney", "email": "nalini.varshney22@gmail.com", "time": "Fri Jan 12 08:48:07 2018 +0530" }, "message": "Migrate to override_role for network port tests\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the network test\ntest_ports_rbac.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I015ec82431a2d6b6f2346da73f0d4ca901c6c274\n" }, { "commit": "b9455064583c92e4f2f3fc6bb81c69382899addc", "tree": "8518f33993bc3143fec11d64127f052a1c71f48c", "parents": [ "eb00e43a9f9c11dcc9a0cd3ba7b56811f8e2e0b2", "f456a3816866e9d30a94a8d2a4c5d2d896cac98d" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Jan 12 02:57:57 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Jan 12 02:57:57 2018 +0000" }, "message": "Merge \"Migrate to override_role for volume module (part 2)\"" }, { "commit": "eb00e43a9f9c11dcc9a0cd3ba7b56811f8e2e0b2", "tree": "a51e2617fccb8062a0e80aaaf9489d56dd0938cd", "parents": [ "f50b46173625665a848fa56db0f3e1562ca0909a", "81949e6d01a1b835c7329560c3a299b9ca4c6f64" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Jan 12 02:44:48 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Jan 12 02:44:48 2018 +0000" }, "message": "Merge \"Migrate to override_role for network metering tests\"" }, { "commit": "9da74401d2380bfec1241901fe92218a3df1234d", "tree": "de713321c783696afd05c5544576bce329f3197d", "parents": [ "f50b46173625665a848fa56db0f3e1562ca0909a" ], "author": { "name": "Hifza Sakhi", "email": "hifza.sakhi@att.com", "time": "Wed Jan 10 21:24:47 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jan 12 01:13:53 2018 +0000" }, "message": "Migrate to override_role for volume module (part 4)\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the volume module. This\nPS handles the remaining module for volume.\n\nThis PS also removes unnecessary indexing into response bodies.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I3d134db7efb0717546c224c8e53ff687984d47d1\n" }, { "commit": "f456a3816866e9d30a94a8d2a4c5d2d896cac98d", "tree": "0e1df73cac08052811b9e5a59d76f126e789c632", "parents": [ "1e197202a5938f20046f018fce6c4b881a7a51a3" ], "author": { "name": "Hifza Sakhi", "email": "hifza.sakhi@att.com", "time": "Thu Jan 11 21:10:20 2018 +0000" }, "committer": { "name": "Hifza Sakhi", "email": "hifza.sakhi@att.com", "time": "Thu Jan 11 22:20:22 2018 +0000" }, "message": "Migrate to override_role for volume module (part 2)\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the volume module. This\nPS handles the next few modules for volume.\n\nThis PS also removes unnecessary indexing into response bodies.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I58a9fc9a7ca1e77f48f597ca0d6cf01f4f3f3a15\n" }, { "commit": "0eb222030501da9f5d915410da3fbc27268031aa", "tree": "fe37592c4468ebc178e8e18da6a638d85c03787b", "parents": [ "422c0573adcb4ef8e48327efaae52ba2046e5a5d" ], "author": { "name": "saswati", "email": "saswati.k10@gmail.com", "time": "Thu Jan 11 05:42:47 2018 +0530" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Jan 11 21:25:49 2018 +0000" }, "message": "Migrate to override_role for volume module (last)\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the remaining one\nvolume file.\n\nOther volume files are already taken care till\nI3d134db7efb0717546c224c8e53ff687984d47d1\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I4590971e39e54e8cf7e13c076e3e2a9647888695\n" }, { "commit": "f50b46173625665a848fa56db0f3e1562ca0909a", "tree": "7907627a4c77e17eeda0830b206817f88cd3c742", "parents": [ "422c0573adcb4ef8e48327efaae52ba2046e5a5d" ], "author": { "name": "ra90707", "email": "rohitanand489@gmail.com", "time": "Thu Jan 11 11:45:37 2018 +0530" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Jan 11 21:25:28 2018 +0000" }, "message": "Migrate to override_role for network test_networks_rbac\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.This PS switches to override_role for the network test\ntest_networks_rbac.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I8a90f63aa488d37a1b779ab1d0c00c031c356e81\n" }, { "commit": "422c0573adcb4ef8e48327efaae52ba2046e5a5d", "tree": "077ab1a063b7c9639c370dc6968792cb06daef27", "parents": [ "2cf5810287e7ed5477f73dd436a1093e93616b9b", "07a1c17e68c540e422f4c3d075ac6dfc399ae73c" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Jan 11 21:10:24 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Jan 11 21:10:24 2018 +0000" }, "message": "Merge \"Implement RbacUtilsMixin for base RBAC classes\"" }, { "commit": "2cf5810287e7ed5477f73dd436a1093e93616b9b", "tree": "42e63d86f3c3436b54291a0119d189c9da9b6986", "parents": [ "1e197202a5938f20046f018fce6c4b881a7a51a3", "97ce5c78c37a48d3cb8ece903f098b71a4df73a0" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Jan 11 21:01:15 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Jan 11 21:01:15 2018 +0000" }, "message": "Merge \"Migrate to override_role for network metering_labels tests\"" }, { "commit": "81949e6d01a1b835c7329560c3a299b9ca4c6f64", "tree": "be4e827c07574f2c49cea0d486f464567f76af62", "parents": [ "1d500d49961a300e12634ce288dc44cd5d9834e1" ], "author": { "name": "Rajat Dhasmana", "email": "rajatdhasmana@gmail.com", "time": "Thu Jan 11 11:05:41 2018 +0530" }, "committer": { "name": "Rajat Dhasmana", "email": "rajatdhasmana@gmail.com", "time": "Thu Jan 11 08:58:37 2018 +0000" }, "message": "Migrate to override_role for network metering tests\n\nNow that override_role has supplanted switch_role (which has \nbeen deprecated) in [0], the RBAC tests need to switch to use \noverride_role.\n\nThis PS switches to override_role for the network test \ntest_metering_label_rules_rbac.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I84177b1c9384be54ae62203118ee80eea11f24a8\n" }, { "commit": "97ce5c78c37a48d3cb8ece903f098b71a4df73a0", "tree": "d530c9f9d8c202fab01dfe0877377ee3c9a8cf1a", "parents": [ "1d500d49961a300e12634ce288dc44cd5d9834e1" ], "author": { "name": "Vishakha Agarwal", "email": "agarwalvishakha18@gmail.com", "time": "Thu Jan 11 11:14:32 2018 +0530" }, "committer": { "name": "Vishakha Agarwal", "email": "agarwalvishakha18@gmail.com", "time": "Thu Jan 11 06:51:53 2018 +0000" }, "message": "Migrate to override_role for network metering_labels tests\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the network test\ntest_metering_labels_rbac.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: Iccefa15039b5a2fccdce07aafca073cc79d7b917\n" }, { "commit": "1e197202a5938f20046f018fce6c4b881a7a51a3", "tree": "efb1e0a2c79cb23c6f0b4e2f65d059612317fe25", "parents": [ "1d500d49961a300e12634ce288dc44cd5d9834e1", "c1b30051c94464e3ead4777d577de2b6ce15d27b" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Jan 11 05:39:48 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Jan 11 05:39:48 2018 +0000" }, "message": "Merge \"Migrate to override_role for image module (part 1)\"" }, { "commit": "dbb089525f7f8c63fc3fd174012e9182fd656d8d", "tree": "bcac7fe4e7d54737729d85c70394482aaf621288", "parents": [ "211d4f971f5ec8cce91e4bf4e04897708c2fd0d8" ], "author": { "name": "damini chopra", "email": "damini.chopra45@gmail.com", "time": "Thu Jan 11 10:43:37 2018 +0530" }, "committer": { "name": "Damini Chopra", "email": "damini.chopra45@gmail.com", "time": "Thu Jan 11 05:32:11 2018 +0000" }, "message": "Migrate to override_role for network multiprovider tests\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the network test\ntest_networks_multiprovider_rbac.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: Id1e8da294c853be5408f39fc032aefe30abeea93\n" }, { "commit": "1d500d49961a300e12634ce288dc44cd5d9834e1", "tree": "bacd32412888e97cce00868b168470c515117cef", "parents": [ "ba1ba8d62e04bd4cd06cafae0a4b9ec6ed663e1e", "96f23c6c2a3683849cd59380956b25681ef5071c" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Jan 11 04:26:59 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Jan 11 04:26:59 2018 +0000" }, "message": "Merge \"Migrate to override_role for network tests\"" }, { "commit": "ba1ba8d62e04bd4cd06cafae0a4b9ec6ed663e1e", "tree": "3367cfe5976324c3b91f1139f2bf5df53c55f992", "parents": [ "814a7af78c0b6d9b92740ac4efd2d65871dbec46", "0fb59a87fbb9f70f947cb33f0f8f8da3b4a94291" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Jan 11 00:29:52 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Jan 11 00:29:52 2018 +0000" }, "message": "Merge \"Migrate to override_role for network tests-2\"" }, { "commit": "0fb59a87fbb9f70f947cb33f0f8f8da3b4a94291", "tree": "8fb37ce9010b07ee8273f79b46f3fddc92666d73", "parents": [ "211d4f971f5ec8cce91e4bf4e04897708c2fd0d8" ], "author": { "name": "shweta1", "email": "duhanshweta@gmail.com", "time": "Wed Jan 10 19:24:18 2018 +0530" }, "committer": { "name": "shweta1", "email": "duhanshweta@gmail.com", "time": "Wed Jan 10 19:24:18 2018 +0530" }, "message": "Migrate to override_role for network tests-2\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the network module\nfor 3 modules.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: Ie4bd14b5cb9520381c25d1a3df0973a038680fdf\n" }, { "commit": "c1b30051c94464e3ead4777d577de2b6ce15d27b", "tree": "d7c4ecdf7adfefe447968e4a3f881ba3dfc54070", "parents": [ "211d4f971f5ec8cce91e4bf4e04897708c2fd0d8" ], "author": { "name": "Yuji Azama", "email": "yuj-azama@rc.jp.nec.com", "time": "Wed Jan 10 14:53:34 2018 +0900" }, "committer": { "name": "Yuji Azama", "email": "yuj-azama@rc.jp.nec.com", "time": "Wed Jan 10 22:17:25 2018 +0900" }, "message": "Migrate to override_role for image module (part 1)\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the image module\nfor 4 files.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I91160f8aa8c1831b33dcaa866104a73403293354\n" }, { "commit": "96f23c6c2a3683849cd59380956b25681ef5071c", "tree": "567a7c873982b4a31b2aa8abf4f4dfda01dc80e4", "parents": [ "211d4f971f5ec8cce91e4bf4e04897708c2fd0d8" ], "author": { "name": "udaybhan", "email": "uday.24@gmail.com", "time": "Wed Jan 10 17:53:01 2018 +0530" }, "committer": { "name": "udaybhan", "email": "uday.24@gmail.com", "time": "Wed Jan 10 18:01:18 2018 +0530" }, "message": "Migrate to override_role for network tests\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the network module\nfor 3 files.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I7220bf22d59945a17de4b242895a80eb0316cd04\n" }, { "commit": "80b9aab7699d439f3ddc88787e626967b64bde44", "tree": "91eb55264315dd6d49ee259a7e8b3ef4ca22aa6d", "parents": [ "c5f039645d3853bf5f1f56ce283db82565e5d17e" ], "author": { "name": "Masayuki Igawa", "email": "masayuki@igawa.io", "time": "Tue Jan 09 17:00:45 2018 +0900" }, "committer": { "name": "Masayuki Igawa", "email": "masayuki@igawa.io", "time": "Tue Jan 09 17:05:09 2018 +0900" }, "message": "[docs] Fix weird indentation in documentation\n\nThis commit fixes weird indentations in the documentation. And this\ncommit also adds auto generated file `patrole.conf.sample` to\n.gitignore because we don\u0027t need to manage it in a git repository.\n\nChange-Id: Ic6816ad04675917bf81c9d172b09feb5f40a2829\n" }, { "commit": "c5f039645d3853bf5f1f56ce283db82565e5d17e", "tree": "cd75d188f38ab1f30d86adf7e2153946c1353eec", "parents": [ "e3fa64f96d23da14783cd2b58d67778f61bc1ef9", "017664f1a1f55b20ad1822b6c385e14bd513cba2" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Jan 08 17:43:07 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Jan 08 17:43:07 2018 +0000" }, "message": "Merge \"Migrate to override_role for compute module (part 3)\"" }, { "commit": "e3fa64f96d23da14783cd2b58d67778f61bc1ef9", "tree": "2a7b96db1af883065b309030ac94b01a7cfdefae", "parents": [ "97a97a2ec2da46094f5c62245e5d9f6cd48a3a0b", "41eef07c1d8613c2024a3a3682d3280d4e3f76e9" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Jan 08 16:54:05 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Jan 08 16:54:05 2018 +0000" }, "message": "Merge \"Migrate to override_role for identity module (part 1)\"" }, { "commit": "017664f1a1f55b20ad1822b6c385e14bd513cba2", "tree": "b62099c1fd5639f9354cf3f4a49073b1a0c22ce9", "parents": [ "d6f107a0800be0ced64b2c5167d3c25583d4420b" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jan 05 22:06:42 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jan 05 22:06:53 2018 +0000" }, "message": "Migrate to override_role for compute module (part 3)\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the compute module. This\nPS handles the last 11 modules for compute.\n\nThis PS also removes unnecessary indexing into response bodies.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I0f8d249d58d7c6ad6f1d2fde2b52aefda10c64c4\n" }, { "commit": "41eef07c1d8613c2024a3a3682d3280d4e3f76e9", "tree": "7e036646fd562c355e64aa67540052c2d9d8494f", "parents": [ "d6f107a0800be0ced64b2c5167d3c25583d4420b" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jan 05 18:31:00 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jan 05 22:03:33 2018 +0000" }, "message": "Migrate to override_role for identity module (part 1)\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the identity module. This\nPS handles the first 10 modules for identity.\n\nThis PS also removes unnecessary indexing into response bodies.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: Ia80582119a98e63320859d8473987cdc2196d7e8\n" }, { "commit": "97a97a2ec2da46094f5c62245e5d9f6cd48a3a0b", "tree": "8e64598c9d5a01d021919c7c946b4df19b388e09", "parents": [ "d6f107a0800be0ced64b2c5167d3c25583d4420b" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jan 05 18:59:24 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jan 05 22:02:53 2018 +0000" }, "message": "Migrate to override_role for identity module (part 2)\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the identity module. This\nPS handles the last 10 modules for identity.\n\nThis PS also removes unnecessary indexing into response bodies.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I6be1dcebf75ff19ba746b24c005d6acc5aeb2787\n" }, { "commit": "d6f107a0800be0ced64b2c5167d3c25583d4420b", "tree": "150c26b42179856e9ab94da3dbdf9f77c1d5ee37", "parents": [ "c35e316a9eeb6d0a39065399f99061f6af22380f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jan 05 19:46:04 2018 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Jan 05 19:46:04 2018 +0000" }, "message": "[Fix gate] Fix compute snapshot tests raising ServerFault\n\nChange-Id: I0116a5b8253396a855ccceff7c52c6bace1d9029\n" }, { "commit": "4ffa4b401a75b5204980d5f57daab482722fa2ec", "tree": "9ad9bed5ef41b9d0198569e98a61416dcae22a38", "parents": [ "f8cd8e3c31698e4d4470fea9fe5a3b737ef72043", "d278efe4d5e47df015c6497ed7331a5a5cb55567" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Jan 01 17:01:24 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Jan 01 17:01:24 2018 +0000" }, "message": "Merge \"Migrate to override_role for compute module (part 2)\"" }, { "commit": "f8cd8e3c31698e4d4470fea9fe5a3b737ef72043", "tree": "972676a7c7c770dffa686ba3ec9b922cba9fa9b5", "parents": [ "ba0da6d01097a9fca8b336e5ae82e2a39d69671c", "2e2af4885d99770a693c21c1519a8e3c3a2cb668" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Jan 01 17:01:24 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Jan 01 17:01:24 2018 +0000" }, "message": "Merge \"[TrivialFix] Use _override_role in rbac_rule_validation\"" }, { "commit": "ba0da6d01097a9fca8b336e5ae82e2a39d69671c", "tree": "af2ad9309c2d575ce2d87569c188311aee990cef", "parents": [ "d5aee6c5221540967f4e2093a55222d551df8f75", "ad2dd7993286d16476f9a047bb63f2a2a2c5c561" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Jan 01 16:39:07 2018 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Jan 01 16:39:07 2018 +0000" }, "message": "Merge \"Fix min_microversion in volume test_groups_rbac\"" }, { "commit": "d5aee6c5221540967f4e2093a55222d551df8f75", "tree": "eadb2b141599a7bd35787b19a9a7a40c6e023e5a", "parents": [ "496958fed07d2b12d0b54d3aaf3c5031a8b9c0b8" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Dec 21 18:01:13 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Dec 21 18:02:18 2017 +0000" }, "message": "Fix wrong exception in test_snapshot_manage_rbac\n\nThis PS fixes the wrong exception being raised in skip_checks\nin test_snapshot_manage_rbac. `cls.InvalidConfiguration` doesn\u0027t\nexist. It has been changed to `lib_exc.InvalidConfiguration`.\n\nChange-Id: Iecdc495d82d1f1948f9042be97fa3c37464eb173\n" }, { "commit": "496958fed07d2b12d0b54d3aaf3c5031a8b9c0b8", "tree": "34c91b5b69ffba624edcdbc4f64332082ffe76fd", "parents": [ "0a58049c96a54c23aa55dfde4116b1af935e790a", "e25d8a66ff518a63a8cd4f59fe7062b50af0157b" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Dec 21 02:23:39 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Dec 21 02:23:39 2017 +0000" }, "message": "Merge \"Add \"snapshot_manage\" Rbac test\"" }, { "commit": "e25d8a66ff518a63a8cd4f59fe7062b50af0157b", "tree": "00e7d43409b1f15d710de2bc202de6798dc61660", "parents": [ "a3f01ec26de4244b47b6e32b2ac921e19f92515c" ], "author": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Fri Dec 15 11:18:59 2017 +0530" }, "committer": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Tue Dec 19 10:04:09 2017 +0530" }, "message": "Add \"snapshot_manage\" Rbac test\n\nThis PS adds Rbac test for \"snapshot_manage\" policy [0],\napi-ref[1]\n\n[0]https://github.com/openstack/cinder/blob/0cf910d4345c000e8c306b1cb2b2dd291975cf71/cinder/policies/manageable_snapshots.py\n[1]https://developer.openstack.org/api-ref/block-storage/v3/#manage-an-existing-snapshot\n\nChange-Id: Iafbbd33e96f77a14591170d4f8eadc1a2c3c1ec8\n" }, { "commit": "ad2dd7993286d16476f9a047bb63f2a2a2c5c561", "tree": "65e7fdebb629474beea486afc38c2da6e6ed578e", "parents": [ "0a58049c96a54c23aa55dfde4116b1af935e790a" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Dec 18 20:09:39 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Dec 18 20:27:57 2017 +0000" }, "message": "Fix min_microversion in volume test_groups_rbac\n\nThis PS fixes the min_microversion in volume test_groups_rbac\nwhich is incorrectly 3.14 when in fact it should be 3.13 [0] according\nto Cinder microversion documentation. This change will also make Patrole\nconsistent with Tempest [1].\n\n[0] https://docs.openstack.org/cinder/latest/contributor/api_microversion_history.html#id13\n[1] https://github.com/openstack/tempest/blob/c536175d8d4d572278b4e592dadc548b34e4ea91/tempest/api/volume/admin/test_groups.py#L27\n\nChange-Id: I9b19d44e25057d688e4b968cab2a047049658344\n" }, { "commit": "0a58049c96a54c23aa55dfde4116b1af935e790a", "tree": "18de27acf25bae145fa38a6b75408a70e1706338", "parents": [ "06ca9ad285dc13abbb506f14d8a98eb68ad77164", "0085d324cd76edc59dfe857293b5da9adeb2039a" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Dec 18 19:38:44 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Dec 18 19:38:44 2017 +0000" }, "message": "Merge \"Adding \u0027reset_group_status\u0027 rbac test\"" }, { "commit": "06ca9ad285dc13abbb506f14d8a98eb68ad77164", "tree": "0146b9653e081f2e2034cd78eb0f67d8751a4f27", "parents": [ "95fb07a7cfe19cc41c17e17e586bac4be1833bb3", "961212fb1c56bede029f0e8f08ccbfde60d1af1b" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Dec 18 18:02:38 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Dec 18 18:02:38 2017 +0000" }, "message": "Merge \"Migrate to override_role for compute module (part 1)\"" }, { "commit": "95fb07a7cfe19cc41c17e17e586bac4be1833bb3", "tree": "c5de40c936c531c8bd60bed7960eb04f9d9c0df2", "parents": [ "b0764e6b0dd1ae5ecf4911ec803c54df8c2605af", "27e0c8ed4ec17611df886057f4d7ab4bfb0532d8" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Dec 18 17:40:14 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Dec 18 17:40:14 2017 +0000" }, "message": "Merge \"\"get_association_qos\" test using wrong policy rule\"" }, { "commit": "b0764e6b0dd1ae5ecf4911ec803c54df8c2605af", "tree": "e60476815d1b05f75062f7eb27b161b032f1d805", "parents": [ "a8c25f045079b6859cc307684ef5ebbfaeb0d05a", "b9e3fd8b89d7021955f202e7bba936b4979d0791" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Dec 18 16:52:11 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Dec 18 16:52:11 2017 +0000" }, "message": "Merge \"Adding Missing rbac test for Volume\"" }, { "commit": "27e0c8ed4ec17611df886057f4d7ab4bfb0532d8", "tree": "0df0b985b8e6034d3a04deecd94f3d52eb081342", "parents": [ "a8c25f045079b6859cc307684ef5ebbfaeb0d05a" ], "author": { "name": "deepak_mourya", "email": "deepak.mourya@nectechnologies.in", "time": "Fri Dec 15 15:01:35 2017 +0530" }, "committer": { "name": "Deepak Mourya", "email": "deepak.mourya@nectechnologies.in", "time": "Fri Dec 15 11:42:01 2017 +0000" }, "message": "\"get_association_qos\" test using wrong policy rule\n\nAssociate list function should use under qos_specs_manage:get_all\npolicy rule [0]\n[0]https://github.com/openstack/cinder/blob/master/cinder/policies/qos_specs.py#L40\n\nChange-Id: I91ff96a85e9162af1f9510db1431a38fc2e3ea13\n" }, { "commit": "0085d324cd76edc59dfe857293b5da9adeb2039a", "tree": "4481799ffcb7e0c6a3b4ee07aeccb158f2dace29", "parents": [ "1dec9ce91e54b70e014da7a78beecd7bfc024de6" ], "author": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Fri Dec 08 11:12:57 2017 +0530" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Dec 14 21:20:28 2017 +0000" }, "message": "Adding \u0027reset_group_status\u0027 rbac test\n\nThis PS adds \u0027reset_group_status\u0027 test for policy[0],\nAPI ref is available here[1]\n\n[0]https://github.com/openstack/cinder/blob/0cf910d4345c000e8c306b1cb2b2dd291975cf71/cinder/policies/group_actions.py#L42\n[1]https://developer.openstack.org/api-ref/block-storage/v3/#reset-group-status\n\nCloses-Bug: #1718527\n\nChange-Id: Ia9e748c1733abd8abdb73c50491ff2f1198e3193\nDepends-On: If123e20b10614e8e31ecaecf74e4beda6b575e40\n" }, { "commit": "a8c25f045079b6859cc307684ef5ebbfaeb0d05a", "tree": "4f2677d8ea6b75175b578bb144fa329c2ef7da71", "parents": [ "a3f01ec26de4244b47b6e32b2ac921e19f92515c" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Dec 14 19:40:39 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Dec 14 19:40:39 2017 +0000" }, "message": "[Gate fix] Change policy for create_port/update_port:fixed_ips\n\nThis commit fixes the policies used by the tests:\n\n * test_create_port_fixed_ips\n * test_update_port_fixed_ips\n\nTo validate the following policy actions instead:\n\n * create_port:fixed_ips:ip_address\n * update_port:fixed_ips:ip_address\n\nThis change is necessary because Neutron recently added more specific\npolicy enforcement for these actions in:\n\n I1046f6b13e68b1e274cc8f62f5b30aa5f8d71cdc\n\nAlso renames the test names to convey the more specific policy\nname.\n\nChange-Id: If123e20b10614e8e31ecaecf74e4beda6b575e40\n" }, { "commit": "a3f01ec26de4244b47b6e32b2ac921e19f92515c", "tree": "dd3502cc5a20ae642cf0753ce72a2c0a4198431e", "parents": [ "1dec9ce91e54b70e014da7a78beecd7bfc024de6", "087c010776a3f3a98d7d95c95d17645fa9d68fb7" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Dec 12 23:52:12 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Dec 12 23:52:12 2017 +0000" }, "message": "Merge \"Complete coverage for volume transfers policies\"" }, { "commit": "b9e3fd8b89d7021955f202e7bba936b4979d0791", "tree": "6b37ae0fc318f784a4e2e86b42dc5d49d20bf7a8", "parents": [ "1dec9ce91e54b70e014da7a78beecd7bfc024de6" ], "author": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Thu Dec 07 11:53:37 2017 +0530" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Dec 12 14:26:44 2017 +0000" }, "message": "Adding Missing rbac test for Volume\n\nThis PS adds \u0027update_snapshot_status\u0027 test for policy[0]\n\n[0]https://github.com/openstack/cinder/blob/0cf910d4345c000e8c306b1cb2b2dd291975cf71/cinder/policies/snapshot_actions.py#L37\n\nChange-Id: I0237500328bd360482177845de3e7b05c8d175b2\n" }, { "commit": "2e2af4885d99770a693c21c1519a8e3c3a2cb668", "tree": "448e1f9338c66c01f8cdbc4cc6b1140268c80357", "parents": [ "1dec9ce91e54b70e014da7a78beecd7bfc024de6" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Dec 11 19:07:34 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Dec 11 19:07:34 2017 +0000" }, "message": "[TrivialFix] Use _override_role in rbac_rule_validation\n\nThis PS changes switch_role usage to _override_role usage in\nrbac_rule_validation. This is a temporary change while switch_role\ngoes through a deprecation phase. This code change should have been\nmade earlier in:\n\n I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I7154b7bf9440aaef69c8dae9b6643f956564369f\n" }, { "commit": "1dec9ce91e54b70e014da7a78beecd7bfc024de6", "tree": "c8e69130296ad955923996be99adc6b40f3d83b8", "parents": [ "9b4232a6988b40527b75bc4eb6fbbe1f650afee2", "017fcd6404cc8913f891fa49d511e9c69b101ba2" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Dec 11 17:00:52 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Dec 11 17:00:52 2017 +0000" }, "message": "Merge \"Unskip volume show host test\"" }, { "commit": "d278efe4d5e47df015c6497ed7331a5a5cb55567", "tree": "d570f73ba789021a9dbe494572d14ad9995f7668", "parents": [ "10b2bd7075c5b161a5429937f1cf6b6ccbfc09d4" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Dec 10 23:43:01 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Dec 11 00:17:27 2017 +0000" }, "message": "Migrate to override_role for compute module (part 2)\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the compute module. This\nPS handles 11 modules; 1 follow-up patch sets will handle the\nremaining 11 modules.\n\nThis PS also removes unnecessary indexing into response bodies.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I2a1bd0b9c929252541eec0e9e8a3ddd73cf1ab30\n" }, { "commit": "961212fb1c56bede029f0e8f08ccbfde60d1af1b", "tree": "9abc22eb41e4a1008e54cd8a85cc08ee75cfd8cb", "parents": [ "10b2bd7075c5b161a5429937f1cf6b6ccbfc09d4" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Dec 10 19:58:44 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Dec 10 23:37:42 2017 +0000" }, "message": "Migrate to override_role for compute module (part 1)\n\nNow that override_role has supplanted switch_role (which has\nbeen deprecated) in [0], the RBAC tests need to switch to use\noverride_role.\n\nThis PS switches to override_role for the compute module. This\nPS handles 11 modules; 2 follow-up patch sets will handle the\nremaining 22 modules.\n\nThis PS also removes unnecessary indexing into response bodies.\n\n[0] I670fba358bf321eae0d22d18cea6d2f530f00716\n\nPartially Implements: blueprint rbac-utils-contextmanager\nChange-Id: If0a73139fa339109881f52fa588eec94f8cec1c9\n" }, { "commit": "07a1c17e68c540e422f4c3d075ac6dfc399ae73c", "tree": "2223a759cbdeb37ef7a71e741faa00b88b375765", "parents": [ "9b4232a6988b40527b75bc4eb6fbbe1f650afee2" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Dec 10 04:26:08 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Dec 10 04:28:57 2017 +0000" }, "message": "Implement RbacUtilsMixin for base RBAC classes\n\nThis PS implements a RbacUtilsMixin mixin class in rbac_utils\nmodule. This mixin is useful for doing basic Patrole setup in one\nplace. The mixin currently handles skipping tests if the flag\n`[patrole] enable_rbac` is False and initializing rbac_utils\nfor each RBAC test.\n\nFollowing changes have been made:\n * Implementation of RbacUtilsMixin\n * Associated unit tests\n * Refactor base RBAC classes to use the mixin\n * Trivial documentation changes\n\nChange-Id: Ieaf19ccc8ce374b12af4c481a2bddcdbe86dedec\n" }, { "commit": "9b4232a6988b40527b75bc4eb6fbbe1f650afee2", "tree": "c97323139c56e95b313c442b2c939cf7e23a12cd", "parents": [ "10b2bd7075c5b161a5429937f1cf6b6ccbfc09d4" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Dec 10 03:34:02 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Dec 10 03:34:02 2017 +0000" }, "message": "Remove unusued BaseV1ImageRbacTest class\n\nThis PS removes unused BaseV1ImageRbacTest class as Patrole\nremoved suppor for Glance v1 some time ago with PS:\nI5b2e47542b8e6a7a9c0ce7f5c9d4c76291fac8c1\n\nChange-Id: I945043830a2e9fe653c8578b61183176a0ed7fd9\n" }, { "commit": "017fcd6404cc8913f891fa49d511e9c69b101ba2", "tree": "aca3b94de2e2af29fc17e28f41559d132e22d5f5", "parents": [ "5718d26c32e6cdb2f2670ec5628fc3c79cd05140" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Dec 09 05:03:50 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Dec 09 05:06:38 2017 +0000" }, "message": "Unskip volume show host test\n\nThis PS unskips volume show how test because the related bug\nwas fixed [0] and now the endpoint appears in the policy in code\ndocumentation for \"volume_extension:hosts\" [1].\n\n[0] I76ca1251cd14da6c777bd48a28906d8362d836b0\n[1] https://github.com/openstack/cinder/blob/4ca4f644008f4c89edc472cacda19050367ba54a/cinder/policies/hosts.py\n\nRelated-Bug: #1732808\nChange-Id: I5ddeb7f11d18c5e7382930aa2e05bf9c5dc1057e\n" }, { "commit": "087c010776a3f3a98d7d95c95d17645fa9d68fb7", "tree": "d02aba0f89762512f23c59056a9072cd15b6d443", "parents": [ "5718d26c32e6cdb2f2670ec5628fc3c79cd05140" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Dec 09 04:55:32 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Dec 09 04:55:32 2017 +0000" }, "message": "Complete coverage for volume transfers policies\n\nThis PS adds the last endpoint which enforces \"volume:get_all_transfers\":\n\u0027/os-volume-transfer/detail\u0027 [0].\n\n[0] https://github.com/openstack/cinder/blob/4ca4f644008f4c89edc472cacda19050367ba54a/cinder/policies/volume_transfer.py#L40\n\nChange-Id: I82eb09c719583572573a490162383d15e78235c3\n" }, { "commit": "10e82fdb0fd64cf600d68080899cbfd4ebe33211", "tree": "4ed9cef760895dbc933471cceec75f7fbd823125", "parents": [ "b2e9bb2ebd3f16574317a70f5bca0f8a40d8d1cf" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Nov 21 01:47:20 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Dec 05 00:13:57 2017 +0000" }, "message": "Base implementation of override_role for automatic role re-switch\n\nThis PS deprecated switch_role in rbac_utils and replaces it with\noverride_role. override_role realizes the same functionality as\nswitch_role, but uses @contextmanager so that role-switching can be\nstreamlined. This approach offers the following advantages:\n\n 1) Role switching is performed in 1 class only. There is no\n need to call ``test_obj.switch_role(test_obj, toggle_rbac_role\u003dFalse)``\n from ``rbac_rule_validation``. This de-coupling between both modules\n leads to cleaner, more readable code.\n 2) Improves test code readability.\n 3) Improve role switch granularity, meaning the role remains switched\n within the narrowest scope possible.\n 4) Simplifies interface, making it easier for test-writers to use\n the Patrole framework.\n\nRather than doing:\n\n # setup code here\n rand_name \u003d data_utils.rand_name(...)\n # ...\n # more setup code here\n self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)\n # execute the test here\n\n(Without newlines, this code is very hard to read.)\n\nIt is instead possible to now do:\n\n # setup code here\n rand_name \u003d data_utils.rand_name(...)\n # ...\n # more setup code here\n with self.rbac_utils.override_role(self):\n # execute the test here\n # notice the indentation... visually it is easy to see\n # that this block here is where the role is switched\n # now we are back to admin credentials in case we still\n # need it in the test... this was not possible before w/o\n # calling ``switch_role`` yet again...\n waiters.wait_for_volume_status(self.volumes_client, ...)\n\nThis commit:\n * Adds the necessary logic to rbac_utils to allow for automatic\n role re-switch following test execution (i.e. override_role)\n * Deprecates switch_role method in rbac_utils.\n * Refactors RBAC tests in test_volumes_extend_rbac to prove\n the concept introduced here.\n * Removes _validate_switch_role functionality since its purpose\n was to overcompensate for the old switch_role interface which\n allowed users to pass in a boolean flag; now this is no longer\n needed. Also removes associated unit tests.\n * Updates a docstring in rbac_utils module.\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I670fba358bf321eae0d22d18cea6d2f530f00716\n" }, { "commit": "8e2dce277f1d6acf58f1350042abfc00ebf6de90", "tree": "17ff065eaf1e7e734f95aea80ffa7afaf443e336", "parents": [ "da22b225a6e34ed20a1a5d39cfec45752af6403a", "b58c1197e9cbedb0713ea2342e8710d9869a1362" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Dec 04 13:34:43 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Dec 04 13:34:43 2017 +0000" }, "message": "Merge \"Remove deprecrated [rbac] config group\"" }, { "commit": "da22b225a6e34ed20a1a5d39cfec45752af6403a", "tree": "2dcbc7e3f8dd852fc13918ea8fbd435a1b5d841e", "parents": [ "1fe85f0890c6d9a2c0f23b7fa22159be4b1b2fe4", "b3bf95e32de1243f36f2bb076abb3e0441962a63" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Dec 01 23:09:19 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Dec 01 23:09:19 2017 +0000" }, "message": "Merge \"Additional volume quota set RBAC tests\"" }, { "commit": "1fe85f0890c6d9a2c0f23b7fa22159be4b1b2fe4", "tree": "d97d5710a77f4503d1bcae1aa085a2a38b292d2d", "parents": [ "29a1008b031e9d8e7e6fbec585eb376f86f85ee0", "a4cccaedd4ce4f2572b09361d1019ae08e14a131" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Dec 01 19:06:35 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Dec 01 19:06:35 2017 +0000" }, "message": "Merge \"Fix volume delete_group data race in clean up\"" }, { "commit": "29a1008b031e9d8e7e6fbec585eb376f86f85ee0", "tree": "f1793bff0c0d5557082592ae5ad59ac6158be123", "parents": [ "09a18338caa562a3a47480985d2203625ef80f07", "9792c16643b3df1f8caba3bacfa459ea4c45864c" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Dec 01 19:06:34 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Dec 01 19:06:34 2017 +0000" }, "message": "Merge \"Correct policy names for volume metadata tests\"" }, { "commit": "71b5e9db6cfd36dbda54bf933f178580816a8a1f", "tree": "092788cb6c3a37a73ca6026283a7535ce2256e98", "parents": [ "05dbcfa3441aa718dc84b45bdf9041468f20647d", "eac9c8eb109125c2489276ab3e95cb4ed3f9b247" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Nov 28 03:17:24 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Nov 28 03:17:24 2017 +0000" }, "message": "Merge \"Skip test_show_host volume test\"" }, { "commit": "9792c16643b3df1f8caba3bacfa459ea4c45864c", "tree": "022cd5356aef5af03ec576f4379759a08bcc9a5d", "parents": [ "05dbcfa3441aa718dc84b45bdf9041468f20647d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Nov 27 18:47:56 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Nov 27 18:55:42 2017 +0000" }, "message": "Correct policy names for volume metadata tests\n\nThis PS accomplishes 2 things:\n\n1) Correct policy name for volume metadata tests that have the\nwrong name. They are:\n * \"volume:update_volume_metadata\" -\u003e\n \"volume_extension:volume_image_metadata\" [0]\n * \"volume:delete_volume_metadata\" -\u003e\n \"volume_extension:volume_image_metadata\" [0]\n2) Group together both the \"volume_extension:volume_image_metadata\"\n policy tests for easier readability/maintenance.\\\n3) Add cleanups to both tests.\n\n[0] https://github.com/openstack/cinder/blob/0ac4af182fdd55d4a97ce283070f7b8e6480540f/cinder/policies/volume_metadata.py#L98\n[1] https://github.com/openstack/cinder/blob/0ac4af182fdd55d4a97ce283070f7b8e6480540f/cinder/policies/volume_metadata.py#L106\n\nChange-Id: Ie110283eca9decc37741b6197d0eb3f11d8918e9\n" }, { "commit": "a4cccaedd4ce4f2572b09361d1019ae08e14a131", "tree": "3521b8c5ee9b60773e81822cb51d7ce5b795005f", "parents": [ "38f344bb525a45e9bc299de522d4e687f1076c2f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 27 03:30:46 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Nov 27 18:40:30 2017 +0000" }, "message": "Fix volume delete_group data race in clean up\n\nSometimes _delete_group in GroupsV3RbacTest fails because\nthere are still volumes attached to the group before group\ndeletion. This PS refactors _delete_group method to wait\nfor each volume belonging to the group to delete before\nwaiting for the group itself to delete.\n\nChange-Id: I31483e91f55ea99f83310b37ed6f557aeec1c279\n" }, { "commit": "05dbcfa3441aa718dc84b45bdf9041468f20647d", "tree": "1c755128bb891120e927cd4fb56c0ca81c7b31ef", "parents": [ "feec999bde210930fe1e8b16bbc60c093927c608", "f14ce8122093b81bb34137adfc1e8323687c80ef" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Nov 27 06:52:34 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Nov 27 06:52:34 2017 +0000" }, "message": "Merge \"Add missing volume RBAC test\"" } ], "next": "b58c1197e9cbedb0713ea2342e8710d9869a1362" }