)]}' { "log": [ { "commit": "087c010776a3f3a98d7d95c95d17645fa9d68fb7", "tree": "d02aba0f89762512f23c59056a9072cd15b6d443", "parents": [ "5718d26c32e6cdb2f2670ec5628fc3c79cd05140" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Dec 09 04:55:32 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Dec 09 04:55:32 2017 +0000" }, "message": "Complete coverage for volume transfers policies\n\nThis PS adds the last endpoint which enforces \"volume:get_all_transfers\":\n\u0027/os-volume-transfer/detail\u0027 [0].\n\n[0] https://github.com/openstack/cinder/blob/4ca4f644008f4c89edc472cacda19050367ba54a/cinder/policies/volume_transfer.py#L40\n\nChange-Id: I82eb09c719583572573a490162383d15e78235c3\n" }, { "commit": "10e82fdb0fd64cf600d68080899cbfd4ebe33211", "tree": "4ed9cef760895dbc933471cceec75f7fbd823125", "parents": [ "b2e9bb2ebd3f16574317a70f5bca0f8a40d8d1cf" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Nov 21 01:47:20 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Dec 05 00:13:57 2017 +0000" }, "message": "Base implementation of override_role for automatic role re-switch\n\nThis PS deprecated switch_role in rbac_utils and replaces it with\noverride_role. override_role realizes the same functionality as\nswitch_role, but uses @contextmanager so that role-switching can be\nstreamlined. This approach offers the following advantages:\n\n 1) Role switching is performed in 1 class only. There is no\n need to call ``test_obj.switch_role(test_obj, toggle_rbac_role\u003dFalse)``\n from ``rbac_rule_validation``. This de-coupling between both modules\n leads to cleaner, more readable code.\n 2) Improves test code readability.\n 3) Improve role switch granularity, meaning the role remains switched\n within the narrowest scope possible.\n 4) Simplifies interface, making it easier for test-writers to use\n the Patrole framework.\n\nRather than doing:\n\n # setup code here\n rand_name \u003d data_utils.rand_name(...)\n # ...\n # more setup code here\n self.rbac_utils.switch_role(self, toggle_rbac_role\u003dTrue)\n # execute the test here\n\n(Without newlines, this code is very hard to read.)\n\nIt is instead possible to now do:\n\n # setup code here\n rand_name \u003d data_utils.rand_name(...)\n # ...\n # more setup code here\n with self.rbac_utils.override_role(self):\n # execute the test here\n # notice the indentation... visually it is easy to see\n # that this block here is where the role is switched\n # now we are back to admin credentials in case we still\n # need it in the test... this was not possible before w/o\n # calling ``switch_role`` yet again...\n waiters.wait_for_volume_status(self.volumes_client, ...)\n\nThis commit:\n * Adds the necessary logic to rbac_utils to allow for automatic\n role re-switch following test execution (i.e. override_role)\n * Deprecates switch_role method in rbac_utils.\n * Refactors RBAC tests in test_volumes_extend_rbac to prove\n the concept introduced here.\n * Removes _validate_switch_role functionality since its purpose\n was to overcompensate for the old switch_role interface which\n allowed users to pass in a boolean flag; now this is no longer\n needed. Also removes associated unit tests.\n * Updates a docstring in rbac_utils module.\n\nPartially Implements: blueprint rbac-utils-contextmanager\n\nChange-Id: I670fba358bf321eae0d22d18cea6d2f530f00716\n" }, { "commit": "8e2dce277f1d6acf58f1350042abfc00ebf6de90", "tree": "17ff065eaf1e7e734f95aea80ffa7afaf443e336", "parents": [ "da22b225a6e34ed20a1a5d39cfec45752af6403a", "b58c1197e9cbedb0713ea2342e8710d9869a1362" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Dec 04 13:34:43 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Dec 04 13:34:43 2017 +0000" }, "message": "Merge \"Remove deprecrated [rbac] config group\"" }, { "commit": "da22b225a6e34ed20a1a5d39cfec45752af6403a", "tree": "2dcbc7e3f8dd852fc13918ea8fbd435a1b5d841e", "parents": [ "1fe85f0890c6d9a2c0f23b7fa22159be4b1b2fe4", "b3bf95e32de1243f36f2bb076abb3e0441962a63" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Dec 01 23:09:19 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Dec 01 23:09:19 2017 +0000" }, "message": "Merge \"Additional volume quota set RBAC tests\"" }, { "commit": "1fe85f0890c6d9a2c0f23b7fa22159be4b1b2fe4", "tree": "d97d5710a77f4503d1bcae1aa085a2a38b292d2d", "parents": [ "29a1008b031e9d8e7e6fbec585eb376f86f85ee0", "a4cccaedd4ce4f2572b09361d1019ae08e14a131" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Dec 01 19:06:35 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Dec 01 19:06:35 2017 +0000" }, "message": "Merge \"Fix volume delete_group data race in clean up\"" }, { "commit": "29a1008b031e9d8e7e6fbec585eb376f86f85ee0", "tree": "f1793bff0c0d5557082592ae5ad59ac6158be123", "parents": [ "09a18338caa562a3a47480985d2203625ef80f07", "9792c16643b3df1f8caba3bacfa459ea4c45864c" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Dec 01 19:06:34 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Dec 01 19:06:34 2017 +0000" }, "message": "Merge \"Correct policy names for volume metadata tests\"" }, { "commit": "71b5e9db6cfd36dbda54bf933f178580816a8a1f", "tree": "092788cb6c3a37a73ca6026283a7535ce2256e98", "parents": [ "05dbcfa3441aa718dc84b45bdf9041468f20647d", "eac9c8eb109125c2489276ab3e95cb4ed3f9b247" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Nov 28 03:17:24 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Nov 28 03:17:24 2017 +0000" }, "message": "Merge \"Skip test_show_host volume test\"" }, { "commit": "9792c16643b3df1f8caba3bacfa459ea4c45864c", "tree": "022cd5356aef5af03ec576f4379759a08bcc9a5d", "parents": [ "05dbcfa3441aa718dc84b45bdf9041468f20647d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Nov 27 18:47:56 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Nov 27 18:55:42 2017 +0000" }, "message": "Correct policy names for volume metadata tests\n\nThis PS accomplishes 2 things:\n\n1) Correct policy name for volume metadata tests that have the\nwrong name. They are:\n * \"volume:update_volume_metadata\" -\u003e\n \"volume_extension:volume_image_metadata\" [0]\n * \"volume:delete_volume_metadata\" -\u003e\n \"volume_extension:volume_image_metadata\" [0]\n2) Group together both the \"volume_extension:volume_image_metadata\"\n policy tests for easier readability/maintenance.\\\n3) Add cleanups to both tests.\n\n[0] https://github.com/openstack/cinder/blob/0ac4af182fdd55d4a97ce283070f7b8e6480540f/cinder/policies/volume_metadata.py#L98\n[1] https://github.com/openstack/cinder/blob/0ac4af182fdd55d4a97ce283070f7b8e6480540f/cinder/policies/volume_metadata.py#L106\n\nChange-Id: Ie110283eca9decc37741b6197d0eb3f11d8918e9\n" }, { "commit": "a4cccaedd4ce4f2572b09361d1019ae08e14a131", "tree": "3521b8c5ee9b60773e81822cb51d7ce5b795005f", "parents": [ "38f344bb525a45e9bc299de522d4e687f1076c2f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 27 03:30:46 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Nov 27 18:40:30 2017 +0000" }, "message": "Fix volume delete_group data race in clean up\n\nSometimes _delete_group in GroupsV3RbacTest fails because\nthere are still volumes attached to the group before group\ndeletion. This PS refactors _delete_group method to wait\nfor each volume belonging to the group to delete before\nwaiting for the group itself to delete.\n\nChange-Id: I31483e91f55ea99f83310b37ed6f557aeec1c279\n" }, { "commit": "05dbcfa3441aa718dc84b45bdf9041468f20647d", "tree": "1c755128bb891120e927cd4fb56c0ca81c7b31ef", "parents": [ "feec999bde210930fe1e8b16bbc60c093927c608", "f14ce8122093b81bb34137adfc1e8323687c80ef" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Nov 27 06:52:34 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Nov 27 06:52:34 2017 +0000" }, "message": "Merge \"Add missing volume RBAC test\"" }, { "commit": "b58c1197e9cbedb0713ea2342e8710d9869a1362", "tree": "065b7cb38206f89237925f1056c2d6a65ef02c15", "parents": [ "feec999bde210930fe1e8b16bbc60c093927c608" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Nov 20 01:50:24 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Nov 27 04:58:28 2017 +0000" }, "message": "Remove deprecrated [rbac] config group\n\nThis PS removes the deprecated [rbac] config group. It was replaced\nlast release cycle with the [patrole] config group, which has\nthe exact same options. This is because [patrole] is more user-friendly\nand congruent with the project name.\n\nChange-Id: Id1a7af0445bd50f44ddcc4277f952391968726b8\n" }, { "commit": "b3bf95e32de1243f36f2bb076abb3e0441962a63", "tree": "8e54bdad1ada41404d591da9ae6a5530746d49c2", "parents": [ "feec999bde210930fe1e8b16bbc60c093927c608" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Nov 14 11:20:48 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Nov 26 23:45:51 2017 +0000" }, "message": "Additional volume quota set RBAC tests\n\nThis PS adds additional volume quota set RBAC tests for the\nfollowing endpoints:\n\n * \u0027/os-quota-sets/{project_id}\u0027 [0]\n * \u0027/os-quota-sets/{project_id}/default\u0027 [0]\n * \u0027/os-quota-sets/{project_id}\u0027 [1]\n\nThis PS also adds a clean up to test_update_quota_set\nso that the default quotas are reset following test\nexecution.\n\n[0] https://github.com/openstack/cinder/blob/10a3f4e1c6f21effc79fd309628111c221543e0d/cinder/policies/quotas.py#L28\n[1] https://github.com/openstack/cinder/blob/10a3f4e1c6f21effc79fd309628111c221543e0d/cinder/policies/quotas.py#L57\n\nChange-Id: I5a42b8b6235e0a9a5985e8eea4d00f7f614de632\n" }, { "commit": "feec999bde210930fe1e8b16bbc60c093927c608", "tree": "2e505102a7edadf212f9ba53b63e9ae3e328e5f5", "parents": [ "ae37f5ceeb6b9b8dd469da65b8c6f3396aa688a1", "f89b7f235938b4dcf483b82642e4e03406500e57" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Sat Nov 25 22:20:29 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Sat Nov 25 22:20:29 2017 +0000" }, "message": "Merge \"Add get_router high availaibility test policy\"" }, { "commit": "f89b7f235938b4dcf483b82642e4e03406500e57", "tree": "3107aaa08d747e0bb3a2760c3c8486a4dbdef2ec", "parents": [ "c1f7f47f762ae5dcaff104f8b7c6709330398d89" ], "author": { "name": "deepakmourya", "email": "deepak.mourya@nectechnologies.in", "time": "Thu Nov 16 04:32:34 2017 +0000" }, "committer": { "name": "Ghanshyam Mann", "email": "ghanshyammann@gmail.com", "time": "Sat Nov 25 16:10:51 2017 +0000" }, "message": "Add get_router high availaibility test policy\n\nAdd missing RBAC test case for the neutron router in policy file [1]\n\npolicy doc : [1] https://github.com/openstack/neutron/blob/bf84f308d71ad770b1173487391d23f2afd29efa/etc/policy.json#L100\n\n\nChange-Id: I8f2623a4f1eecce359ffb6f66e9e9ef9365690e2\n" }, { "commit": "f14ce8122093b81bb34137adfc1e8323687c80ef", "tree": "f719078f9f4e2f0f8cec709664687a022d8b2114", "parents": [ "f07edf12bfcdc4f92b14604af1e52aaa59bdd142" ], "author": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Mon Nov 20 13:55:21 2017 +0530" }, "committer": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Thu Nov 23 10:13:04 2017 +0530" }, "message": "Add missing volume RBAC test\n\nAdd missing RBAC test for \u0027show_group_type\u0027\nAPI [0] which enforces \"group:access_group_type_specs\"\naccording to policy in code docs [1].\n[0]https://developer.openstack.org/api-ref/block-storage/v3/#show-group-type-details\n[1]https://github.com/openstack/cinder/blob/76231f3ad2828fe7bb60ecd9686db807622bbb7a/cinder/policies/group_types.py#L53\n\nChange-Id: I71c81d0798082c03408d75deb021e7fcf077b938\n" }, { "commit": "eac9c8eb109125c2489276ab3e95cb4ed3f9b247", "tree": "4934c014108a9d1d0dcf363819859f6b426c9b3b", "parents": [ "e182300601d0b17c85f86315d1904525b1bc1977" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Nov 14 10:44:22 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 22 01:09:57 2017 +0000" }, "message": "Skip test_show_host volume test\n\nThis PS makes test_show_host volume test in test_volume_hosts_rbac\nskip until bug 1732808 is resolved. This is because Cinder does\nnot currently do policy enforcement for this endpoint.\n\nInstead, Cinder checks whether the request context is_admin [1].\nThe policy in code documentation [0] does not include the \"show\"\nendpoint for the \"volume_extension:hosts\" policy action\n(i.e. GET /hosts/{host_name} is missing).\n\n[0] https://github.com/openstack/cinder/blob/10a3f4e1c6f21effc79fd309628111c221543e0d/cinder/policies/hosts.py\n[1] https://github.com/openstack/cinder/blob/0cf910d4345c000e8c306b1cb2b2dd291975cf71/cinder/api/contrib/hosts.py#L149\n\nRelated-Bug: #1732808\nChange-Id: I348166738ae574ebd7220802cfc00f143d52aa2c\n" }, { "commit": "e182300601d0b17c85f86315d1904525b1bc1977", "tree": "a6e023f06122f4562884a882cfd04392cd778c28", "parents": [ "e90f6d602e1df6e62225ed04af1c98d12414bea5", "0cf00b4ca03f2d281be26c83bee0e241f9dad3c6" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Nov 21 23:29:22 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Nov 21 23:29:22 2017 +0000" }, "message": "Merge \"Remove Cinder v2 RBAC tests\"" }, { "commit": "952b3d05ce64c5f8c116bd3741d874dc2f6a3d72", "tree": "a012d748e04f5d405b481f3e6faadfed51e50aae", "parents": [ "c92846a1c2f93ea853388fe722e641ceea18456c", "d5a9ba954db5c2e8bd3c2a9c9555a4b7565d59e8" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Nov 21 08:09:43 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Nov 21 08:09:43 2017 +0000" }, "message": "Merge \"Add \u0027fixed ips\u0027 APIs policy tests\"" }, { "commit": "c92846a1c2f93ea853388fe722e641ceea18456c", "tree": "277408dba6c7e7846312f8389b64a4672fe75ccd", "parents": [ "f07edf12bfcdc4f92b14604af1e52aaa59bdd142" ], "author": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Mon Nov 20 12:03:57 2017 +0530" }, "committer": { "name": "Rajat Sharma", "email": "rajat.sharma@nectechnologies.in", "time": "Mon Nov 20 06:42:29 2017 +0000" }, "message": "Rename function name to avoid confusion\n\nRemaning \u0027test_show_back_end_capabilities\u0027 to\n\u0027test_show_limits\u0027 to make its functionality clear\n\nChange-Id: I2f2dbb7240d1473bf7def4ca6955aaeb57b7fe83\n" }, { "commit": "0cf00b4ca03f2d281be26c83bee0e241f9dad3c6", "tree": "38874daf4322ffca534c2587584963b35f64a93c", "parents": [ "43ec81a4c57c64a117332849e4a1966c3feb3f25" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Nov 14 10:33:31 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Nov 20 01:45:14 2017 +0000" }, "message": "Remove Cinder v2 RBAC tests\n\nThis PS removes Cinder v2 RBAC tests, as the policy tests can\nbe performed via the v3 API. Policy enforcement doesn\u0027t change\nbetween v2 and v3 APIs, so we should only test the latest API.\n\nChange-Id: Id0421a958a2c4b087bd7a886ae088eac5fe3c79a\n" }, { "commit": "bf3743f507802704443512a23beb55355048e673", "tree": "bed95f55a60a4b35bdced2ab0df717ce7d5bf6ef", "parents": [ "90ab6387e001051f569ac293b8c6b06eb2f8c979", "e7f4ed64d53d3e51ec270bc070b614ba69b7c772" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Nov 17 01:42:25 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Nov 17 01:42:25 2017 +0000" }, "message": "Merge \"Add RBAC tests for volume limits client\"" }, { "commit": "90ab6387e001051f569ac293b8c6b06eb2f8c979", "tree": "c21894c8a1ba99b6410149808b41d3568cc939c8", "parents": [ "c1f7f47f762ae5dcaff104f8b7c6709330398d89", "7a85dfe852b082718381f5453a7e6de6b851163f" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Nov 16 23:55:01 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Nov 16 23:55:01 2017 +0000" }, "message": "Merge \"Add Pause/Unpause policy tests\"" }, { "commit": "7a85dfe852b082718381f5453a7e6de6b851163f", "tree": "e593707000734e4523f337d0be4de5da792e3eab", "parents": [ "81247497ce8e36a92c0f4f52781db22c80fd0cbf" ], "author": { "name": "deepakmourya", "email": "deepak.mourya@nectechnologies.in", "time": "Thu Oct 26 05:02:30 2017 +0000" }, "committer": { "name": "deepakmourya", "email": "deepak.mourya@nectechnologies.in", "time": "Thu Nov 16 09:36:30 2017 +0000" }, "message": "Add Pause/Unpause policy tests\n\nAdd Missing RBAC test case for server action in policy file [1]\n\n[1] https://github.com/openstack/nova/blob/722cc06aad401fefa558dc5eba7d04fe615b5d51/nova/policies/pause_server.py\n\nChange-Id: I20a23232bbec706eb82dd67b79984f4b01f8bbfe\n" }, { "commit": "c1f7f47f762ae5dcaff104f8b7c6709330398d89", "tree": "7e9a3a5a1e9cc4e3dae7e6d10110aff77302101d", "parents": [ "d475a98e86b9ad7cfddf19adf9c47a53f1af5101", "7ab96ceea022c34ba23bf919aede3ab945164c1d" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Thu Nov 16 02:09:06 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Nov 16 02:09:06 2017 +0000" }, "message": "Merge \"Add RBAC test for \u0027get_auth_domains\u0027\"" }, { "commit": "7ab96ceea022c34ba23bf919aede3ab945164c1d", "tree": "455d432f374c30eec8696a99c5c2837aa18ea23c", "parents": [ "43ec81a4c57c64a117332849e4a1966c3feb3f25" ], "author": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Wed Nov 15 12:49:46 2017 +0530" }, "committer": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Wed Nov 15 12:49:46 2017 +0530" }, "message": "Add RBAC test for \u0027get_auth_domains\u0027\n\nAdding \u0027get_auth_domains\u0027 rbac test for this policy[1]\n[1]https://github.com/openstack/keystone/blob/master/keystone/common/policies/auth.py#L50\n\nChange-Id: I0da9330a455dabe5c21b0a6d35bc5bb1ba6cd875\n" }, { "commit": "d5a9ba954db5c2e8bd3c2a9c9555a4b7565d59e8", "tree": "a6550a5ad268659d5d05b2f2f6cd43dfb7ff1b05", "parents": [ "8849bc2199b75728e9690ba3479c0fdca0ccd67f" ], "author": { "name": "M V P Nitesh", "email": "m.nitesh@nectechnologies.in", "time": "Mon Oct 16 03:58:33 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 15 03:46:31 2017 +0000" }, "message": "Add \u0027fixed ips\u0027 APIs policy tests\n\n\u0027fixed ips\u0027 API tests are not covered for policy testing.\nThis commit adds The tests for this APIs.\n\nChange-Id: Idc3d022c03bd5890535eea19301e59cf616de278\n" }, { "commit": "e7f4ed64d53d3e51ec270bc070b614ba69b7c772", "tree": "71797f79f93d7d6840fb1205b2cd283ec08ba817", "parents": [ "43ec81a4c57c64a117332849e4a1966c3feb3f25" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Nov 14 10:53:46 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Nov 14 10:53:46 2017 +0000" }, "message": "Add RBAC tests for volume limits client\n\nThis PS adds RBAc tests for volume limits endpoints, the policies\nfor which are here: [0].\n\n[0] https://github.com/openstack/cinder/blob/master/cinder/policies/limits.py\n\nChange-Id: I5d51feab755ad3d2b64201afd2c423c1c6f84771\n" }, { "commit": "4c5dbdd78adbefd7eadb839a75fd0d3dd9162be6", "tree": "839fef8582bc6b93959afb3f5db9fc2b414a723d", "parents": [ "43ec81a4c57c64a117332849e4a1966c3feb3f25" ], "author": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Tue Nov 14 12:39:28 2017 +0530" }, "committer": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Tue Nov 14 12:39:28 2017 +0530" }, "message": "Add \u0027show_trust\u0027 Policy Test for Identity\n\nAdding missing \u0027show_trust\u0027 RBAC test for identity[1]\n\n[1]https://github.com/openstack/keystone/blob/master/keystone/common/policies/trust.py#L55\n\nChange-Id: I8725ed13cc1ec45b4f1fbd57c7b177b3139377f4\n" }, { "commit": "43ec81a4c57c64a117332849e4a1966c3feb3f25", "tree": "728ace1e9ac4efa87d8dade533cdcc93ebd0a2e8", "parents": [ "47d33276ba4979f918c2c95494b98796a1bef16c", "7c3ba053f331c94f9cd1e6b34c7a29a6fcff7dcf" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Nov 14 00:56:00 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Nov 14 00:56:00 2017 +0000" }, "message": "Merge \"Adding missing snapshot_metadata RBAC tests\"" }, { "commit": "7c3ba053f331c94f9cd1e6b34c7a29a6fcff7dcf", "tree": "54b20cb50af0219e1d39e66a44105fbe8005e564", "parents": [ "81247497ce8e36a92c0f4f52781db22c80fd0cbf" ], "author": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Thu Nov 09 12:18:12 2017 +0530" }, "committer": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Mon Nov 13 15:29:24 2017 +0530" }, "message": "Adding missing snapshot_metadata RBAC tests\n\nAdding misssing tests for following:\n1)update_snapshot_metadata\n2)update_snapshot_metadata with a given key\n3)show_snapshot_metadata with a given key\n4)delete_snapshot_metadata with a given key\n\nAdding misssing update_snapshot_metadata RBAC test for volume tests\nin policy file[1].\n\n[1]https://github.com/openstack/patrole/blob/master/patrole_tempest_plugin/tests/api/volume/test_snapshots_metadata_rbac.py\n\nChange-Id: I71f67a1c206fcd541bb75c602854a28e9280b63a\n" }, { "commit": "47d33276ba4979f918c2c95494b98796a1bef16c", "tree": "b273a402b367b9a5c8d0f585c429396055b26dfc", "parents": [ "bc058fcaea9435877f839b090061e234d5e92581", "912b9fe9c50d43a3bc1cadbca80b6b5f7f784a80" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Nov 10 16:00:32 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Nov 10 16:00:32 2017 +0000" }, "message": "Merge \"Add Show \u0027 update_backup \u0027 policy tests\"" }, { "commit": "bc058fcaea9435877f839b090061e234d5e92581", "tree": "a8e659385e2da5fdbb200cc1fd314a5adac5a65b", "parents": [ "81247497ce8e36a92c0f4f52781db22c80fd0cbf" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 08 14:10:11 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 08 14:10:11 2017 +0000" }, "message": "Correct policy action for backup export volume endpoint\n\nThis PS corrects the policy action for exporting a volume\nbackup from \"backup:backup-export\" to \"backup:export-import\".\nThe former is causing the related RBAC test to fail [0] and\nthe in-code policy documentation confirms that the latter is\ncorrect [1].\n\n[0] http://logs.openstack.org/08/518208/3/check/legacy-tempest-dsvm-patrole-multinode-admin/5f129df/job-output.txt.gz#_2017-11-08_01_02_55_782843\n[1] https://github.com/openstack/cinder/blob/fb27334719fb612d2d5386b7d9de374d4a415d81/cinder/policies/backups.py#L127\n\nChange-Id: I10dd9cb8134a2b83cf92131c1b28a58881757f32\n" }, { "commit": "912b9fe9c50d43a3bc1cadbca80b6b5f7f784a80", "tree": "8aaa88463b5e2b3bf1502d55ac0f1b7f17661aed", "parents": [ "21db8fca4a06b8bf799acc2fa0c03672242827d9" ], "author": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Fri Oct 27 13:26:17 2017 +0530" }, "committer": { "name": "rajat29", "email": "rajat.sharma@nectechnologies.in", "time": "Wed Nov 08 09:51:38 2017 +0530" }, "message": "Add Show \u0027 update_backup \u0027 policy tests\n\nAdding missing RBAC test for volume backup update\nin policy file[1], api-ref[2]\n\n[1]https://github.com/openstack/patrole/blob/master/patrole_tempest_plugin/tests/api/volume/test_volumes_backup_rbac.py\n\n[2]https://github.com/openstack/cinder/blob/master/cinder/policies/backups.py#L80\n\nChange-Id: I1189f53f32b5008200dbf2b67e349577973065df\n" }, { "commit": "81247497ce8e36a92c0f4f52781db22c80fd0cbf", "tree": "9667d840d8743804dd4e75f9ddfd50bd8c026922", "parents": [ "c5ca0bacd84c3c9c2d1e34fbc3dbe660e8679d39", "501c828c0b3e39dacfba19b7518865329136b3a2" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Nov 07 23:15:33 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Nov 07 23:15:33 2017 +0000" }, "message": "Merge \"Add Shelve/Unshelve policy tests\"" }, { "commit": "c5ca0bacd84c3c9c2d1e34fbc3dbe660e8679d39", "tree": "d3af29006f434067544f41480cc1a22c4c739b23", "parents": [ "1c4066a5a84275ff9b5b5f69b17a2c9fac843a04", "53530ad8a027523d50c4921fc228d974075318ec" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Nov 07 23:10:22 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Nov 07 23:10:22 2017 +0000" }, "message": "Merge \"Correct policy action for attach/detach volume actions\"" }, { "commit": "1c4066a5a84275ff9b5b5f69b17a2c9fac843a04", "tree": "12a8b9ab81f422fbf7e31805c45b1f6c78e63307", "parents": [ "38f344bb525a45e9bc299de522d4e687f1076c2f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Nov 07 03:30:56 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Nov 07 05:35:14 2017 +0000" }, "message": "Correct policy action for reserve/unreserve volume actions\n\nThis PS corrects the policy action for reserve and unreserve\nvolume actions. There are a few policy actions that currently\nhave the wrong name. This PS is a pre-requsite for removing\nstrict_policy_enforce Patrole configuration option in order\nto avoid false positives (e.g. a non-existent policy action\nbeing validated against an API).\n\nThe os-reserve volume actions actually enforces\n\"volume_extension:volume_actions:reserve\" and os-unreserve\nactually enforces \"volume_extension:volume_actions:reserve\" [0].\n\n[0] https://github.com/openstack/cinder/blob/ae7355c1f8d5d137bfb8bdf7b521ff5519cc20f8/cinder/policies/volume_actions.py#L197\n\nChange-Id: Ib1b68cbde992b57619e877e0a4fe2f1948fdd6c1\n" }, { "commit": "53530ad8a027523d50c4921fc228d974075318ec", "tree": "8e33c9ae15ad81c0422281d3dd2c99997a839a1d", "parents": [ "38f344bb525a45e9bc299de522d4e687f1076c2f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Nov 07 03:36:30 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Nov 07 03:39:31 2017 +0000" }, "message": "Correct policy action for attach/detach volume actions\n\nThis PS corrects the policy action for attach and detach\nvolume actions. There are a few policy actions that currently\nhave the wrong name. This PS is a pre-requsite for removing\nstrict_policy_enforce Patrole configuration option in order\nto avoid false positives (e.g. a non-existent policy action\nbeing validated against an API).\n\nThe os-attach volume actions actually enforces\n\"volume_extension:volume_actions:attach\" and os-detach\nactually enforces \"volume_extension:volume_actions:detach\" [0].\n\n[0] https://github.com/openstack/cinder/blob/ae7355c1f8d5d137bfb8bdf7b521ff5519cc20f8/cinder/policies/volume_actions.py#L224\n\nChange-Id: I7d0c99ffb197832182e8f7b2af952f94acd29b0d\n" }, { "commit": "501c828c0b3e39dacfba19b7518865329136b3a2", "tree": "4aa913a756f68899c23a2181d2625f3b6e19f3c9", "parents": [ "a1b039dd0ebc343f1b4ee1efac2bf3cf55a5b9af" ], "author": { "name": "aditi", "email": "aditi.s@nectechnologies.in", "time": "Thu Oct 26 05:02:30 2017 +0000" }, "committer": { "name": "aditi", "email": "aditi.s@nectechnologies.in", "time": "Mon Nov 06 05:40:11 2017 +0000" }, "message": "Add Shelve/Unshelve policy tests\n\nThis patch adds RBAC test case for shelve/unshelve\nserver actions.\n\npolicy details [1]\n\n[1] https://github.com/openstack/nova/blob/722cc06aad401fefa558dc5eba7d04fe615b5d51/nova/policies/shelve.py\n\nChange-Id: I919cdeb51a9b45a1bb01dbf7268f352f2fc77148\n" }, { "commit": "38f344bb525a45e9bc299de522d4e687f1076c2f", "tree": "6cb47340611bf2f12f3c832d1715247d33561722", "parents": [ "3ff3c8164579d004fe3751a43caf2c5b98d55ead" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Nov 03 12:59:15 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Nov 03 19:44:27 2017 +0000" }, "message": "Fix six.reraise bug in rbac_rule_validation\n\nThis PS fixes an issue [0] when calling six.reraise in\nrbac_rule_validation after a generic Exception has been\ncaught. Instead of using six.reraise and changing the\nexception\u0027s detailed error message unnecessarily,\nexcutils.save_and_reraise_exception from oslo_utils\nis used instead.\n\n[0] http://logs.openstack.org/97/507697/5/check/legacy-tempest-dsvm-patrole-member/d2530aa/job-output.txt.gz#_2017-11-02_20_04_35_107548\n\nChange-Id: I99f2cc60f301172847dd8f98fbc7deff4d5e94e4\n" }, { "commit": "b987141e1541f63af938efd1f7388fa5fd7e0ec7", "tree": "c25173c13aa4cebdd76cd1ec3bcb634a414b8eed", "parents": [ "322ca259b95b27653a1eb3d655d96a82e69dd1dc" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 01 02:15:41 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Nov 01 02:15:41 2017 +0000" }, "message": "RBAC test for unrescue server\n\nThis PS adds an RBAC test for unrescue compute server action to\nvalidate that \"os_compute_api:os-rescue\" is enforced for the\nendpoint.\n\nChange-Id: I6c73d23dcd89addc0a364596c4f93511facb633f\n" }, { "commit": "322ca259b95b27653a1eb3d655d96a82e69dd1dc", "tree": "12d89493f747de35cccd867ec04ea8cace01f9e0", "parents": [ "68d6c4ffb15527ffdd261d6b99e2465283a41407", "906623ed3920860364059243867a22c5306ffe4c" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Mon Oct 30 21:34:44 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Oct 30 21:34:44 2017 +0000" }, "message": "Merge \"Image create v1/v2 compatible in compute test_images_rbac\"" }, { "commit": "4bc86e812bd46e12f70ad3f1fa3e35bb150772ba", "tree": "77cc7c752fc2f75224069ad06a6a6c1fe972687d", "parents": [ "a1b039dd0ebc343f1b4ee1efac2bf3cf55a5b9af" ], "author": { "name": "Manik Bindlish", "email": "manikbindlish19@gmail.com", "time": "Mon Oct 16 04:50:34 2017 +0000" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Oct 28 23:11:43 2017 +0000" }, "message": "Cover more \u0027floating ips\u0027 APIs for policy tests\n\nChange-Id: Ide1ed1dab738a273b6776f52378db9172bc88f08\n" }, { "commit": "a1b039dd0ebc343f1b4ee1efac2bf3cf55a5b9af", "tree": "e39e4afe5039be2a5f74ddc0db24fbfd5431e00c", "parents": [ "b58096308fc6258085170749d3ce8f9361ca8f14", "c6f7e2269c0c1b5f76cbe983f9784f7db95b100f" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Sat Oct 28 20:58:22 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Sat Oct 28 20:58:22 2017 +0000" }, "message": "Merge \"Rename base.rebuild_server to base.recreate_server\"" }, { "commit": "21db8fca4a06b8bf799acc2fa0c03672242827d9", "tree": "8a8bf43d50938e0714fefe7ffac064192ab0caf8", "parents": [ "d35e8adef5b2255552c7f237420a7f348b8e6786", "4fb116ee4ae283e5993862367e7f81053a223740" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Oct 17 04:45:47 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Oct 17 04:45:47 2017 +0000" }, "message": "Merge \"Add Show \u0027 os-attach-interfaces \u0027 policy tests\"" }, { "commit": "c6f7e2269c0c1b5f76cbe983f9784f7db95b100f", "tree": "6e7213eae2f332d2611320ddaaba1723bd5a28a0", "parents": [ "6dc6040afd72561169aad27abd6ccba65523f932" ], "author": { "name": "zhu.fanglei", "email": "zhu.fanglei@zte.com.cn", "time": "Thu Oct 12 15:25:27 2017 +0800" }, "committer": { "name": "zhufl", "email": "zhu.fanglei@zte.com.cn", "time": "Tue Oct 17 00:53:50 2017 +0000" }, "message": "Rename base.rebuild_server to base.recreate_server\n\nIn https://review.openstack.org/#/c/503515/, compute.base.\nrebuild_server will be renamed as recreate_server to\ndistinguish from servers_client.rebuild_server, so this\nis to change the helper name in tempest plugin accordingly.\n\nDepends-on: I1589750870dff1a2681192e2f3d151ef18bf4d2a\nChange-Id: I142ef812ef56595e8b0c64f1c1d4fe52342ea791\n" }, { "commit": "4fb116ee4ae283e5993862367e7f81053a223740", "tree": "70334e46ed57f545e3b2eb0e7bfed4a72b84e76f", "parents": [ "8849bc2199b75728e9690ba3479c0fdca0ccd67f" ], "author": { "name": "shubhendu", "email": "shubhendu.poothia@nectechnologies.in", "time": "Mon Oct 16 06:02:24 2017 +0530" }, "committer": { "name": "shubhendu", "email": "shubhendu.poothia@nectechnologies.in", "time": "Mon Oct 16 06:05:10 2017 +0530" }, "message": "Add Show \u0027 os-attach-interfaces \u0027 policy tests\n\nChange-Id: Ic6b2b8530b7f736a97270c1d278f2563719d0e53\n" }, { "commit": "d35e8adef5b2255552c7f237420a7f348b8e6786", "tree": "42ce5bb4e1fb364b8b01304ce8ee23ca1f21a805", "parents": [ "8849bc2199b75728e9690ba3479c0fdca0ccd67f" ], "author": { "name": "akhiljain23", "email": "akhil.jain@nectechnologies.in", "time": "Sun Oct 15 20:47:23 2017 +0530" }, "committer": { "name": "akhiljain23", "email": "akhil.jain@nectechnologies.in", "time": "Sun Oct 15 20:50:46 2017 +0530" }, "message": "Skip floating IPs tests with new config options\n\nTempest patch Iedc3c7f9d045408f54d94c34b478fb1b28b593c9 added\nthe new config options to enable/disable the floating ips support in cloud.\n\nPatrole floating IPS tests also should consider that config options to\ndisable those tests.\n\nChange-Id: I5a57410342d2503f0e9fc7f7777df9d14ceb8f92\n" }, { "commit": "8849bc2199b75728e9690ba3479c0fdca0ccd67f", "tree": "7bac5092a2a2a9cbf3d07095fe6a28c8514968c4", "parents": [ "6dc6040afd72561169aad27abd6ccba65523f932", "d2f9f6ed5cd01181a5792befc855e181e2132b1b" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Fri Oct 13 22:30:40 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Oct 13 22:30:40 2017 +0000" }, "message": "Merge \"Use Tempest decorators in tempest.common.utils\"" }, { "commit": "6dc6040afd72561169aad27abd6ccba65523f932", "tree": "fda90d7a141b828edf7e3b4aa5bca796e40eb390", "parents": [ "03a3d878d02b1050a4fb6d0a9431171b9d40be55", "c0188efba4c908b0a9c305b3c6669eefd14a7d75" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu Oct 05 22:02:27 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Oct 05 22:02:27 2017 +0000" }, "message": "Merge \"Clean up identity base class resources via addClassResourceCleanup\"" }, { "commit": "03a3d878d02b1050a4fb6d0a9431171b9d40be55", "tree": "ba75968a59eba3dbfd40f0fb9e48ea00d4020e1d", "parents": [ "2cb5da9c397a029931d53a527ea65b7cd94e5bf1", "0dd58e79879722f18491213e9384c6edf6bdd54a" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu Oct 05 21:59:28 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Oct 05 21:59:28 2017 +0000" }, "message": "Merge \"Clean up network class resources via addClassResourceCleanup\"" }, { "commit": "d2f9f6ed5cd01181a5792befc855e181e2132b1b", "tree": "f46b1ea21740e01bd2a6be812828b918b9ab9672", "parents": [ "7a9b3e27619d16f6ad7c129b08ff9b9fac087b9f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Aug 27 00:59:13 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Oct 04 02:11:11 2017 +0100" }, "message": "Use Tempest decorators in tempest.common.utils\n\nThis patch uses the decorators in tempest.common.utils instead\nof the ones in tempest.test as they have been deprecated in [0].\n\n[0] Ibd52153d00b8e60fb8c89e38d94e358ddc787251\n\nChange-Id: Ib725e9d9fd087f75586daaafbfdb9aba49bdd5c6\n" }, { "commit": "c0188efba4c908b0a9c305b3c6669eefd14a7d75", "tree": "f208107d5ca0bd04c5a3401fb3effe41cc97d876", "parents": [ "7a9b3e27619d16f6ad7c129b08ff9b9fac087b9f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Oct 04 02:06:36 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Oct 04 02:06:36 2017 +0100" }, "message": "Clean up identity base class resources via addClassResourceCleanup\n\nThis PS cleans up identity base class resources via\naddClassResourceCleanup.\n\nChange-Id: If855b67414298d4c43c57bfaa9019d39ace7776f\n" }, { "commit": "2cb5da9c397a029931d53a527ea65b7cd94e5bf1", "tree": "cc0adbf3cf25919db43de94140150013d6c6b163", "parents": [ "7a9b3e27619d16f6ad7c129b08ff9b9fac087b9f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Oct 04 02:02:28 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Oct 04 02:02:28 2017 +0100" }, "message": "Clean up image resource types class resources via addClassResourceCleanup\n\nThis patch cleans up test_image_resource_types_rbac class resources\nvia addClassResourceCleanup.\n\nChange-Id: I99298fac3060c4affe5f04e8068b70c047aa39eb\n" }, { "commit": "0dd58e79879722f18491213e9384c6edf6bdd54a", "tree": "01caefbe7596a32d13747a25f1cd7094bcf8a294", "parents": [ "d1a72df9c9d94d4756cc0768d672a9a0b489609d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Oct 02 03:14:51 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Oct 04 00:17:59 2017 +0000" }, "message": "Clean up network class resources via addClassResourceCleanup\n\nThis PS cleans up network class resources via addClassResourceCleanup.\n\nChange-Id: Ifc1679eb5ae7a5fc2304506929cac2b86b7b8ead\n" }, { "commit": "7a9b3e27619d16f6ad7c129b08ff9b9fac087b9f", "tree": "ff973cd76ee9d372ad1ad768084e301666e0dff5", "parents": [ "21ab97e47db13227ccb68b8394a9d15036b69561", "e22ed5a098718ef62751d8c5c7f70cfe0251b75b" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Tue Oct 03 08:10:06 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Oct 03 08:10:06 2017 +0000" }, "message": "Merge \"Clean up namespace class resources via addClassResourceCleanup\"" }, { "commit": "e22ed5a098718ef62751d8c5c7f70cfe0251b75b", "tree": "1d5bc513bcd5adf8ed6d5329c16ea97db5be3159", "parents": [ "d1a72df9c9d94d4756cc0768d672a9a0b489609d" ], "author": { "name": "Madhuri Kumari", "email": "madhuri.rai07@gmail.com", "time": "Mon Oct 02 13:00:07 2017 +0530" }, "committer": { "name": "Madhuri Kumari", "email": "madhuri.rai07@gmail.com", "time": "Mon Oct 02 13:01:37 2017 +0530" }, "message": "Clean up namespace class resources via addClassResourceCleanup\n\nThis patch cleans up namespace class resources via addClassResourceCleanup.\n\nChange-Id: I4507b56856f20bfc1adbfdaafc92a9ff66ff6f4b\n" }, { "commit": "21ab97e47db13227ccb68b8394a9d15036b69561", "tree": "16384d9fdd9923c4c19c53598379e710bdab7975", "parents": [ "d1a72df9c9d94d4756cc0768d672a9a0b489609d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Oct 02 03:20:04 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Oct 02 03:20:04 2017 +0100" }, "message": "Clean up volume class resources via addClassResourceCleanup\n\nThis PS cleans up volume class resources via addClassResourceCleanup.\n\nChange-Id: Ia22813f734927c2aa2d5828603ce795ea29a8c8e\n" }, { "commit": "906623ed3920860364059243867a22c5306ffe4c", "tree": "29f54d2558763d1a49f93dbdf18c845efb9f0431", "parents": [ "d1a72df9c9d94d4756cc0768d672a9a0b489609d" ], "author": { "name": "Sean Pryor", "email": "spryor@redhat.com", "time": "Wed Aug 23 15:15:04 2017 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Sep 29 09:47:45 2017 +0100" }, "message": "Image create v1/v2 compatible in compute test_images_rbac\n\nThis is due to glance v1 not accepting the kwarg ``name``, thus on\nsystems with both a v1 and v2 endpoint configured, setUpClass will\nfail.\n\nCo-Authored-By: Felipe Monteiro \u003cfelipe.monteiro@att.com\u003e\nChange-Id: I636e8a72210524840917e147e125ed52ed390bbe\n" }, { "commit": "d1a72df9c9d94d4756cc0768d672a9a0b489609d", "tree": "815fe26ca63e33ea95407a4a688fdfaaa0d25763", "parents": [ "63881a9bd34d75f58e46dde4b4c89cb17d3e5fac", "bc6c682b66688b1aab38a75df748b2f08cf66977" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Sep 29 02:35:57 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Sep 29 02:35:57 2017 +0000" }, "message": "Merge \"Clean up compute class resources via addClassResourceCleanup\"" }, { "commit": "63881a9bd34d75f58e46dde4b4c89cb17d3e5fac", "tree": "f62e62a67198b4d46ae2f5a23ef61858891f2214", "parents": [ "b18a3f6524f64cbc9c650237fe1220585f653294", "1a9cd96273f3fdb56de0ac2e9461b3c895d2ae69" ], "author": { "name": "Zuul", "email": "zuul@review.openstack.org", "time": "Fri Sep 29 02:35:52 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Sep 29 02:35:52 2017 +0000" }, "message": "Merge \"Clean up test_server_actions_rbac\"" }, { "commit": "1a9cd96273f3fdb56de0ac2e9461b3c895d2ae69", "tree": "c85cc9cd70ed5505f164dda6e4cd489f3f34855f", "parents": [ "1171b6fb1b6fae40817bf1a2cb5d52bad4a73304" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 27 03:38:57 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 27 03:38:57 2017 +0100" }, "message": "Clean up test_server_actions_rbac\n\nThis PS removes unnecessary helpers from test_server_actions_rbac\nthat are only used once. Helpers that are used at least twice\nare kept.\n\nHelpers were renamed to drop the \"_test\" prefix as the helpers\nthemselves do not test anything, but rather invoke server\nactions.\n\nChange-Id: Ia9f83517b0ed9cf93af729c856e0adcc68da9314\n" }, { "commit": "b18a3f6524f64cbc9c650237fe1220585f653294", "tree": "c72561bbe6de9290581337c1ed7214415ec4cf5e", "parents": [ "f7e74ac95c04f19fd0468a69ec7830acc3226193" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Sep 19 04:25:51 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 27 03:31:32 2017 +0100" }, "message": "[flake8] Enable extra, optional hacking checks\n\nUpdate test-requirements.txt to use latest version of:\n * hacking\n\nEnable the following off-by-default checks:\n * [H203] Use assertIs(Not)None to check for None.\n * [H204] Use assert(Not)Equal to check for equality.\n * [H205] Use assert(Greater|Less)(Equal) for comparison.\n * [H210] Require ‘autospec’, ‘spec’, or ‘spec_set’ in\n mock.patch/mock.patch.object calls\n * [H904] Delay string interpolations at logging calls.\n\nMade necessary unit test changes to work with these checks.\n\nChange-Id: I9db3445caa2883563fd7271d6bf0b24800e06c01\n" }, { "commit": "f7e74ac95c04f19fd0468a69ec7830acc3226193", "tree": "ac6b91377d5be4962f5722b840e30cfcc3f8017b", "parents": [ "1171b6fb1b6fae40817bf1a2cb5d52bad4a73304", "0f86ca422a6bd2d1a6edc76e8496426262128edf" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed Sep 27 01:22:51 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Sep 27 01:22:51 2017 +0000" }, "message": "Merge \"RBAC tests for extended server attributes policies\"" }, { "commit": "bc6c682b66688b1aab38a75df748b2f08cf66977", "tree": "6766a509ddeab67630c328ded12770547de3db4a", "parents": [ "1171b6fb1b6fae40817bf1a2cb5d52bad4a73304" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Sep 26 23:50:51 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 27 00:23:46 2017 +0000" }, "message": "Clean up compute class resources via addClassResourceCleanup\n\nThis PS cleans up compute class resources via addClassResourceCleanup.\n\nChange-Id: I14a2152ac48362495a2a705d3b415ed1449b381a\n" }, { "commit": "0f86ca422a6bd2d1a6edc76e8496426262128edf", "tree": "281d701010fd2992f0b4169f8f08fd19681e5ad2", "parents": [ "a63f854f6392c554c0095862ab766ee09be14cfd" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 29 21:30:52 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Sep 26 16:48:30 2017 +0000" }, "message": "RBAC tests for extended server attributes policies\n\nThis commit adds RBAC tests for extended server attributes\npolicies, the documentation for which can be found here:\n\nhttps://github.com/openstack/nova/blob/master/nova/policies/extended_server_attributes.py\n\nTests for both APIs that enforce each policy were added.\n\nChange-Id: I4150bcff934f1386ba8947d271289b790900ce2e\nImplements: blueprint rbac-tests-for-extended-server-attributes\n" }, { "commit": "1171b6fb1b6fae40817bf1a2cb5d52bad4a73304", "tree": "5b9ece0cdcc2ec252c89cd1ef493df947621c9a9", "parents": [ "a63f854f6392c554c0095862ab766ee09be14cfd" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Aug 31 04:27:45 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Sep 26 16:47:24 2017 +0000" }, "message": "Add os-create-backup compute RBAC test\n\nAdd RBAC test for creating a server backup, providing coverage for the\npolicy action: \"os_compute_api:os-create-backup\".\n\nThis patch also:\n - Removes unnecessary setUp from ServerActionsV216RbacTest\n since it does a rebuild server in case something bad\n happened to the server -- but there is only 1 test case\n in the class.\n - Use data_utils.rand_name to create a fake host name for\n evacuate server test to further randomize host name to\n guarantee 404 is thrown which is the desired outcome.\n\nChange-Id: Ia5f95deb7b9495345db50c0569885a17b22984f6\nDepends-On: Ib97e65cca468a09bbeaf68fcfe0e8192674a481e\n" }, { "commit": "a63f854f6392c554c0095862ab766ee09be14cfd", "tree": "a25141edf370353078690104f2431b7234376b46", "parents": [ "bb3c257f77e52bf9da2f0822d40a2a716275bd8f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Sep 22 07:06:26 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Sep 26 05:54:57 2017 +0000" }, "message": "[Gate Fix] Fix AttributeError in ServerActionsRbacTest\n\nThis PS fixes an AttributeError being raised in ServerActionsRbacTest\n[0] due to a recent Tempest change [1]. Besides, the volume\ncreation was being done manually in Patrole, when the volume\nshould have been created using Tempest\u0027s base helper for creating\na volume.\n\nThis same issue applies with `test_create_image_volume_backed` in\nthe same class [2] due to a recent Tempest change [3], and besides\nthat, the previous way of spinning up a volume-backed server did\nnot leverage Tempest\u0027s helpers, which this PS corrects.\n\n[0] http://logs.openstack.org/06/466806/8/check/gate-tempest-dsvm-patrole-admin-ubuntu-xenial/c186718/console.html#_2017-09-22_01_07_10_242418\n[1] https://review.openstack.org/#/c/498888/\n[2] http://logs.openstack.org/31/506531/3/check/gate-tempest-dsvm-patrole-member-ubuntu-xenial/01bfbc6/console.html#_2017-09-22_07_08_39_483859\n[3] https://review.openstack.org/#/c/498886/\n\nChange-Id: I6f93dc6961844e2154d348790cad3fde77b9d218\n" }, { "commit": "bb3c257f77e52bf9da2f0822d40a2a716275bd8f", "tree": "7fff853042d8bd4556dd214f4ee3d364a74139e0", "parents": [ "88cd29969d65c8ffc157b883249f0b26641ae42d", "2466aeb15e0e08f66edfe81f4a90bf2094a51182" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed Sep 20 00:54:07 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Sep 20 00:54:07 2017 +0000" }, "message": "Merge \"Improve test coverage for flavor_access nova policies\"" }, { "commit": "9c0a0aa729cd456f2b8c3f3d59c629df18d79026", "tree": "af46102b79b551331a5bf5e2f495d31b7ef1db18", "parents": [ "384bc468a1e9176be6b6adee9739d31dc898acdd", "5ed98d78a023844ac44decdd10ae5a7964b036c5" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Tue Sep 19 16:18:15 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Sep 19 16:18:15 2017 +0000" }, "message": "Merge \"Clean up rbac_rule_validation unit tests\"" }, { "commit": "384bc468a1e9176be6b6adee9739d31dc898acdd", "tree": "3150c80db632481172703921328d7c5bc4c6089a", "parents": [ "0f593351d428dff4e5d4c8a0ba746b610b167b04", "4af0345627ad9201b91e8bccf62ae93fbcec57ff" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Tue Sep 19 16:18:05 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Sep 19 16:18:05 2017 +0000" }, "message": "Merge \"Volume test for backup:backup_project_attribute\"" }, { "commit": "0f593351d428dff4e5d4c8a0ba746b610b167b04", "tree": "4f7f0497fb897bc643f676ac46474af888c04bf5", "parents": [ "6b2fbfecda1f2659edac40fcc3233a60f38b9a86", "72b55d9db79ac1e38f33cce28fe7af5f23d2ff47" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Tue Sep 19 16:09:10 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Sep 19 16:09:11 2017 +0000" }, "message": "Merge \"Add missing v3 volume tests for which v2 tests exist\"" }, { "commit": "2466aeb15e0e08f66edfe81f4a90bf2094a51182", "tree": "65f2a6e5811c20843a11550708d23acb3f2e6ebd", "parents": [ "b3939a8f2a6712d73dd99ab734948cf41b5e7cf0" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Sep 01 20:33:50 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Sep 15 14:38:22 2017 +0000" }, "message": "Improve test coverage for flavor_access nova policies\n\nThis commit improves test coverage for flavor_access policies, achieving\nthe the most amount of coverage in Patrole for these policies that is\ncurrently possible.\n\nThe base policy \"os_compute_api:os-flavor-access\" is covered by\n4 separate APIs, but currently Patrole only tests 1 one of those\nAPIs. This commit extends the existing tests to achieve almost\nfull test coverage, with the exception of this endpoint:\n\n POST /flavors\n\nAt present, it is impossible to test os-flavor-access for that\nendpoint since it also enforces os-flavor-manage:create\n(or os-flavor-manage) both of which require admin.\n\nIn addition, this commit fixes test_show_flavor always passing.\nWhile policy enforcement happens in Nova when calling\n`self.flavors_client.show_flavor`, no Forbidden exception\nis raised following failure. Instead, the attribute\n\"os-flavor-access:is_public\" is injected into the response\nbody following successful policy enforcement. So Patrole\nchecks for the attribute and, if not found, raises an\nappropriate RbacMalformedResponse exception.\n\nReference: https://github.com/openstack/nova/blob/master/nova/policies/flavor_access.py\n\nChange-Id: Icaf516f996ec088ce48bbfc768116b2d6994c336\n" }, { "commit": "b3939a8f2a6712d73dd99ab734948cf41b5e7cf0", "tree": "4dfacd136d385d8e6921b4235fceb74e043ea089", "parents": [ "6f4bc6795745e002e27b098125ca7e48ea47ad7e" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Sep 11 17:27:40 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Sep 14 08:06:52 2017 +0100" }, "message": "[Gate fix] Change expected_error_code to 403 for some subnetpool tests\n\nThis change corrects some expected_error_code\u0027s for subnetpool tests.\nThese endpoints actually raise a 403, not a 404 (example: [0]):\n\n - test_update_subnetpool_is_default\n - test_delete_subnetpool\n\nThis commit also corrects resource_cleanup in\ntest_image_resource_types_rbac which wrongly calls super\nresource_setup in resource_cleanup.\n\nThese changes have been combined to unblock the gate.\n\n[0] http://logs.openstack.org/80/496080/9/check/gate-tempest-dsvm-patrole-member-ubuntu-xenial/f9cde4d/console.html#_2017-09-11_14_55_54_024285\n\nChange-Id: If4399c5f67058925c800bd2ce32c19bf6657d9b5\n" }, { "commit": "6f4bc6795745e002e27b098125ca7e48ea47ad7e", "tree": "8d1c1b522d69db74ba38ef0450c5296b3f98ad85", "parents": [ "be3fac39f8ee43d09704a5e59f6aee61623045c0", "72430755e2f2054badc1d8ebaabc96d2b6ac9cae" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu Sep 07 17:12:27 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Sep 07 17:12:27 2017 +0000" }, "message": "Merge \"RBAC tests for key_name in response\"" }, { "commit": "72430755e2f2054badc1d8ebaabc96d2b6ac9cae", "tree": "b0b6ac7fa070d3508289037a1e96cef1a8f91008", "parents": [ "2a4bc7e28a3a1a18dbce0d537e97eb6d4d4a5ff6" ], "author": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Fri Aug 25 16:01:10 2017 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 06 20:41:42 2017 +0000" }, "message": "RBAC tests for key_name in response\n\nAdds tests for os-keypairs that looks for \"key_name\" in the\nresponse body from a call to list or show server. Also adds a\nskip exception to test_keypairs_rbac if os-keypairs extension\nis not enabled.\n\nImplements bp:rbac-tests-for-key-name-in-response\n\nChange-Id: I2dc5332bfd59ea7c7a0e4a32b69d94ccd19ffaac\n" }, { "commit": "08b267d081d98aab0090eed9715b630e16fdd005", "tree": "b994479820ba41fce11f0d9c267013de15dacf17", "parents": [ "789d6b47e2508512f420afd730039d683e400bb0", "e0e2edc1e1eb6ec990cd2c56bd4a41091493df82" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed Sep 06 04:13:47 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Sep 06 04:13:47 2017 +0000" }, "message": "Merge \"Remove a few tests from multinode gate\"" }, { "commit": "789d6b47e2508512f420afd730039d683e400bb0", "tree": "0512b4f17c764670b59601f63521ba777c31ebaf", "parents": [ "45fffa50e0020d4a34b1c3eac4b553522bf5fb35", "bf58a7fe3a2e03a60d4142b28b831663ddaf7b68" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed Sep 06 03:13:13 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Sep 06 03:13:13 2017 +0000" }, "message": "Merge \"Fix flavor_rxtx_rbac\"" }, { "commit": "5ed98d78a023844ac44decdd10ae5a7964b036c5", "tree": "ec3162a96784f8cd4045a50ffc43b4f53aec3278", "parents": [ "2a4bc7e28a3a1a18dbce0d537e97eb6d4d4a5ff6" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Sep 01 20:30:25 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Sep 06 03:24:19 2017 +0100" }, "message": "Clean up rbac_rule_validation unit tests\n\nThis patch simply makes the unit tests for rbac_rule_validation\ncleaner, easier to read, and thus easier to maintain.\n\nChange-Id: I9205909ff376ce94523b89499df415e9481a9e37\n" }, { "commit": "2a4bc7e28a3a1a18dbce0d537e97eb6d4d4a5ff6", "tree": "2f28e06067495507d6db18a3693dfac600da7dfb", "parents": [ "00f779fc61d6eb9c365cab6e053515430578191f", "88a5bab82076e9f783f9a4857eafd1a1cf242bbc" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu Aug 31 18:29:09 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Aug 31 18:29:09 2017 +0000" }, "message": "Merge \"Rename rbac_policy_parser to policy_authority\"" }, { "commit": "4af0345627ad9201b91e8bccf62ae93fbcec57ff", "tree": "815de5278adb031a580bfee2a427b5dde768329f", "parents": [ "11b023243f5d58a69f9f6fe65db44bd8cea98721" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 15 21:49:49 2017 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Aug 31 14:35:27 2017 +0000" }, "message": "Volume test for backup:backup_project_attribute\n\nAdd RBAC test for \"backup:backup_project_attribute\" which verifies\nthat the \"os-backup-project-attr:project_id\" attribute appears in\nthe response body only policy enforcement succeeds.\n\nThis commit specifically:\n * adds the test specified above\n * adds a class-wide volume shared by test_show_backup and\n test_show_backup_project_attribute tests (i.e. moved\n volume creation for these tests from setUp into\n resource_setup)\n\nChange-Id: I751275633a3b6f20e67894fceb826f0f97a62b46\n" }, { "commit": "88a5bab82076e9f783f9a4857eafd1a1cf242bbc", "tree": "d87460ede44f239734fe96a62181d28e9ff9d653", "parents": [ "7f8993fe3c5edb9157d696f1e0b5b97f37f31032" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Aug 31 04:00:32 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Aug 31 04:00:45 2017 +0100" }, "message": "Rename rbac_policy_parser to policy_authority\n\nThis change is a follow-up to commit\n\nI8ba89ab5e134b15e97ac20a7aacbfd70896e192f\n\nwhich introduced an abstract class from which (previously)\nrbac_policy_parser and requirements authority inherit, providing\nrbac_rule_validation with 2 ways of validating RBAC.\n\nFor the sake of naming consistency, rbac_policy_parser is renamed\nto policy_authority. This naming scheme is better because\n\"policy parser\" is implementation-specific and doesn\u0027t convey\nwhat the file (and class name) do from a high-level perspective.\n\nBecause this file is only used internally to Patrole, it can be\nchanged without backward-compatibility concerns.\n\nThis commit also includes documentation for the policy authority\nmodule and the rbac_rule_validation module.\n\nChange-Id: Ie09fc2d884f9211244b062fdd5fe018970c2bb2d\n" }, { "commit": "5e9656d375f5d2a49fa7cc3459c126b76ce9c0e5", "tree": "0c12a2fb9346ab4e8208a7011a29f11ec240f781", "parents": [ "c545832800e2e8e9f607a446d9adc48d6306dff1", "3983d1321031469b7e750c059498c172676e8eb6" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed Aug 30 21:00:45 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Aug 30 21:00:45 2017 +0000" }, "message": "Merge \"RBAC tests for os-extended-volumes policies\"" }, { "commit": "c545832800e2e8e9f607a446d9adc48d6306dff1", "tree": "3aa2b28599e012864caed2e792b4629d5ccc29a1", "parents": [ "2b441901c347f912c3593d2482de902191c2e1f7", "c27a62fb21ee638dcaade901bddcffab43d4d815" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed Aug 30 21:00:40 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Aug 30 21:00:40 2017 +0000" }, "message": "Merge \"Fix router tests expecting wrong error code\"" }, { "commit": "2b441901c347f912c3593d2482de902191c2e1f7", "tree": "16eb4ddb8bbdeb07b6a9e524cb4ca5e8785a760b", "parents": [ "7f8993fe3c5edb9157d696f1e0b5b97f37f31032", "146735df7ae0b8483b820c60f13b871d93ffe16c" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed Aug 30 20:44:17 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Aug 30 20:44:17 2017 +0000" }, "message": "Merge \"Test coverage for compute flavor_manage policies\"" }, { "commit": "bf58a7fe3a2e03a60d4142b28b831663ddaf7b68", "tree": "d53259e8001193da2e2ccdd78700c944522ced5e", "parents": [ "9db9a1b0cb5bc63af7bbdf6ec543622cac3c64f1" ], "author": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Fri Aug 25 14:21:49 2017 -0400" }, "committer": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Tue Aug 29 14:30:31 2017 -0400" }, "message": "Fix flavor_rxtx_rbac\n\nUpdates flavor_rxtx to more thoroughly test policy enforcement\nby\n- making use of RbacMalformedResponse to ensure rxtx_factor\n is included in response body\n- adding new flavor_rxtx tests\n\nCurrently, POST /flavors is not tested as that action also\nenforces os-flavor-manage: create, which is admin-only by\ndefault and would therefore fail due to conflicting policy\nrestrictions. This test will be added once multi-policy\nsupport is available.\n\nChange-Id: I7fb35212fc6bb817a2b04077c983865e1191f214\nCloses-Bug: #1712725\n" }, { "commit": "e0e2edc1e1eb6ec990cd2c56bd4a41091493df82", "tree": "4fa5713664a79584266e19319e808762611c1291", "parents": [ "9db9a1b0cb5bc63af7bbdf6ec543622cac3c64f1" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Aug 21 20:47:47 2017 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Aug 26 17:15:23 2017 +0000" }, "message": "Remove a few tests from multinode gate\n\nThe multinode gate is reserved for tests that require multiple nodes\nlike server migration tests. It is also used for slow-running\ntests that take a while to execute (20-30+ seconds) to better\nparallelize tests in the gates.\n\nHowever, 3 tests currently meet neither of these criteria and are\nhence being moved to the voting gates:\n\n * test_create_security_group_for_server [6.492102s]\n * test_remove_security_group_from_server [6.525612s]\n * test_volume_upload_public [4.558483s]\n\nChange-Id: I24c65839692264f30a1494c051eec5fb72eb78a6\nSource: http://logs.openstack.org/68/494368/12/check/gate-tempest-dsvm-patrole-multinode-member-ubuntu-xenial-nv/32ae39c/console.html\n" }, { "commit": "7f8993fe3c5edb9157d696f1e0b5b97f37f31032", "tree": "142ed239840fd76b629343d96e776a08b7900cd1", "parents": [ "472b84c9bcf80e352caa4e652cd47571489fb59a" ], "author": { "name": "Sean Pryor", "email": "spryor@redhat.com", "time": "Mon Aug 14 12:53:17 2017 -0400" }, "committer": { "name": "Sean Pryor", "email": "spryor@redhat.com", "time": "Fri Aug 25 23:12:08 2017 -0400" }, "message": "Add a per-test log\n\nThis patch adds a new per-test logging feature to Patrole\nTo accomplish this, it adds two new config variables\n\nThe logging now prints a log message containing the results of each RBAC\ntest to a separate log file, as well as to the normal\ntempest.log file. This message is of the form:\n[Service] \u003cnova, neutron, etc\u003e\n[Test] \u003cname of the test\u0027s method\u003e\nfollowed by either the result of the test as Allowed/Denied/Error, or\nthe expected result (from oslopolicy) and then the actual result\n\nThere are two new config variables that control this, added in a new\nconfig group called patrole_log:\nenable_reporting - defaults to True, which enables this new logging\nfunctionality\nreport_log_name - defaults to patrole.log, controls the name of the log\nthe output is written to.\nreport_log_path - Defaults to the local directory, path (relative or\nabsolute) where to store the log\n\nChange-Id: Iff2176f1a7c7d10f78b96d748f1d70b222fd5072\n" }, { "commit": "3983d1321031469b7e750c059498c172676e8eb6", "tree": "7379a5095058c76726bfe870fedba0e303dc13d3", "parents": [ "d6bde6096519a9fb6878a4fafb592c039420d422" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 01 01:51:07 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Aug 25 05:03:49 2017 +0000" }, "message": "RBAC tests for os-extended-volumes policies\n\nThis commit adds RBAC tests for os-extended-volumes\npolicies, the documentation for which can be found here:\n\nhttps://github.com/openstack/nova/blob/master/nova/policies/extended_volumes.py\n\nTests for both APIs that enforce each policy were added.\n\nChange-Id: I6669f420743a3fee6470a7bb4ca5f1353a0e9696\nImplements: blueprint rbac-tests-for-compute-extended-volumes\nDepends-On: I1c14646dc8d102cd093be09833c23846781e5e73\n" }, { "commit": "c27a62fb21ee638dcaade901bddcffab43d4d815", "tree": "c4cb250a32813d65241c10204282c9639321a8dc", "parents": [ "bc39ee8ec61eec7ec5924cd48801f14d5b28e657" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Aug 24 23:01:34 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Aug 24 23:01:34 2017 +0100" }, "message": "Fix router tests expecting wrong error code\n\nCurrently tests in test_router_rbac expect a 404 for some endpoints\nthat actually raise a 403 instead. The reason why the tests currently\npass in the gates for admin and Member is because the associated\npolicies are admin_or_owner -- meaning that the 403 or 404 is never\nraised, causing the tests to silently pass. But if elevated permissions\nare used then a 403 -- not a 404 -- is raised.\n\nThe except is for the test \"test_show_router\" which enforces `get_router`\nwhich does raise a 404, so that is left unchanged.\n\nChange-Id: If37e0b15137d1421f9d16fc515068628ab87768f\n" }, { "commit": "9db9a1b0cb5bc63af7bbdf6ec543622cac3c64f1", "tree": "fb366131be033dd90adc3d329bf39bf01bcb8847", "parents": [ "25b12810f15d4c8b56f680dfcfaf76611196a3ae", "dc73cff02ab484f901876bb42cfdd4d1f266432b" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu Aug 24 21:54:34 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Aug 24 21:54:34 2017 +0000" }, "message": "Merge \"Remove identity v3 change_password test\"" }, { "commit": "25b12810f15d4c8b56f680dfcfaf76611196a3ae", "tree": "2e7f6845949126dc375ffab928f629df2639dcb1", "parents": [ "bc39ee8ec61eec7ec5924cd48801f14d5b28e657" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Aug 24 17:21:56 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Aug 24 17:22:05 2017 +0100" }, "message": "[TrivialFix] Move security group tests into correct test file\n\nThis commit moves security group tests currently in test_server_rbac\ninto test_security_groups_rbac as that is the logical place\nfor the tests. And this commit renames the deprecated security\ngroups test class to avoid a name conflict with the non-deprecated\ntest class.\n\nChange-Id: Iae32d9bc7e22e39415e498e44f0da4f2711dc550\n" }, { "commit": "bc39ee8ec61eec7ec5924cd48801f14d5b28e657", "tree": "8312e40bacbe8fb362b2c0d5bdf75bea9e9f3b3b", "parents": [ "9d086ab44610799ad8203926d1b3e6fdd29a6616" ], "author": { "name": "ghanshyam", "email": "ghanshyammann@gmail.com", "time": "Thu Aug 24 04:57:54 2017 +0000" }, "committer": { "name": "Ghanshyam Mann", "email": "ghanshyammann@gmail.com", "time": "Thu Aug 24 08:27:48 2017 +0000" }, "message": "Do not use test.get_service_list()\n\nCurrently \u0027network\u0027 service is always True in test.get_service_list()\nS check for the same is not much of use.\nAlso Tempest is moving the get_service_list from test.py to utils.\n- Ibd52153d00b8e60fb8c89e38d94e358ddc787251\n\nTill that movement is done, let\u0027s comment the usage of get_service_list\nand if needed to check \u0027network\u0027 service availability, then get_service_list\ncan be used from new location.\n\nChange-Id: I8edd8da695698db03a752dcfedbd290facfa8fca\n" }, { "commit": "dc73cff02ab484f901876bb42cfdd4d1f266432b", "tree": "a5c80693d03f677c61c05a5176aaac0997e60af5", "parents": [ "d6bde6096519a9fb6878a4fafb592c039420d422" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 22 22:21:50 2017 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 22 22:21:50 2017 -0400" }, "message": "Remove identity v3 change_password test\n\nThis commit removes the v3 change_password test because\nit is currently getting skipped [0], because the policy\naction does not exist in [1] and the API where it would\nbe enforced does not enforce it [2].\n\nSo the correct approach is to remove the test. Also renames\nthe class name to drop \"Admin\" substring as there is nothing\nabout this test class that requires admin credentials in any\nway.\n\n[0] http://logs.openstack.org/68/496068/4/check/gate-tempest-dsvm-patrole-admin-ubuntu-xenial/7069c22/console.html#_2017-08-23_00_50_18_947787\n[1] https://github.com/openstack/keystone/blob/master/keystone/common/policies/user.py\n[2] https://github.com/openstack/keystone/blob/4950c24bddaf98b79dfd9ee178ae1086cf48e322/keystone/identity/controllers.py#L279\n\nChange-Id: I90496d3969b1ef69316a2254754622679bca54b5\n" }, { "commit": "9d086ab44610799ad8203926d1b3e6fdd29a6616", "tree": "c382df8c6240ee29a20e5216e0c03ca55b63cd19", "parents": [ "d6bde6096519a9fb6878a4fafb592c039420d422" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Aug 21 22:49:39 2017 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 22 20:10:23 2017 -0400" }, "message": "Use create_test_server for attach volume server test\n\nThis commut uses create_test_server to clean up the\ntest test_create_server_attach_volume, which currently\nsuffers from a higher-than-usual failure rate. Example:\n\nThis commit also replaces manual volume creation with\n``create_volume`` helper function defined in Tempest\u0027s\nbase compute class.\n\nhttp://logs.openstack.org/47/496047/1/check/gate-tempest-dsvm-patrole-admin-ubuntu-xenial/2901c0f/console.html#_2017-08-22_01_40_22_359577\n\nChange-Id: If85279ff2f4ee7fad2b3d4c665398f699afc7b38\n" }, { "commit": "146735df7ae0b8483b820c60f13b871d93ffe16c", "tree": "4a88bcbb593036a55d90d6bf5891f5c750a1f61d", "parents": [ "d6bde6096519a9fb6878a4fafb592c039420d422" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Aug 21 23:38:19 2017 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Aug 22 12:51:46 2017 +0000" }, "message": "Test coverage for compute flavor_manage policies\n\nThis commit adds test coverage for the flavor_manage policies,\nwhich includes tests only for the non-deprecated policy actions:\n\n* \"os_compute_api:os-flavor-manage:create\"\n* \"os_compute_api:os-flavor-manage:delete\"\n\nThis commit also renames _create_flavor in rbac_base for compute\nmodule to be public since it is consumed by other files. It also\nadds a wait_for_resource_deletion call.\n\nChange-Id: I632235a1d81488ecc8fb1e92f801415a08c7e778\n" }, { "commit": "72b55d9db79ac1e38f33cce28fe7af5f23d2ff47", "tree": "76b5f13a942a3d7a97ae8440232c72ad9cec0bf4", "parents": [ "6315a252d29d35724be8c95834242590592de3d4" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Aug 21 17:45:09 2017 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Aug 21 20:37:46 2017 -0400" }, "message": "Add missing v3 volume tests for which v2 tests exist\n\nThis commit adds missing v3 volume tests for which corresponding\nv2 tests exist, and if the v2 API is also present in v3.\n\nThis commit is necessary for partially deprecating the v2 volume\nRBAC tests -- but before that can be done, we need to ensure\nthat v3 has at least the exact same coverage v2 does, plus\nadditional coverage for v3 APIs.\n\nThis commit specifically adds v3 tests for:\n - test_qos_rbac\n - test_volume_basic_crud_rbac\n - test_volume_hosts_rbac\n - test_volume_metadata_rbac\n\nThis commit also adds a missing RBAC test for showing a volume\nhost for both v2 and v3.\n\nDepends-On: I09ad8200f73273dae8e5d926939620b71d9210e8\nChange-Id: I443dfb8e1032ff327f03eb8e8b257df124ad6180\nPartially Implements: blueprint test-v3-volume-api-only\n" }, { "commit": "d6bde6096519a9fb6878a4fafb592c039420d422", "tree": "98df94c422485688b65ff6e6ee59da96fa46c8e9", "parents": [ "337e17a2f14e68373a1f19ad7d0e5720c1a7695b", "5f72954f121a5aa5f6bd378e2d013d2973297766" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Mon Aug 21 22:42:18 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Aug 21 22:42:18 2017 +0000" }, "message": "Merge \"RBAC tests for extended availability zone policies\"" }, { "commit": "337e17a2f14e68373a1f19ad7d0e5720c1a7695b", "tree": "cef4ab278333f11c0ef2a22c71184a8a675225ab", "parents": [ "620105c1165464e0d2e28b9350d6e3b07f392a2d", "b6a9c21424332d4e112d51e03158ea5ecb434e62" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Mon Aug 21 20:25:44 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Aug 21 20:25:44 2017 +0000" }, "message": "Merge \"Adds unit tests for hacking checks\"" }, { "commit": "5f72954f121a5aa5f6bd378e2d013d2973297766", "tree": "be3fb98ac07aa30bd1ac7e1b66f03b9a14951668", "parents": [ "620105c1165464e0d2e28b9350d6e3b07f392a2d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Jul 31 22:44:04 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Aug 21 20:17:57 2017 +0000" }, "message": "RBAC tests for extended availability zone policies\n\nThis commit adds RBAC tests for extended availability zone\npolicies, the documentation for which can be found here:\n\nhttps://github.com/openstack/nova/blob/master/nova/policies/extended_availability_zone.py\n\nTests for both APIs that enforce each policy were added.\n\nChange-Id: I36aad1ea7ef3c1418cd23fda8357132ac8bde559\nDepends-On: I1c14646dc8d102cd093be09833c23846781e5e73\n" }, { "commit": "620105c1165464e0d2e28b9350d6e3b07f392a2d", "tree": "90a4fbec0ecd906744b5666eef6fbf19e06e14cf", "parents": [ "6315a252d29d35724be8c95834242590592de3d4", "6056d6b996cb8471141d983797c82e323441ae8c" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Mon Aug 21 19:51:12 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Aug 21 19:51:12 2017 +0000" }, "message": "Merge \"Move some slow tests into the multinode gate\"" } ], "next": "6056d6b996cb8471141d983797c82e323441ae8c" }