)]}' { "log": [ { "commit": "03fd7903ee13e7145ab4bbff0a3afe47d5f387c8", "tree": "b3f57242b4091c75514c80aea7545bf74c3321c2", "parents": [ "dca00e8dd4564c836fc1fd12c6ec4dd0aaf96263", "17e9b49f4849d1e2900bf087d7c8b059c135b48b" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Fri Jun 02 15:05:23 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri Jun 02 15:05:23 2017 +0000" }, "message": "Merge \"Add rbac_utils is_admin helper method\"" }, { "commit": "dca00e8dd4564c836fc1fd12c6ec4dd0aaf96263", "tree": "20cc771e718ad76fc5c4b7e6b44dcb1f2382483f", "parents": [ "eeb271a21ef1bdcda060643b970ecff15c30b1a1" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Jun 01 19:33:01 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Jun 01 19:36:08 2017 +0100" }, "message": "Add RBAC test for communitize_image policy\n\nThis commit adds an RBAC test for communitize_image\npolicy, enforced via:\n\nPOST /v2/images with attribute visibility \u003d community [0]\n\n[0] https://github.com/openstack/glance/blob/b7c627ef68c303d4c3182c1a41b36185447039a3/doc/source/policies.rst\n\nChange-Id: Icf2f14f8240389b17da4b92f6f0df168746d06b2\n" }, { "commit": "17e9b49f4849d1e2900bf087d7c8b059c135b48b", "tree": "3f026d33e962adb7fd046e1622f78610a959529b", "parents": [ "eeb271a21ef1bdcda060643b970ecff15c30b1a1" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat May 27 05:45:20 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Jun 01 15:42:03 2017 +0000" }, "message": "Add rbac_utils is_admin helper method\n\nThis patch adds a helper method to rbac_utils.RbacUtils called\n``is_admin`` which returns True if the current RBAC test role\nis equal to the admin role defined in tempest.conf (i.e.\nCONF.rbac.rbac_test_role \u003d\u003d CONF.identity.admin_role). This\nmakes it easier to check this equivalence in a test by simply\nrunning:\n\n if self.rbac_utils.is_admin:\n do something\n\nChange-Id: I0efb005f90ac77449453f6b68a010ec64e7a03f7\n" }, { "commit": "eeb271a21ef1bdcda060643b970ecff15c30b1a1", "tree": "cb6c80394cfd120f87dd43c12ec8ce0196b607c8", "parents": [ "a44dddf13a6973d35f7bd81c6c3ad0a2550a72b9" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue May 30 20:26:01 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 31 21:06:38 2017 +0100" }, "message": "[Gate fix] Fix py35 gate due to incompatible import\n\nThe py35 gate is failing due to the same issue\nfor a few tests [0]: when creating an image with\nrandom bytes, six.moves.cStringIO is used, when\nthe compatible way is instead six.StringIO.\n\nThis commit also makes ``test_create_server_forced_host``\ncompatible with python3. Currently, the following error is thrown:\n\nTypeError: \u0027dict_keys\u0027 object does not support indexing\n\nThis commit wraps keys() with list() before indexing to fix\nthe error.\n\n[0] http://logs.openstack.org/51/462251/19/check/gate-tempest-dsvm-patrole-py35-member-ubuntu-xenial-nv/cdb7cdb/console.html\n\nChange-Id: I8728c2e68f99807b70bd566fd8e0b6b9caf871af\nCloses-Bug: #1689960\n" }, { "commit": "6e78dca90c506fad74300107a52e6335d39cc0d8", "tree": "78d41c794ac94def917d78f99ce8d10c4409e324", "parents": [ "63aa1ea0ea866e896b7e15587091e36229f3f0f6" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat May 27 09:06:10 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat May 27 22:12:21 2017 +0100" }, "message": "[Gate fix] Fix test_server_actions raising BadRequest\n\nWhen validatable is set to True for\ncreate_test_server, a BadRequest is thrown, with\ndetails that \u0027Instance network is not ready yet.\u0027\n\nA workaround is to remove validatable\u003dTrue from\ncalls to create_test_server, because it is not\nnecessary for Patrole testing. The docs\nfor create_test_server are:\n\n:param validatable: Whether the server will be\n pingable or sshable.\n\nSo we can remove it.\n\nChange-Id: I5e963cd2b8649ed8ebe35cf776432bd2496bdd27\n" }, { "commit": "63aa1ea0ea866e896b7e15587091e36229f3f0f6", "tree": "2b54c866fe3f8b388cca37841115f99c796a7241", "parents": [ "2c29ec3a2681a0b2bd24430daea74b7af5d81266", "96f826dcd40e5ced125aeb23c1c96a50f8ac2e28" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Fri May 26 02:13:04 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri May 26 02:13:04 2017 +0000" }, "message": "Merge \"Compute server metadata rbac tests\"" }, { "commit": "2c29ec3a2681a0b2bd24430daea74b7af5d81266", "tree": "18bf412b1c105af9362cd4b3c08a6def864b4ca6", "parents": [ "13ff694f76c0f528552e0b6d1b70cb12e370e26d", "e6fbe0fe30639275066ce181ea1b7be8d1541885" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu May 25 22:18:09 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu May 25 22:18:09 2017 +0000" }, "message": "Merge \"Remove assisted volume snapshot RBAC tests\"" }, { "commit": "c0e52b7f0b5933121e0358c2e4035ccfdde948b0", "tree": "95b6c693262d9594c8fdcd5996a12bb4456356aa", "parents": [ "0772520ffede572df8dedc6399bf179058a8ade7", "0441eab999406c523800ab4f6b5485467f46a8d1" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu May 25 16:35:49 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu May 25 16:35:49 2017 +0000" }, "message": "Merge \"Adds volume summary test reno\"" }, { "commit": "0772520ffede572df8dedc6399bf179058a8ade7", "tree": "117105051dbe67687aa5ed9736c70d0eef3e798a", "parents": [ "0b968496e669146b3f06d6a7c1e06efb758f8b8a", "b6f415f7f958723cb69fd767ab71077c796347fe" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu May 25 16:29:06 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu May 25 16:29:06 2017 +0000" }, "message": "Merge \"List hypervisors with details rbac test\"" }, { "commit": "0b968496e669146b3f06d6a7c1e06efb758f8b8a", "tree": "e689e1e67d1ac151f7eee90c55bd9447039eb873", "parents": [ "d187c3cf0b39e901ca353b75850069e43ad681c1", "944e8bc267c5c324f2056cae1d96e1563d02cf2a" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed May 24 22:41:05 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed May 24 22:41:06 2017 +0000" }, "message": "Merge \"Fix compute create volume test race condition\"" }, { "commit": "b6f415f7f958723cb69fd767ab71077c796347fe", "tree": "0b877ff0c9b2064e475fd1aa1037d95661d20456", "parents": [ "e52cbc64c08a1c1a8d55c7f03613988f4304d6db" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri May 19 17:28:02 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 24 22:57:52 2017 +0100" }, "message": "List hypervisors with details rbac test\n\nAs mentioned in a previous patch [0],\na test can be added for listing hypervisors\nwith details, which is what this patch does.\n\n[0] https://review.openstack.org/#/c/462742/3/patrole_tempest_plugin/tests/api/compute/test_hypervisor_rbac.py\n\nChange-Id: Ib828c707604b57747e9e54800455831d12155138\n" }, { "commit": "8f042fcf0ebaa1d1411ff9221bb0c285e9a50852", "tree": "13a2b09c51c16a1fba98b3615ed321631cff5f98", "parents": [ "e52cbc64c08a1c1a8d55c7f03613988f4304d6db", "96212024e4405c0394db3dd659976fa6729907dc" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed May 24 21:45:05 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed May 24 21:45:05 2017 +0000" }, "message": "Merge \"Remove incorrect compute min_microversions\"" }, { "commit": "96f826dcd40e5ced125aeb23c1c96a50f8ac2e28", "tree": "7dcb912742d6c41cf4b6e8a975d08aac40d98699", "parents": [ "4064607afcc853c89514ced54ae2fdd7da940748" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri May 19 19:00:48 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 24 22:27:19 2017 +0100" }, "message": "Compute server metadata rbac tests\n\nAdd rbac tests for the compute server metadata API [0] whose\npolicy definitions can be found here [1].\n\n[0] https://developer.openstack.org/api-ref/compute/#server-metadata-servers-metadata\n[1] https://github.com/openstack/nova/blob/master/nova/policies/server_metadata.py\n\nChange-Id: Ifb8901bce0965e4a763814b29ab1d3a16d9021d9\n" }, { "commit": "0441eab999406c523800ab4f6b5485467f46a8d1", "tree": "f0707598b67eb45b879d801b1761efec1d8ce6e1", "parents": [ "fba3135950e7cba2a2bffae5927831835b93b754" ], "author": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Wed May 17 15:57:43 2017 -0400" }, "committer": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Wed May 24 20:10:57 2017 +0000" }, "message": "Adds volume summary test reno\n\nAdds release notes for volumes v3 client show_volume_summary test.\n\nChange-Id: Ia5ab97976a783defb3f129269d105d768db4c54e\nPartial-Bug: #1691528\n" }, { "commit": "e52cbc64c08a1c1a8d55c7f03613988f4304d6db", "tree": "6b7039ee028215e8e2c0df2ddba7c81bbbfb7027", "parents": [ "f9a935d57e1681441abdfadf9380c700a16f983d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 24 17:48:59 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 24 17:48:59 2017 +0100" }, "message": "Fix rbac_rule_validation log statement raises TypeError\n\nIf an OverPermission error occurs, then the LOG.error statement\nthat should execute throws a TypeError due to a minor syntax issue.\n\nExample: http://logs.openstack.org/31/466331/6/check/gate-tempest-dsvm-patrole-member-ubuntu-xenial/dc38b01/console.html\n\nChange-Id: I3f7fde708521cfd200fd0835a6f2d697ed83b08b\nCloses-Bug: #1693297\n" }, { "commit": "944e8bc267c5c324f2056cae1d96e1563d02cf2a", "tree": "3053a07674b3a12572c6fc62af345e8668b95c30", "parents": [ "f9a935d57e1681441abdfadf9380c700a16f983d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 24 17:18:50 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 24 17:18:50 2017 +0100" }, "message": "Fix compute create volume test race condition\n\nCurrently, create_volume test in test_volume_rbac in compute\nmodule can fail [0] because of a race condition associated\nwith not waiting for the volume to reach \u0027active\u0027 status\nfollowing creation. Normally this is not an issue because\nthe class helper method \"create_volume\" is used which\ndoes this in the background, but in this particular test,\ncreate_volume is called via the volumes_extensions_client,\nso no wait is currently being done.\n\nThis patch adds a wait for the volume to reach \u0027active\u0027\nstatus.\n\n[0] http://logs.openstack.org/71/466871/4/check/gate-tempest-dsvm-patrole-admin-ubuntu-xenial/fbb5290/console.html\n\nChange-Id: I8c16fab69502fe94e39a63afbb94eee72cc4cac1\n" }, { "commit": "96212024e4405c0394db3dd659976fa6729907dc", "tree": "619c73696be6166ee6033fe88cf63b2b5b7d2066", "parents": [ "fba3135950e7cba2a2bffae5927831835b93b754" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon May 22 16:48:59 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue May 23 19:32:59 2017 +0100" }, "message": "Remove incorrect compute min_microversions\n\nMany compute tests assume that the min_microversion\nis 2.10; however, this assumption is incorrect [0].\n\nThis patch removes these incorrect min_microversions.\n\n[0] https://review.openstack.org/#/c/462996/\n\nChange-Id: Idb030b8c63949bd16af93e402971ce8855e41938\nCloses-Bug: #1692174\n" }, { "commit": "e6fbe0fe30639275066ce181ea1b7be8d1541885", "tree": "3c4e571512c1a88ecb261797386c009f0a2d347c", "parents": [ "744ccdfdc7978f73fc03d3bf1b1e04eb7c304f03" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon May 22 22:09:51 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon May 22 22:09:51 2017 +0100" }, "message": "Remove assisted volume snapshot RBAC tests\n\nThis patch removes assisted volume snapshots RBAC tests from\nthe compute module, because the assisted volume snapshot\nclient does not yet exist in Tempest.\n\nAccording to Tempest\u0027s hacking rules, \"Skipping tests should be\nbased on configuration only.\" Skipping the tests unconditionally\nis bad practice.\n\nOnce the relevant Tempest client is implemented, this patch can\nbe reverted and the skip test decorator from the tests can be\nremoved.\n\nChange-Id: Ib276b834df703f854708d0bb482fcf5cd5d9ea58\n" }, { "commit": "fba3135950e7cba2a2bffae5927831835b93b754", "tree": "de7361cc5c9b8d03d66bc934a1c2af73f2a6ac61", "parents": [ "744ccdfdc7978f73fc03d3bf1b1e04eb7c304f03" ], "author": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Wed May 17 17:35:54 2017 -0400" }, "committer": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Fri May 19 15:08:48 2017 -0400" }, "message": "Removes client aliases\n\nRemoves client aliases from Patrole tests\n\nChange-Id: I4995bb26264f14e98d682ed24fa8f457ad9d04fe\nCloses-Bug: #1691528\n" }, { "commit": "744ccdfdc7978f73fc03d3bf1b1e04eb7c304f03", "tree": "ebafb84c26b8d134e47ab87df73ed4c37ca3abd1", "parents": [ "cc9e5dac4ea611e29fb7102c9b5976801ae9bd84", "4e9a4964ffaf54a70b3c1effc6009f70546be041" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Fri May 19 16:28:32 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri May 19 16:28:32 2017 +0000" }, "message": "Merge \"Remove cinder v1 artifacts from code base\"" }, { "commit": "cc9e5dac4ea611e29fb7102c9b5976801ae9bd84", "tree": "b59d9454b2a9f133df862df90c20adb47da83546", "parents": [ "4064607afcc853c89514ced54ae2fdd7da940748", "b35de585b865e9f24a537380050132788928fb0b" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Fri May 19 16:28:00 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri May 19 16:28:00 2017 +0000" }, "message": "Merge \"Remove singleton from RbacUtils constructor\"" }, { "commit": "4064607afcc853c89514ced54ae2fdd7da940748", "tree": "91113adeee0b40606ea32fa4f9d7fd5d2dacfdcf", "parents": [ "a960582555c19405525854e018a1bb584ff0d63a", "980bff394616ed204ef5865cd6c406f636ad76d9" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Fri May 19 03:06:33 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri May 19 03:06:33 2017 +0000" }, "message": "Merge \"Extra hypervisor rbac tests\"" }, { "commit": "a960582555c19405525854e018a1bb584ff0d63a", "tree": "fa3f6bc4045e9dcc5bacd00270da4c06e0170eae", "parents": [ "beff0ca8c398cea5dcbdf887b14e97cc24998c17", "4bf66a22855c2d96399cf20ed96b1cbed2f65266" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Fri May 19 02:51:52 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Fri May 19 02:51:52 2017 +0000" }, "message": "Merge \"Hacking: enable extensions H106, H203 and H904\"" }, { "commit": "b35de585b865e9f24a537380050132788928fb0b", "tree": "695c7ab131254c5324609ad6aa53cb543e17ac91", "parents": [ "beff0ca8c398cea5dcbdf887b14e97cc24998c17" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri May 05 00:16:53 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu May 18 00:40:04 2017 +0100" }, "message": "Remove singleton from RbacUtils constructor\n\nCurrently, the RbacUtils class in rbac_utils is a singleton,\nwhich means the constructor is only called once. The problem with\nthat is when we instantiate RbacUtils in each rbac_base class,\nwe have to then also call switch_role(toggle_rbac_role\u003dFalse).\nWe could do that inside the constructor to simplify the code,\nbut only if RbacUtils constructor stops being a singleton -- or\nelse admin credentials are not guaranteed during set up across\nall test classes.\n\nIn addition, setting \"rbac_utils \u003d RbacUtils\" at the end of rbac_utils\nis pointless and only makes the code harder to read. This patch\nremoves that line of code and refactors the imports for rbac_utils where\nnecessary.\n\nChange-Id: I778ae19b4bd0b71ab77984ae57dd96fd829a1fc4\nCloses-Bug: #1688079\n" }, { "commit": "beff0ca8c398cea5dcbdf887b14e97cc24998c17", "tree": "da95860fa95d60dfca85708e147e6dc7912fdd99", "parents": [ "168caab14cb420c29a21e73dcdb5be018a4de44e", "d12d2eb2eb306da0aa670dfc383dea402bde810e" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed May 17 20:48:00 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed May 17 20:48:00 2017 +0000" }, "message": "Merge \"Remove enforce_type\u003dTrue from oslo.config set_override\"" }, { "commit": "20e780f44540c0ef309aa6657404ed826e9e9504", "tree": "7fc3d15120b47db5343742e7907c00d7dd00770f", "parents": [ "4791c4b11bf3fcabffda75138a2599d0ac570e55" ], "author": { "name": "maniksidana", "email": "ms702g@att.com", "time": "Wed May 17 02:47:35 2017 -0500" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 17 15:43:26 2017 +0000" }, "message": "Include class name in resource names for resource cleanup debugging\n\nApplied class names in calling of data_utils.rand_name()\n\nChange-Id: Ia73b3b484721803f084de4648249ed1f586226c6\nCloses-Bug: #1690429\n" }, { "commit": "4bf66a22855c2d96399cf20ed96b1cbed2f65266", "tree": "4c3c9a6110c287b25bba3071f98a33c1fa598439", "parents": [ "4791c4b11bf3fcabffda75138a2599d0ac570e55" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun May 07 14:44:21 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 17 15:36:16 2017 +0000" }, "message": "Hacking: enable extensions H106, H203 and H904\n\n[H106] Don\u0027t put vim configuration in source files.\n[H203] Use assertIs(Not)None to check for None.\n[H904] Delay string interpolations at logging calls.\n\nThis change makes Patrole\u0027s hacking consistent with\nTempest\u0027s [0][1].\n\n[0] https://review.openstack.org/#/c/408211/\n[1] https://review.openstack.org/#/c/408066/\n\nChange-Id: Ia56f66b4ab7e1eea6a8bfea05bf52865be13430c\n" }, { "commit": "980bff394616ed204ef5865cd6c406f636ad76d9", "tree": "4236a37a91092cfacf3ffdeb62b708f10ed27785", "parents": [ "4791c4b11bf3fcabffda75138a2599d0ac570e55" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu May 04 22:26:29 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 17 15:36:07 2017 +0000" }, "message": "Extra hypervisor rbac tests\n\nAdds additional hypervisor rbac tests that were previously missing.\nThe following tests were added:\n - test_show_hypervisor\n - test_list_servers_on_hypervisor\n - test_show_hypervisor_statistics\n - test_show_hypervisor_uptime\n - test_search_hypervisor\n\nChange-Id: Iec77d81895e30bd7adb764555fb6accc9f088ea4\n" }, { "commit": "4791c4b11bf3fcabffda75138a2599d0ac570e55", "tree": "96a0279c0a6ca8f24e63424601efffecff1fe436", "parents": [ "fe95f3f16ba226a64726cf646e2458eeb062fa10", "4cf2ffb43297e7a66c1ffdd1145bb3b6dc496e7b" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed May 17 03:31:09 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed May 17 03:31:09 2017 +0000" }, "message": "Merge \"Identity V3 Tests - Domain Configurations\"" }, { "commit": "fe95f3f16ba226a64726cf646e2458eeb062fa10", "tree": "46577ae5c19f4e6d0815fbc6ca2ad3a80b5d4fdc", "parents": [ "98bcb397fdb4880066a8e0ffd3a604b5b4c51164", "581268e24a8096d44bba42a6f9ddacbb9b903fe4" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed May 17 03:31:04 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed May 17 03:31:04 2017 +0000" }, "message": "Merge \"Remove unnecessary create_volume calls\"" }, { "commit": "98bcb397fdb4880066a8e0ffd3a604b5b4c51164", "tree": "92d6530b60ae14d522af7848a3ba5764fde9e0c9", "parents": [ "c15af320aa308e4388b5c4da2b1a399e8be1bb3d", "b18f98b28b9f6e70e603f12b71fac44f6b4ac280" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Tue May 16 22:41:50 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue May 16 22:41:50 2017 +0000" }, "message": "Merge \"Add RBAC tests for v3 auth policy actions\"" }, { "commit": "c15af320aa308e4388b5c4da2b1a399e8be1bb3d", "tree": "603dcf6146b75e7f779e3e1a370af529033f4511", "parents": [ "32aace93219d60afd561527a6ece67060abd4525" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue May 16 19:56:13 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue May 16 20:10:53 2017 +0000" }, "message": "[Gate fix] Fix volume metadata RBAC tests\n\nThis patch fixes volume metadata RBAC tests in\n``test_volume_metadata_rbac`` that are currently\nfailing in the gate [0].\n\nBecause a 404 is being thrown for certain volume\nmetadata tests for the v3 API version, this\npatch removes v3 support for these tests.\n\nThis patch also corrects two previously incorrect\npolicy actions:\n * ``test_create_volume_metadata`` should enforce\n \"volume:create_volume_metadata\" not\n \"volume:update_volume_metadata\"\n * ``test_show_volume_metadata`` should enforce\n \"volume:get_volume_metadata`` not \"volume:get\"\n (it also enforces \"volume:get\" but that is\n not the directly relevant policy action)\n\n[0] http://logs.openstack.org/26/465126/2/check/gate-tempest-dsvm-patrole-admin-ubuntu-xenial/c4d1ba0/console.html\n\nChange-Id: I2f98494e44e341b0a3e8c6aa2502961f8d804280\n" }, { "commit": "4cf2ffb43297e7a66c1ffdd1145bb3b6dc496e7b", "tree": "e0bc2b051d4702726ae449ae68a734cd6bcb31f2", "parents": [ "0854dedaec8220ac9cce6d96b06e11a4a73aa541" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Apr 17 19:32:45 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon May 15 19:40:22 2017 +0100" }, "message": "Identity V3 Tests - Domain Configurations\n\nTests for identity v3 domain configurations\n\nCo-Authored-By: Nicolas Helgeson \u003cnh202b@att.com\u003e\n\nDepends-On: I2f6229076aa7d2939dd91c487085ea73de001403\nChange-Id: I5122cf3459306577d152a420c46be9eabc060a3e\n" }, { "commit": "d12d2eb2eb306da0aa670dfc383dea402bde810e", "tree": "f1d77195b5eb43b659f3de89200ee539153977f7", "parents": [ "32aace93219d60afd561527a6ece67060abd4525" ], "author": { "name": "maniksidana", "email": "ms702g@att.com", "time": "Mon May 15 12:04:04 2017 -0500" }, "committer": { "name": "maniksidana", "email": "ms702g@att.com", "time": "Mon May 15 12:06:25 2017 -0500" }, "message": "Remove enforce_type\u003dTrue from oslo.config set_override\n\nRemove the kwarg \"enforce_type\" in the calling of set_override()\n\nChange-Id: Ib5fa3bd79aaacdcf8f24cbe067827c598d2dcc83\nCloses-Bug: #1689958\n" }, { "commit": "32aace93219d60afd561527a6ece67060abd4525", "tree": "5cc102412cbf384aebb7de758cff4854f6fd73c4", "parents": [ "5428230ce95bb587c82312240215da3522d87985", "d55e786dc2824a41134d738529cae4a45576d761" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Mon May 15 16:11:58 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon May 15 16:11:58 2017 +0000" }, "message": "Merge \"Rename \"Rbac Flag\" to \"Rbac testing\" in skip exceptions\"" }, { "commit": "5428230ce95bb587c82312240215da3522d87985", "tree": "a5fd2d3fff6d5f17baf474d10ec0220239d00486", "parents": [ "0854dedaec8220ac9cce6d96b06e11a4a73aa541", "d2e2074e605c60c9da6c0315237eb804d46453d2" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Mon May 15 15:43:21 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon May 15 15:43:21 2017 +0000" }, "message": "Merge \"Nova test for Volume client\"" }, { "commit": "d2e2074e605c60c9da6c0315237eb804d46453d2", "tree": "9b342f15e87615deb8a01fca4a7dfee5ac4e01e2", "parents": [ "c6a1e0a479ebcc20be7173bcd8d5387042d531a9" ], "author": { "name": "Uday T Kumar", "email": "uk310y@att.com", "time": "Tue Apr 25 18:42:20 2017 +0530" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon May 15 13:42:53 2017 +0000" }, "message": "Nova test for Volume client\n\nTests for Nova for volume client. The Nova proxy API is deprecated from microversion 2.36\n\nChange-Id: I06376b0b9b5cb44dfa80173dad3f131029494b9d\nCo-Authored-By: Pradeep Kumar \u003cpk5294@att.com\u003e\nCo-Authored-By: Felipe Monteiro \u003cfelipe.monteiro@att.com\u003e\nCo-Authored-By: Samantha Blanco \u003csamantha.blanco@att.com\u003e\nCo-Authored-By: Sangeet Gupta \u003csg774j@att.com\u003e\n" }, { "commit": "581268e24a8096d44bba42a6f9ddacbb9b903fe4", "tree": "5c125b480916f9f93352056a8d9b46db23be5824", "parents": [ "0854dedaec8220ac9cce6d96b06e11a4a73aa541" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri May 12 20:04:38 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri May 12 20:04:38 2017 +0100" }, "message": "Remove unnecessary create_volume calls\n\nThis patch removes unnecessary ``create_volume`` calls from\n``test_volume_basic_crud_rbac`` and also removes unusued\n``CONF`` variable.\n\nChange-Id: I1ddb0e91042bf9daff523cf25ff0f1664df5424d\n" }, { "commit": "b18f98b28b9f6e70e603f12b71fac44f6b4ac280", "tree": "eb4ca4b655bbb1c694ba4f927d42409fab3bdc48", "parents": [ "ea997a718bc5678317943825f0de1aa1a25af976" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon May 01 19:22:50 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu May 11 00:01:30 2017 +0000" }, "message": "Add RBAC tests for v3 auth policy actions\n\nImplements RBAC tests for v3 auth-related policy actions contained\nin [0]. But since the Tempest identity v3 client currently only\nhas an endpoint for list_auth_projects [1], this patch only adds an\nRBAC test for identity:get_auth_projects.\n\nOnce the other endpoints (show_auth_catalog and list_auth_domains)\nare added to the Tempest client, then the remaining tests can be\nadded in a follow-up patch.\n\n[0] https://github.com/openstack/keystone/blob/master/keystone/common/policies/auth.py\n[1] https://github.com/openstack/tempest/blob/master/tempest/lib/services/identity/v3/identity_client.py\n\nChange-Id: I002acfe760aeaab6d4618d366a2da522c6a27695\nPartial-Bug: #1687317\n" }, { "commit": "d55e786dc2824a41134d738529cae4a45576d761", "tree": "de952920f34284320ce525c2486e2bdc406c63a6", "parents": [ "ea997a718bc5678317943825f0de1aa1a25af976" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 10 15:28:45 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 10 15:28:45 2017 +0100" }, "message": "Rename \"Rbac Flag\" to \"Rbac testing\" in skip exceptions\n\nThis is a trivial change. Since \"Rbac Flag\" CONF param\nwas changed in a previous patch, \"Rbac testing\" is more\nappropriate as a ``skipException`` message.\n\nChange-Id: Iee448b44f9aa06a20f75324967f5eca0b372acc5\n" }, { "commit": "8d3e4396d9003eba77ed1354eff3516e7e4bc429", "tree": "cd7a6f4301b8244db24769715b4f73d20bb98017", "parents": [ "9e0e46270495929cfa0f78ffd82ec6b37e6f62a9", "3c3fc9a9b168a18f7ac3abec1db1807042d56b71" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Tue May 09 16:09:43 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue May 09 16:09:43 2017 +0000" }, "message": "Merge \"Consolidates rbac_base for v2 and v3 identity tests\"" }, { "commit": "9e0e46270495929cfa0f78ffd82ec6b37e6f62a9", "tree": "1cc2c8ec7a0cdccd7eb4d76f68fe52d8219715b7", "parents": [ "e4782c0e4bbac1a5e5fe119bf02d5f7995d80cf2", "7cec526593995d4464cba6d345ea8f2103192243" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Tue May 09 16:09:37 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue May 09 16:09:37 2017 +0000" }, "message": "Merge \"Corrects compute microversion docstrings\"" }, { "commit": "e4782c0e4bbac1a5e5fe119bf02d5f7995d80cf2", "tree": "5e3a0c2d17657a3f3c82b3facff8ca70c9b9dd52", "parents": [ "f1bd2b06abbb8c19ddf939f79b8dc1dcdbd7e71e", "f6b69e23b95d5348a19774ed14f14b53b52b1452" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Tue May 09 16:08:06 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue May 09 16:08:06 2017 +0000" }, "message": "Merge \"Change \"admin\" literal for admin role to CONF admin_role\"" }, { "commit": "7cec526593995d4464cba6d345ea8f2103192243", "tree": "f7218766efa10c9729e010226d0aef007a8cef65", "parents": [ "3db2fb7279fd6c90b2255998e970624d0c214006" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu May 04 17:18:46 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri May 05 21:43:30 2017 +0100" }, "message": "Corrects compute microversion docstrings\n\nThis patch updates API ref links for the comments above the\nmicroversions to point to the precise location of the\ndeprecated API comment. Also adds min_microversion where\nmax_microversion is specified.\n\nChange-Id: I6c6e9e3c5bd78d62c6cfd3ccef480d2b6c54dd75\n" }, { "commit": "f1bd2b06abbb8c19ddf939f79b8dc1dcdbd7e71e", "tree": "2d431d1ba679695c3695f3792f854e519d002173", "parents": [ "aca34184ad26a7b4d6936f5537bad25d61c16523" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri May 05 05:16:40 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri May 05 05:18:20 2017 +0100" }, "message": "Volume services rbac test\n\nAdds an RBAC test for the volume services API. This covers\nthe cinder policy action \"volume_extension:services:index\".\n\nChange-Id: I8d12de532087b52bd113c052bfa173f6041e9e1d\n" }, { "commit": "4e9a4964ffaf54a70b3c1effc6009f70546be041", "tree": "bd5989f02c80acfe61a90b358cfdfffdbb3c9d3b", "parents": [ "ae6d0ef3c15a2f5e86250e446031005f290a73d4" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri May 05 00:10:31 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri May 05 00:10:31 2017 +0100" }, "message": "Remove cinder v1 artifacts from code base\n\nFollowing Tempest\u0027s removal of Cinder v1 [0], Patrole should do\nthe same by removing any support for v1 from the code base.\n\n[0] https://review.openstack.org/#/c/446233/\n\nChange-Id: Ia27d7b9c19f7c53dd5605dea8f77a02251a0ab38\n" }, { "commit": "aca34184ad26a7b4d6936f5537bad25d61c16523", "tree": "6a0ae2699303f6e95e2ed9b677a578da588c9a81", "parents": [ "ae6d0ef3c15a2f5e86250e446031005f290a73d4", "45c2b35d55fded3fe5e31f478567bff45355e254" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu May 04 23:08:01 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu May 04 23:08:01 2017 +0000" }, "message": "Merge \"Remove heat tests from patrole\"" }, { "commit": "f6b69e23b95d5348a19774ed14f14b53b52b1452", "tree": "33874463560c02812dbff7396aa55b1cc7d5c00d", "parents": [ "ae6d0ef3c15a2f5e86250e446031005f290a73d4" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu May 04 21:55:04 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu May 04 20:59:29 2017 +0000" }, "message": "Change \"admin\" literal for admin role to CONF admin_role\n\nCurrently, the Patrole framework always assumes that the admin\nrole is \"admin\". But this might not necessarily be the case.\nThe word \"admin\" is just a convention, but is nonetheless an\narbitrary designation for administration privileges.\n\nInstead, the Patrole framework should take advantage of the\nalready-existing Tempest configuration option:\n\n cfg.StrOpt(\u0027admin_role\u0027,\n default\u003d\u0027admin\u0027,\n help\u003d\"Role required to administrate keystone.\"),\n\nThis patch changes instances of \u0027admin\u0027 (for identifying the\nadmin role) with ``CONF.identity.admin_role``. This patch doesn\u0027t\nmake changes to \u0027admin\u0027 in unit tests, as that\u0027s not necessary,\nbut instead uses ``CONF.set_override`` to change the ``admin_role``\nto \"admin\".\n\nCloses-Bug: #1680294\nChange-Id: Ia4431c2a16892a60fe10bb7e8495e7e384e552c1\n" }, { "commit": "3c3fc9a9b168a18f7ac3abec1db1807042d56b71", "tree": "acb43dcf42a53caa93307f5aeb272169b585ee2e", "parents": [ "83d77303ec44000821da7961116ee06ac4cf9497" ], "author": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Wed Apr 26 17:02:33 2017 -0400" }, "committer": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Thu May 04 18:36:15 2017 +0000" }, "message": "Consolidates rbac_base for v2 and v3 identity tests\n\nConsolidates identity v2 and v3 base classes into one file and\nrefactors necessary identity tests as a result of this change.\n\nChange-Id: Iab2850f6863cb4c2250bd2ad5fe47ee7ba5fb954\nCloses-Bug: #1685958\n" }, { "commit": "ae6d0ef3c15a2f5e86250e446031005f290a73d4", "tree": "865ea7b45bf55b3ab0bde3adc849cd47bd7c618f", "parents": [ "83d77303ec44000821da7961116ee06ac4cf9497", "2c9e3a4379d824fca792867321515a923226aaf7" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu May 04 18:18:56 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu May 04 18:18:56 2017 +0000" }, "message": "Merge \"Removes force_backup_delete test\"" }, { "commit": "83d77303ec44000821da7961116ee06ac4cf9497", "tree": "7fff5ffd7ed710618a48723e35d3cb6de04d4118", "parents": [ "6f8b350c9b18c77ceff071825d82da23b06e74b7", "78fc4895be73245937414611079d03a1e8a2132f" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu May 04 15:40:27 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu May 04 15:40:27 2017 +0000" }, "message": "Merge \"Merge rbac_auth with rbac_rule_validation\"" }, { "commit": "6f8b350c9b18c77ceff071825d82da23b06e74b7", "tree": "63ed7baff7b28ec7149ab9dc06a524b95eadb47b", "parents": [ "f950f859fbfe17849db8ab6342d5d8d1fbdb73a5", "2297aa1e08522650841ad18697811efd6735ef78" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu May 04 15:40:16 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu May 04 15:40:16 2017 +0000" }, "message": "Merge \"Add RBAC test cases to manage cinder volume\"" }, { "commit": "f950f859fbfe17849db8ab6342d5d8d1fbdb73a5", "tree": "e0960b9b5598e72f0abf069976240ccfee29d8e3", "parents": [ "63459954835032dce4083997baccd988e66d281d", "d7120bbdc37d4b8471286cb1d3538c275eaecbd3" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed May 03 21:55:36 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed May 03 21:55:36 2017 +0000" }, "message": "Merge \"Add force detach volume test.\"" }, { "commit": "d7120bbdc37d4b8471286cb1d3538c275eaecbd3", "tree": "326d77e1d187bd8927262da40939341b72f5da96", "parents": [ "910c7c860786073e25b6a8a8ada0493bc5477651" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Apr 26 22:30:20 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 03 20:03:02 2017 +0000" }, "message": "Add force detach volume test.\n\nThis patch adds the force detach volume test to\ntest_volume_actions_rbac, which enforces the following policy\naction:\n\n volume_extension:volume_admin_actions:force_detach\n\nfor the force_detach endpoint [0].\n\n[0] https://github.com/openstack/cinder/blob/master/cinder/api/contrib/admin_actions.py#L130\n\nChange-Id: I4442f97012572bb2bfb398ba5593d742b920f13e\n" }, { "commit": "2c9e3a4379d824fca792867321515a923226aaf7", "tree": "e2f6bd7574d085d876bc07234602d6a1430c46a2", "parents": [ "e7e552e7db5a7876a067b7aba46fc66b05b36743" ], "author": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Wed May 03 15:28:09 2017 -0400" }, "committer": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Wed May 03 15:28:09 2017 -0400" }, "message": "Removes force_backup_delete test\n\nTempest has removed support for force_backup_delete and does not\ncurrently have any plans to add it back in [0]. As such, this\ntest should be removed.\n\n[0] https://review.openstack.org/#/c/461625/\n\nChange-Id: Id456b384e2302c08a785add184ce0b0dd9642f4b\n" }, { "commit": "63459954835032dce4083997baccd988e66d281d", "tree": "341d23bca32c1e3d6de1ad6be8c1871b8f74c051", "parents": [ "910c7c860786073e25b6a8a8ada0493bc5477651" ], "author": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Fri Apr 28 15:15:59 2017 -0400" }, "committer": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Wed May 03 19:26:43 2017 +0000" }, "message": "Adds create metadef resource test\n\nAdds test for glance\u0027s add_metadef_resource_type_association policy.\n\nChange-Id: Ic249cb10f4e0715e8f89676ee8686e737b011ba4\n" }, { "commit": "910c7c860786073e25b6a8a8ada0493bc5477651", "tree": "099c8b1cb5b5c00924bef3672075388e7e8e6cb2", "parents": [ "4606d0ca14ebb153da992ad25a35b1f8921f51be", "85f79d7abf6b2e5445a667025397d05dacad757a" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed May 03 19:20:14 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed May 03 19:20:14 2017 +0000" }, "message": "Merge \"Creates config options for policy.json paths\"" }, { "commit": "4606d0ca14ebb153da992ad25a35b1f8921f51be", "tree": "872565f55271f576ccaeebeba0068252567794db", "parents": [ "e7e552e7db5a7876a067b7aba46fc66b05b36743", "b89e5849b635fe1600159e161c4df415875bb0f0" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed May 03 19:19:46 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed May 03 19:19:46 2017 +0000" }, "message": "Merge \"Move tests from volumes into volumes actions.\"" }, { "commit": "e7e552e7db5a7876a067b7aba46fc66b05b36743", "tree": "a4ce83902f697492c7d2fca31403fd61ef300f83", "parents": [ "a0e6940339e6ada37ccf52c45c0b398f42f6be2e" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue May 02 17:04:12 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 03 16:09:54 2017 +0000" }, "message": "[Fix gate] Fix failing identity v2 admin tests\n\nThis patch fixes the failing identity tests that\nbelong to the v2 admin API [0].\n\nDue to recent changes to Keystone and DevStack,\nthe v2 admin API tests fail if run outright.\n\nTempest now skips the v2 admin tests uness\n``CONF.identity_feature_enabled.api_v2_admin`` is true [1];\nPatrole should do the same.\n\nThis patch makes the following changes:\n - Skips identity v2 admin tests unless\n ``CONF.identity_feature_enabled.api_v2_admin`` is true\n - Removes superfluous tempest.conf overrides from\n post_test_hook\n - Updates ``rbac_utils.switch_role`` to ensure that admin\n identity credentials are properly configured and that\n the ``roles_v3_client`` is always used\n - Refactors test_projects_rbac in v2 identity because\n the API belongs to both the admin and non-admin API,\n which was causing OverPermission error to be thrown.\n\n[0] https://developer.openstack.org/api-ref/identity/v2-admin/\n[1] https://review.openstack.org/#/c/458844/\n\nChange-Id: Ic698d0b2cf669793aaad6aff972ba155ef993e4a\n" }, { "commit": "45c2b35d55fded3fe5e31f478567bff45355e254", "tree": "c6c6f24b7fd78bb2056e4afbb3d10b2b31fb96f0", "parents": [ "a0e6940339e6ada37ccf52c45c0b398f42f6be2e" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 03 02:47:37 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed May 03 03:20:35 2017 +0100" }, "message": "Remove heat tests from patrole\n\nAs Tempest is now in the process of removing\nheat tests [0], Patrole should follow suit\nby doing the same.\n\n[0] https://review.openstack.org/#/c/461841/\n\nChange-Id: I169e74a3af4957248cda26d108b61ff187ae4b1d\nRelated-Change-Id: Ifc2cac575919da4e361eaa3234d7e0f3e2f98d21\nDepends-On: Ifd150ef113988e7a3721ee174f0453f99ce198f6\nCloses-Bug: #1687837\n" }, { "commit": "a0e6940339e6ada37ccf52c45c0b398f42f6be2e", "tree": "2b79543306c913a331c6095b4808f4e773237fa8", "parents": [ "203c338ffbf50dac15e3a90677aaa7dc2c5070e2", "b45a05e8bed5c404016724c0ca39f050885ea9bd" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Mon May 01 15:37:57 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon May 01 15:37:58 2017 +0000" }, "message": "Merge \"Add RBAC test for force-deleting a backup\"" }, { "commit": "203c338ffbf50dac15e3a90677aaa7dc2c5070e2", "tree": "001db1c0e34be697d3fe8e42740a81e4dcdd6297", "parents": [ "985052a456968458edca8bb133e9a921b76dbfb8", "c82ce14af86224d888cc6ec0edde8e1b9dac2425" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Mon May 01 15:02:28 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon May 01 15:02:28 2017 +0000" }, "message": "Merge \"Replace generic api_extensions checks\"" }, { "commit": "985052a456968458edca8bb133e9a921b76dbfb8", "tree": "d7f3ab0b6e7424f4203a9d61c9878ad0bd3070f2", "parents": [ "f568d04215f1e70e959cdbcab1a74e12e89fbd6a", "d0b747bd640ca9bc1f932f9d91cfe2b6801eb5f3" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Mon May 01 14:57:57 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon May 01 14:57:57 2017 +0000" }, "message": "Merge \"Add RBAC tests for cinder os-quota-class-sets API\"" }, { "commit": "d0b747bd640ca9bc1f932f9d91cfe2b6801eb5f3", "tree": "05a99d668852f89eb83f7acc831e25b39b57822a", "parents": [ "edcdbecd6bfaf5476eb57a35d21c78a5c2876a5d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Apr 30 04:41:44 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Apr 30 19:01:40 2017 +0000" }, "message": "Add RBAC tests for cinder os-quota-class-sets API\n\nThis patch adds RBAC tests for the cinder os-quota-class-sets API,\nwhich cover the policy action \"volume_extension:quota_classes\" [0][1].\n\n[0] https://github.com/openstack/cinder/blob/master/cinder/api/contrib/quota_classes.py#L44\n[1] https://github.com/openstack/cinder/blob/master/cinder/api/contrib/quota_classes.py#L55\n\nChange-Id: Iba5dc5caf7ed3f1ad344b0d7b2d6c13a9842cf79\n" }, { "commit": "b45a05e8bed5c404016724c0ca39f050885ea9bd", "tree": "b3155249c06b7c9cfd8ac515c3dac0f775774fba", "parents": [ "edcdbecd6bfaf5476eb57a35d21c78a5c2876a5d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Apr 30 03:51:08 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sun Apr 30 03:51:08 2017 +0100" }, "message": "Add RBAC test for force-deleting a backup\n\nThis patch adds a new test for force-deleting a backup in\ntest_volumes_backup_rbac, which tests the cinder policy action:\n\"volume_extension:backup_admin_actions:force_delete\".\n\nThis patch also corrects the currently wrong policy action for\nthe test test_snapshot_force_delete from\n\"volume_extension:volume_admin_actions:force_delete\" to\n\"volume_extension:snapshot_admin_actions:force_delete\". (The\n``_force_delete`` function in the cinder admin actions API enforces\nthe policy action corresponding to the resource name [0][1]).\n\n[0] https://github.com/openstack/cinder/blob/master/cinder/api/contrib/admin_actions.py#L133\n[1] https://github.com/openstack/cinder/blob/master/cinder/api/contrib/admin_actions.py#L82\n\nChange-Id: Icecf2152fe84da2847ae677a74a4d183eb4cd88b\n" }, { "commit": "f568d04215f1e70e959cdbcab1a74e12e89fbd6a", "tree": "36c86893f34bd0b412c4ad392357972bdcb9dde6", "parents": [ "edcdbecd6bfaf5476eb57a35d21c78a5c2876a5d" ], "author": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Tue Apr 25 16:32:54 2017 -0400" }, "committer": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Fri Apr 28 20:20:51 2017 +0000" }, "message": "Adds missing volumes client tests\n\nAdds missing volumes client tests for set bootable, reserve,\nunreserve, and update metadata actions, as well as renames update\nmetadata item and delete metadata items tests to properly represent\nwhat actions they perform.\n\nChange-Id: I75bbf62635f3476e658f5b162f5bd65f9fcaab08\nImplements: bp: test-volumes-rbac\n" }, { "commit": "c82ce14af86224d888cc6ec0edde8e1b9dac2425", "tree": "11184d9fb8e14ed7238374b41ce1d98c2dbf9604", "parents": [ "edcdbecd6bfaf5476eb57a35d21c78a5c2876a5d" ], "author": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Thu Apr 27 13:20:28 2017 -0400" }, "committer": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Fri Apr 28 16:10:05 2017 -0400" }, "message": "Replace generic api_extensions checks\n\nReplaces generic api_extensions checks with specific extension\nthat is being called in each test file.\n\nChange-Id: I219bb336dd0323f944bd9b4c36ed0a9f715931c2\nCloses-Bug: #1686593\n" }, { "commit": "78fc4895be73245937414611079d03a1e8a2132f", "tree": "bd57f093e6c8fade8f617a8da1a501f330d19a40", "parents": [ "84227729cfc252a62404fdb46c9a3ea33cbf349d" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Apr 12 21:33:39 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Apr 27 21:57:37 2017 +0000" }, "message": "Merge rbac_auth with rbac_rule_validation\n\nCurrently, rbac_auth doesn\u0027t do much: It decentralizes logic\nthat can be easily merged into rbac_rule_validation without\ndoing anything authentication-related. All rbac_auth does is:\n\n 1) Construct RbacPolicyParser and check whether a given role\n is allowed to perform a given policy action.\n 2) Dump some info to LOG\n 3) Catch some exceptions\n\nThus, there\u0027s no justification for keeping rbac_auth. It doesn\u0027t\nprovide a high-enough level of abstraction to warrant being used.\nIt should be removed and its logic inserted in rbac_rule_validation.\n\nChange-Id: I756175ea28ec11f24150f46d5ae4c2f64499a0ea\nCloses-Bug: #1681459\n" }, { "commit": "85f79d7abf6b2e5445a667025397d05dacad757a", "tree": "730ba99421d70b7c3cd8e4c6f7645c5ac94dbedd", "parents": [ "c6a1e0a479ebcc20be7173bcd8d5387042d531a9" ], "author": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Fri Apr 21 11:09:14 2017 -0400" }, "committer": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Thu Apr 27 17:55:05 2017 -0400" }, "message": "Creates config options for policy.json paths\n\nRemoves unsused \"path\" parameter from rbac_policy_parser.py.\nAllows for configuration of policy.json paths by service for\nCinder, Glance, Keystone, Neutron, and Nova.\n\nChange-Id: Ifb386511fd533d587d99de6585ddb78bc17cbc94\n" }, { "commit": "edcdbecd6bfaf5476eb57a35d21c78a5c2876a5d", "tree": "66187cb526df7b52f4ba15ef8dfc7141f492cc7e", "parents": [ "6bbc6255589b995bb523ad65ad45c11ebc3f2782" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Apr 26 22:43:02 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Apr 27 22:46:10 2017 +0100" }, "message": "Stop using aliases for creds manager\n\nNow that Tempest has stopped using aliases like cls.os\nand cls.os_adm [0], Patrole should do the same.\n\nThis patch normalizes the usage around os_admin, os_primary and\nos_alt.\n\n[0] https://review.openstack.org/#/c/457555/\n\nChange-Id: Ibc826c8c6be2590db9ad9da0831fffeae6d3a01b\nRelated-Change-Id: I5f7164f7a7ec5d4380ca22885000caa0183a0bf7\n" }, { "commit": "6bbc6255589b995bb523ad65ad45c11ebc3f2782", "tree": "b6597471f4075b15b9d6027c2ef4d86efe0ead44", "parents": [ "39c4684b40220e1efdc502d9e5ba24db3aeee67b", "6704253b0d692ab4b3d453c9ccf35af25f498608" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed Apr 26 17:30:20 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Apr 26 17:30:20 2017 +0000" }, "message": "Merge \"Add encryption types test\"" }, { "commit": "39c4684b40220e1efdc502d9e5ba24db3aeee67b", "tree": "800e039f46cd7be6bbe346ca911d869c15fa3599", "parents": [ "84227729cfc252a62404fdb46c9a3ea33cbf349d", "b059d49dd2d051ca26e5680e8a199def0ea3e18b" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Tue Apr 25 22:03:10 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Apr 25 22:03:10 2017 +0000" }, "message": "Merge \"Fix up test_volume_actions_rbac\"" }, { "commit": "b059d49dd2d051ca26e5680e8a199def0ea3e18b", "tree": "d23622db02e2129f6e85d01163bb3507578beacb", "parents": [ "4fc9a6b4bcbad1df306a7f08f84860e5abe22213" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Apr 14 18:54:07 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Apr 25 19:38:30 2017 +0000" }, "message": "Fix up test_volume_actions_rbac\n\nThis patch:\n - Adds additional volume actions tests\n - Adds a few decorators to existing tests where needed\n - Fixes test_volume_upload throwing 300\n\nChange-Id: I712cc85c7708cf3592a77114e5dfbfa783a2a190\nCloses-Bug: #1672799\n" }, { "commit": "84227729cfc252a62404fdb46c9a3ea33cbf349d", "tree": "441a7dfd2880254d5a80177812e18ac8f5c27b38", "parents": [ "e2bfb85ec46e854cade683516f244782cd95f62f", "1fa5b2e859420cebe4081117ebcb5d0de9c713b4" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Tue Apr 25 18:40:36 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Apr 25 18:40:36 2017 +0000" }, "message": "Merge \"Keystone v3 tests for endpoint filters for projects\"" }, { "commit": "1fa5b2e859420cebe4081117ebcb5d0de9c713b4", "tree": "f7321847c3f1338fbace4108dcbc8578e3c90d1e", "parents": [ "3f4158d93541c8832f5d7afe6ed10dc15730b87f" ], "author": { "name": "Uday T Kumar", "email": "uk310y@att.com", "time": "Mon Apr 03 19:02:25 2017 +0530" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Apr 25 15:22:48 2017 +0000" }, "message": "Keystone v3 tests for endpoint filters for projects\n\nTests for Keystone v3 for rbac for endpoint filters for projects\n\nChange-Id: Ie4e786483295fcae183b539f96edd25efbec6a1a\nCo-Authored-By: Pradeep Kumar \u003cpk5294@att.com\u003e\nCo-Authored-By: Kaustav Royburman \u003ckr336r@att.com\u003e\nCo-Authored-By: Nicolas Helgeson \u003cnh202b@att.com\u003e\nDepends-on: I42fc49dea52ac4612cb018f3964675444c96ffdd\n" }, { "commit": "e2bfb85ec46e854cade683516f244782cd95f62f", "tree": "34bd31dd761552e8ff23c3fe2cb9ce4ce3fdecaa", "parents": [ "c6a1e0a479ebcc20be7173bcd8d5387042d531a9" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Apr 12 15:51:15 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Apr 25 13:56:44 2017 +0000" }, "message": "Add additional tests to test_images_rbac\n\nThis patch adds the following new tests to test_images_rbac:\n - test_create_image_tag_rbac\n - test_delete_image_tag_rbac\n - test_download_image_rbac\n\nThis patch also refactors the code by creating helper method\nto clean up the tests.\n\nChange-Id: I4362d667c20609974d3187be260e710365ca6665\n" }, { "commit": "6704253b0d692ab4b3d453c9ccf35af25f498608", "tree": "ae480331f845f745cecb4377328f8654b0f817d9", "parents": [ "c6a1e0a479ebcc20be7173bcd8d5387042d531a9" ], "author": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Mon Apr 24 12:02:45 2017 -0400" }, "committer": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Mon Apr 24 21:17:37 2017 -0400" }, "message": "Add encryption types test\n\nAdds patrole tests for the encryptions types client. Also\nrefactors test_volume_types_extra_specs to make use of the\ncreate_volume_type class method.\n\nChange-Id: Ice66abb1546e4f0d882927b0489f3ab1cf330c01\nImplements: bp: rbac-tests-for-encryption-types-client\nDepends-On: I1a52fca1360afb8544148e9e0e8fc2905e74db0a\n" }, { "commit": "b89e5849b635fe1600159e161c4df415875bb0f0", "tree": "43151786af009d241c209002a3a93468a90b82da", "parents": [ "c6a1e0a479ebcc20be7173bcd8d5387042d531a9" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Apr 25 00:54:03 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Apr 25 00:03:36 2017 +0000" }, "message": "Move tests from volumes into volumes actions.\n\nThis patch moves the tests for the following policy actions:\n\n - volume_extension:volume_admin_actions:reset_status\n - volume_extension:volume_admin_actions:force_delete\n\ninto test_volume_actions_rbac because they do not belong\nin test_volumes_rbac, as resetting a status of a volume [0]\nand force-deleting a volume [1] are a part of the volume\nactions API, not the volumes API.\n\nAs there are no tests left in test_volumes_rbac after relocating\nthese 2 tests, the file is deleted.\n\n[0] https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dreset-a-volume-s-statuses-detail\n[1] https://github.com/openstack/tempest/blob/master/tempest/api/volume/admin/test_volumes_actions.py\n\nChange-Id: Idc0286de76e1a58826f411de60988975694a2da3\n" }, { "commit": "c6a1e0a479ebcc20be7173bcd8d5387042d531a9", "tree": "20ba23d3b075eea34eee36388669aaa79b45bb6b", "parents": [ "b9452528eed17303d9701e8294ffa5fb37095a40", "fd1db988dc92e07be99d975665e5928ca5090978" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Mon Apr 24 20:06:17 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Apr 24 20:06:17 2017 +0000" }, "message": "Merge \"Identity trust rbac tests\"" }, { "commit": "b9452528eed17303d9701e8294ffa5fb37095a40", "tree": "c767c256f7e6afcbf98ed5aa2b6b6bd0ea18a98a", "parents": [ "e03d69a169ccaec3c103f2bb0328854ea24353d3", "e46a27df7b220bf0e0658dc7332bbff6b49ab1f0" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Mon Apr 24 19:57:30 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Apr 24 19:57:30 2017 +0000" }, "message": "Merge \"Remove skip exception from virtual interfaces test\"" }, { "commit": "e03d69a169ccaec3c103f2bb0328854ea24353d3", "tree": "b5592ed580d8aa4cd1c224df93fdb3572a535e6c", "parents": [ "e5e03d2076c717b2626de05ca779ffa9d1043fdc", "5c4b97de1cc8549eb9220853556b0c38f11b5ad7" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Mon Apr 24 17:45:54 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Apr 24 17:45:54 2017 +0000" }, "message": "Merge \"Add volume user messages rbac test\"" }, { "commit": "2297aa1e08522650841ad18697811efd6735ef78", "tree": "e13a6a601de939c42c49a7294b721dcfb2212551", "parents": [ "a0e6940339e6ada37ccf52c45c0b398f42f6be2e" ], "author": { "name": "Chi Lo", "email": "cl566n@att.com", "time": "Fri Apr 21 20:03:04 2017 -0500" }, "committer": { "name": "Chi Lo", "email": "cl566n@att.com", "time": "Sat Apr 22 08:02:43 2017 -0500" }, "message": "Add RBAC test cases to manage cinder volume\n\nAdd test cases to test the following actions:\n\"volume_extension:volume_manage\": \"rule:admin_api\",\n\"volume_extension:volume_unmanage\": \"rule:admin_api\",\n\nChange-Id: Ic47cb1638c0793d288f3dd40a3036aa50b4ab24a\nPartially-Implements: blueprint \"Add rbac tests for volume_manage_client\"\n" }, { "commit": "0620e9b679e9880a4d5c76bcaf8a3c6c485c1643", "tree": "63894ff02e4acb882d5a5664e5e93219c5a38860", "parents": [ "e7df9c4819336b9631e297bf507b45b7584c1a4e", "6ed0e03496c75f22ca7237111fc2447b8a5c9867" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Wed Apr 19 16:06:52 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Wed Apr 19 16:06:52 2017 +0000" }, "message": "Merge \"Adding server evacuate test\"" }, { "commit": "6ed0e03496c75f22ca7237111fc2447b8a5c9867", "tree": "66bc0f887cd0b8d4064776b793cf1adf969e319e", "parents": [ "a810851df46b02fa3403c0b304d90fa3eb4dad33" ], "author": { "name": "raiesmh08", "email": "mr290n@att.com", "time": "Tue Apr 18 19:49:40 2017 +0530" }, "committer": { "name": "raiesmh08", "email": "mr290n@att.com", "time": "Wed Apr 19 12:45:12 2017 +0530" }, "message": "Adding server evacuate test\n\nThis patch adds server evacuate test.\n\nCloses-Bug: #1673811\n\nChange-Id: Ic731475d3770d6f9a03dac683b269a5ffe36d794\n" }, { "commit": "e46a27df7b220bf0e0658dc7332bbff6b49ab1f0", "tree": "ccb28d344d9bb203e6745f908b0c16581f1d9949", "parents": [ "3f4158d93541c8832f5d7afe6ed10dc15730b87f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Apr 18 04:27:46 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Wed Apr 19 02:04:58 2017 +0000" }, "message": "Remove skip exception from virtual interfaces test\n\nCurrently, test_list_virtual_interfaces in the virtual interfaces\nrbac test file throws a skip exception in the event that a BadRequest\nis thrown -- which happens if neutron is enabled. This is because\nlisting virtual interfaces is only available for nova-network, in nova.\n\nHowever, skipping the test is not necessary, because policy enforcement\nis always performed [0]: the API always performs policy enforcement\nfirst followed by everything else, so a 403 is always thrown before a 400.\n\nSo, this patch gets rid of the unnecessary raising of skipException.\nIt also adds a assertRaisesRegexp with the expected error message:\n\"Listing virtual interfaces is not supported by this cloud\" and\nexpected BadRequest error. By checking for a specific regex (error\nmessage), there is certainty that the expected BadRequest is indeed\nthrown; if any other BadRequest is thrown, an AssertionError will be\nraised.\n\nIn short: this patch removes the skipException because policy\nenforcement is always performed and ensures that the correct\nBadRequest is thrown.\n\n[0] https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/virtual_interfaces.py\n\nChange-Id: Ia5bd4feb2708095bbab9eb2a377f336da84103fc\n" }, { "commit": "e7df9c4819336b9631e297bf507b45b7584c1a4e", "tree": "2e2722f1248e0185ea692c74819d4c0a25a105e8", "parents": [ "3f4158d93541c8832f5d7afe6ed10dc15730b87f" ], "author": { "name": "Joseph Abad", "email": "joseph.abad@att.com", "time": "Tue Apr 18 16:38:50 2017 -0400" }, "committer": { "name": "Joseph Abad", "email": "joseph.abad@att.com", "time": "Tue Apr 18 16:38:50 2017 -0400" }, "message": "Increase unit test coverage for policy parser.\n\nChange-Id: If801873d95c0157e3a243924b2da96a119e2acb0\n" }, { "commit": "5c4b97de1cc8549eb9220853556b0c38f11b5ad7", "tree": "a838bf080075b9e47161713eda7b4ae674ef068d", "parents": [ "a810851df46b02fa3403c0b304d90fa3eb4dad33" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Apr 17 20:29:57 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Apr 17 20:29:57 2017 +0100" }, "message": "Add volume user messages rbac test\n\nThis patch:\n * Adds test_user_messages_rbac which tests the cinder messages\n API [0].\n * Adds volume_types create helper to volume rbac_base.\n\nNote that microversioning is required for this test; see [1]\nfor more details.\n\n[0] https://developer.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003d#messages\n[1] https://github.com/openstack/tempest/blob/master/tempest/api/volume/admin/test_user_messages.py\n\nChange-Id: I1a52fca1360afb8544148e9e0e8fc2905e74db0a\n" }, { "commit": "3f4158d93541c8832f5d7afe6ed10dc15730b87f", "tree": "9a5bceb999fd7160c099db2526579df81f524f7a", "parents": [ "a810851df46b02fa3403c0b304d90fa3eb4dad33" ], "author": { "name": "Nicolas Helgeson", "email": "nh202b@att.com", "time": "Wed Mar 15 16:47:05 2017 -0700" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Apr 17 19:30:59 2017 +0100" }, "message": "Identity V3 Tests - Domains\n\nTests for identity v3 domains\n\nPartially-Implements bp: initial-tests-identity\n\nChange-Id: I580eabc733f948939cfed842fef083f791e263e1\nCo-Authored-By: Nishant Kumar \u003cnk613n@att.com\u003e\n" }, { "commit": "fd1db988dc92e07be99d975665e5928ca5090978", "tree": "600e3a4572d0e2a67caff8d9576e08bb83c6304f", "parents": [ "a810851df46b02fa3403c0b304d90fa3eb4dad33" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Thu Apr 13 21:19:41 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Apr 17 18:11:30 2017 +0000" }, "message": "Identity trust rbac tests\n\nAdd identity trust rbac tests corresponding to the policy actions\nin [0].\n\nMost of the policy actions in [0] have a rule of \u0027\u0027 (empty string),\nmeaning any role can perform the action. However, the\n\"identity:create_trust\" policy action has a rule of\nbase.RULE_TRUST_OWNER which translates to:\n\n user_id:%(trust.trustor_user_id)s [1].\n\nThis is a rather unique rule, one that is not dependent on the\ncurrent user\u0027s user_id, project_id or even role. Rather, this\nrule translates to: \"Does the current user\u0027s user_id match\nthe user_id of the trustor creating a trust with a trustee?\"\n\nAs should be expected, \"trust.trustor_user_id\" can only be\ndynamically calculated at runtime, rather than immediately\nretrieved from a tempest credential variable, as is the case\nwith user_id and project_id.\n\nHence, this patch not only 1) creates trust rbac tests but 2)\nenhances the framework, particularly the rbac_rule_validation\ndecorator, as well as the rbac_policy_parser framework, to\nhandle additional target data that must be passed to\noslo-policy-checker in order for proper authorization\ndetermination.\n\nThe \"target\" parameter in oslo.policy is a dictionary that\ncontains \"As much information about the object being\noperated on as possible\" [2]. Accordingly, the\nrbac_rule_validation decorator has been enhanced with a new\nparam called `extra_target_data` that is a dictionary\ncontaining key-value pairs of dynamically calculated\ndata needed by oslo.policy to correctly determine whether\nthe \"target\" has authorization to perform a policy action.\n\nFor example,\n\n extra_target_data\u003d{\n \"trust.trustor_user_id\": \"os.auth_provider.credentials.user_id\"\n })\n\nmeans that trust.trustor_user_id equals the primary credential\u0027s\nuser_id. So, if a trustor\u0027s user_id equals the primary credential\u0027s\nuser_id, then the policy parser will return True for `is_allowed`.\nHowever, if a trustor\u0027s user_id doesn\u0027tequal to the primary credential\u0027s\nuser_id, but rather the alt credential\u0027s user_id, say, then `is_allowed`\nreturns False.\n\nThus, the only way to do negative testing with test_trusts_rbac is\nto explicitly create a negative test, as described in the above\nparagraph, which is what this patch does. Normally, negative testing\nis baked in, dependent on the `rbac_test_role`, but with more\ncomplicated policy enforcement as described above, this is not\npossible.\n\nWhile it is possible to create a new CONF value called trustor_user_id,\nit would require using pre-provisioned credentials, which is something\nPatrole doesn\u0027t explicitly use.\n\n[0] https://github.com/openstack/keystone/blob/master/keystone/common/policies/trust.py\n[1] https://github.com/openstack/keystone/blob/master/keystone/common/policies/base.py\n[2] https://docs.openstack.org/developer/oslo.policy/api/oslo_policy.html\n\nDepends-On: Ib82e8b8a0d6c8587fb0b1ce415e751c3ebc3c2f9\nChange-Id: I5c00fdb345556066343bdaeb5f008d639a94bc4b\n" }, { "commit": "a810851df46b02fa3403c0b304d90fa3eb4dad33", "tree": "d7a0ea102bc22cf5b4ce1648c52694a07428b5c8", "parents": [ "4fc9a6b4bcbad1df306a7f08f84860e5abe22213" ], "author": { "name": "Samantha Blanco", "email": "samantha.blanco@att.com", "time": "Fri Apr 14 14:33:09 2017 -0400" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Apr 15 01:14:00 2017 +0100" }, "message": "Add capabilities and scheduler stats tests\n\nAdds RBAC tests for the capabilities and scheduler stats clients.\n\nChange-Id: I08bf2539eff08e77c37b83b98da853da71c76f52\n" }, { "commit": "4fc9a6b4bcbad1df306a7f08f84860e5abe22213", "tree": "c45eed6dd8c55c8a7ba0ed97ca8ce603c658c861", "parents": [ "16e6d4b9fefc9177b05df0f93fd6cf97567bc1ec", "6a99c56bb4e28f4c6984b8c3a9c2d3afdb544791" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Thu Apr 13 22:20:49 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Thu Apr 13 22:20:49 2017 +0000" }, "message": "Merge \"Remove admin namespace throughout Patrole - Identity tests\"" }, { "commit": "16e6d4b9fefc9177b05df0f93fd6cf97567bc1ec", "tree": "a5f6856a6fe5b943ae96307f2a1d6cac807e8071", "parents": [ "4d14c699fdc0bcf02ee82d06cb847a32e2773e39", "94c1cc61b8c7404f05372e8af48a2e5d1bd711ac" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Tue Apr 11 20:15:55 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Apr 11 20:15:55 2017 +0000" }, "message": "Merge \"Add RBAC tests for namespace_tags_client.\"" }, { "commit": "4d14c699fdc0bcf02ee82d06cb847a32e2773e39", "tree": "50947e9e615db740f4307fe8fcc7862f9880bcf7", "parents": [ "40ca06d7dbfd6173a5476bf04bf90963b4a5bfd1", "706fd34fcc75bba9dc868b9566f50ffa4fa9e940" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Tue Apr 11 17:09:35 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Apr 11 17:09:35 2017 +0000" }, "message": "Merge \"Remove admin namespace throughout Patrole - Volume tests\"" }, { "commit": "94c1cc61b8c7404f05372e8af48a2e5d1bd711ac", "tree": "6ffe7fdb9b868ec72d0fde96802835d47b1f758b", "parents": [ "40ca06d7dbfd6173a5476bf04bf90963b4a5bfd1" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Apr 11 16:38:45 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Tue Apr 11 16:41:48 2017 +0100" }, "message": "Add RBAC tests for namespace_tags_client.\n\nAdds RBAC tests for all the endpoints in namespace_tags_client\nexcept for\n\n 1) delete_namespace_tag\n 2) delete_namespace_tags\n\nbecause Glance does not currently do policy enforcement for them [0]\n(the policy actions are even missing from the policy.json).\n\nThis patch also removes invalid occurrences of CONF and LOG\nthroughout Patrole image tests, and renames a few incorrectly\nnamed image test files.\n\nPartially-Implements blueprint: initial-tests-image\n\n[0] https://github.com/openstack/glance/blob/master/etc/policy.json\n\nChange-Id: I15be44d50886b8f500d640b67563504287767d91\n" }, { "commit": "40ca06d7dbfd6173a5476bf04bf90963b4a5bfd1", "tree": "b75523e5d38dcaffde078f588f3d5210aa816361", "parents": [ "4d6264c2cc341dce889f97b59bad6ee9ff707bcf", "9909ac6d33f54f6a8487757d653e232ffc759dad" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Tue Apr 11 13:42:37 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Tue Apr 11 13:42:37 2017 +0000" }, "message": "Merge \"Remove admin namespace throughout Patrole - Nova tests\"" }, { "commit": "6a99c56bb4e28f4c6984b8c3a9c2d3afdb544791", "tree": "e106a063732cee11d0ba27c66f988beeff59f5c9", "parents": [ "083eb7cfd6fc8952e57745e49ee68dbe63e5c50f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Apr 08 19:13:55 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Apr 10 23:45:03 2017 +0100" }, "message": "Remove admin namespace throughout Patrole - Identity tests\n\nIn Tempest, it is meaningful to separate admin and non-admin\ntests into different classes and files, because Tempest\nmust use clients with admin credentials to perform admin-only\nAPI calls, like changing an admin password. More specifically,\nTempest must use the os_adm/os_admin-namespace clients\n(instantiated with admin credentials) to perform these tests;\nelse 403s are thrown.\n\nPatrole, on the other hand, doesn\u0027t need to use\nos_adm/os_admin-namespace clients, because of the fact that\nrole-switching is performed to grant the os-namespace\nclients sufficient credentials to perform API actions that\nrequire admin credentials during setting up and cleaning up\ntest resources. Thus, the distinction between admin and\nnon-admin is not important in Patrole, as role-switching\nmeans that at different points in time the clients have admin\nand non-admin credentials.\n\nThus, all namespaces (files, folders and classes) that contain\n\"admin\" should be renamed, if the non-admin version does not\nalready exist. If the admin version and non-admin version\ntests both exist, then the admin version should be removed and\nits tests merged with the non-admin version.\n\nThis patch, in addition, adds additional tests to test_rbac_roles:\nsome identity:check_grant tests were missing. Following tests\nwere added:\n 1) Checking user role on domain\n 2) Checking group role on project\n 3) Checking group role on domain\n\nChange-Id: Ib82e8b8a0d6c8587fb0b1ce415e751c3ebc3c2f9\nPartial-Bug: #1672250\n" }, { "commit": "4d6264c2cc341dce889f97b59bad6ee9ff707bcf", "tree": "72a0c1d2365be99d4cb93ffaf6815ab4839cf408", "parents": [ "1a2784bdffbe292da9e929ecedd166f9d7a6f0e7" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Apr 10 16:52:06 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Apr 10 18:52:27 2017 +0000" }, "message": "Fix non-existent cinder policy action tests.\n\nThe current policy actions are invalid as they are not included\nin Cinder\u0027s policy.json [0] and are not enforced by Cinder\u0027s\npolicy enforcement system:\n\n - volume:list_extensions\n - volume_extension:get_volumes_image_metadata\n - volume:availability_zone_list\n - volume:get_volume_image_metadata\n\nSome of these are incorrectly spelled:\n - volume:get_volume_image_metadata \u003d\u003e volume:get_snapshot_metadata\n - volume_extension:get_volumes_image_metadata \u003d\u003e\n volume_extension:volume_image_metadata\n\nSome of these are not enforced at all so have been removed:\n - volume:list_extensions\n - volume:availability_zone_list\n\nSome of these are not as granular (but are not being changed due\nto their being fixed in Related-Change):\n - volume_extension:qos_specs_manage:\u003ccreate/update/delete/read\u003e \u003d\u003e\n volume_extension:qos_specs_manage\n\n[0] https://github.com/openstack/cinder/blob/master/etc/cinder/policy.json\n\nChange-Id: I2d3fcdb38126df4df4e2ffe78acec7cefeba8ea3\nRelated-Change: I1ca996e968a273b989bea0bf3c54b47349ca47fe\nCloses-Bug: #1677026\n" }, { "commit": "9909ac6d33f54f6a8487757d653e232ffc759dad", "tree": "233259234cb242ef9b7e024d6c45d8c6fc42d310", "parents": [ "083eb7cfd6fc8952e57745e49ee68dbe63e5c50f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Fri Apr 07 21:12:36 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Apr 10 18:51:47 2017 +0000" }, "message": "Remove admin namespace throughout Patrole - Nova tests\n\nIn Tempest, it is meaningful to separate admin and non-admin\ntests into different classes and files, because Tempest\nmust use clients with admin credentials to perform admin-only\nAPI calls, like changing an admin password. More specifically,\nTempest must use the os_adm/os_admin-namespace clients\n(instantiated with admin credentials) to perform these tests;\nelse 403s are thrown.\n\nPatrole, on the other hand, doesn\u0027t need to use\nos_adm/os_admin-namespace clients, because of the fact that\nrole-switching is performed to grant the os-namespace\nclients sufficient credentials to perform API actions that\nrequire admin credentials during setting up and cleaning up\ntest resources. Thus, the distinction between admin and\nnon-admin is not important in Patrole, as role-switching\nmeans that at different points in time the clients have admin\nand non-admin credentials.\n\nThus, all namespaces (files, folders and classes) that contain\n\"admin\" should be renamed, if the non-admin version does not\nalready exist. If the admin version and non-admin version\ntests both exist, then the admin version should be removed and\nits tests merged with the non-admin version.\n\nChange-Id: I4bc55c7e1c8b7391fb11baf35987ace1c4080ef1\nPartial-Bug: #1672250\n" }, { "commit": "1a2784bdffbe292da9e929ecedd166f9d7a6f0e7", "tree": "8a3b146d201007eec7f530334f4377a22c449e26", "parents": [ "15293514aeea518060fb656414db18881004d8e2", "ba4881b06bcf3293426f8f1efc4b26181c59a1bf" ], "author": { "name": "Jenkins", "email": "jenkins@review.openstack.org", "time": "Mon Apr 10 17:47:25 2017 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "review@openstack.org", "time": "Mon Apr 10 17:47:25 2017 +0000" }, "message": "Merge \"Fix _validate_switch_role throwing incorrect error message\"" }, { "commit": "706fd34fcc75bba9dc868b9566f50ffa4fa9e940", "tree": "a6f3f47c07b15462bfc87c5927d25d4f96004ae8", "parents": [ "083eb7cfd6fc8952e57745e49ee68dbe63e5c50f" ], "author": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Sat Apr 08 19:31:04 2017 +0100" }, "committer": { "name": "Felipe Monteiro", "email": "felipe.monteiro@att.com", "time": "Mon Apr 10 18:27:50 2017 +0100" }, "message": "Remove admin namespace throughout Patrole - Volume tests\n\nIn Tempest, it is meaningful to separate admin and non-admin\ntests into different classes and files, because Tempest\nmust use clients with admin credentials to perform admin-only\nAPI calls, like changing an admin password. More specifically,\nTempest must use the os_adm/os_admin-namespace clients\n(instantiated with admin credentials) to perform these tests;\nelse 403s are thrown.\n\nPatrole, on the other hand, doesn\u0027t need to use\nos_adm/os_admin-namespace clients, because of the fact that\nrole-switching is performed to grant the os-namespace\nclients sufficient credentials to perform API actions that\nrequire admin credentials during setting up and cleaning up\ntest resources. Thus, the distinction between admin and\nnon-admin is not important in Patrole, as role-switching\nmeans that at different points in time the clients have admin\nand non-admin credentials.\n\nThus, all namespaces (files, folders and classes) that contain\n\"admin\" should be renamed, if the non-admin version does not\nalready exist. If the admin version and non-admin version\ntests both exist, then the admin version should be removed and\nits tests merged with the non-admin version.\n\nDepends-On: I8c3944e766210a31aa684e29c45e39470b738640\nChange-Id: I417fa0d29fc06b04582cdac24608b0373db6aacb\nPartial-Bug: #1672250\n" } ], "next": "ba4881b06bcf3293426f8f1efc4b26181c59a1bf" }