Add switchToRbacRole=True to test instance actions in compute.
As the title says, switchToRbacRole=True is not performed in
either of the 2 tests. Also, the test file should be renamed
from test_instance_actions => test_instance_actions_rbac.
This patch resolves both issues.
Change-Id: I2a21c63af491466c94a1a94bb69e48eb9d31ab16
Closes-Bug: #1672445
diff --git a/patrole_tempest_plugin/tests/api/compute/test_instance_actions.py b/patrole_tempest_plugin/tests/api/compute/test_instance_actions_rbac.py
similarity index 87%
rename from patrole_tempest_plugin/tests/api/compute/test_instance_actions.py
rename to patrole_tempest_plugin/tests/api/compute/test_instance_actions_rbac.py
index a1f12d6..e35f60c 100644
--- a/patrole_tempest_plugin/tests/api/compute/test_instance_actions.py
+++ b/patrole_tempest_plugin/tests/api/compute/test_instance_actions_rbac.py
@@ -13,14 +13,12 @@
# License for the specific language governing permissions and limitations
# under the License.
-from tempest import config
from tempest.lib import decorators
+from tempest import test
from patrole_tempest_plugin import rbac_rule_validation
from patrole_tempest_plugin.tests.api.compute import rbac_base
-CONF = config.CONF
-
class InstanceActionsRbacTest(rbac_base.BaseV2ComputeRbacTest):
@@ -32,9 +30,9 @@
@classmethod
def skip_checks(cls):
super(InstanceActionsRbacTest, cls).skip_checks()
- if not CONF.compute_feature_enabled.api_extensions:
+ if not test.is_extension_enabled('os-instance-actions', 'compute'):
raise cls.skipException(
- '%s skipped as no compute extensions enabled' % cls.__name__)
+ '%s skipped as os-instance-actions not enabled' % cls.__name__)
@classmethod
def resource_setup(cls):
@@ -51,6 +49,7 @@
service="nova",
rule="os_compute_api:os-instance-actions")
def test_list_instance_actions(self):
+ self.rbac_utils.switch_role(self, switchToRbacRole=True)
self.client.list_instance_actions(self.server['id'])
@decorators.idempotent_id('eb04c439-4215-4029-9ccb-5b3c041bfc25')
@@ -58,5 +57,6 @@
service="nova",
rule="os_compute_api:os-instance-actions:events")
def test_get_instance_action(self):
+ self.rbac_utils.switch_role(self, switchToRbacRole=True)
self.client.show_instance_action(
self.server['id'], self.request_id)['instanceAction']