tree 972d07b06bf05e915794107c8b51df94b477d430
parent 3cc966f093dbc8db2ca7c99cb52b74c0cfd51af4
author Felipe Monteiro <felipe.monteiro@att.com> 1491429597 +0100
committer Felipe Monteiro <felipe.monteiro@att.com> 1491430151 +0000

Fix role validation edge case bug in rbac_utils

Currently, a history of the order of switchToRbacRole calls is
maintained by class name in rbac_utils. This means that each
uniquely named class has its own distinct history, allowing
for determination of whether proper role-switching is being
performed.

However, sometimes class names are not unique across modules:
for example, both network and compute service folders have
a test called test_floating_ips_rbac, causing essentially
collisions to take place in the role-switching history dictionary.
This currently causes a false negative in role validation
in the logs [0].

The solution to this edge case is straightforward: the key
that indexes into the history dictionary should be changed
from class name to module path + class name. For example,
the key "TestFloatingIpsRbac" will be changed to:

  - "patrole_tempest_plugin.tests.api.compute..." + class name
  - "patrole_tempest_plugin.tests.api.network..." + class name

This also works for different versions of, say, test_users_rbac:

  - "patrole_tempest_plugin.tests.api.identity.v2..." + class name
  - "patrole_tempest_plugin.tests.api.identity.v3..." + class name

[0] http://logs.openstack.org/82/448782/11/check/gate-tempest-dsvm-patrole-member-ubuntu-xenial-nv/bce54d8/console.html

Change-Id: I4a1273e56a25dbc7fee950cf55f439f36cbf8e5c
Closes-Bug: #1680262