Merge "Increase coverage for volume metadata tests"
diff --git a/patrole_tempest_plugin/tests/api/volume/test_encryption_types_rbac.py b/patrole_tempest_plugin/tests/api/volume/test_encryption_types_rbac.py
index 62ccc9e..f10e41b 100644
--- a/patrole_tempest_plugin/tests/api/volume/test_encryption_types_rbac.py
+++ b/patrole_tempest_plugin/tests/api/volume/test_encryption_types_rbac.py
@@ -82,3 +82,13 @@
vol_type_id = self._create_volume_type_encryption()
with self.rbac_utils.override_role(self):
self.encryption_types_client.show_encryption_type(vol_type_id)
+
+ @decorators.idempotent_id('d4ed3cf8-52b2-4fa2-910d-e405361f0881')
+ @rbac_rule_validation.action(
+ service="cinder",
+ rule="volume_extension:volume_type_encryption")
+ def test_show_encryption_specs_item(self):
+ vol_type_id = self._create_volume_type_encryption()
+ with self.rbac_utils.override_role(self):
+ self.encryption_types_client.show_encryption_specs_item(
+ vol_type_id, 'provider')
diff --git a/patrole_tempest_plugin/tests/api/volume/test_limits_rbac.py b/patrole_tempest_plugin/tests/api/volume/test_limits_rbac.py
index 976d756..78cfd9a 100644
--- a/patrole_tempest_plugin/tests/api/volume/test_limits_rbac.py
+++ b/patrole_tempest_plugin/tests/api/volume/test_limits_rbac.py
@@ -15,6 +15,7 @@
from tempest.lib import decorators
+from patrole_tempest_plugin import rbac_exceptions
from patrole_tempest_plugin import rbac_rule_validation
from patrole_tempest_plugin.tests.api.volume import rbac_base
@@ -26,5 +27,20 @@
@rbac_rule_validation.action(service="cinder",
rule="limits_extension:used_limits")
def test_show_limits(self):
+ # It is enough to check whether any of the following keys below
+ # are in the response body under ['limits']['absolute'], but no harm
+ # in checking for them all.
+ expected_keys = {
+ 'totalVolumesUsed',
+ 'totalGigabytesUsed',
+ 'totalSnapshotsUsed',
+ 'totalBackupsUsed',
+ 'totalBackupGigabytesUsed'
+ }
+
with self.rbac_utils.override_role(self):
- self.volume_limits_client.show_limits()
+ absolute_limits = self.volume_limits_client.show_limits()[
+ 'limits']['absolute']
+ for key in expected_keys:
+ if key not in absolute_limits:
+ raise rbac_exceptions.RbacMalformedResponse(attribute=key)
diff --git a/releasenotes/notes/start-of-queens-support-6c379f2b9cafbf31.yaml b/releasenotes/notes/start-of-queens-support-6c379f2b9cafbf31.yaml
new file mode 100644
index 0000000..588266b
--- /dev/null
+++ b/releasenotes/notes/start-of-queens-support-6c379f2b9cafbf31.yaml
@@ -0,0 +1,11 @@
+---
+prelude: >
+ This release marks the start of Queens release support in Patrole.
+other:
+ - OpenStack Releases supported after this release are **Queens**
+ and **Pike**.
+
+ The release under current development of this tag is Rocky, meaning
+ that every Patrole commit is also tested against master during the Rocky
+ cycle. However, this does not necessarily mean that using Patrole as of
+ this tag will work against a Rocky (or future release) cloud.