commit 0eae4844d6452203baf0d8600b1296ef8ab42544
author Ihar Hrachyshka <ihrachys@redhat.com> Thu Aug 03 12:52:32 2017 -0700
committer garyk <gkotton@vmware.com> Tue Aug 08 11:17:19 2017 +0000
tree 5d8523710721c346d9a0353bb7f3c95950eed52f
parent 6bd1266418c76dddf59cd17635afe53b7dc663bd

Don't check full subnet body in test_filtering_shared_subnets

Plugins may add attributes to subnets, in which case simple equality
check will fail. Instead of comparing bodies, compare just IDs. It
should be enough to achieve the goal of the test case.

Change-Id: Iebc22f99285777df7de499c713b2bc1e38e0bd62
Closes-Bug: #1706986

neutron/tests/tempest/api/admin/test_shared_network_extension.py

diff --git a/neutron/tests/tempest/api/admin/test_shared_network_extension.py b/neutron/tests/tempest/api/admin/test_shared_network_extension.py
index fc2e55c..2be0ea2 100644
--- a/neutron/tests/tempest/api/admin/test_shared_network_extension.py
+++ b/neutron/tests/tempest/api/admin/test_shared_network_extension.py
@@ -65,19 +65,22 @@
                                     client=self.admin_client)
         self.assertIn(shared['id'],
                       self._list_subnets_ids(self.client, shared=True))
-        self.assertIn(shared,
-            self.admin_client.list_subnets(shared=True)['subnets'])
-        self.assertNotIn(priv,
-            self.client.list_subnets(shared=True)['subnets'])
-        self.assertNotIn(priv,
-            self.admin_client.list_subnets(shared=True)['subnets'])
-        self.assertIn(priv, self.client.list_subnets(shared=False)['subnets'])
+        self.assertIn(shared['id'],
+                      self._list_subnets_ids(self.admin_client, shared=True))
+        self.assertNotIn(priv['id'],
+                         self._list_subnets_ids(self.client, shared=True))
+        self.assertNotIn(
+            priv['id'],
+            self._list_subnets_ids(self.admin_client, shared=True))
+        self.assertIn(priv['id'],
+                      self._list_subnets_ids(self.client, shared=False))
         self.assertIn(priv['id'],
                       self._list_subnets_ids(self.admin_client, shared=False))
-        self.assertNotIn(shared,
-            self.client.list_subnets(shared=False)['subnets'])
-        self.assertNotIn(shared,
-            self.admin_client.list_subnets(shared=False)['subnets'])
+        self.assertNotIn(shared['id'],
+                         self._list_subnets_ids(self.client, shared=False))
+        self.assertNotIn(
+            shared['id'],
+            self._list_subnets_ids(self.admin_client, shared=False))
 
     @decorators.idempotent_id('6661d219-b96d-4597-ad10-55766ce4abf7')
     def test_create_update_shared_network(self):