commit da415b4f1c3107ca05245ed9abd53a3ab67d83e3
author Goutham Pacha Ravi <gouthampravi@gmail.com> Tue Jul 27 15:29:53 2021 -0700
committer Goutham Pacha Ravi <gouthampravi@gmail.com> Tue Jul 27 15:29:53 2021 -0700
tree 444b040e833f30735f905e8d2b6284fbbe398211
parent 86f2432476ba9128bb2c26a78ae3b3f53327d4bd

Fix parsing of share group type json

When using the shares client, since
86f2432476ba9128bb2c26a78ae3b3f53327d4bd,
JSON objects from the response body are extracted in-place
rather than in the client methods. We didn't catch this issue
when merging [1] because these tests are skipped in the jobs
running against manila-tempest-plugin:

manila_tempest_tests.tests.api.admin.test_share_groups.ShareGroupsTest.test_default_share_group_type_applied_1_2_31 ... SKIPPED: Only if defaults are defined.
manila_tempest_tests.tests.api.admin.test_share_groups.ShareGroupsTest.test_default_share_group_type_applied_2_2_55 ... SKIPPED: Only if defaults are defined.
manila_tempest_tests.tests.api.admin.test_share_groups.ShareGroupsTest.test_default_share_group_type_applied_3_2_61 ... SKIPPED: Only if defaults are defined.

However, default share and group types are defined in the
grenade job and these tests are currently failing.

Change-Id: Ida39026d655d34af17846cd45867c2d46141f39f
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

manila_tempest_tests/tests/api/admin/test_share_groups.py

diff --git a/manila_tempest_tests/tests/api/admin/test_share_groups.py b/manila_tempest_tests/tests/api/admin/test_share_groups.py
index b4f0e92..651a842 100644
--- a/manila_tempest_tests/tests/api/admin/test_share_groups.py
+++ b/manila_tempest_tests/tests/api/admin/test_share_groups.py
@@ -148,7 +148,7 @@
         try:
             default_type = self.shares_v2_client.get_default_share_group_type(
                 version=version
-            )
+            )['share_group_type']
         except exceptions.NotFound:
             msg = "There is no default share group type"
             raise self.skipException(msg)