Fix NetApp Manila Replication test TearDown Failures

[test_replication_negative.py:test_try_add_replica_nonexistent_subnet]  Changed to use self.create_share_network from the base class instead of self.shares_v2_client.create_share_network, so that the created share network is automatically tracked and cleaned up during test cleanup. The direct client call did not handle cleanup, causing resource leaks.



Change-Id: I38e761c412f634b43a34af15b0f407b8d2b0bcf6
Signed-off-by: Manideep <manideep.openstack@gmail.com>
diff --git a/manila_tempest_tests/tests/api/test_replication_negative.py b/manila_tempest_tests/tests/api/test_replication_negative.py
index 9424a08..565b174 100644
--- a/manila_tempest_tests/tests/api/test_replication_negative.py
+++ b/manila_tempest_tests/tests/api/test_replication_negative.py
@@ -261,8 +261,9 @@
         data['neutron_net_id'] = subnet['neutron_net_id']
         data['neutron_subnet_id'] = subnet['neutron_subnet_id']
         data['availability_zone'] = self.share_zone
-        share_net = self.shares_v2_client.create_share_network(
-            **data)['share_network']
+        share_net = self.create_share_network(cleanup_in_class=True,
+                                              client=self.shares_v2_client,
+                                              **data)
         share, instance_id = self._create_share_get_instance(
             share_network_id=share_net['id'])