commit 79721c0572c769225258d8d563eda72ce6df8e44
author Clinton Knight <cknight@netapp.com> Wed Sep 09 11:27:40 2015 -0400
committer Clinton Knight <cknight@netapp.com> Thu Sep 10 15:47:38 2015 +0000
tree 43c8f049c8434660585bd51f7a286795fc3f17d4
parent 90532460f79e4be1c63b6bb54bafdd972c8f7794

Missing check in ShareManager::manage_existing()

In ShareManager::manage_existing(), there is a check for the DHSS mode of
the driver but there is no check for the DHSS mode in the specified share
type. This omission requires redundant checks in the drivers. This patch
adds the missing check to the share manager, removes the redundant checks
from the drivers, and updates all relevant unit tests.  Also, fix a
couple minor tempest resource cleanup issues discovered while
debugging this issue.

Change-Id: Ib579fd0558e59c28777342bb9d36def12f6bf4da
Closes-Bug: #1493869

manila_tempest_tests/tests/api/admin/test_share_manage.py

diff --git a/manila_tempest_tests/tests/api/admin/test_share_manage.py b/manila_tempest_tests/tests/api/admin/test_share_manage.py
index df3896e..286f501 100644
--- a/manila_tempest_tests/tests/api/admin/test_share_manage.py
+++ b/manila_tempest_tests/tests/api/admin/test_share_manage.py
@@ -100,7 +100,7 @@
 
         # Add managed share to cleanup queue
         self.method_resources.insert(
-            0, {'type': 'share_type', 'id': share['id'],
+            0, {'type': 'share', 'id': share['id'],
                 'client': self.shares_client})
 
         # Wait for success
@@ -137,7 +137,7 @@
 
             # Add managed share to cleanup queue
             self.method_resources.insert(
-                0, {'type': 'share_type', 'id': share['id'],
+                0, {'type': 'share', 'id': share['id'],
                     'client': self.shares_client})
 
             # Wait for success