Fix 'extend' API for 2.7+ microversions
Extend/Shrink share is not working in microversion 2.7+.
When trying to extend/shrink a share, manila raises an
error telling that the new share size must be an integer.
Bug was due to improper use of get method on dictionary.
Corrected by using get method properly.
Change-Id: I700581d815da0fdd6addedc42f3e2ba528680e60
Closes-Bug: #1531536
diff --git a/manila_tempest_tests/tests/api/test_shares_actions.py b/manila_tempest_tests/tests/api/test_shares_actions.py
index 36fd6e5..42a7589 100644
--- a/manila_tempest_tests/tests/api/test_shares_actions.py
+++ b/manila_tempest_tests/tests/api/test_shares_actions.py
@@ -473,12 +473,19 @@
new_size = 2
# extend share and wait for active status
- self.shares_client.extend_share(share['id'], new_size)
+ self.shares_v2_client.extend_share(share['id'], new_size)
self.shares_client.wait_for_share_status(share['id'], 'available')
# check state and new size
- share = self.shares_client.get_share(share['id'])
- self.assertEqual(new_size, share['size'])
+ share_get = self.shares_v2_client.get_share(share['id'])
+ msg = (
+ "Share could not be extended. "
+ "Expected %(expected)s, got %(actual)s." % {
+ "expected": new_size,
+ "actual": share_get['size'],
+ }
+ )
+ self.assertEqual(new_size, share_get['size'], msg)
@test.attr(type=["gate", ])
@testtools.skipUnless(
@@ -489,12 +496,19 @@
new_size = 1
# shrink share and wait for active status
- self.shares_client.shrink_share(share['id'], new_size)
+ self.shares_v2_client.shrink_share(share['id'], new_size)
self.shares_client.wait_for_share_status(share['id'], 'available')
# check state and new size
- share = self.shares_client.get_share(share['id'])
- self.assertEqual(new_size, share['size'])
+ share_get = self.shares_v2_client.get_share(share['id'])
+ msg = (
+ "Share could not be shrunk. "
+ "Expected %(expected)s, got %(actual)s." % {
+ "expected": new_size,
+ "actual": share_get['size'],
+ }
+ )
+ self.assertEqual(new_size, share_get['size'], msg)
class SharesRenameTest(base.BaseSharesTest):