Allow share server migration with replica
- Update migration test to consider replica scenario
Related-Bug: #2052785
Depends-On: https://review.opendev.org/c/openstack/manila/+/933902
Change-Id: Ic091ef68947aee20bd5cda2dd9e0a7a1308f6e78
diff --git a/manila_tempest_tests/tests/api/admin/test_share_servers_migration.py b/manila_tempest_tests/tests/api/admin/test_share_servers_migration.py
index d3ec3f1..3864e57 100644
--- a/manila_tempest_tests/tests/api/admin/test_share_servers_migration.py
+++ b/manila_tempest_tests/tests/api/admin/test_share_servers_migration.py
@@ -21,6 +21,7 @@
from manila_tempest_tests.common import constants
from manila_tempest_tests.common import waiters
+from manila_tempest_tests import share_exceptions
from manila_tempest_tests.tests.api import base
from manila_tempest_tests import utils
@@ -57,7 +58,15 @@
raise cls.skipException(msg)
# create share type (generic)
- extra_specs = {}
+ replication_type = CONF.share.backend_replication_type
+ if replication_type not in constants.REPLICATION_TYPE_CHOICES:
+ raise share_exceptions.ShareReplicationTypeException(
+ replication_type=replication_type
+ )
+ extra_specs = {
+ "replication_type": replication_type,
+ "driver_handles_share_servers": CONF.share.multitenancy_enabled,
+ }
if CONF.share.capability_snapshot_support:
extra_specs.update({'snapshot_support': True})
cls.share_type = cls.create_share_type(extra_specs=extra_specs)
@@ -318,8 +327,14 @@
@decorators.idempotent_id('99e439a8-a716-4205-bf5b-af50128cb908')
@tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)
- @ddt.data(False, True)
- def test_share_server_migration_complete(self, new_share_network):
+ @ddt.data(
+ (False, False),
+ (True, False),
+ (True, True)
+ )
+ @ddt.unpack
+ def test_share_server_migration_complete(self, new_share_network,
+ check_with_replica):
"""Test the share server migration complete."""
share_network_id = self.provide_share_network(
self.shares_v2_client, self.networks_client)
@@ -346,6 +361,12 @@
preserve_snapshots = True if snapshot_id else False
+ replica = {}
+ if check_with_replica:
+ replica = self.create_share_replica(
+ share['id'],
+ cleanup_in_class=False)
+
# Start share server migration.
self.shares_v2_client.share_server_migration_start(
src_server_id, dest_host,
@@ -393,6 +414,12 @@
self.admin_shares_client.wait_for_resource_deletion(
server_id=src_server_id)
+ if check_with_replica:
+ replica = self.shares_v2_client.get_share_replica(
+ replica["id"])['share_replica']
+ self.assertEqual(constants.REPLICATION_STATE_IN_SYNC,
+ replica["replica_state"])
+
@decorators.idempotent_id('52e154eb-2d39-45af-b5c1-49ea569ab804')
@tc.attr(base.TAG_POSITIVE, base.TAG_BACKEND)
@ddt.data(True, False)